From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DB626A04B5; Mon, 11 Jan 2021 13:30:49 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 536B1140CB5; Mon, 11 Jan 2021 13:30:49 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 6FCFE140FCD for ; Fri, 8 Jan 2021 13:38:56 +0100 (CET) IronPort-SDR: KZ8yJ7XaD60EF0Mv3hLNEPn685sKGpcRHf4fr+kxFS/FcItFH7IzjyA8TtFcah+65NI34AWX7Y C9GuhpYJo1uw== X-IronPort-AV: E=McAfee;i="6000,8403,9857"; a="239138970" X-IronPort-AV: E=Sophos;i="5.79,330,1602572400"; d="scan'208";a="239138970" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jan 2021 04:38:54 -0800 IronPort-SDR: Gbs08AzP/PeVrGXrBDICk7DVn4DNTWCWm6WSmCiNw6J0wlaIOp+05tYccF2sroa10wcKnxPAmT vcbec54yOG0g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,330,1602572400"; d="scan'208";a="463369255" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga001.fm.intel.com with ESMTP; 08 Jan 2021 04:38:54 -0800 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 8 Jan 2021 04:38:53 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Fri, 8 Jan 2021 04:38:53 -0800 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.36.54) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Fri, 8 Jan 2021 04:38:53 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eNIkhGig+ULnPu+Z6+q/cNn00oiKsxIQ8OjaFpQBOpqY1Dhdsv3b6PFX3410b/8AE2Q87TNjkC5gxGdht5bKLuqVoYedxJx78SL8OlnF9cqwIy2ywcboUge1a5IKZEN7+7h+aBaHfzuFlOZWw2s4p2vTw5ZKBp+4Y30V6eU2tms/eI6EX4k5j/NaPyzPDnkQ85j5xkRvtILf3UhpT5On1/s7IWMOpItSBsk+ekOwC8g3lk3VsdAHT5rDgxFI1WjbEusFytLIK3oN961DY38sTyXCX+9u0n+0N/MSrWXgQOBYdHYkg1s/J5qrSI0L/b0bB9xnXHDyyrkkrtotXj+Bkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2ZX0rLe0Ka9KbKbQ4eAj5y97vttvZ36/P6hM6GTpETY=; b=j/5fNzfxiL1ikgZs8LR2yQ9/VYo7koamO0hq7Hgs7i8XYqm5/Bpy4dUFuI8oXAq9INPIvCnZ3uOi3NyjRXX7pyiXoZTAb2vOyC2DfrFhm/aoGGIExAcV1cXd0sWRvIWYSCLrKA8M6KwJiMV2DKQUjoFO1HWCYgaszdV5k7tZyxdNPoZAu6124ebQQg2ZDi3dyxjhJ617CBiWK/C5ADk3+k5jYILGcPDSRYFA8g31fmHu1AgOHu0XfDlWnm1R3bV4Oq7CKYfdRMPaw5vXYw8DbiaNdZjjxoWfZQqv+91HhDCfZuwrEuT8wIX60AgQeQOjJxC2qtv8EpClngvDSABnyA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2ZX0rLe0Ka9KbKbQ4eAj5y97vttvZ36/P6hM6GTpETY=; b=dUaY/avvEZIfr6dM9mxAm5lC6pw/d9g6E9dTviynfawoIbBPewywDRhIISZSkeQl1Z1sAch1KhHeLuQxdOo8RklaYQPR4Ts7XnlYQWYgTKDYRy56FT22AKYb2T9AoPDV1GkIcvWXQgoRSBKF/YHNgcIBkPmSN7Z6WjYNRbFPPZ0= Received: from PH0PR11MB4776.namprd11.prod.outlook.com (2603:10b6:510:30::14) by PH0PR11MB4805.namprd11.prod.outlook.com (2603:10b6:510:32::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3742.6; Fri, 8 Jan 2021 12:38:51 +0000 Received: from PH0PR11MB4776.namprd11.prod.outlook.com ([fe80::cd31:7d2a:22ab:7e1d]) by PH0PR11MB4776.namprd11.prod.outlook.com ([fe80::cd31:7d2a:22ab:7e1d%3]) with mapi id 15.20.3742.008; Fri, 8 Jan 2021 12:38:51 +0000 From: "Kinsella, Ray" To: Thomas Monjalon , "Guo, Jia" , "Zhang, Qi Z" , "Yigit, Ferruh" CC: "Wu, Jingjing" , "Yang, Qiming" , "Wang, Haiyue" , "dev@dpdk.org" , "andrew.rybchenko@oktetlabs.ru" , "orika@nvidia.com" , "getelson@nvidia.com" , Dodji Seketeli Thread-Topic: [dpdk-dev] [dpdk-dev v2 1/2] ethdev: add new tunnel type for ecpri Thread-Index: AQHW5ahymfe7ROGK4Uynzi66f5H5gqodqIpA Date: Fri, 8 Jan 2021 12:38:50 +0000 Message-ID: References: <20201216085854.7842-1-jia.guo@intel.com> <27289607.Vi9ZVq1Shk@thomas> <2191627.gY80Bp0Rq6@thomas> In-Reply-To: <2191627.gY80Bp0Rq6@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=intel.com; x-originating-ip: [89.124.12.13] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 22ea8d5d-46b8-496e-e6d8-08d8b3d25a38 x-ms-traffictypediagnostic: PH0PR11MB4805: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: quNFheTJqQ7l+Sdz2pdkIM/xqBmJ3SrwC/QOAV00TU/rr4kTeTgB54HHwveAfvmXEETs2psCsVA0fGmCz27INdy0QHrryuWNTiKdm+EnKuhzxM11K7V0xq5kvnkU6h8m4Uq7xSU7udqeki6SWq0fqAjqGSev0lqWe2/mwqyaf1/JZlRhL8pW/w6Yw1hbPVC1WYdBymJkn21l8+BTyVYwl7QQzDtgVeLjdBypwFbYTaOhDusTpM6dZ58jUIuOcJeU4CnIg8eBa8F4bLjc4hCYy3vMVqAtBQ3Sq7xIIUYgWFJiFa/RUFZw8GFCgdExpyZZsmkxmk016FPL1ABoRi45WXiolsfWCEekFee0Amgb+G24TJMntwf3yOtypHig9vtaHM/PSdg2NLfxsuRRWHpjEzufVXO+TPAF4riMVuodtkppA0peXwb1q0fQPutBxFxZTwKo6MODMyWfW9exrLB/6Q== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB4776.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(39860400002)(366004)(396003)(346002)(376002)(83380400001)(86362001)(33656002)(5660300002)(66556008)(66446008)(64756008)(8936002)(7696005)(52536014)(76116006)(66476007)(66946007)(8676002)(6506007)(53546011)(2906002)(4326008)(9686003)(26005)(186003)(55016002)(6636002)(110136005)(966005)(54906003)(478600001)(316002)(71200400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?Xq2Z0Ee2TEALHXXIp8tmSLQTMzHTKQDg/CXKzazZKf6PGkXqrZVetwaF/vkA?= =?us-ascii?Q?d1uMuThAYzRCRaxI2VFkNs5xRQMk8F6vU/aCX7rKMOmjtAj0WceZ4mZEL8Ul?= =?us-ascii?Q?nYWKgWn/nSeRlzPcQY2pRJjqUbpzo5oDVWKUeAkoaQndnxC3IzkzwywaQEFd?= =?us-ascii?Q?wpyupC9+WGfd//mVuCSyIWaeTdV0/jvn9+nZk0R8uRm7hy/Ebgz6Q7QBYg7C?= =?us-ascii?Q?TYvP2fTDzsKrMGjDukrDRWXYxpu9j2M6lRmx5x2omfIkyoopNnuHAyRNHncS?= =?us-ascii?Q?/OBnBiQKAvdiQJUbsChYbC8tpuTu0MSnwE4mYqEAB6hI2AhzaVTzN/4qANdg?= =?us-ascii?Q?fwiwTue18NNY3p02oU0VjgPG4ZdlSxqp7dSYORJMFiZFIcWmHgPTA1cKSK6O?= =?us-ascii?Q?jUNczA6QuF5IUEU9kDWYX9Epl3BXKvvwNYZbxfsVAdStLLfaPZcVKMNEuQ4V?= =?us-ascii?Q?nulWFJEtMChhK4IVyAFIMS/gOvpw+VPBkRQnJ3omopiprlcwFAG/RfD4dPCx?= =?us-ascii?Q?liw/KscogISak7JiZ4IVZnlvN4v2ht5yuDjVh1WaqzdH0+XTpkKjfDHX5ufe?= =?us-ascii?Q?z8LA9wkHeQsPqDcUA6tdOgrTHNYu9Ur5es2NOT2VQsKk07m/eOiYYXEM9rKc?= =?us-ascii?Q?+9JN4jqA1G79wAySPGRvUnGKMGo+v/ePJJjB71u0fHOAOWTJlDoB0xcHusUt?= =?us-ascii?Q?ZqazHjgCFZxtYbNC+cMcjrCTLMsweNS67HuWGyDC7XlQ493pX5Mb+kO0cLK7?= =?us-ascii?Q?G/2INE1EmU228yD+WjMgdS4e57k4iDjSejpLIl0HN9iGQ00hMrAE8qDOiaQl?= =?us-ascii?Q?fBy1lamOfOJmiNCffLFKnjDbkbrQTc6sBlPZU/o1ctnwcwBDFbIhnVXgeyvM?= =?us-ascii?Q?Cg6PPC7O9Vv+DWpVUiCaKaKsyoMD3f91vawriUwj+7/t/QeclRJbS5F1dEqM?= =?us-ascii?Q?VL7QOzixH1DCI2NXOKxunahvkmqFAIa8Vk/b2tYX2/4=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4776.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 22ea8d5d-46b8-496e-e6d8-08d8b3d25a38 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jan 2021 12:38:50.9116 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: X4CbhtK3SL78/BwznyRrIh6bKU+RLMN3b0e8GwAVheGePf0yzwXPTC5oaJt4T2sJ6mliac1VNdypVN+SHwF0LQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4805 X-OriginatorOrg: intel.com X-Mailman-Approved-At: Mon, 11 Jan 2021 13:30:48 +0100 Subject: Re: [dpdk-dev] [dpdk-dev v2 1/2] ethdev: add new tunnel type for ecpri X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Thomas Monjalon > Sent: Friday 8 January 2021 10:24 > To: Guo, Jia ; Zhang, Qi Z ; > Yigit, Ferruh > Cc: Wu, Jingjing ; Yang, Qiming > ; Wang, Haiyue ; > dev@dpdk.org; andrew.rybchenko@oktetlabs.ru; orika@nvidia.com; > getelson@nvidia.com; Dodji Seketeli ; Kinsella, Ray > > Subject: Re: [dpdk-dev] [dpdk-dev v2 1/2] ethdev: add new tunnel type > for ecpri >=20 > 08/01/2021 10:22, Ferruh Yigit: > > On 1/7/2021 1:33 PM, Thomas Monjalon wrote: > > > 07/01/2021 13:47, Zhang, Qi Z: > > >> From: Thomas Monjalon > > >>> 07/01/2021 10:32, Guo, Jia: > > >>>> From: Thomas Monjalon > > >>>>> Sorry, it is a nack. > > >>>>> BTW, it is probably breaking the ABI because of > RTE_TUNNEL_TYPE_MAX. > > >> > > >> Yes that may break the ABI but fortunately the checking-abi- > compatibility tool shows negative :) , thanks Ferruh' s guide. > > >> https://github.com/ferruhy/dpdk/actions/runs/468859673 > > > > > > That's very strange. An enum value is changed. > > > Why it is not flagged by libabigail? > > > > As long as the enum values not sent to the application and kept > within > > the library, changing their values shouldn't be problem. >=20 > But RTE_TUNNEL_TYPE_MAX is part of lib/librte_ethdev/rte_ethdev.h so it > is exposed to the application. > I think it is a case of ABI breakage. >=20 Really a lot depends on context, Thomas is right it is hard to predict how = these _MAX values are used. We have seen cases in the past where _MAX enumeration values have been used= to size arrays the like - I don't immediately see that issue here. My unde= rstanding is that the only consumer of this enumeration is rte_eth_dev_udp_= tunnel_port_add and rte_eth_dev_udp_tunnel_port_delete, right? On face valu= e, impact looks negligible.=20 I will take a look at why libabigail doesn't complain.=20