From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CF087A04B5; Mon, 11 Jan 2021 13:30:56 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5F08A140CCA; Mon, 11 Jan 2021 13:30:50 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 14055140E09 for ; Fri, 8 Jan 2021 15:08:04 +0100 (CET) IronPort-SDR: PU+0YLSt5/jmnLdgWCqoFbr46sjzEQHnANaGvKoaf1mz+lQbQLfausREThT+D7KfhAQzR0Ra/o UkHnjScviSaA== X-IronPort-AV: E=McAfee;i="6000,8403,9857"; a="174090299" X-IronPort-AV: E=Sophos;i="5.79,331,1602572400"; d="scan'208";a="174090299" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jan 2021 06:08:03 -0800 IronPort-SDR: kG/4VIquFrd8o1HdTeMKZ+vv+GGM1Ay5nlAQ6OxUfgcsp35xuMZbDDrJfyyE8v0kOl5Cg21AZr tZZ+rLW02KPg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,331,1602572400"; d="scan'208";a="351688549" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga008.fm.intel.com with ESMTP; 08 Jan 2021 06:08:03 -0800 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 8 Jan 2021 06:08:02 -0800 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 8 Jan 2021 06:08:02 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Fri, 8 Jan 2021 06:08:02 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.103) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Fri, 8 Jan 2021 06:08:01 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BiebAAwnkv4dm4QkTtw7zsBmLAQLr10buF6QuuA2NBoKXwxL3e1OuYwwQNA4vrJcLLhCDRwlG4YczCbLvz2mPoD140DpGsTxMWF2FcUJiKKE7SvVaX7S/tQq7T9nfU6pn7rbmi6/4534WrX0/yAWLhdMywfDVjMgKii59MYzdEjGFSA+cTVC+txJTtmG9L9AZYKXr2PGDgw1isYPDwyU2OBf2NNZqnbIMRscNJZzk43JkzwyIGXIr5hIF5Z3L1EsTY95zjxnMYFrh9c2wlTmzUfzVE7QN4vWIjiPmZ4He2fvg/CKy5Ym3NCuf4W0MbLU1QHdT7NTaAYOUMrYc0SM9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UTG2BMhhhaqHnfFojiG3/9NcQiE0TOUyXXwqnkbwVIE=; b=TNHDILfhJ32sP7qGXggDgkuqx7VspcH9jc1gzZ3NCzmYhAL1V1BEEom/JHS3FVWz0HOJQ+L3DGZyYA14/sW8+YpHAIw03mP5UZcGdu/mV3WdEq5EXw1NE8ktmk9/HrGeVsJjWZCEXVxsstLbqiP38/rBTUPzWNcbbdGGgkqASFUcGrMF+c0jx4Q7sqvG9eFDxNUi8squhT9/FF3nUj8fhWuD+q8MG2zIjgoliyicEC1wopKV1bg8lrznw1jRGCqSRbNWoa8GbJwU2Aa/5gqXnO/UHNEXJhTgU3pm07Bcq1xNVV/TstlzldENnNHw7sxNpts1POALW8uO8vNuRfCMEw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UTG2BMhhhaqHnfFojiG3/9NcQiE0TOUyXXwqnkbwVIE=; b=uB2TEDzaXOpBD5F3Bgf+6eY0AfHguv+sA4+hoIGPgYkmLbq2HdQE5P+KnupTh3JhvsgG04m+ButN6KZKoskh131wyjGj/Bx0t9kRXX8S11CY6AUT+ao315eiYh7EPxphSa4reQHSNIG+AzON/7ag6faYbkONiH2GfWW0hgnABHw= Received: from PH0PR11MB4776.namprd11.prod.outlook.com (2603:10b6:510:30::14) by PH0PR11MB4933.namprd11.prod.outlook.com (2603:10b6:510:33::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3742.9; Fri, 8 Jan 2021 14:07:54 +0000 Received: from PH0PR11MB4776.namprd11.prod.outlook.com ([fe80::cd31:7d2a:22ab:7e1d]) by PH0PR11MB4776.namprd11.prod.outlook.com ([fe80::cd31:7d2a:22ab:7e1d%3]) with mapi id 15.20.3742.008; Fri, 8 Jan 2021 14:07:54 +0000 From: "Kinsella, Ray" To: Thomas Monjalon , "Guo, Jia" , "Zhang, Qi Z" , "Yigit, Ferruh" CC: "Wu, Jingjing" , "Yang, Qiming" , "Wang, Haiyue" , "dev@dpdk.org" , "andrew.rybchenko@oktetlabs.ru" , "orika@nvidia.com" , "getelson@nvidia.com" , Dodji Seketeli Thread-Topic: [dpdk-dev] [dpdk-dev v2 1/2] ethdev: add new tunnel type for ecpri Thread-Index: AQHW5ahymfe7ROGK4Uynzi66f5H5gqodituAgAA4uQCAAABI4A== Date: Fri, 8 Jan 2021 14:07:53 +0000 Message-ID: References: <20201216085854.7842-1-jia.guo@intel.com> <2191627.gY80Bp0Rq6@thomas> <76ec1db3-b739-330b-97d9-d99fc9110328@intel.com> <3369453.mArGO5O6NO@thomas> In-Reply-To: <3369453.mArGO5O6NO@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=intel.com; x-originating-ip: [89.124.12.13] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1b4658af-5848-4db5-d446-08d8b3decaef x-ms-traffictypediagnostic: PH0PR11MB4933: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: h3BEFDFuLY6rp6ropT8Gf4rYBhApLUwpw8IWXgdLCdyXDBF70tRCCOriAV0b/mxfvJP1wkmagHYQENnonr+uQ3weav37kn03rsDNXl4wPFtutP0e+hixP5o+KxxZZg3Idmk+eWHu5VdvVUXQI1jangyIKRkmL/9W3weKtuZSz0QpidNdTmml4fp/BXe+EWJ+LDaAFzHiUJktN2BLnOEf0KL2Wjy/v5TPTn5S4jX/t5kPDSKZDg4wjqRx9hvuJw0r0EKWySXasXljYv6xMtGiGbQd8LG/bPM8Jn87OVR+PS8lMIHwA0Ff5JW/mB2mztlYoHG+opp2vpaobLDnDoEB7ohIEtsD7HnSy5NMC3tVcRksAeVOWEMmyX0zlC5640jBO2SlQPjXm4mBajRhrAvZeTmdbYUfGHu0yhpPsC5yfohTwmav3sxe6CI4e9rNLMHXGWnZU9Y/RUCdrcK+7LpAtw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB4776.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(346002)(136003)(396003)(39860400002)(366004)(2906002)(76116006)(53546011)(83380400001)(6506007)(66446008)(55016002)(66476007)(9686003)(966005)(66946007)(26005)(186003)(33656002)(64756008)(478600001)(66556008)(8936002)(6636002)(86362001)(71200400001)(5660300002)(8676002)(316002)(54906003)(7696005)(4326008)(110136005)(52536014); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?rStaPMlCiYvz6bOrs+YaYb/ZAeKm4l44dQWCrH4LtbOs3nYdzeut0PqILYlP?= =?us-ascii?Q?5Eboym9xXO4JTpFJmapMgJTgcBlT6ZU3x/rdSO7ydoSk9Yi4P/nHbK6iWd+k?= =?us-ascii?Q?s9loW/hH5YfN3fEAhI182A3cMuUPIXBBmwMPBP02aaXFFgVE/GWi7c5rphXL?= =?us-ascii?Q?F6SMeGrGZkSMYoG5ROm0URYouj56A7IgcGggwFxCnxbxBWhOghv5XetsCxp3?= =?us-ascii?Q?L0UKJDqRqpvnR1PmZC1Rk6GSlWTRc4VgpshxqqYgVGL+teFhn/JFvkvJzOdW?= =?us-ascii?Q?GmAMjl/Yv59dxYGAO9BzBv7NomhJGAaOesdT5dgd+56ybANTQPm6Tuwf8zWM?= =?us-ascii?Q?z8u/nDghG9Fix5LqzhNkyMLKXgFISVYlycZifqy4NnJWqMQe+J8n36iTXfo6?= =?us-ascii?Q?INmLEvtYVAuY8krujEyblCzLmIbW5ynMD2YOvAb7KlFDFKzBY8ApTVPiPDpJ?= =?us-ascii?Q?HdQo55mBIOGFF5kKig5I9Jgd7wBecDpVam2g4kXP4XT791AYFZ8Xdpyc0UiZ?= =?us-ascii?Q?XuKQJ9sUjY17yAp+k/W6K3T5O/lcAJhFrVyXCbgtTZ5PPCh0Xv9h1EGq3pns?= =?us-ascii?Q?Z+rvjiHomIK/9MQJB1Kg9HBYhUg0P0Gq35GopT9pwuz1efhlFcMmjI8XJMAF?= =?us-ascii?Q?snmtUfTQcPlt3XvteBNV/06TgcvqSNnYDApkcAjvIk4lZpwnD9UMsC7mvgXK?= =?us-ascii?Q?A2jIzPJVwxExfUfr8VGC+D0jNjdEIWNymeEcQXLTwPGEGqn+qYS2EHjxGSfV?= =?us-ascii?Q?sgdhLsYR3wMY55jMmoDMPb2aTztBIgPl8yYcMaA4PSdC5TadQQ8yoCVIFg9o?= =?us-ascii?Q?16Iwxo4tcKHwXYHf8+4kU+f2efzN8W2yt6wPPmyh+fOKdMX+jOhGEDyXj8S6?= =?us-ascii?Q?Ieia8AGfTwKDrvcksVst3yEtEhlChJR1Oy4IcwdnE2m/3BCcwyEEbwU7YK4N?= =?us-ascii?Q?WnifpoVeKwqEXqvIipleqvcEhNpUEpOfGdIfpH4vIzc=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4776.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1b4658af-5848-4db5-d446-08d8b3decaef X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jan 2021 14:07:53.9332 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 4df9VkYZVK+jQlYH8tmVf1tH0OmPEuLLHLHh1OnZ9aXIow1bzRbJWDqAMt3h7jK2dwVm4E4BiObyWws+i+ywmQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4933 X-OriginatorOrg: intel.com X-Mailman-Approved-At: Mon, 11 Jan 2021 13:30:48 +0100 Subject: Re: [dpdk-dev] [dpdk-dev v2 1/2] ethdev: add new tunnel type for ecpri X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Thomas Monjalon > Sent: Friday 8 January 2021 14:06 > To: Guo, Jia ; Zhang, Qi Z ; > Yigit, Ferruh > Cc: Wu, Jingjing ; Yang, Qiming > ; Wang, Haiyue ; > dev@dpdk.org; andrew.rybchenko@oktetlabs.ru; orika@nvidia.com; > getelson@nvidia.com; Dodji Seketeli ; Kinsella, Ray > > Subject: Re: [dpdk-dev] [dpdk-dev v2 1/2] ethdev: add new tunnel type > for ecpri >=20 > 08/01/2021 11:43, Ferruh Yigit: > > On 1/8/2021 10:23 AM, Thomas Monjalon wrote: > > > 08/01/2021 10:22, Ferruh Yigit: > > >> On 1/7/2021 1:33 PM, Thomas Monjalon wrote: > > >>> 07/01/2021 13:47, Zhang, Qi Z: > > >>>> From: Thomas Monjalon > > >>>>> 07/01/2021 10:32, Guo, Jia: > > >>>>>> From: Thomas Monjalon > > >>>>>>> Sorry, it is a nack. > > >>>>>>> BTW, it is probably breaking the ABI because of > RTE_TUNNEL_TYPE_MAX. > > >>>> > > >>>> Yes that may break the ABI but fortunately the checking-abi- > compatibility tool shows negative :) , thanks Ferruh' s guide. > > >>>> https://github.com/ferruhy/dpdk/actions/runs/468859673 > > >>> > > >>> That's very strange. An enum value is changed. > > >>> Why it is not flagged by libabigail? > > >> > > >> As long as the enum values not sent to the application and kept > > >> within the library, changing their values shouldn't be problem. > > > > > > But RTE_TUNNEL_TYPE_MAX is part of lib/librte_ethdev/rte_ethdev.h > so > > > it is exposed to the application. > > > I think it is a case of ABI breakage. > > > > Yes it is exposed to the application. But in runtime does it > exchanged > > between library and application is the issue I think. > > For this case it seems it is not, so not an ABI break. >=20 > If I create a table of size RTE_TUNNEL_TYPE_MAX with DPDK 20.11, I will > get an overflow when writing to the new ECPRI index. I guess the question is - are you likely to do this? > The question is: can I receive the ECPRI value dynamically from ethdev? > If yes, it is an ABI breakage. But I cannot think of such case now. Ray K