From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 497C3A00BE; Thu, 17 Feb 2022 14:29:33 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0FD8340150; Thu, 17 Feb 2022 14:29:33 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 144AF40042 for ; Thu, 17 Feb 2022 14:29:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645104571; x=1676640571; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=nFwLtZOfNAk0McNUJNeNxOeySh0AlYzb1UHq1MFgJRg=; b=PBbMKvCsVTetwMrwUFHfPVnHogoH2FZMmc3YqKMoxGOTNkEN1YFhKSE+ /yUoxxfXHGMZfUkIU2kQ38LxthpbD86NHKhrfefpeAHOBVcdwYDfl0uNX +RsTFMqUM4ELdjow9uHzU0cW8g6j0uDIXg55/IafTKYB0EYGS1cezNa4C GwiDBqLFThoj55q1nzDksWazmj0Xc5h1SA8mEKm5Kb8SCiY3+k23P7Ha3 MztPUTE0Pd1Ek3/7LMkR0t3UEL4GkZukng/bvGYFVuuJ/kF6hlGG+BurT /dOwe30ijJIlr7Km6VWxqYrW/cfk6OTfw6A5QPlhoqyEnLutQIt9qoMT6 Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10260"; a="275461639" X-IronPort-AV: E=Sophos;i="5.88,375,1635231600"; d="scan'208";a="275461639" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Feb 2022 05:29:30 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,375,1635231600"; d="scan'208";a="545599722" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga008.jf.intel.com with ESMTP; 17 Feb 2022 05:29:29 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 17 Feb 2022 05:29:29 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Thu, 17 Feb 2022 05:29:29 -0800 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.40) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Thu, 17 Feb 2022 05:29:29 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cnpJKWzSiTaw/xA7SMvQOoZWWiB9ZSXWhoEdwv0qnWxHFueDzlkvr5EByl9vMogKF9jzrhkHU9vi2Mtd2seSR3y6YEuxTQ/pI70cEOurz0rg7KM8s67399ZtgheCJFZOPvZjnz8y3/cV7fZcYc2ys/0Gl66FbAQ42FUQpig0FzZOoxxLD+NmxSfRSzmkTD2dCRZDSBOtKhlIn+oqZzFXBi0oFO8shAax4s9JkQGrwkyRapsxBW/xBvacpm1UedPseKrg8ht4tVZ4bKWdL4CKzZB+RK7KkRMzRj6BQcx27uvX7LAMEojeh4XP49L5chjQbCRbIlrDDE5KK7ty1mEivw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SnPMQkyE8+uP9t7iUKYk6HW/O0QjDa6xrEf3IHMLoTE=; b=JKgBAyYo10FJkTwoKt+srOpZ535mFWF6uCiHP3tJ/ljHYequx1f7e8MRAj+GnBan6qA2TD3uZ2ek/U9OQtXyBzrXhNdTZXrsetX2wj5a8t8HHiz9e5tSuDrmke47V8MHJM52H2wnVF4C4waavkKtUpJWEV1IxYLl2LYqOoh0eALhYAzjrSp2WwokMJfUpLCL+SU4tdGajBKlAHJ29HKL48BPbgIjEbM/HEPuN6mWpg1M/HsrWNUkL1g6DcESIMT3OqxIvlVfFuBeD1Imm7S9O0Uk7ZFe0J8nI+LkUSylpY84jcsX2wM3ItAH0A5EBKfYYBkwyxJ7cROIxh1QifRHng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from PH0PR11MB4791.namprd11.prod.outlook.com (2603:10b6:510:43::10) by MN2PR11MB4096.namprd11.prod.outlook.com (2603:10b6:208:138::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.14; Thu, 17 Feb 2022 13:29:26 +0000 Received: from PH0PR11MB4791.namprd11.prod.outlook.com ([fe80::b58f:bb46:9881:3771]) by PH0PR11MB4791.namprd11.prod.outlook.com ([fe80::b58f:bb46:9881:3771%5]) with mapi id 15.20.4995.016; Thu, 17 Feb 2022 13:29:26 +0000 From: "Loftus, Ciara" To: Junxiao Shi , "dev@dpdk.org" Subject: RE: [PATCH v2] net/af_xdp: allow operation when multiprocess is disabled Thread-Topic: [PATCH v2] net/af_xdp: allow operation when multiprocess is disabled Thread-Index: AQHYI++juY9h+jBP9EGTLdPDSq/umqyXvKuQ Date: Thu, 17 Feb 2022 13:29:26 +0000 Message-ID: References: <2c42205a4bcc20cd@cs.arizona.edu> <2c422567d3640972@cs.arizona.edu> In-Reply-To: <2c422567d3640972@cs.arizona.edu> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8912b47c-07b5-4eb2-ea1c-08d9f21984e7 x-ms-traffictypediagnostic: MN2PR11MB4096:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:178; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: YP2U5K5+0LZlsTu8a0KMrDzIJl2L/NVNpDMKAC6bIE6bySx67F7ojNqSofrfcczSFs0Fhd8huwNnL5TIQIZUgVBAl0hCujurULiugmaP9tUaUxl9hI4AVm4Z4CiG9JXqSjm5wnfEVF746a1sjVMRiipj3Nh5oNrvUt9QTYwlk8qb+HgJjUtrCjqNKENWOstW296OT4sU3vcyPD3UygElUA3Dg4K188mEfWfGqtbeZll0aX4FFJAZIEAy8e+huJwu7MfjseRJs8FFeLz38hi2+cqY3U2L1KM7K4jSi0e1AZnWXDjZhKZR+cEt/VRUq1UHwKxKuOBA4S2cUvWZpEMJWiN3673YR4wBTbLhu2lX1erxwbTuTVrP5B3hi8uBd+dIX3vL8ipgK8p9ULJvzWJdDediONAB4X8DVf1m7KWQ2wMhotq87mSMcA2k+HDmhoY2gsmFYbnEyLSnI9FFUuLrnwxz1GiEDzsEYPbqs8ZxlMkYLCt8ooAAlmAzEnsyd6OzMoMTFsBa7EJ+iXNLVH4r98cZoJ60wNSW5HrbVxSRCJl+Ecpt+3p6b6yLibOCm/anyJ2eCqrkLScLVNNxGVwbP4jrIIljM6ByYF08JTlU0oem4XVJ+6C3pMKK5ppkGPm26RfdDpevZBn7UOKYltmXTIlDpS0NorwyeA+/Pk2GVd4KQgjPJpvSCXRBM0lBNRAyNInB7xetW54h+dfb8VE8vw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB4791.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(55016003)(86362001)(8676002)(38100700002)(71200400001)(8936002)(66556008)(33656002)(76116006)(66476007)(66946007)(66446008)(38070700005)(9686003)(83380400001)(64756008)(52536014)(5660300002)(186003)(110136005)(508600001)(82960400001)(122000001)(316002)(7696005)(2906002)(6506007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?BpfFPxIV7uq/Fju2Q1dFhfYyyVhM0tbxRza559/f+d+RdrdGWFnl9qJNlffa?= =?us-ascii?Q?HWGdgY8FGXcs1gNolaDgWGK2MUOoph+oBv2lHn8tiu7ZO0Yg3bUsDepVm7du?= =?us-ascii?Q?BBa6Q2maSKbygoKMFo1geDy8QChur5isxzwEbXCY7fQ1Gw4nMQruvOEDoA+q?= =?us-ascii?Q?lA3jWsbFvUqRdfGwxFnF6anBtvh332zS806N6MGLfjQ0qsQPoj21CI+sgU1L?= =?us-ascii?Q?udDuf8TN6LPxagEEBUP+Co8ffr8ph25DqTDlJfm/ROAGkM5lAMV71VHNgmQN?= =?us-ascii?Q?qIyT1q3X3QFpRZsL4MOnN34CaN5vPqe+GRx65uvggpa9CKRlsHZH8dCZdUNt?= =?us-ascii?Q?AWkjinvCQJDR5IuSaqvC0m6QnkKQ7VSi/jAl2mH38ZvyM4TyztI5wI5UbPf1?= =?us-ascii?Q?xPfBSIQ2eXs7dGmyXrOhxvTxjp/hjiq64N11wmoD+U+xyVOzfR3c4nHRpnfQ?= =?us-ascii?Q?FwvUJtazlTOEP058iCBWqc+HE2+Fd6GOlR6gWU8NUZFp9ngGwbrK22zek7h9?= =?us-ascii?Q?kbwBQj9i0leA5jCIUw8sBJU5wu5ngOZhqwOYeNDd+ABfPSIkLJQ7NZVoIBib?= =?us-ascii?Q?S5JtXh0hPg6Zb6xEIkTN3Hg/57XuUPVh1rywvisuZ99MZgJFYcJbFduvEcF1?= =?us-ascii?Q?bX8zp1eLMKvrr5gbYpCibBesfVeB/m7XqU/0mvEKWogP1VTpL7y4ZmbYd2zB?= =?us-ascii?Q?SIxmW6PgZ6Kk0CyUe3zan95mdB8Cf6l75H387zWU2tp36n5wuxik1k9S/m2l?= =?us-ascii?Q?5Ivc628Rq6eVf2tmKznIn9BbI3od+2Pyi7FUzvsxMGXrWVqpJgawaqSLh0jv?= =?us-ascii?Q?2kBpFED+Y2RkEbZfgmoAidUJdbWa+oaq+YyW17CGw6rhlgrevlBec1VcNHBV?= =?us-ascii?Q?o2C70cnAhu0kmT1fDlwxl54UHPY8UVu3Ypn1p2yYuX8xRW3ujo4IrYqidhCL?= =?us-ascii?Q?uS9NiLBS0ljPhD+7vo/D8dCrRIWLuUmHXMnfqZECoSuK3lCFt6B8begYnx/H?= =?us-ascii?Q?dHRk5TzC6dgLsmbO3B4mqR/+dtiAV79XccxdqtoBY0aUUOfWNJETBRW+jGlb?= =?us-ascii?Q?iKAtjnsjAuhjlvjWEdDCwAAoND/xIHeAwaiRP0qTo/KvD8JuEnHqJzEuCn9i?= =?us-ascii?Q?7GtNJcNirnPXyoQj+4quynMZYIewG82m4dGoadB9UWtQYqvPG7jNOhLX/uQe?= =?us-ascii?Q?kthwPaeGCvaYPbF4+iqVr8g3emhop1+TtrEp7d9HT54kE7O1eTBsl0FmqJbA?= =?us-ascii?Q?ktvAPEO294VNGgobWXQVjhkr6XtcKyPjiN55iYEi08n9bCW4YC8ikilUKqRL?= =?us-ascii?Q?3cARHe+xA9kvgTggl3jZXCchOqfmXYR9cmJRJVB/G1MWhpYlcQfnfReDuPEo?= =?us-ascii?Q?8BhxZed9rV2BwEjNqb0OLrULDOypcM/hbFtLlJhPQJ/0emdb8POgS26pJoSO?= =?us-ascii?Q?OUi3KN12/wo5IPgkQKs6mhS/4f3fI806XRt27DXlEKIID5a7JdwoeSC62QXY?= =?us-ascii?Q?pYpTVDTm7UO9NYyLDoH6BkW1cB4gDXx3M5vhxmXih0tsk5QYoTDJlAPKhsup?= =?us-ascii?Q?yline6oZRx0dHGlsUncOkDK/l5K7oT0alwYKgY1Bh00B1b0NtzHJvxCxSKv+?= =?us-ascii?Q?rHwYXdXkK4ywl5mo7+ufn5C0cEIja8yTvp5lphl8wo2AJWuGc6vJHsMB56k+?= =?us-ascii?Q?qWd8TQ=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4791.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8912b47c-07b5-4eb2-ea1c-08d9f21984e7 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Feb 2022 13:29:26.7049 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: h3/uc2kfEoJQy8PXjWHzaGvTDC1vcXlg1RqtfY3v3YQW1ipuxtag14pZIbtt0zaJ9t96I72+twkzysz9AHPQ/Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4096 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > Subject: [PATCH v2] net/af_xdp: allow operation when multiprocess is > disabled >=20 > If EAL multiprocess feature has been disabled via rte_mp_disable() > function, AF_XDP driver may not be able to register its IPC callback. > Previously this leads to probe failure. > This commit adds a check for this condition so that AF_XDP can still be > used even if multiprocess is disabled. >=20 > Fixes: 9876cf8316b3 ("net/af_xdp: re-enable secondary process support") >=20 > Signed-off-by: Junxiao Shi Thanks for the patch! Acked-by: Ciara Loftus > --- > drivers/net/af_xdp/rte_eth_af_xdp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c > b/drivers/net/af_xdp/rte_eth_af_xdp.c > index 6ac710c6bd..2163df7c5c 100644 > --- a/drivers/net/af_xdp/rte_eth_af_xdp.c > +++ b/drivers/net/af_xdp/rte_eth_af_xdp.c > @@ -1995,7 +1995,7 @@ rte_pmd_af_xdp_probe(struct rte_vdev_device > *dev) > /* Register IPC callback which shares xsk fds from primary to > secondary */ > if (!afxdp_dev_count) { > ret =3D rte_mp_action_register(ETH_AF_XDP_MP_KEY, > afxdp_mp_send_fds); > - if (ret < 0) { > + if (ret < 0 && rte_errno !=3D ENOTSUP) { > AF_XDP_LOG(ERR, "%s: Failed to register multi- > process IPC callback: %s", > name, strerror(rte_errno)); > return -1; > -- > 2.17.1