Re: [dpdk-dev] [PATCH] net/af_xdp: use bpf link for XDP programs

["Loftus, Ciara" <ciara.loftus@intel.com>]

> 
> On 10/14/2021 10:50 AM, Ciara Loftus wrote:
> > --- a/drivers/net/af_xdp/compat.h
> > +++ b/drivers/net/af_xdp/compat.h
> > @@ -2,9 +2,11 @@
> >    * Copyright(c) 2020 Intel Corporation.
> >    */
> >
> > +#include <bpf/bpf.h>
> >   #include <bpf/xsk.h>
> >   #include <linux/version.h>
> >   #include <poll.h>
> > +#include <xdp/filter.h>
> 
> Hi Ciara,
> 
> I am getting build error because xdp/filter.h is missing [1], where
> that header should be?
> And should the meson recognize the missing header/library and behave
> according, or is the build error expected?

My mistake. This header shouldn't be included. Thank you for catching this.
It was to provide the macros BPF_MOV64_IMM and BPF_EXIT_INSN but we can derive these from the bpf/bph.h header and remove this dependency. I will implement this in the v2.

PS I noticed the PMD will not initialize since the "fix max Rx packet length" series. Probably an incorrect value for max_rx_pktlen in the PMD. I will look into it and provide a patch.

Thanks,
Ciara

> 
> 
> [1]
> In file included from ../drivers/net/af_xdp/rte_eth_af_xdp.c:42:
> ../drivers/net/af_xdp/compat.h:9:10: fatal error: xdp/filter.h: No such file or
> directory
>      9 | #include <xdp/filter.h>
>        |