RE: [PATCH v1] eventdev/crypto_adapter: remove logically dead code

["Gujjar, Abhinandan S" <abhinandan.gujjar@intel.com>]

Acked-by: Abhinandan Gujjar <abhinandan.gujjar@intel.com>

> -----Original Message-----
> From: Kundapura, Ganapati <ganapati.kundapura@intel.com>
> Sent: Wednesday, February 23, 2022 1:05 PM
> To: Jayatheerthan, Jay <jay.jayatheerthan@intel.com>;
> jerinjacobk@gmail.com; Gujjar, Abhinandan S
> <abhinandan.gujjar@intel.com>; dev@dpdk.org
> Subject: [PATCH v1] eventdev/crypto_adapter: remove logically dead code
> 
> eca_cryptodev_cdev_flush() is internal function and called with valid range
> of cdevs.
> 
> crypto_cdev_info structure is allocated at adapter creation time and
> retrieved from the adapter for a valid cdevs which cannot be NULL and
> hence no need for NULL check.
> 
> Fixes: 2ae84b39ae7b ("eventdev/crypto: store operations in circular buffer")
> 
> Signed-off-by: Ganapati Kundapura <ganapati.kundapura@intel.com>
> 
> diff --git a/lib/eventdev/rte_event_crypto_adapter.c
> b/lib/eventdev/rte_event_crypto_adapter.c
> index 0b484f3..f624f50 100644
> --- a/lib/eventdev/rte_event_crypto_adapter.c
> +++ b/lib/eventdev/rte_event_crypto_adapter.c
> @@ -529,10 +529,8 @@ eca_crypto_cdev_flush(struct
> event_crypto_adapter *adapter,
>  	uint16_t qp;
> 
>  	curr_dev = &adapter->cdevs[cdev_id];
> -	if (unlikely(curr_dev == NULL))
> -		return 0;
> -
>  	dev = rte_cryptodev_pmd_get_dev(cdev_id);
> +
>  	for (qp = 0; qp < dev->data->nb_queue_pairs; qp++) {
> 
>  		curr_queue = &curr_dev->qpairs[qp];
> --
> 2.6.4