From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 235FEA0353; Thu, 24 Feb 2022 04:12:06 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BC58541C27; Thu, 24 Feb 2022 04:11:21 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 1AC85411C9 for ; Thu, 24 Feb 2022 04:11:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645672277; x=1677208277; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=SfSp/1LQeBK7O9AhZE9QpI7AX/AIK3o4mlJ1PxhYIAI=; b=VbY/QsuZliTT8n2Gfr0QUnUvRPVdrx+pkrz6unqkwgop4sLsZYkID+Du XBiFDkTao7JPSH0ZvvwND0WiI+zQixgNLbqBakub/mPdG/YE4hMKgdRak EcfyzKdelCTTiT2/1Bwtak6JMB8UqEtqOg5nVqOAtvk9XA5TSJCRNSUKJ l0RZSHw4dTtIb+6Ph6m835oxjD6xLr3gkRjp++38OUQctNLFCEnko8Eqp unfGDx65OGVgDY2ZwJb6PS7ZuhhvjTadMbV/RTf4aBETCXX+FKYx2dFd/ tohMKCDydkffqPSRjotVuQtbkQKp3sFaYiyVkTflJxSWPmPw8rYwqmH9b A==; X-IronPort-AV: E=McAfee;i="6200,9189,10267"; a="251873954" X-IronPort-AV: E=Sophos;i="5.88,392,1635231600"; d="scan'208";a="251873954" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2022 19:11:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,392,1635231600"; d="scan'208";a="532956220" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by orsmga007.jf.intel.com with ESMTP; 23 Feb 2022 19:11:16 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Wed, 23 Feb 2022 19:11:15 -0800 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 23 Feb 2022 19:11:15 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Wed, 23 Feb 2022 19:11:15 -0800 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.173) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Wed, 23 Feb 2022 19:11:14 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MNufwO0l9mMauAS+keZzzVUpHi2MsBVLNGeFzsuwsaeEI6kPw63U/boH81xbokvGScFdwMRM3t9gZCM4B0iVtVszrO21N127teR8/21KGfMBTAoHK495xnqqmFLy9T73hazvoCfZrM9M4UEGvBKT99jFVgyw6ue9vEAXNWRuT+g4BmhMi5NTtsvFNiT+JsS/4MlRDORv8rruAuJfHDcyzqh2RsPa/bVJmvfYiuOUJJs9AmUvIvJRSFURR+IMsJCGVO39qWS7c06nzcsDo7LJbcJ/KRbsmFtFjF+fsugTm7u2/6/4z3LbuohFIJwhYsrTwrzhvsWTEXYCAm5P9Rbiig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ke7mlMqdgw0n/lFhPNnZpXxsbx7dFyqkn4QMSS+4j7Q=; b=WfAHtnC1bbAUyY+cddB09mhtTJ8lkcFlNUdO/brjHSw9zh4IueGDo3At6u7O14joPwoe3Qx8BDPlufWFQFCuNQpSoVt/ArHle5HLZ7gZyNbBCnxYoOGIunHRHjuUcQnjoAwUfkb9LgGZXRce7JUrLq+wysQNgVm41N+mvLqh/j6+gOAr86tUyCR8eF/Clwe09V1M5YbRcJXofELfPJ69LElN4JJq6hVnKV47UnZRZiJ7ZxUt5oyVZSlE5Lq4yETq72z3qRG1WU3Bqfdu0LQcmul9d1kY089Beg4nHC5MsYajmCDvnZiR+f84xbxd6JFl2BrXx8LUyAeTecJ3SBHQnQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB4824.namprd11.prod.outlook.com (2603:10b6:510:38::13) by SA2PR11MB5129.namprd11.prod.outlook.com (2603:10b6:806:11f::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.16; Thu, 24 Feb 2022 03:11:13 +0000 Received: from PH0PR11MB4824.namprd11.prod.outlook.com ([fe80::2520:b8df:8b59:bf84]) by PH0PR11MB4824.namprd11.prod.outlook.com ([fe80::2520:b8df:8b59:bf84%6]) with mapi id 15.20.4995.028; Thu, 24 Feb 2022 03:11:12 +0000 From: "Gujjar, Abhinandan S" To: "Kundapura, Ganapati" , "Jayatheerthan, Jay" , "jerinjacobk@gmail.com" , "dev@dpdk.org" Subject: RE: [PATCH v1] eventdev/crypto_adapter: remove logically dead code Thread-Topic: [PATCH v1] eventdev/crypto_adapter: remove logically dead code Thread-Index: AQHYKIfb2xld20avBEagC0pKlsGZBqyiBuPA Date: Thu, 24 Feb 2022 03:11:12 +0000 Message-ID: References: <20220223073443.647695-1-ganapati.kundapura@intel.com> In-Reply-To: <20220223073443.647695-1-ganapati.kundapura@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b5e0decf-afd1-4d84-8c10-08d9f743501b x-ms-traffictypediagnostic: SA2PR11MB5129:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: cXlpdQeYHPXQt/7rFV4fsnw0NBRM2NJ7X79nxxgq9bKXNzZjqMcB3yxajPHx97X7THnKzdC4/bJhRvHp9kn4mchMnkSdwPI+b6ZRzNFgdM6PfyVCLIxcfOns5YM3xgSV/wWizi6v9xWHGyVvICDieU8q4WIfFcB5vQmrOtkJ1EOahv912kAc5Xdmanb06W2jAlEMJmKubAvDZOLM9uUALqPhYW0HH/hVB8FyKbjHpnRzjmyKrp2CA7llB2AmQv4UKkBWUQ0pwR/fAtAdKQEDjYjDk1G4SFHzg4AhUGu72LmnQS6URQVoxbEwyKNuXsiEJDaHriYpIf1xnHAWZzv1JG0noU1kxfniqEWAier7XzFXlSr8rLB7yFqUHt/5KZjIogVvzxsEhZclMuuiEvbYk0TsnKz/nTEwWZa8Z+M0UVHDvIttt33bflMVYThSu+z9nTtiea2EMZN9okm6UgLOnQnmAp6as0UcmFpaPkDiXNb4mdpZnFiO6Le4lMvziXcsI297ow+1gBVvzTLWx5iPH5gVJ+3qN2/1X3IxjH1IeqqPNOIX5kZkJYgZyVEILMYK18YRKVXvHcMFgHNplDwPN8dioGlnO9zNkNhArfGK51iGbfAYW1ljSFccBPIW9FT/ZzzE8QAAQsWnI32+1QL4JdRZaSj20wlgvsEfHnw20A654DkQgKn4zsNh71rTNZ9K5Wz1nfQK6HT87lQ0zOkYKQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB4824.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(66556008)(316002)(122000001)(66446008)(64756008)(66476007)(66946007)(55016003)(76116006)(8676002)(53546011)(110136005)(83380400001)(186003)(52536014)(508600001)(38100700002)(8936002)(5660300002)(82960400001)(26005)(71200400001)(33656002)(38070700005)(6506007)(7696005)(9686003)(2906002)(86362001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?vMF2x3pA4g3Sp5XZ0TPSFZLGQj2bL1k2KmKOug/lhTWhjYiZ8PrOvrq9ucj4?= =?us-ascii?Q?0V7jxMx/Hh2gY4OhuQ4V0q5D/mO8AOqgvspDxJW7XGhiitQQX6xwV4rOxYD5?= =?us-ascii?Q?o1F8w2FCSR9mbKwidOqCuayLHb5fGoQC2uJtibsf6L7xO7JK/n1W/2vQ5l1d?= =?us-ascii?Q?aiszDoPys3DP5KA4Sj/bJY7Hw2XSO+alKZHW+YvFKd9BAkvq/UrWPuCJ9/0A?= =?us-ascii?Q?JFlYQf8oJUE7/bVJMc4vGjclBOhQFgaxRyG5E0CgKFJeusnq87K0iXsxLBkS?= =?us-ascii?Q?n9KbPvIyUmhWLsPOpi9DKBmo4injI+gvOKr8JzZx5uIbxHo+1M6lzVifp+eF?= =?us-ascii?Q?l2CkM9L9IJlrNGVN0k4T/rFGFfaCJxcVdpzSDEMDNTOigvDiKuuLxCpZyJET?= =?us-ascii?Q?mDjs55yGrRMYBpznXzsbrQ8QmvkEU8H9mTlaIMDHrDNJ1Bv6RtYt9Hh9Lkfs?= =?us-ascii?Q?sk1NZxI0G13OCn1uoY8dmHBxjHT2sR1Oslzmcgv4RG/1AQVSvEq/NYw4npUP?= =?us-ascii?Q?pWiYPQLsRwPGF9EB+4BhcjlLnP+mjFHpWDvCxWkN63a18vLovMQXeo9+5FW9?= =?us-ascii?Q?PHLjJkVWz50GgGmH8lzgID1rMO+hUX0O+5MTBVjHKJnOlubPWSks2O9GYdUl?= =?us-ascii?Q?aZ8QUHqnVFGUjozbko/6S5f6tlHLdBPbu/eB2qZMgqjkVh85vCMfGyUBltlM?= =?us-ascii?Q?hGRVL+vYGlU8dteIcWt7fNrOzV04eKKiXqkOE+HZyfG3Ei4aekbhO7iraDSL?= =?us-ascii?Q?/G4Q8NBmjDDvF6whr3ZKF35sJOKmuF6HCOo4/lkLntRH3gewRBk8GS2Un9c2?= =?us-ascii?Q?Y8PsTnTihMxJHfccLY/5sN0o1J68lJNE65n3Qd+WZX2TLomcOuxkVSfN/7He?= =?us-ascii?Q?UZGgtXiAPUFH6QdUbrm3lfNH8RsI2x1DgruryM8anpyPQeq4cacbzDsqvMAs?= =?us-ascii?Q?gvCf9glj6H5Q6G/sxFZxFjHfyFnJjMa1AwQCOC59Re9Tb9AiX/zENIlyjAQu?= =?us-ascii?Q?EgqXIY7Gt2z82Kc3xzS6Ox5fwMI9QeDN7c20wfLwpFh83U243X5PCAzqat7Z?= =?us-ascii?Q?HdXQlw/xZ12kvWUI/giv/EZAmIZ9XkOJsS4jQn3wMqzXHT5z5IEwg75eEQ0R?= =?us-ascii?Q?e4rIWP8DPs1e6a8UxBtj7UhoYL0m+5n07142ihvNBa/p8IHi3lW3UgqD7bpm?= =?us-ascii?Q?0AFZmzB5MY9priEAcr+R1eRQ97rMBB/lhnp5Y21jrS7nrOy/gZez+/OXwPdj?= =?us-ascii?Q?whqAKM/nTH1pzyjjyjOBbt5yMqbxOz4yUBz+2pWy04kCZAu2BUVaKl5uFVsm?= =?us-ascii?Q?aLA24iFtza4EqeCP8TcoZlDISNlAMySkHk+kgrf1xBU5qOsZEC4+4Kzduf0N?= =?us-ascii?Q?Qo26gwc/NCsBU9q2jQGjlb3+EnBixe7nS9nr8q/p2ckjdJH307EtJBF2W5Xg?= =?us-ascii?Q?8X05WZ/q8cP+xu5MV6kteskcOF7wbCihjAMO9DG7rky7gQaL9HilVMSQTSnw?= =?us-ascii?Q?6R3FEgGu+QGutKfFsE8oWUZjqvHFwTygw/7OjfbkaYO5OKymbvZCzjTm2aJL?= =?us-ascii?Q?egG5ILsMwE9i/aILfMR9wUhI1R5iSZCci+8u1ui6RDw2hViOspD9t9Y91dbf?= =?us-ascii?Q?QcRL+UhoQRclYBNpn1XDNxzLSsc8AoML308a4A374Ohwn86aQ9iLbQpipjU8?= =?us-ascii?Q?9Q8UJw=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4824.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b5e0decf-afd1-4d84-8c10-08d9f743501b X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Feb 2022 03:11:12.7550 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Lq+Gws25zBETtAYs96YfmhLOpBdZg32EBRjCi9AEDmhf+XrN5gU7mkeBH9IGugdJEsSucrBmRrOzJSPuFxGl8FOIpY9BGE4Fh+7MYV3uPXk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5129 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Acked-by: Abhinandan Gujjar > -----Original Message----- > From: Kundapura, Ganapati > Sent: Wednesday, February 23, 2022 1:05 PM > To: Jayatheerthan, Jay ; > jerinjacobk@gmail.com; Gujjar, Abhinandan S > ; dev@dpdk.org > Subject: [PATCH v1] eventdev/crypto_adapter: remove logically dead code >=20 > eca_cryptodev_cdev_flush() is internal function and called with valid ran= ge > of cdevs. >=20 > crypto_cdev_info structure is allocated at adapter creation time and > retrieved from the adapter for a valid cdevs which cannot be NULL and > hence no need for NULL check. >=20 > Fixes: 2ae84b39ae7b ("eventdev/crypto: store operations in circular buffe= r") >=20 > Signed-off-by: Ganapati Kundapura >=20 > diff --git a/lib/eventdev/rte_event_crypto_adapter.c > b/lib/eventdev/rte_event_crypto_adapter.c > index 0b484f3..f624f50 100644 > --- a/lib/eventdev/rte_event_crypto_adapter.c > +++ b/lib/eventdev/rte_event_crypto_adapter.c > @@ -529,10 +529,8 @@ eca_crypto_cdev_flush(struct > event_crypto_adapter *adapter, > uint16_t qp; >=20 > curr_dev =3D &adapter->cdevs[cdev_id]; > - if (unlikely(curr_dev =3D=3D NULL)) > - return 0; > - > dev =3D rte_cryptodev_pmd_get_dev(cdev_id); > + > for (qp =3D 0; qp < dev->data->nb_queue_pairs; qp++) { >=20 > curr_queue =3D &curr_dev->qpairs[qp]; > -- > 2.6.4