From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0E60C42D5F; Mon, 26 Jun 2023 20:21:01 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9007640223; Mon, 26 Jun 2023 20:21:00 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 709114013F for ; Mon, 26 Jun 2023 20:20:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687803659; x=1719339659; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=RXL5RUW9bSZmRxZ6OhIrGdCp1iE5ZyMHtG7OOJnEPXw=; b=g3MRzWCOd5Wg0IBQPYn+qYdFxLLPSBwAhQMGBolrpXsNI6j0gSVAhFse t90kuAFsK3Jjq3YORDMsTLJLnN+FOyMrs4RR+2hfk1HrOqegH2b0Hrx1A PZrsdDJLtFZhG9r6TMXyT0HghmJ9tUpjAf8aIzWodwD6CcwQ0Yd7qvdDP grnH479IHzUzBSzzF/UnsLN3Zei+B1RwLfTV5ST8/yxRgTbf3y5JfwsIQ IxH7qm6CrJQ9i05f1KvU9SKtb+oC4565/yS4TcEL7AaLhcNF3MxlYzBWv ChaiL/ffFDExEGMfOgIx1GV1cqnsMMbhFu7Wc6t+yX15UqMCq7BMf0gay w==; X-IronPort-AV: E=McAfee;i="6600,9927,10753"; a="358848321" X-IronPort-AV: E=Sophos;i="6.01,160,1684825200"; d="scan'208";a="358848321" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jun 2023 11:20:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10753"; a="860786548" X-IronPort-AV: E=Sophos;i="6.01,160,1684825200"; d="scan'208";a="860786548" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga001.fm.intel.com with ESMTP; 26 Jun 2023 11:20:57 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 26 Jun 2023 11:20:56 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 26 Jun 2023 11:20:56 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Mon, 26 Jun 2023 11:20:56 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.45) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Mon, 26 Jun 2023 11:20:56 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V76fmMIxyrJVTSpX6Qz759oKjmfOyO/PbE5Hy7n3JiFu/5KMYCF6IgGtZ3lSmRN8D89PLMCxwrrBJsi/z3HHdEqtNKkCMaa65VckbPjTr2LysBpy8MKxdBsK4LIpft2UO/SRK7KkDUdOHzNRbaPC1DpxhbS3iRmvV90UBuDzYeo0sFkfjqNnPXtolcyEvni5qyQc6HbpyqRIDBOQME40S7MKcJdDUQlmntEOhA6XK1K5MReLQYSwjB1CXRBJleqdOLb/sDmSNy0+6hPpldYOIq6B8jvvNvsdVdiD0Vnsmnd8cBpWB93TtPByWQD5v0mdEUlTaTQ6qkzi+d5ctDpLyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RXL5RUW9bSZmRxZ6OhIrGdCp1iE5ZyMHtG7OOJnEPXw=; b=GF715tWzkPa/q5p6GViDYefC8W4EiW66i4RJ/lS/1GJOtgZ9oPouzO1M0i3/NN9Rcv9cf42I/JeBaw1YymzVzZKA3likigcnQA/lXIlstmWGLRNcneJAb1DBUOS9k+6J8SNonnrbZ85e0YXUHBfZ6GpWGPwUtfbPkxm/Yqe1v+NI9JyitIECBbFrbfDtJNkX2pOJINO55Ie/yPVidHyl51Sg7OchWNNTRi7oY0ILB6Y7La/GIt1LlzqIWADfsmoSyQVxaCv8k0pJHnmYOw+q6+JllIPNqVDo9Nm3OXJ0nP41IgmvPbv+RNTZU7qH+JlKh9czqNktEk8qIjcVlqToZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5013.namprd11.prod.outlook.com (2603:10b6:510:30::21) by IA0PR11MB7935.namprd11.prod.outlook.com (2603:10b6:208:40e::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.26; Mon, 26 Jun 2023 18:20:54 +0000 Received: from PH0PR11MB5013.namprd11.prod.outlook.com ([fe80::fcef:c262:ba36:c42f]) by PH0PR11MB5013.namprd11.prod.outlook.com ([fe80::fcef:c262:ba36:c42f%4]) with mapi id 15.20.6521.024; Mon, 26 Jun 2023 18:20:54 +0000 From: "Kusztal, ArkadiuszX" To: "Power, Ciara" , "dev@dpdk.org" CC: "Power, Ciara" , "Ji, Kai" Subject: RE: [PATCH v2] crypto/qat: fix NULL algorithm digest placement Thread-Topic: [PATCH v2] crypto/qat: fix NULL algorithm digest placement Thread-Index: AQHZpdnniLSaYHBoG06sJ4lC8M7jPK+dafXw Date: Mon, 26 Jun 2023 18:20:54 +0000 Message-ID: References: <20230621144022.1187874-1-ciara.power@intel.com> <20230623135105.1377882-1-ciara.power@intel.com> In-Reply-To: <20230623135105.1377882-1-ciara.power@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB5013:EE_|IA0PR11MB7935:EE_ x-ms-office365-filtering-correlation-id: 4fb59f64-332f-4cf3-f9ae-08db76721460 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: AH9R2HdarVAyar7OW0UFTd3y22xXbZishi+geAnTMXyKOYxBau7UBVTcI3i32Nmw0X73G5WW58xRVutDed+/xp4CIjlOcCSsXEKxiwcuv3t2BCcA+UP2B4MDo/j9DauQJ+EP9byMlJf5Vn1xfrNA9okEWxLNGsx6nOZcVm/P1xOjItUSCZjb3kgDiFk+slV39S7aw82/pQx5oZaprknCCn/upekUBpsyLRl2QWH63KmWc8sS60VAaooiSBrxzj9E7WFwmuqQyRHqKKFVRJVreIqs182PTCLz06tzunmqssWZrfoq03452Ras5OvgRaHhaEyYKWlwBFryIzzbY2jAAJE8z9FwHTv7psMqkuphNOBOKkTn2EXp0eXxkI5zkw7XkzJIlhL2uWc2xyKlGYJG4LbCctECu2C1WxV+MJcvMRjz/nF09cwMiE3fn9uVbgzEhcwZBO90bDTDD8CnlzbMviTdH8Z2J8Eta7YWrVBUHs5zZ2yKO3Jnvi578P2FlgWoulKeTBu12ZvaXwiwJJ3+RQAxM+GHLd0O1CufjyZ9uGWDyCU/NTwsOELpFyeXm6+bFC3Dnw9AK+2sKo0sNM5kvR9pmSjv/ATKRnwykr+XDOaKxhuggOeXH5HExVpHbBSowSgdzbJau+dsTOz02/MmL1GPfu/WNt58OKq4Q6wnFXE= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5013.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(366004)(39860400002)(376002)(136003)(396003)(346002)(451199021)(2906002)(4744005)(186003)(71200400001)(7696005)(107886003)(122000001)(82960400001)(38100700002)(83380400001)(6506007)(26005)(53546011)(9686003)(55016003)(41300700001)(110136005)(54906003)(38070700005)(86362001)(478600001)(316002)(66556008)(66446008)(4326008)(66946007)(33656002)(64756008)(66476007)(76116006)(5660300002)(52536014)(8676002)(8936002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?03qZ1CtIG+heTKIu7nnUTOasjtEq4it+h1FaqUUJB5XtglYiyMW77AIfJh1u?= =?us-ascii?Q?pxc75lYatS3yxOmbzVXpVQxA24mBk4LtHN3RXOgMvLp2HFipzDAcXrVXO8gT?= =?us-ascii?Q?qyWNzKoSRi1aAWK0OKZ5nIKuGmo2QYRd24avi4fBgAPHFy3yMF/li0tQLxgf?= =?us-ascii?Q?vbOv4Ma7Lykxm7I9PusdeLurgK8cGiByh7EMi52B/twMW6j86mwbQfZJPPRp?= =?us-ascii?Q?QBW91EM4wh4VRMG7s0uwhCEjcjaOMQkDggHj16JQ771agPCUeC3qj7le0TI4?= =?us-ascii?Q?jrnPuvPT5kNDsF64u5S5jbE464fVQEGsiVRGM5WxHSv4rVHHICp40LIhdekK?= =?us-ascii?Q?heT0pz1pvKwXmc/hkmaaSEC3bQNep3jLDWS42jA0xEwjr/fe5cKiqfh/9iaS?= =?us-ascii?Q?34LSJQXxSXcwE5FK0FSN4dIBNPQ30ev22nag11kne64Poz94D0HNOlgm6itk?= =?us-ascii?Q?IFy8ADmTFiFjquWsfuEXK3eyc3+n4ooP4E+COxVhIyOsIsgClACpm3d6vzKD?= =?us-ascii?Q?hQ42GhNXjE3pP0xOIf2ZkBnup9yLu8wU7aMH8Upg5ZjUIRxmLTC2FDJiWsZP?= =?us-ascii?Q?++HOnla26l31eq5yeZ9n9a9jqOEZSczj7wP2h+Fesw2xkdIhw+gUYQO6cJYI?= =?us-ascii?Q?SkXQjgiD+hBDDNbmHu4wJtT7qDzzXnv9gwfHazhjrcyBt6QQpGz6YyDFWWX5?= =?us-ascii?Q?UtHbzV5BYR0pnnUz6jgQMyetXt4tAhABCqPO3mN4zqJrbIABgnvvReAWPJIo?= =?us-ascii?Q?tai5YuXh7lZq2PXfambnHFCv2Dw3UhRE9eMyNJuhQO2hY5vVO60cBqgF4IFj?= =?us-ascii?Q?s1+Rv5EISeDn1WjxgYCSTbBjrk6YBjPMQxL3yopivELf6BxJl2VsT4oHRG83?= =?us-ascii?Q?JbRbMV4EmE2dFEMYj9c4qIr/1Cd1gG4x3FFAfADPCvZhQrU3eU30H5uA/+oM?= =?us-ascii?Q?/0NM9laaAsfZzBM5tU7e3Kh1Pp0VBJh6/kcCANvniF7OBzL0Rez54uLxnawX?= =?us-ascii?Q?M3OvtBWTfFBpfGm2VVGlwjXZP/D2EsK5W2xioWA088/GUHnhiyK8gSi2FaaR?= =?us-ascii?Q?9OBiOe9pRc+yrji4kyUY+HCoyAec7OKwN9q716UfPeoBoA9P0yt3TxIn8NnF?= =?us-ascii?Q?G7CDem4I/CKqBcouXMpFMZgucDLI0Ds46SB/3+Y/KtNF7jD8Rgg9SI8eh4gS?= =?us-ascii?Q?U8B5tMFyVum+bK+ZPKBqeewFfCbS0C2X4+HGmRgmKs/KL6O7sVorxLjlZvlz?= =?us-ascii?Q?PyR7DdqK0qLnORSt5wUZFyAgvT1qNVfYhhDlnHU2Tg/93uVavls55/KJ9d5j?= =?us-ascii?Q?f7ZPqB76vqz0KDqPjmCY3YtQjphzVfMNAfHjMsww6PxRiuv0PdYl2VnHICvH?= =?us-ascii?Q?GAe8GczTRZmURzij0j+nuJgqH/zd4b+LrqpsfvPsjBLI0nIm3GJTNKu4Ie9K?= =?us-ascii?Q?hzZw+ISoz4ofV1l/fUEUmPvmOUARoaFXHYqJKGE2MLPRwdUeJUT1HXvgYgtZ?= =?us-ascii?Q?yqdxWhUHlaFuVJk/pUPAhDWkjSJFnm5vbn63KbbP/JYuGHdA9f9EYiJv3JzL?= =?us-ascii?Q?dIKcXOErSUaHq0Z53U0PuYg9bPlI9pdKfcXKy5U88yDptcP1xy3/qb4TM3Bx?= =?us-ascii?Q?eA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5013.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4fb59f64-332f-4cf3-f9ae-08db76721460 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jun 2023 18:20:54.3293 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: JOMQtDgRn8Pg7uTS2X15IMIcy8YawHW08+vBhG49rmzlHcqD21Fh1G79o9zNbF5FIQ3mCY+RExMa0m5mbBTPeesDsgsdp/FIfgEiWLkIsVs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB7935 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Ciara Power > Sent: Friday, June 23, 2023 3:51 PM > To: dev@dpdk.org > Cc: Power, Ciara ; Ji, Kai > Subject: [PATCH v2] crypto/qat: fix NULL algorithm digest placement >=20 > QAT HW generates bytes of 0x00 digest, even when a digest of len 0 is > requested for NULL. This caused test failures when the test vector had di= gest len > 0, as the buffer has unexpected changed bytes. >=20 > By placing the digest into the cookie for NULL authentication, the buffer > remains unchanged as expected, and the digest is placed to the side, as i= t won't > be used anyway. >=20 > Fixes: db0e952a5c01 ("crypto/qat: add NULL capability") >=20 > Signed-off-by: Ciara Power > --- > v2: added fixes line as this was a bug > --- > -- > 2.25.1 Acked-by: Arek Kusztal