RE: [EXT] [PATCH 1/2] lib/cryptodev/: Add SM3_HMAC/SM4_CFB/SM4_OFB support in DPDK

["Kusztal, ArkadiuszX" <arkadiuszx.kusztal@intel.com>]

> -----Original Message-----
> From: Sunyang Wu <sunyang.wu@jaguarmicro.com>
> Sent: Saturday, March 18, 2023 2:00 PM
> To: Akhil Goyal <gakhil@marvell.com>; dev@dpdk.org
> Cc: Ji, Kai <kai.ji@intel.com>
> Subject: 回复: [EXT] [PATCH 1/2] lib/cryptodev/: Add
> SM3_HMAC/SM4_CFB/SM4_OFB support in DPDK
> 
> Hi all:
> SM3 and SM4 are widely used in China, and they are Chinese national standards.
> I'm very to tell you that I didn't find the relevant RFC documents for SM3 and
> SM4, but I found the national standards for SM3 and SM4 in the full text
> disclosure system of Chinese national standards, but they are all in Chinese. The
> links are shown below:
> SM3:
> http://c.gb688.cn/bzgk/gb/showGb?type=online&hcno=45B1A67F20F3BF33921
> 1C391E9278F5E
> SM4:
> http://c.gb688.cn/bzgk/gb/showGb?type=online&hcno=7803DE42D3BC5E80B0
> C3E5D8E873D56A
> If these modes(SM3_HMAC / SM4_OFB / SM4_CFB) are not necessary, I can
> resubmit a patch, delete the corresponding test cases for these modes, and
> retain only the test cases for the mods currently supported by DPdK.
> 
> -----邮件原件-----
> 发件人: Akhil Goyal <gakhil@marvell.com>
> 发送时间: 2023年3月16日 18:43
> 收件人: Sunyang Wu <sunyang.wu@jaguarmicro.com>; dev@dpdk.org
> 抄送: kai.ji@intel.com
> 主题: RE: [EXT] [PATCH 1/2] lib/cryptodev/: Add
> SM3_HMAC/SM4_CFB/SM4_OFB support in DPDK
> 
> > Add SM3_HMAC/SM4_CFB/SM4_OFB support in DPDK.
> >
> 
> Can you give reference to some documentation for each of these modes.
> Cannot find RFCs for SM3_HMAC etc.

HMAC is supposed to work with any iterated hash function. Since we already have SM3 in the API, I would not worry about lack of RFC for specific SM3 + HMAC combination.

> 
> > Signed-off-by: Sunyang Wu <sunyang.wu@jaguarmicro.com>
> > ---
> >  lib/cryptodev/rte_crypto_sym.h | 8 +++++++-
> >  1 file changed, 7 insertions(+), 1 deletion(-)