From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 08EAAA054A; Wed, 25 May 2022 08:30:23 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C8491400EF; Wed, 25 May 2022 08:30:22 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 402A6400EF for ; Wed, 25 May 2022 08:30:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653460220; x=1684996220; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=NGQYZv77sJuMInz3Ty/uWzGfIhLFhioeHZaH68Ud6Fo=; b=YMIiwYjDk7me/1/rgV3SVBSEv+QLfnc5r1+50hxigl0zu0Rri3mX0/ZP XoLPWzDdVeNlao6yWz286uFW/2u30hD/thC4KHw73WHT2KsyRMC/N6ey9 wMa6u7hk8VTcpMWO9RbOIR6rtyAsiHlXuQhZ8eWEpl14KDMZm4Cc+3DS1 ZcmefF1TaXFTEQSBpxuVY+Tqdc5jwH6C22aOLobi3+SFlwPbQReU7koeK /PFh91WfRIhf1WrhjbziGBUeBbviIKgJFuwDKJcVLG2Z7o45p4BXKH611 5OCO7p/BQDVfT1Dzr217f1an6528AhRBJE3J1afECb0wEzvXTH65yCsEY A==; X-IronPort-AV: E=McAfee;i="6400,9594,10357"; a="253604384" X-IronPort-AV: E=Sophos;i="5.91,250,1647327600"; d="scan'208";a="253604384" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 May 2022 23:30:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,250,1647327600"; d="scan'208";a="573053630" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga007.jf.intel.com with ESMTP; 24 May 2022 23:30:18 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 24 May 2022 23:30:18 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 24 May 2022 23:30:17 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 24 May 2022 23:30:17 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.46) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 24 May 2022 23:30:17 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OueFc6Iai3A6odE0Padbsr/HQ17L1fAcah2QsgqK8nYP2rIbpLuQQIapnLN+MvnFBatyCP38A54Bxeeh2V0KXRHCMe5ueuA/lvfqkaGSvd+0NPTise4jDVF5sESwC6NV0vJey7T8EpEi4K3cTb4+tw0cTz9CEeV4cXK4mqc4BWfUZaIeAOGlgW62nzAmLzbAhqpnDsdkEBMpARUR3bb8Drx3+mgGsdsNmqa1POPULIeJOxk2LID4mGiR5Fi1zWFtcVyCE3ggc3kYYvEr6BeSbao1HDQtNJPPVCTdCs7OOxeKEjlbzi9SBXcKDNH9NHQPUhXmfSgNvpqGUfRMt/HreQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oTRvVugc9rZ7ipAwJqo/PfNqEwNheTMN7nfqhGlSN5E=; b=LLKL5k+yveLqZtSSOlwSCRGD/Kr16/YmXwH5iM4jqbXn1cusNzaAgnzTa7gr+zqbseIFFlcGvF7kIHYbXEpv3vUrwWSuRJi9Km3DHnqD+DWIsWR1f6Qjf++1mYaIgY2hkkYiGLEb50j+HDQ1XCX6yMcA0PL9FqoyIo6UVFnEGZ0XjP+PDif223hysYZgzmhxOcOaB3o53okwIh67kRZhE2yVyll9MIFO6Jjzql/9ASgIDaG/FUnOtDkR/qQ7VkcZ9CsBT1CtufcXMad5JCawTUtlzxIzaco2zOK8sbx9UWnn8oGeJ6ZpT7CmT/NwIBlxQXD8S6UcOtCUQLvt2Mut+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5013.namprd11.prod.outlook.com (2603:10b6:510:30::21) by CO1PR11MB5156.namprd11.prod.outlook.com (2603:10b6:303:94::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14; Wed, 25 May 2022 06:30:15 +0000 Received: from PH0PR11MB5013.namprd11.prod.outlook.com ([fe80::fc0f:1644:98b5:be1]) by PH0PR11MB5013.namprd11.prod.outlook.com ([fe80::fc0f:1644:98b5:be1%5]) with mapi id 15.20.5273.023; Wed, 25 May 2022 06:30:15 +0000 From: "Kusztal, ArkadiuszX" To: Akhil Goyal , "dev@dpdk.org" CC: Anoob Joseph , "Zhang, Roy Fan" , "Ji, Kai" Subject: RE: [EXT] [PATCH 21/40] cryptodev: add public key verify option Thread-Topic: [EXT] [PATCH 21/40] cryptodev: add public key verify option Thread-Index: AQHYbBe3jZkOfB7ZGUOnF6pEOyCAaa0t9t4AgAAtwMCAAPycgIAABwNQ Date: Wed, 25 May 2022 06:30:15 +0000 Message-ID: References: <20220520055445.40063-1-arkadiuszx.kusztal@intel.com> <20220520055445.40063-22-arkadiuszx.kusztal@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 99e173ba-beb3-469c-0788-08da3e1807df x-ms-traffictypediagnostic: CO1PR11MB5156:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: zqBxwGvvbsLpGleAGPseo0mzQKiGdWM1UyjTxr29XdzDSpmjnsbOQEcn/aEK0WKF9NCp5mprwtj8M1e5Dg7Y6ZxuIWeTnjdQ3xDUjwYWToA/Eui6+wCB3Z26OFs+asl4Rs6/VF3JKIc7unnCag2ct673Kp+RWsRgLFnATHacvXlAQN82nYUVv0CLezoKInZkaMNNlVFvNP0nTdXe2D5e0kY/PPCnRGA2aqy+zjvk95XINXzjxZxahpuZsTiEsVSCHXnMM2WNYbeBa0dAywkjg7NpO+sEI0m8bAvUBf4ZNT8zpYHfDFtGd8IAxSi0OodecunaQ62PmjCqXLJwK0oBsGQ5zmgcLCcXCAkTRkKi27VyXAzfOwN4ZoEDPhhc/OGIs6vN9CLnNI4hIj9K2HRpm+GcWbIIgoLnUoLLiUxaE+nWXqifzKzMfkgOKbg5jbO/JtZTApaXWWd5DXlZSDgYJq0IGaBZyF3QqqNheqslUwro0o4zGVrnE2zesow/cFT9mHWlpQFZYeUNwjtiDr9U1sbAPdC/4HXznOftHK9+xw0ThwuURpi2/YWfP2jgl7RDQIz9Tii49IojEEnonRm4ebPhwIVSgVJDLHZGixunM4sH07zz1ZIopBDhQde20UemxDWVn9MSJO39sdzw2uGSPJgwi8nmhwKDlOPuEtdRZhSmRf7NPD+aduUBLw2+SZ9yCYENud/3RWnrx5eFT40yDQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5013.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(508600001)(26005)(66556008)(316002)(83380400001)(38100700002)(54906003)(66946007)(71200400001)(64756008)(66476007)(55016003)(9686003)(76116006)(33656002)(86362001)(15650500001)(66446008)(107886003)(2906002)(82960400001)(122000001)(186003)(7696005)(8936002)(52536014)(4326008)(53546011)(6506007)(8676002)(38070700005)(110136005)(5660300002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?O0rUn1WSKsrXCE6H6BAwzztq0UZ4e9SZD/qu3BiSxBzZiBCsLlYoUd/UY6Ax?= =?us-ascii?Q?LnWqH10iVL0W2pnuG1il1CDFJGWv3Ebco84kXTP63kDw2hUDpI9WMGl9M659?= =?us-ascii?Q?j4sT53PgJ9OiOZvY9ILIkYcREBWWShK2p/IwJcGucAA1BUMRG/qJ7dzGZtyr?= =?us-ascii?Q?bLG7fOo0OkoIh2qREKkybTJWcwFNeWhFsR5b26QRXPdGjlErS3ex9trJUgDr?= =?us-ascii?Q?WR3N4MkXg9KYmWNq6LREoZChdTReyvm0pdOMgq3/RLKSTyxSaxFWFeODU/8P?= =?us-ascii?Q?a7yE1pxleUIQcRglFI2JI1XaYgef26vbVO0ueLMzTHf/dnJEvnDBcK3lsszk?= =?us-ascii?Q?5KaVT0e3TKRBQ3zKpF/Q9lv6ccu2zNK0KmApW8exhdoFQoW2S22/9303xho0?= =?us-ascii?Q?HQYMLGKaT6TQrYhZjHViUaZbLEO64eSq+rePoBuQiUpzDtjq/0jBWa01ER7p?= =?us-ascii?Q?2vBo0UIFPAi2/kRCRLJu7dj90w613HRaU/Qt7rrxApD9KMXJUOwOtAR9NRK9?= =?us-ascii?Q?wfsTUbS8hJtfruZktBZQTlY/cF4EBvXQE1z6Eo6b59PvnEoXr0r9IMSwRSlg?= =?us-ascii?Q?RdO+ATLbi53OnSFCrKurY0LB4/69x+qzmRMMAgXq0FqKXibwv76e7Vg6V3gM?= =?us-ascii?Q?oCEP6dv7PiLTzqNAgXv9q29s+PtmQkzW4NjQ7CUamh7zWhilptEE1mnzCRSI?= =?us-ascii?Q?ewDoCHdzGOna8xsnEkKMm1TsBtNTDHxw77OMxbq2kFQXvTTDLBSmsApr7hWa?= =?us-ascii?Q?g6VctQmlMu5vnVb1hzo4b15C6Z7lHcDCQ7GSw62Rq8Q956nLczDawCT4JDCR?= =?us-ascii?Q?LdqG8MVRBg+H9sDCimO4fOqUlGnJmIPKsIEqlyhlhYwdT69pKmJmlSQMKSWY?= =?us-ascii?Q?/CkbnlLj2YmC7Hr/euvjl67aJmEpfmcel+niK9/VZAiXBph9SRdC4KPIvf4P?= =?us-ascii?Q?266BD8NW9dBW+awJ3A88PFJ23Lsz6gwmtRq0yd87dmanHmVW2HefaxayuXTz?= =?us-ascii?Q?EnxE6F26dIxkFx+oJA1loCQ5SopSFgnms8i+68zlSjYz799WmBidRCWWZSKv?= =?us-ascii?Q?edZ4CZtyPmOlliibmeWf7PdkGCFb6Xfc6EVkuzTSre52TMRT6Z/nrSKg0MT/?= =?us-ascii?Q?Y9Q9ZpiXqFLaYaJ1VKBDcZAqFVEpeiJimKQVR4tWxVy94493ixatoCtlhSP/?= =?us-ascii?Q?iOuQnArY1N2h4duc/83XhLhKg/eN+ozScB7AM71FOYlcUND4drrZBXrdHoOO?= =?us-ascii?Q?SnIPcE9Z3IuPCqNwi631xWx9cFJGcKJ2GmsdXsD04q2yTDPkHpdvKghX7976?= =?us-ascii?Q?hGIU9WXFHwYHAwHTg2xCwRIkDbyqbsItVzWTX7G6nj1QT7p0jBCoY4UcBzOA?= =?us-ascii?Q?Sd/tHZJT6bSHMINkHdCrX6IL/dXsPRIvI76NHMv58nMO1cxEzrdmS3hfsha5?= =?us-ascii?Q?PNyphhLOEpmnl20dgxzFvEimZgwAsb3mFYY4O5LSZVsdshkUq+MhXFjJPtlt?= =?us-ascii?Q?rp+QTAguCDQ7a4+31hlVqgFBaRnkpZ6tr7B1WHT9G75KqRppIANdTId/Mu0e?= =?us-ascii?Q?uPdBbTjw9vjgtndkgaWo1ivZYt6EOU05ZMKpghzyfCgujcIn4HyElvd1+OMC?= =?us-ascii?Q?7/PhJychpKlAYuv9+IZmaAGD9BqRN0ST23qfKqzGO3iAK2WtEgMMbhe7ZXa/?= =?us-ascii?Q?OJJBbUhAKJzFsURWqJAzDtv4Jr+Ck3QPHbOw60/HwOTn2wJwEQttG9sjZ3Sl?= =?us-ascii?Q?LeqZo8CzZ/c9JF6PIH7cT5M/td3518o=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5013.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 99e173ba-beb3-469c-0788-08da3e1807df X-MS-Exchange-CrossTenant-originalarrivaltime: 25 May 2022 06:30:15.8072 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: eTOGoX0l0uT9M5AQFKWTIODeP/gylzhM2eRyJRCf95AqmBH5MzRbxLtAqwVYiCDlkIZD7TgwOg5/6XJZ8L/hys3Gvb0K1ZspTp4qxruDfZ4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5156 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Akhil Goyal > Sent: Wednesday, May 25, 2022 8:00 AM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: Anoob Joseph ; Zhang, Roy Fan > > Subject: RE: [EXT] [PATCH 21/40] cryptodev: add public key verify option >=20 > > > > > > > > /** > > > > @@ -397,6 +399,10 @@ struct rte_crypto_dh_op_param { > > > > * For ECDH it is a point on the curve. > > > > * Output for RTE_CRYPTO_ASYM_KE_PUBLIC_KEY_GENERATE > > > > * Input for RTE_CRYPTO_ASYM_KE_SHARED_SECRET_COMPUTE > > > > + * > > > > + * VERIFY option can be used only for elliptic curve > > > > + * point validation, for FFDH (DH) it is user's reponsibility > > > > + * to check the public key accordingly. > > > > > > What is expected from the user? Please be specific. > > [Arek] - Well, this depends on protocol, usually it is size check for > > FFDH and zero check for x25519/448. Not sure how much information shoul= d > be provided here. > I can understand we cannot specify everything here. > How about adding in documentation a section to give details? [Arek] - actually I came with another idea. I have added ECDH param, VERIFY is valid only for ecdh_op and verify is: RTE_CRYPTO_ASYM_KE_EC_PUBLIC_KEY_VERIFY, so it is not included in dh_op_par= am. I doubt there will be any hw acceleration for anything else than EC point v= erification + I doubt there will be 4 steps verification (that's why I have= not included it in flags). I have spilt DH into DH and ECDH, as it probabl= y will be easier when adding sm2 key exchange (instead of extending union f= ields) + Kai >=20 > > > Add reference to the ke_type for which this comment id valid. > > > > > > > > > */ > > > > union { > > > > rte_crypto_uint shared_secret; > > > > -- > > > > 2.13.6