RE: [EXT] [PATCH 0/4] cryptodev: add SM3 and SM4 algorithms

["Kusztal, ArkadiuszX" <arkadiuszx.kusztal@intel.com>]

> -----Original Message-----
> From: Akhil Goyal <gakhil@marvell.com>
> Sent: Wednesday, September 28, 2022 1:05 PM
> To: Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>; dev@dpdk.org
> Cc: Ji, Kai <kai.ji@intel.com>
> Subject: RE: [EXT] [PATCH 0/4] cryptodev: add SM3 and SM4 algorithms
> 
> > > > ShangMi 4 (SM4) is a block cipher used in the Chinese National
> > > > Standard for Wireless LAN WAPI and also used with Transport Layer
> Security.
> > > > ShangMi 3 (SM3) is a cryptographic hash function used in the
> > > > Chinese National Standard.
> > >
> > > Add these full forms in comments of the enums that are added in
> > > patch 1 and 2
> > I do not think we should, it is just current description of usage state of SM3/4.
> > Especially that we do not put much effort into other algorithms,
> > particularly with 3gpp algorithms which are all over the place with naming and
> comments.
> 
> Yes, we do not do so, as those algos are very common and does not have any
> other full form.
> But SM3 and SM4 are relatively new and does not come up easily in search
> results if we just type SM3.
> However, if we search for ShangMi 3, we get the RFC on first result.
Ok, you meant algorithm full name - not full comment.
I misunderstood you, yes of course I will add full name.