From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8DCEDA054F; Tue, 31 May 2022 17:39:59 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3A3874067B; Tue, 31 May 2022 17:39:59 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 780EC40143 for ; Tue, 31 May 2022 17:39:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1654011597; x=1685547597; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=bQCBNhvjuMajH1vs+e3DX419VRyO2t2rk0vhSsoCTTo=; b=ERwjTHiL4BPUMmNFXxbGVZvLi62Uq2TDf9gIa8FybYHuqoYyn+o8JHiM OfY/J82fJN4uXz4UW2WZeRYfTgm2zaox60Cia/v22OC9ykHfgU1auPyQZ oQ2arbm91YMlIVJ2r//Uo6+FWqdmzR4dnM/qc/rupqWot7QEY6sHKLy3E 1zbzWs3kyqU02PnDOhLEbMB/L7WltbYYcW78WoVh2Bc1jZ+FhoSmz2pyV 5GUARo+3IyFgdSnRa4B25AHAmG8hiDycTjG38q2utwKUwN5Y5olGWmXnX ZVzzWcucB7ZNK4GLa7naz6W73Xo58OhTONKqsUfLim/0QyOLM9pS5GP4+ w==; X-IronPort-AV: E=McAfee;i="6400,9594,10364"; a="275377924" X-IronPort-AV: E=Sophos;i="5.91,265,1647327600"; d="scan'208";a="275377924" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 May 2022 08:39:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,265,1647327600"; d="scan'208";a="633095609" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga008.fm.intel.com with ESMTP; 31 May 2022 08:39:56 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 31 May 2022 08:39:55 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 31 May 2022 08:39:55 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 31 May 2022 08:39:55 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.46) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 31 May 2022 08:39:54 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PqR8/GWMsJmMXpRMh0T4z8B5fot0iSV9sgYO8AsdRFCAx3sGsPeOQTxhKprP0mGcyrXbzYs0QnOPv/nX1Qj3ikig8TExL7So8IbFmvCE+DgL7RMvEpK2JTQlvKAcGM8nFvJqdY4gRFaWWIkaOI0ZZc1lcvGIuQMdWtV1hJplImEleeFu08FYnzzl3BHUTLzLJ0SKtkxOwxxhvCy0ikUOPjKkVTia1At2XYpZxWzO49qj91cYW+lry2X+rYm0FlBCIQ+qUUm14wq4EmRng9opRDE9BuD7mT+kT8JloMXARHcSpwUR4Yr/1csl7Uz3pEDcCEQIZiuo26YXH7OTPB5n1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bQCBNhvjuMajH1vs+e3DX419VRyO2t2rk0vhSsoCTTo=; b=c8HbNe8rxEFLD++/Q1k0VqcK7gSPuIcfOxKBJrfHM63sMtin16ZROd1ha10hwi1V3A3FMzO8YjUgZ4s5x0hKZ85er+6yBhWUyyDtkdfeJ9Tdjwl5XlduR3ErvNJF3evHdyLaxyOq1tF/iJkoC4cuJzeVgm5GD+nNFjNQV08csX50rw/SlBZmENA/QTqBH4JwQXILbfGCa29IW2GrEAY0S9lICMzLtORS9z7bFU4VzVW8z6lCaZHnm6aoey7N6pTN6ZcB0UFIpYQJY0xlxX8OJZsnZH4ga8OmSDw/DhqW1GYyG+uJ4q/+cN9hQlYU0rU91JK9/hJiKJ0OfP9Bo/9ERg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5013.namprd11.prod.outlook.com (2603:10b6:510:30::21) by PH0PR11MB4790.namprd11.prod.outlook.com (2603:10b6:510:40::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.12; Tue, 31 May 2022 15:39:52 +0000 Received: from PH0PR11MB5013.namprd11.prod.outlook.com ([fe80::c1de:722f:b4f3:91b5]) by PH0PR11MB5013.namprd11.prod.outlook.com ([fe80::c1de:722f:b4f3:91b5%3]) with mapi id 15.20.5293.019; Tue, 31 May 2022 15:39:52 +0000 From: "Kusztal, ArkadiuszX" To: Akhil Goyal , "dev@dpdk.org" CC: "Zhang, Roy Fan" Subject: RE: [EXT] [PATCH] cryptodev: add support for 25519 and 448 curves Thread-Topic: [EXT] [PATCH] cryptodev: add support for 25519 and 448 curves Thread-Index: AQHYSoWEbOKfDI5+JEKb+UOUXNOO8a0iGI0AgAEZm1CADnbRAIAHt4bwgAAP2QCAAAOMsA== Date: Tue, 31 May 2022 15:39:52 +0000 Message-ID: References: <20220407134334.20226-1-arkadiuszx.kusztal@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8ec5ba86-ff98-4602-9ab5-08da431bce27 x-ms-traffictypediagnostic: PH0PR11MB4790:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: PyNai0S5rPvhhYMuEl8MFGFz/Go+djFeTrT0Yyz4Q5rRIK4P/EVyL3hAHgl1PAtH0n31ZE2JT/0PpHUFxXhrFLVivIpQY9Mmj9Gt/LaRYBgJzclPQWGkrAXDBmGzIU83aLoq30s7JD/JiqaqEeKLRNeyEGs7R9PXVUcA9cX2XzBpj+uOjOi+vKKAUdVWInLw9JJoO4YBhFoMlQ1f06VwXWAToB38ZZ3DZUW1IQFsBSvOQ5ZIHI2JOwI/3bvp5Qa+31ZCRCHIRoosyFd+abzKPhYRdd2iCp+TEaHFtDUybYygz/3J3stDkpnMtCVzJZdOv4qnQ+R6OxT/B0BVzpXsn/dkFAPebbSLP/ZSD2tfv3n1R19aU99GoTeAKOAp+McKQ6U4aJvk32ZUppXuh+/p+/IfUCz8lRSrwRpKv6aBQrUoWaOKL3cvcfymCTebTX+9lwP0lgphGDqcZahpnNLop7OhtJX+6/clbCRsggcaOHtKyTu+ce/LIdPvv3vKZn1ZfzwvPrccb9AFeHa/4cKgbcYSHdFMlAssfaG2wcjziHIo5GFOe+roqht/PexSSYe3eKci9uPvXAqqZx/vdbWHkWJQmAvdAThr99+sHV/PIw+DcTtL7lDgkD5raccPf7JEi8cCTNcJ3tNX30gtyJpk/m9Os8irEcpV9+lLPrYs1kAxePBULxs+AMaZXks5F7Z4LBMA8cYwtWd+jTPIhy9r5Q== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5013.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(110136005)(316002)(8936002)(86362001)(71200400001)(122000001)(26005)(186003)(9686003)(107886003)(55016003)(82960400001)(83380400001)(508600001)(53546011)(38070700005)(5660300002)(6506007)(7696005)(52536014)(38100700002)(2906002)(66476007)(64756008)(66556008)(66446008)(66946007)(33656002)(4326008)(8676002)(76116006); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?EQaM82+dYKHjkqTtoJxMp8RBedk7N5eR7bIbvi5J2BmY/hc9x2+XWdrMInap?= =?us-ascii?Q?4vGxkGsHh93tasvsxi+L7/SzW6PxYlsL5L5GnZ0E05ft+Nv0ugx2g/g++5Se?= =?us-ascii?Q?SWBKnnpBRiG4R7hbV6qWL86I3jbn+uhsK/6Vrx5HPW/anybDNHNgVrw0728Q?= =?us-ascii?Q?fjzZO7Xrrq1a7NNSA8MZUfrXpwwlXTD4OjCUXaD5TU5sK1656BjBHzUjVCtH?= =?us-ascii?Q?9MxDRRtmivvCzZlakc73ARjN41gCfAQdo/gZg/7Qxfr29aw+YU7XiaWeeQns?= =?us-ascii?Q?7BqGppDaafNWLWyxrKNtTQrZ+MsCu9m3WggI37F3qx1wprEZ2fhmEMn3RAKW?= =?us-ascii?Q?8BfTdZpFcyCpWmKOJLpJyz/jFKs3oqNtQbr7c6/0J+DqqjiV4poplVMi+ezM?= =?us-ascii?Q?2D1W3ILRRMV1xgkDOOIoAlENnbMKtW+XzYRwlZYJDzC/FdkK0pqZIBaFzD2h?= =?us-ascii?Q?/w86rBry5c8M6oUrgHP816ubT24UFwyyFLMeRsVgTHb/RNfoTRBdgCRI+FQt?= =?us-ascii?Q?5ABIfmUv9eRv+uo/Bu7Yta98z7yMr78r3vpVCB6C8MsjzGfVpyhd60/oxLDW?= =?us-ascii?Q?8at+Uti5eZuOJeLLLZs16WuFgyLoQeYk+YIspcyP3zoA5Pa/pupXDzwVU2s9?= =?us-ascii?Q?SeBlkCQED7xkPjnjgBmTuzBFkjboZEA+ZW25X1lnRpsiOXtdBVDlETyWmq6F?= =?us-ascii?Q?subFPdBVRInHnfxZf7ZePdFJtSo8lGNx/i36rBA4BgiYqP+x5XKojjQ50aiK?= =?us-ascii?Q?I5XV0apYCXIQGGj6YAshxGS7vErl/qewm064YL9FIye54qO3c/LoU4EGaDLB?= =?us-ascii?Q?ANCmZsfuZPZ0IXqj7tCBszZrAPrP54WuAaVTWh0WpO1W5q0uomEeq1JcoZM8?= =?us-ascii?Q?man6dO37H0YlhqtWjhPVcjcP68dbJE1fxv/X/NeuGWeQz5AQLaLRHRIgCCCs?= =?us-ascii?Q?zDdvfl0R0JRHc+H5nSrxFZCz5AMSqZw+ktU1X8fvehRPZ/TSRFqWi1V2VVXJ?= =?us-ascii?Q?4pAiMEwrfgWKAjqJVCZbSlvLxfxbzkxh55zMAu4IPe8UzsU2LVCVfci3o1kJ?= =?us-ascii?Q?CR6qdzLZ90cklZUKodLixBkNyzYYePuQ0MPlNAbTa1oigIQvjKyv4UV9wJyM?= =?us-ascii?Q?t+Fads/8jVNta5cB8MKMWJj4lKoUwV6j71iFwTAYpVO7WsvAvGVN2XySg82f?= =?us-ascii?Q?SCn7hRmO8TsGoucptbkMSeKmx/RSnWMX3/bjOSsLJkZdDgusEDJV7oa2WO5x?= =?us-ascii?Q?tA1UO80ZkKjk1NnLDlmygktqlWpGHCb5ZLzxRFtDG8jHTwEeWG1jdMsKQz/H?= =?us-ascii?Q?HZY8o5zOJlWCqWyviN4djdilyWFyUMhL4AEZGtCcn/+g1dz0f2b58+vBpt9n?= =?us-ascii?Q?PhbaS4VcpBD4K6hRqN2jpxyNd1k+oa/vd2pCnguaFIlsBeTvQeCKbk81YC/n?= =?us-ascii?Q?YmfpVVf5CZJyDUMaJLB4AkcFFuBbQ8oIj1lT7NDzxC4Zsz4Hpeki4tN7VdCm?= =?us-ascii?Q?VBEEcjyvx/iYnmbtPKh1zUh5f/5TWVIMTp5SWxOZtWV90qc+TGoSEvbdQvAl?= =?us-ascii?Q?6a7B4fESXX1VVNhZ+YE2LUNhf+3XKyxJLH+MpM/u2l4DeLN2mAMhru8lU5vQ?= =?us-ascii?Q?4jrWpg0s3BlRYHOkgClTg67//UrVRjbkTfwq+S8S+IadCM7PnlnttGnWszQa?= =?us-ascii?Q?BgnWV7u+LHYfwRI8f+eJRVyLe+GkGNTBnew4FkDgf1sqV3jUi4tDLhTI6jWz?= =?us-ascii?Q?KPWL8/QtiXCciiY6pe3WW0ZfWZeGaK8=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5013.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8ec5ba86-ff98-4602-9ab5-08da431bce27 X-MS-Exchange-CrossTenant-originalarrivaltime: 31 May 2022 15:39:52.8070 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: IEGzaxgFmbGhIup3c57/W5W8aW/mrrg8jGZ39nMQkMtMSDBikeKghS9mrbfA5nCIxeG8BLC2z05zEDP2ZG3mDLpXjdv1p6APMI0mroRO8nA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4790 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Akhil Goyal > Sent: Tuesday, May 31, 2022 5:26 PM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: Zhang, Roy Fan > Subject: RE: [EXT] [PATCH] cryptodev: add support for 25519 and 448 curve= s >=20 >=20 >=20 > > -----Original Message----- > > From: Kusztal, ArkadiuszX > > Sent: Tuesday, May 31, 2022 8:03 PM > > To: Akhil Goyal ; dev@dpdk.org > > Cc: Zhang, Roy Fan > > Subject: RE: [EXT] [PATCH] cryptodev: add support for 25519 and 448 > > curves > > > > Hi Akhil, > > > > Sorry I have missed that, and I think we should revert this patch. > > It would make sense to have TLS derived numbers for these curves if DH > > and ECDH would be in the same op. > > But since we decided to split it we are going to go with separate > > structs for x448 and x25519 as per: >=20 > Even after removing this patch, the patches are not getting applied. > Applying: cryptodev: move RSA padding into separate struct > error: patch failed: drivers/crypto/qat/qat_asym.c:345 > error: drivers/crypto/qat/qat_asym.c: patch does not apply Patch failed a= t 0010 > cryptodev: move RSA padding into separate struct > hint: Use 'git am --show-current-patch' to see the failed patch When you = have > resolved this problem, run "git am --continue". > If you prefer to skip this patch, run "git am --skip" instead. > To restore the original branch and stop patching, run "git am --abort". Yes, it needs to be rebased against: crypto/qat: refactor asym algorithm macros and logs I will do it in v5.