From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 045F6A0503; Fri, 20 May 2022 09:39:27 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EA7BA42B88; Fri, 20 May 2022 09:39:26 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 5B02040222 for ; Fri, 20 May 2022 09:39:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653032364; x=1684568364; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=oEHDZz8M+nJ3NoiLTCbQ7hDwwCQQsBAsz+wWGKYkcpw=; b=m5D48UbMkSq8jfF1HXfD3DGRsQLCr+WexW2pmgXHIB2dAoG2zS0plKwb LJ1OI1s5t09RkZ2QFX3RCHZrHvtkj4xk5AUw3gXAdfF/GZDQUCIYZj5RJ Fycvxbw2uy+XTUvgPcV5+aNvYaUz1AWx8jmbqJcoZz2q0Wk9mu8C2EhNz QOtC7LJUI5kTDIuqIO8+NW4D97RgO2BYfr/piVDqY6BvUZIMNaCNRTZ2C cYERD1pEA2htnVFF0BN6btMy7vRfsWij2rMvEqanUv6U4LpOgBwqrFYzS uyFrIp6BjfcsnQguBrtVBinZMYSs/Am2lYPwW+X8ZpYcdNRjHWrRvoCmf Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10352"; a="272498786" X-IronPort-AV: E=Sophos;i="5.91,238,1647327600"; d="scan'208";a="272498786" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 May 2022 00:39:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,238,1647327600"; d="scan'208";a="546557814" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga006.jf.intel.com with ESMTP; 20 May 2022 00:39:02 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Fri, 20 May 2022 00:39:01 -0700 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Fri, 20 May 2022 00:39:01 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Fri, 20 May 2022 00:39:01 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.168) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Fri, 20 May 2022 00:39:01 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bhsIezekTjBBnYAJ5OhSchJ4WsJoiEK7S0a89FsoX9oV4272aS74bq9icLQ0VwE5ucJvN4X6mq/AMw1ZkQv/zq+Y2wBlbhB1TdOg5n18AtqidERW9iQEdeOPyz9Z54FB2tiUaG1T41JJqejThQgOl+VNvARO7/gAKOD/pmZ+H9OIUDAvfC4zbwDXikF771+0Z+Ctv673U/PpKd78i86GV84VlrSJKQYCfq9Vg7A+n9qeAph7GoUh611c8Pkoo55XbAfKMt6bwJzk/dJUvGnX827Le4+8WVaV1Se1FXKAD1Y+/Y2Lza4RcTRaPEcS9mT1jlg3t9B7RDZJMIXSuo2+tg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0X648dlaOWLUAtcDEcs3zDItYby/u6On8JyVO4PjrBU=; b=CTTmhBOA6Lg5EUDSvOm3wiaFIsBgwZ2HZhSmulRsQup3OL3Tn6wVg4cf83ZlEA+3iy+7gvv+Jqf/IVRNv4EhBSFcluJWwkrC8wxxK227OtsjihPWA2qyYJGwzMbd//I1+z5/L7a+yPju/gPOGP6dCP648EWmGxrSbn40s+hKUuXZovGxecIXEiLI/zko2KWKOB6O8dAeR6oH4szWLjMgArPMg9H0RfGQavFaCl3n/MUWZfAniQgf74Ej81hd+QixMilwtr/F8Mh7SASl+ceFoRaKjK1zFM1w54qYurk/7Xl8iRPmM24InRRiS85LpTRgqXd7Np20GvbVQAipEvBHAw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5013.namprd11.prod.outlook.com (2603:10b6:510:30::21) by BN6PR11MB1475.namprd11.prod.outlook.com (2603:10b6:405:9::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.16; Fri, 20 May 2022 07:38:59 +0000 Received: from PH0PR11MB5013.namprd11.prod.outlook.com ([fe80::fc0f:1644:98b5:be1]) by PH0PR11MB5013.namprd11.prod.outlook.com ([fe80::fc0f:1644:98b5:be1%5]) with mapi id 15.20.5273.017; Fri, 20 May 2022 07:38:59 +0000 From: "Kusztal, ArkadiuszX" To: Akhil Goyal , "dev@dpdk.org" CC: Anoob Joseph , "Zhang, Roy Fan" Subject: RE: [EXT] [PATCH 13/40] test/crypto: remove asym crypto next xform Thread-Topic: [EXT] [PATCH 13/40] test/crypto: remove asym crypto next xform Thread-Index: AQHYbBeulJ1u09UsBkarsVufTY7ZiK0nXQUAgAAD7eA= Date: Fri, 20 May 2022 07:38:59 +0000 Message-ID: References: <20220520055445.40063-1-arkadiuszx.kusztal@intel.com> <20220520055445.40063-14-arkadiuszx.kusztal@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.401.20 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 25c45010-ae14-4afa-7ed8-08da3a33cd8e x-ms-traffictypediagnostic: BN6PR11MB1475:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: EH6cVWa5a19GN3pB+hpcFcprHNmy1n4xzv/SoaBAyCxmMl5xiM+EjqKawDSVTkkk7mfUqr95+iOt04mnnSy6DRAxOj+v5JneTRqs6ATZdFM4hsxTR1kuusbDJVNa0FQIcQwBpc51bcQ81JlOMuRDyFjaIgqYC7af1TpMffl8C8l6TVJpR58dTBlPM/pHYRzHgUEfTLWyqxXtS8S3Ns5Cf5vekC9MlIrG2lTzBJ2id1Eqpd+DjdbUNdGX/kDBAqftGtJGx77WUaaKlOEOOD2roUKf2rjDSMrf4+ruZxaCvG6NrYEye01iMHltgoPJDLggjEhWXOEa0R+KdFx7tHH2zQk3QA6D5uU5XO6UBzL6ArwzbIwCGaYNLtgwzhM2NqnVryjZHj/8FgStmLNE7pw/abDVzqUmHNPezlSOl/Z3mcnJhXHDLXn+55AnDs5aSxZKQS/n4wNsWHjLg553qJfS1Q2PHstXSfD6EBaWBT7otwZImkekxD2Ew0jsFf1+KozuOjEvIsc+cz4p1o/V7zEcyiz3W7pULVGpnHpai3F/Uh8OiBjeHvqbQKxkyyP3xYDkiOXrombJmkOeiDd+0GlckI2o3nlIfdxCv6kbyPZmKETHBTi1kh8/X7USuifO1+VH9u0PDI72qBj1DipFDE3X8rVHIiC6PuaMngeQPIA3MoXy+wGgajeWOHmNbK580il6eKPLmbjQDl2LwlEFVUSqAQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5013.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(4326008)(6506007)(53546011)(8676002)(122000001)(83380400001)(7696005)(71200400001)(82960400001)(38070700005)(64756008)(66446008)(38100700002)(76116006)(66946007)(66556008)(66476007)(107886003)(9686003)(8936002)(52536014)(2906002)(508600001)(86362001)(316002)(33656002)(26005)(186003)(5660300002)(30864003)(110136005)(54906003)(55016003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ecLfYLvd3SkZbyD526NFT/uo18bTPti7+OKGOplzf2nbBgAPegXKvn0t3RxT?= =?us-ascii?Q?fsn9WmfPEltYhBq3CtA5i0WB4/RJkt/hlhqzP0LvaHH6qf7QPLkMVvpqXSah?= =?us-ascii?Q?+Mgjj75359aILt4HIxl18d+XmpVz287URjAAfDnQn245TWiLU+jnrzkoPr5v?= =?us-ascii?Q?deHpadTbs5zL+BBtU68IDAI+QhICyHR3pjiCo/gl2u9zWdMuToV1RkYlXP30?= =?us-ascii?Q?wl1X35HtyVSzViOFgoVzyaAEURm0gjVOhB3bvwWxL6k2pfPnMvuYg6g6LSan?= =?us-ascii?Q?JgvVzT6IKVLEtXrb7bLvRYJFuM9emqDBv4DWkA0VLbyyFUopbm7BsHeLCvpI?= =?us-ascii?Q?Kx3/fhP4pWX9rkF4M8auGeUJ+pslq9f6+4pNvPf7SVkM04YqiXw0I5HM8MPH?= =?us-ascii?Q?9cFNff+4LqwpFsk//y+c9XzpmzOCJ8Pf2/Z+5CcaBsmlccv3B+cZik8BpnVT?= =?us-ascii?Q?v6nQGT5W7OS8e31YJdCENcYKkmaphRFO1FDKBq8ezKKM28zJ0JpQ6K1eDBVT?= =?us-ascii?Q?rK3bnDWsSa+uVaKRn649+Ezma6x4mP3mB91AQkdLjA3TJqnGoNlGGJfkok8/?= =?us-ascii?Q?5uQsYdQ/Nj9yNnqSnk3l9PdsQe65HM7aLV31L3JwW0plf8e83L0biAGtM/Uo?= =?us-ascii?Q?AQrFLNw6JTcpD5+V8Q1oAm2Z6/mHxlXdcqHp3kWROjesM7soc2Pq31syEYmj?= =?us-ascii?Q?69SV37PifNzrd4An98Ms6IqrNJxauT8bXeVwaFCksh+5VksNac8FxXtwntFD?= =?us-ascii?Q?F93Ow9skz09sloMB5/JJqxj8SQ8kKW+M2s+mBpNSZmKx0ehc9dPKSpGzJ5tk?= =?us-ascii?Q?wfzrd7WKUN9nVoptRDpPH34Cg+N74XDZew/2wZ+AH80x7VG7/BmqpmxxRWmz?= =?us-ascii?Q?Y12vw2FN+NlTwGeGl/Gp4xA3Xh+NMWDUkMtdsYykYoVvpvM7h6FVEc1o2DR5?= =?us-ascii?Q?JfAL832MiXpNleA5KvdhgnUNPfdaETA4FPmjaR8bbALBAlydKTrJpRV4DLlI?= =?us-ascii?Q?57XC1DrBPkOnRFQq6s8LCbbPm2r/nboWqpFqrfqK3n95vYviO9kMrxQrrAzR?= =?us-ascii?Q?P/gE9RrA/98sABDhAzP2i9dFQdPeJ0XuZ6eYuMnDLuQ0HmYUs45LiJclWHxV?= =?us-ascii?Q?7tF1NCD1nCVSw/tc0zNM4N2o0G0WaH59bDVopdXBOp8/EU7lHYqvy81AEgy7?= =?us-ascii?Q?7t1MhELZDsmhhfsMVAvwMzscot9zpLsV3aMWZ5wd2Bp+ZjZc3hRaB0hee8qK?= =?us-ascii?Q?2VAX78bGB8tJnKuw8AfXF2lAnyecp5DDSGcNfF9/tbB089C4e3h7smXJzseL?= =?us-ascii?Q?gM8cF20KUeks9riptPcN27Z9l3pCrRX9amgwGuZHIrfQf3xYq7/PmK6qKyy+?= =?us-ascii?Q?AeRMtjPC2ZtIAWEbDB1VOmyb2wxmcI9FG0qC2fEhfsctDBCsdIUqxist7C2R?= =?us-ascii?Q?l5FNfSmf80JMIObSo88TKxryHFX56S65pMC7FU2Mh66Hyk4fWtJovwGgj6kS?= =?us-ascii?Q?sO5VpqIbw8CeYbIJHwPHVdtG4bi63z5iYbr4FBmKRj0+ASpi6aB7wmiWoQhY?= =?us-ascii?Q?8fF2aZHN4ksPo6jZ1yw3qTJKbE0LE/EuK9lXcVVZZi8uEMb+XFtBJw5atC4t?= =?us-ascii?Q?8VSsFH+DJT/8NzHqcVZ9Wja8iClasTdFDvtz1T9AZ7me7Ycbip6Yv2dAFNgQ?= =?us-ascii?Q?xVfjxlZexjqclIhdeomwQvnpV/b8sLHKu4u9SWKul0J5zqHL1WiRWzR9x0QW?= =?us-ascii?Q?PtcGjcJTcGRoDKdUfWuD2VRn/cCLPE8=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5013.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 25c45010-ae14-4afa-7ed8-08da3a33cd8e X-MS-Exchange-CrossTenant-originalarrivaltime: 20 May 2022 07:38:59.2445 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: SSoISU/Y3PR7JsTrAEDdCNziEcVLES9nHojvfLSTOHxqYNUWxoL+ZiiuRIX94h8WTiXygtri8VUMmPeDiJTzg1vYk0/nsFbTM4T9Sn/x86c= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1475 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Akhil Goyal > Sent: Friday, May 20, 2022 9:24 AM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: Anoob Joseph ; Zhang, Roy Fan > > Subject: RE: [EXT] [PATCH 13/40] test/crypto: remove asym crypto next xfo= rm >=20 > > - removed asymnetric crypto xform next field. > > This commit reflects changes to the asymmetric crypto API. > > > > Signed-off-by: Arek Kusztal > > --- > > app/test/test_cryptodev_asym.c | 100 ---------------------= -------- > > app/test/test_cryptodev_dh_test_vectors.h | 1 - > > app/test/test_cryptodev_dsa_test_vectors.h | 1 - > > app/test/test_cryptodev_mod_test_vectors.h | 2 - > > app/test/test_cryptodev_rsa_test_vectors.h | 2 - > > app/test/test_event_crypto_adapter.c | 4 -- > > 6 files changed, 110 deletions(-) > > > > diff --git a/app/test/test_cryptodev_asym.c > > b/app/test/test_cryptodev_asym.c index 0098b6bf65..9e5d5e4f27 100644 > > --- a/app/test/test_cryptodev_asym.c > > +++ b/app/test/test_cryptodev_asym.c > > @@ -318,7 +318,6 @@ test_cryptodev_asym_op(struct > > crypto_testsuite_params_asym *ts_params, > > > > int ret, status =3D TEST_SUCCESS; > > > > - xform_tc.next =3D NULL; > > xform_tc.xform_type =3D data_tc->modex.xform_type; > > > > cap_idx.type =3D xform_tc.xform_type; > > @@ -1063,7 +1062,6 @@ test_dh_gen_shared_sec(struct > > rte_crypto_asym_xform *xfrm) > > > > /* Setup a xform and op to generate private key only */ > > xform.dh.type =3D RTE_CRYPTO_ASYM_KE_SHARED_SECRET_COMPUTE; > > - xform.next =3D NULL; > > asym_op->dh.priv_key.data =3D dh_test_params.priv_key.data; > > asym_op->dh.priv_key.length =3D dh_test_params.priv_key.length; > > asym_op->dh.pub_key.data =3D (uint8_t *)peer; @@ -1145,7 +1143,6 @@ > > test_dh_gen_priv_key(struct rte_crypto_asym_xform > > *xfrm) > > > > /* Setup a xform and op to generate private key only */ > > xform.dh.type =3D RTE_CRYPTO_ASYM_KE_PRIVATE_KEY_GENERATE; > > - xform.next =3D NULL; > > asym_op->dh.priv_key.data =3D output; > > asym_op->dh.priv_key.length =3D sizeof(output); > > > > @@ -1228,7 +1225,6 @@ test_dh_gen_pub_key(struct > rte_crypto_asym_xform > > *xfrm) > > * > > */ > > xform.dh.type =3D RTE_CRYPTO_ASYM_KE_PUBLIC_KEY_GENERATE; > > - xform.next =3D NULL; > > > > asym_op->dh.pub_key.data =3D output; > > asym_op->dh.pub_key.length =3D sizeof(output); @@ -1288,94 +1284,6 > @@ > > test_dh_gen_pub_key(struct rte_crypto_asym_xform *xfrm) } > > > > static int > > -test_dh_gen_kp(struct rte_crypto_asym_xform *xfrm) >=20 >=20 > Why is this function removed? This function is later added with new way of handling it, but in v2 I will = squash this changes into one so it will not be removed. >=20 > > -{ > > - struct crypto_testsuite_params_asym *ts_params =3D &testsuite_params; > > - struct rte_mempool *op_mpool =3D ts_params->op_mpool; > > - struct rte_mempool *sess_mpool =3D ts_params->session_mpool; > > - uint8_t dev_id =3D ts_params->valid_devs[0]; > > - struct rte_crypto_asym_op *asym_op =3D NULL; > > - struct rte_crypto_op *op =3D NULL, *result_op =3D NULL; > > - void *sess =3D NULL; > > - int ret, status =3D TEST_SUCCESS; > > - uint8_t out_pub_key[TEST_DH_MOD_LEN]; > > - uint8_t out_prv_key[TEST_DH_MOD_LEN]; > > - struct rte_crypto_asym_xform pub_key_xform; > > - struct rte_crypto_asym_xform xform =3D *xfrm; > > - > > - /* set up crypto op data structure */ > > - op =3D rte_crypto_op_alloc(op_mpool, > > RTE_CRYPTO_OP_TYPE_ASYMMETRIC); > > - if (!op) { > > - RTE_LOG(ERR, USER1, > > - "line %u FAILED: %s", > > - __LINE__, "Failed to allocate asymmetric crypto " > > - "operation struct"); > > - status =3D TEST_FAILED; > > - goto error_exit; > > - } > > - asym_op =3D op->asym; > > - /* Setup a xform chain to generate > > - * private key first followed by > > - * public key > > - */ > > - xform.dh.type =3D RTE_CRYPTO_ASYM_KE_PRIVATE_KEY_GENERATE; > > - pub_key_xform.xform_type =3D RTE_CRYPTO_ASYM_XFORM_DH; > > - pub_key_xform.dh.type =3D > > RTE_CRYPTO_ASYM_KE_PUBLIC_KEY_GENERATE; > > - xform.next =3D &pub_key_xform; > > - > > - asym_op->dh.pub_key.data =3D out_pub_key; > > - asym_op->dh.pub_key.length =3D sizeof(out_pub_key); > > - asym_op->dh.priv_key.data =3D out_prv_key; > > - asym_op->dh.priv_key.length =3D sizeof(out_prv_key); > > - > > - ret =3D rte_cryptodev_asym_session_create(dev_id, &xform, sess_mpool, > > &sess); > > - if (ret < 0) { > > - RTE_LOG(ERR, USER1, > > - "line %u FAILED: %s", __LINE__, > > - "Session creation failed"); > > - status =3D (ret =3D=3D -ENOTSUP) ? TEST_SKIPPED : TEST_FAILED; > > - goto error_exit; > > - } > > - > > - /* attach asymmetric crypto session to crypto operations */ > > - rte_crypto_op_attach_asym_session(op, sess); > > - > > - RTE_LOG(DEBUG, USER1, "Process ASYM operation"); > > - > > - /* Process crypto operation */ > > - if (rte_cryptodev_enqueue_burst(dev_id, 0, &op, 1) !=3D 1) { > > - RTE_LOG(ERR, USER1, > > - "line %u FAILED: %s", > > - __LINE__, "Error sending packet for operation"); > > - status =3D TEST_FAILED; > > - goto error_exit; > > - } > > - > > - while (rte_cryptodev_dequeue_burst(dev_id, 0, &result_op, 1) =3D=3D 0= ) > > - rte_pause(); > > - > > - if (result_op =3D=3D NULL) { > > - RTE_LOG(ERR, USER1, > > - "line %u FAILED: %s", > > - __LINE__, "Failed to process asym crypto op"); > > - status =3D TEST_FAILED; > > - goto error_exit; > > - } > > - debug_hexdump(stdout, "priv key:", > > - out_prv_key, asym_op->dh.priv_key.length); > > - debug_hexdump(stdout, "pub key:", > > - out_pub_key, asym_op->dh.pub_key.length); > > - > > -error_exit: > > - if (sess !=3D NULL) > > - rte_cryptodev_asym_session_free(dev_id, sess); > > - if (op !=3D NULL) > > - rte_crypto_op_free(op); > > - > > - return status; > > -} > > - > > -static int > > test_mod_inv(void) > > { > > struct crypto_testsuite_params_asym *ts_params =3D &testsuite_params; > > @@ -1611,12 +1519,6 @@ test_dh_keygenration(void) > > dh_test_params.priv_key.length); > > > > RTE_LOG(INFO, USER1, > > - "Test Public and Private key pair generation\n"); > > - > > - status =3D test_dh_gen_kp(&dh_xform); > > - TEST_ASSERT_EQUAL(status, 0, "Test failed"); > > - > > - RTE_LOG(INFO, USER1, > > "Test Public Key Generation using pre-defined priv key\n"); > > > > status =3D test_dh_gen_pub_key(&dh_xform); @@ -1828,7 +1730,6 @@ > > test_ecdsa_sign_verify(enum curve curve_id) > > asym_op =3D op->asym; > > > > /* Setup asym xform */ > > - xform.next =3D NULL; > > xform.xform_type =3D RTE_CRYPTO_ASYM_XFORM_ECDSA; > > xform.ec.curve_id =3D input_params.curve; > > > > @@ -2030,7 +1931,6 @@ test_ecpm(enum curve curve_id) > > asym_op =3D op->asym; > > > > /* Setup asym xform */ > > - xform.next =3D NULL; > > xform.xform_type =3D RTE_CRYPTO_ASYM_XFORM_ECPM; > > xform.ec.curve_id =3D input_params.curve; > > > > diff --git a/app/test/test_cryptodev_dh_test_vectors.h > > b/app/test/test_cryptodev_dh_test_vectors.h > > index fe7510dcd3..078719072d 100644 > > --- a/app/test/test_cryptodev_dh_test_vectors.h > > +++ b/app/test/test_cryptodev_dh_test_vectors.h > > @@ -63,7 +63,6 @@ struct dh_test_param dh_test_params =3D { }; > > > > struct rte_crypto_asym_xform dh_xform =3D { > > - .next =3D NULL, > > .xform_type =3D RTE_CRYPTO_ASYM_XFORM_DH, > > .dh =3D { > > .p =3D { > > diff --git a/app/test/test_cryptodev_dsa_test_vectors.h > > b/app/test/test_cryptodev_dsa_test_vectors.h > > index bbcb0d7297..cc60f50b5c 100644 > > --- a/app/test/test_cryptodev_dsa_test_vectors.h > > +++ b/app/test/test_cryptodev_dsa_test_vectors.h > > @@ -91,7 +91,6 @@ struct dsa_test_param dsa_test_params =3D { }; > > > > struct rte_crypto_asym_xform dsa_xform =3D { > > - .next =3D NULL, > > .xform_type =3D RTE_CRYPTO_ASYM_XFORM_DSA, > > .dsa =3D { > > .p =3D { > > diff --git a/app/test/test_cryptodev_mod_test_vectors.h > > b/app/test/test_cryptodev_mod_test_vectors.h > > index 807ca7a47e..bcd4d5248b 100644 > > --- a/app/test/test_cryptodev_mod_test_vectors.h > > +++ b/app/test/test_cryptodev_mod_test_vectors.h > > @@ -1045,7 +1045,6 @@ uint8_t mod_inv[] =3D { > > > > /* MODEX vector. 8< */ > > struct rte_crypto_asym_xform modex_xform =3D { > > - .next =3D NULL, > > .xform_type =3D RTE_CRYPTO_ASYM_XFORM_MODEX, > > .modex =3D { > > .modulus =3D { > > @@ -1061,7 +1060,6 @@ struct rte_crypto_asym_xform modex_xform =3D { > > /* >8 End of MODEX vector. */ > > > > struct rte_crypto_asym_xform modinv_xform =3D { > > - .next =3D NULL, > > .xform_type =3D RTE_CRYPTO_ASYM_XFORM_MODINV, > > .modinv =3D { > > .modulus =3D { > > diff --git a/app/test/test_cryptodev_rsa_test_vectors.h > > b/app/test/test_cryptodev_rsa_test_vectors.h > > index 04539a1ecf..e769dec1f4 100644 > > --- a/app/test/test_cryptodev_rsa_test_vectors.h > > +++ b/app/test/test_cryptodev_rsa_test_vectors.h > > @@ -346,7 +346,6 @@ uint8_t rsa_qInv[] =3D { > > > > /** rsa xform using exponent key */ > > struct rte_crypto_asym_xform rsa_xform =3D { > > - .next =3D NULL, > > .xform_type =3D RTE_CRYPTO_ASYM_XFORM_RSA, > > .rsa =3D { > > .n =3D { > > @@ -367,7 +366,6 @@ struct rte_crypto_asym_xform rsa_xform =3D { > > > > /** rsa xform using quintuple key */ > > struct rte_crypto_asym_xform rsa_xform_crt =3D { > > - .next =3D NULL, > > .xform_type =3D RTE_CRYPTO_ASYM_XFORM_RSA, > > .rsa =3D { > > .n =3D { > > diff --git a/app/test/test_event_crypto_adapter.c > > b/app/test/test_event_crypto_adapter.c > > index 2ecc7e2cea..feb1d86c00 100644 > > --- a/app/test/test_event_crypto_adapter.c > > +++ b/app/test/test_event_crypto_adapter.c > > @@ -295,7 +295,6 @@ test_op_forward_mode(uint8_t session_less) #endif > > /* Setup Cipher Parameters */ > > cipher_xform.type =3D RTE_CRYPTO_SYM_XFORM_CIPHER; > > - cipher_xform.next =3D NULL; > > cipher_xform.cipher.algo =3D RTE_CRYPTO_CIPHER_NULL; > > cipher_xform.cipher.op =3D RTE_CRYPTO_CIPHER_OP_ENCRYPT; > > > > @@ -474,7 +473,6 @@ test_asym_op_forward_mode(uint8_t session_less) > > return TEST_SKIPPED; > > } > > /* Setup Cipher Parameters */ > > - xform_tc.next =3D NULL; > > xform_tc.xform_type =3D RTE_CRYPTO_ASYM_XFORM_MODEX; > > cap_idx.type =3D xform_tc.xform_type; > > capability =3D rte_cryptodev_asym_capability_get(TEST_CDEV_ID, > > &cap_idx); > > @@ -672,7 +670,6 @@ test_op_new_mode(uint8_t session_less) #endif > > /* Setup Cipher Parameters */ > > cipher_xform.type =3D RTE_CRYPTO_SYM_XFORM_CIPHER; > > - cipher_xform.next =3D NULL; > > cipher_xform.cipher.algo =3D RTE_CRYPTO_CIPHER_NULL; > > cipher_xform.cipher.op =3D RTE_CRYPTO_CIPHER_OP_ENCRYPT; > > > > @@ -807,7 +804,6 @@ test_asym_op_new_mode(uint8_t session_less) > > return TEST_SKIPPED; > > } > > /* Setup Cipher Parameters */ > > - xform_tc.next =3D NULL; > > xform_tc.xform_type =3D RTE_CRYPTO_ASYM_XFORM_MODEX; > > cap_idx.type =3D xform_tc.xform_type; > > capability =3D rte_cryptodev_asym_capability_get(TEST_CDEV_ID, > > &cap_idx); > > -- > > 2.13.6