From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DCB05A0548; Thu, 2 Jun 2022 16:46:51 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C209740691; Thu, 2 Jun 2022 16:46:51 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id B45D54021E for ; Thu, 2 Jun 2022 16:46:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1654181209; x=1685717209; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=IKzdGmI8+20txcLB3bkV8NMNoHRI8fYVAqKE4MEzFv4=; b=SJ0DRGS3vaTFyEH52lkm4fhsCQUeGAx0j367v2linJ2eRRgAuMrghqvo FczAjZhWmn2BiSyFU2de/XOwkcnIFok5XBlyi8ZWBG6wtEUUAW8ldWsjt QgK4l/Bss9usUmHNBYdDyxX0z9wkNtj4RW9312KAQ1tIvXU9S3TVj/cay boPjeopzgruQlnV215eHCojn2krnURjXmEDdNX6pfxdRcsbPDPgLwRFAZ Imn2W9K43l9R2ukpEsmIVat2eBQCHGcwO5PrzS0ZeM97KoJjmolFx/xr6 FMmf4DKNLe/ORfGCJI9J5Rec63bfCKn5Dm1H9Rbe2qW8EV1dbL2M7D5aG A==; X-IronPort-AV: E=McAfee;i="6400,9594,10365"; a="274772333" X-IronPort-AV: E=Sophos;i="5.91,271,1647327600"; d="scan'208";a="274772333" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jun 2022 07:46:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,271,1647327600"; d="scan'208";a="612850592" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by orsmga001.jf.intel.com with ESMTP; 02 Jun 2022 07:46:48 -0700 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 2 Jun 2022 07:46:48 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Thu, 2 Jun 2022 07:46:48 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.102) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Thu, 2 Jun 2022 07:46:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nG/Z48IbPQsBuu9W+vTaKMIvdLSUr53ULx8jLW3x6IPjPmgIHUTdl6VuSjcETigXXSRJ69T4XabWFkNOYfPOSLjfgYeHeV9oUfewjSg1/SDwzuMZ5b0Z8POoY9TA3SPZlm70Kxdar2sdre5BsUWt/H6tKLw9G9PZWGpex8PqB4e6384eUlCQaKQrVYLcymygv7sihbPziDHGvJjvUiN4Oh8q0vF1hEqaCmEV+vADbo3tbAIuh2gCrHVqttGmv8z0X7Em54CpmMp8fN9iLnOr5X3NYLvWGZv6682SD2LTfBjNPK7y/nE/PhP8IvskDYlyD/gGYQ7Y8XCVMLN5Wl0EYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TYAWW2Y5uqG5ygfpd0xzvvvrvL2Tz15bNbASnaLrO4k=; b=hots99jofAyzTthCj+JU+gTruEdCsL1Gj1BxXF/cFlk1OuFyMuG8ma7YQQseJiZhyjwMxE2djm7Gu08hRt+yP1Qu7dVNjqdU5dabisy+v8k9Uaurc/9j8SnYGclD9cyV0BgV6M0X0YJh/gehyfPcyTnVSNk8iCpQQZzwzhwP10x5S5a9p1CnQdw8cxUR1aNj55kd11adKQeQifZX72cRN74lVDhFnzvBhNI39bJXOFBAxQiGAsGrkYl46y/K//hq0YsLVMQU2gecU/aErjTVfMtgU6yrRvRrN4A1ZN5qkQbzP8kfv8V9z7eI2WyJgV4IaovimlaWhaoErvEGZ+VLQQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5013.namprd11.prod.outlook.com (2603:10b6:510:30::21) by BL1PR11MB5416.namprd11.prod.outlook.com (2603:10b6:208:319::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.12; Thu, 2 Jun 2022 14:46:46 +0000 Received: from PH0PR11MB5013.namprd11.prod.outlook.com ([fe80::c1de:722f:b4f3:91b5]) by PH0PR11MB5013.namprd11.prod.outlook.com ([fe80::c1de:722f:b4f3:91b5%3]) with mapi id 15.20.5314.013; Thu, 2 Jun 2022 14:46:45 +0000 From: "Kusztal, ArkadiuszX" To: Akhil Goyal , Ray Kinsella CC: "dev@dpdk.org" , "Zhang, Roy Fan" Subject: RE: [EXT] [PATCH v5 06/12] cryptodev: add elliptic curve diffie hellman Thread-Topic: [EXT] [PATCH v5 06/12] cryptodev: add elliptic curve diffie hellman Thread-Index: AQHYdZ/gzOWkPHcsgEuDFNtP0zcrTa08H3yAgAANTgCAAAEgAIAABczQ Date: Thu, 2 Jun 2022 14:46:45 +0000 Message-ID: References: <20220601090249.86865-1-arkadiuszx.kusztal@intel.com> <20220601090249.86865-7-arkadiuszx.kusztal@intel.com> <87y1yfp2mw.fsf@mdr78.vserver.site> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 534bbd23-6aea-4127-9580-08da44a6b741 x-ms-traffictypediagnostic: BL1PR11MB5416:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: tWhMw0/qMTB8u//BTxtuGbG3EXjexYuHGVuJ5z5SSy+KCiOko0KSNULY8+g69kYKf5Nk0uutqHfoi+f8DrTxypoA21k1siTxGTgCCR5wa6fLJBPP76TD9BWyybES8CuFeoCdRRlUYUNEJfzRM2buQ3d+kK+jbVjRufheZVKoSUs7BeFyr2AP0SZfomMkyfX0Ol49lwGqcL5lzHFt3hBPOsSCNLFjVmY5d1JhCBnwT9S9koTNS5pR7Sy0tLDXnkmESmZ78IZw9djj54RhSrrbeNBOsUCzoHuiDxlAj4bF3XPTf8Aau3kWDbP20q5UPjci8gVSoaCVpPotm9o4SAyhTGdIHlca/fxmh8DJf7J12n537/d+maZ7R/MYIeVLplL5eJqorajlE+wsu2IbdtBcTC/I5p53tdzhiFTW2XEHpgy6YeQ5Agq72LEVB7/XMRHRCDpCvREHUKkXmvtGEPd/V2v8L+YCpW6exe3eptMM7tk1gu+wEDl4lSf7Z6IdwGgQ05T+77jRtfM1XRKN+3Y6Ksc/LAgUhNiDrKZyh0wVlHSloCILGuIQ1nSNzk7FFuC7fTbeXtkCdEqgRZxaxiKa5YOTG0D8tCnQ0ZZ2ytdQ4YTWb+HYSlQ9CkmiY6HN3ZnvJ89vuMzbZd5E8GVpCgbNqkPprUWvCgKex50UmqepGPeS3ayw6pM8jnAWpG8imuP/wnl63+h9tNIHj5kvG+XbxA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5013.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(86362001)(6506007)(7696005)(82960400001)(316002)(53546011)(66446008)(55016003)(71200400001)(64756008)(54906003)(186003)(110136005)(66476007)(66946007)(66556008)(76116006)(4326008)(8676002)(26005)(52536014)(83380400001)(508600001)(8936002)(38100700002)(122000001)(33656002)(38070700005)(9686003)(5660300002)(107886003)(2906002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?7ma6X/h1CMSUsadoo/xS7saUGZA57DpnKsa9eG56yuak8ubmpeyjSrFFRCrq?= =?us-ascii?Q?Syt6xMIz5vV2Hrw+zL9GGT7jL76d3zuP3J6gzFUwz614GMO8Jicml4B6scy+?= =?us-ascii?Q?zx/LPUMCKdgHPiUeHNSw5f45d+MtiusMHSXqQyXkb4SnKXGI/Ss4g2cgKRR9?= =?us-ascii?Q?0HvyPT9oCWT4IkKsheYiy7zHH7t5Kbt38CzCpU90Lt220LuKNc+4oFu5EZ6v?= =?us-ascii?Q?e4GeBMEaR2gQvDWjgdF/ih/h3O5IEfGI9oILqjN6ms6jao/vdo36VMNm0kei?= =?us-ascii?Q?cxLKVk7O67ZjKMxJ10P0r6WaFJAs31trtwlPvorMSA2momo8qppW8mibyEcl?= =?us-ascii?Q?C9A+kJtyOM8R5AXm1d/Ab2i4oqtKdWZ9vXEiBe4fzTKQhRBokcodkDCQjZKD?= =?us-ascii?Q?hifqROpZPkcPRjMEcdSt95oe0vQUGNBUgdzkcTTmYGbfKVzoydAKPRqzl2yu?= =?us-ascii?Q?s6O3xpfmv/hisnbkSJuIX0LNar0KCNqz4EBaUwFeCfzC7x+DV3auPOxB0hOz?= =?us-ascii?Q?ZctxO8JX4+36R5JYJ8TPPxsRV2w6m3VxwHkqM21+170k6otvOpqhKRKLXMuz?= =?us-ascii?Q?ZO2hqVw06a9kjcX8Rzalnne6VkKMNQSDn09HmjWhTDbmVKWaydFkTkgeGfdT?= =?us-ascii?Q?ysiaNW3YChuClrVPf6T6bdZCyKqQck9DrFneko1o9gOeBMZ0kZqNiEmuFiV+?= =?us-ascii?Q?ia4FPwGXAr9yqbWDDuQIgc2Ync5+c7uHSwrQJaDXo+oQJNXKUxsayru+Idff?= =?us-ascii?Q?S03FOnr8+L4nVpwWYis+v8KgAZ/5a0DdT3p/ephLg4SYumY4URCQEyiuh14w?= =?us-ascii?Q?ZsLVqeiR5tMcV+eWI7JX1zvq8i87N2rBefaaIOjORf9Y11RkKHP04fSo73lm?= =?us-ascii?Q?nbDwK0IJaq8Tx5etFrRueWQnP3gyEAXn8vyPvir4XkCWDkzzyLEu4Uhy4n6t?= =?us-ascii?Q?lvLbbreF1UTiSBc1ywP9Jplvs1nk5geLXSQdLwJYj5aMdnbZ6mbhHPcl4ql+?= =?us-ascii?Q?vkmB5rbdU8XeVG3C2nbKChkJVFdwJX1e/5Jys5bXAXQtrY9GJLfWyg+fIPnc?= =?us-ascii?Q?XApseJ5Td99ROLicCB5+KDnHh0fA4nfW8rYCY5I4yUQhjhnAdSOKYHcnI04s?= =?us-ascii?Q?5HXkbgkqOUm6S7xuTkbBccyU3Lv3veoKP35LR1e2cSzwIajeuidjA2W/JRra?= =?us-ascii?Q?Gd5Q3ERjGCOMyYEVeHGKa8/6Y3iBwDJ3whDKQ7KQX/9f62tAPsJjjd4BScDt?= =?us-ascii?Q?fumOpyy2/YUqCh9Tjwsc+HK2BEOrPlzuFKzLjECsif3o+X9JwbgVf9PCQSqG?= =?us-ascii?Q?cv9ylspbvnSBZagmf1QoK7Mrfq887TPAXnQUH8G53Di7WAzwGPWlE9P5yBb/?= =?us-ascii?Q?9LtTwNyniftHtwsogxsjaqoEFUSGcdapmlOkYTXuv7jjEcKsZ8MN7f9PhgWq?= =?us-ascii?Q?ljKbDRiQFt1FUaYGL9XNpZYPUZ/mCNfIX30R74iDNn1/xjZ7JX4427FWhu7K?= =?us-ascii?Q?v3eS3XDADS+btUZRw/UBNu/T25Q30iGyg46aPirFMuiZZPA8kpD55VzE5vD2?= =?us-ascii?Q?czyDtw+GUUdaBpLb4PugXol2HK5Sx8Ku2DbWULLz+oSJj+yFGpk3kBwUOtUE?= =?us-ascii?Q?P0f5rFQXRHtBqKHN4HcbD74kwF6CZxSC3G3k+MgQZR+USBZM4HpILfpBuZMm?= =?us-ascii?Q?8qKSH5J0Ucd4hYx6/iMGhuD6wSFRLaZCp2m53N/8Jgv+CzVaze3xzkoR68yn?= =?us-ascii?Q?Pm2fXBSS6J8s9vSQDxhqxTxUjvsLC4c=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5013.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 534bbd23-6aea-4127-9580-08da44a6b741 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jun 2022 14:46:45.5978 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: juX0zkpH0iJ/Nsjx4kAWDtzOjXYG/IKdm5kmfbq5OgBTNUTV6nFGmt40gua2yJbWGKIv6I3H35vS8dZ8bk2LmqG7jYCcaIEo/OamiezhosA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5416 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Akhil Goyal > Sent: Thursday, June 2, 2022 4:25 PM > To: Ray Kinsella > Cc: Kusztal, ArkadiuszX ; dev@dpdk.org; Zha= ng, > Roy Fan > Subject: RE: [EXT] [PATCH v5 06/12] cryptodev: add elliptic curve diffie = hellman >=20 > > > > Akhil Goyal writes: > > > > >> - Added elliptic curve Diffie-Hellman parameters. > > >> Point multiplication allows the user to process every phase of > > >> ECDH, but for phase 1, user should not really care about the generat= or. > > >> The user does not even need to know what the generator looks like, > > >> therefore setting ec xform would make this work. > > >> > > >> Signed-off-by: Arek Kusztal > > >> --- > > >> devtools/libabigail.abignore | 3 +++ > > >> doc/guides/cryptodevs/features/default.ini | 1 + > > >> doc/guides/prog_guide/cryptodev_lib.rst | 7 +++--- > > >> doc/guides/rel_notes/release_22_07.rst | 2 ++ > > >> lib/cryptodev/rte_crypto_asym.h | 38 > > >> ++++++++++++++++++++++++++++++ > > >> 5 files changed, 48 insertions(+), 3 deletions(-) > > >> > > >> diff --git a/devtools/libabigail.abignore > > >> b/devtools/libabigail.abignore index 79ff15dc4e..6d174b291f 100644 > > >> --- a/devtools/libabigail.abignore > > >> +++ b/devtools/libabigail.abignore > > >> @@ -27,6 +27,9 @@ > > >> ; Ignore changes to rte_crypto_asym_op, asymmetric crypto API is > > >> experimental [suppress_type] > > >> name =3D rte_crypto_asym_op > > >> +; Ignore changes to rte_crypto_asym_xform_type, asymmetric crypto > > >> +API is > > >> experimental > > >> +[suppress_type] > > >> + name =3D rte_crypto_asym_xform_type > > >> > > > This exception does not seem to work. > > > Thomas and I are getting ABI issues even with this suppress rule. > > > > > > [C] 'function void rte_cryptodev_info_get(uint8_t, > > > rte_cryptodev_info*)' at > > rte_cryptodev.c:1582:1 has some indirect sub-type changes: > > > parameter 2 of type 'rte_cryptodev_info*' has sub-type changes: > > > in pointed to type 'struct rte_cryptodev_info' at rte_cryptodev= .h:503:1: > > > type size hasn't changed > > > 1 data member change: > > > type of 'const rte_cryptodev_capabilities* capabilities' ch= anged: > > > in pointed to type 'const rte_cryptodev_capabilities': > > > in unqualified underlying type 'struct > > > rte_cryptodev_capabilities' at > > rte_cryptodev.h:198:1: > > > type size hasn't changed > > > 1 data member change: > > > type of 'anonymous data member union > > {rte_cryptodev_symmetric_capability sym; > > rte_cryptodev_asymmetric_capability asym;}' changed: > > > type size hasn't changed > > > 1 data member change: > > > type of 'rte_cryptodev_asymmetric_capability as= ym' changed: > > > type size hasn't changed > > > 1 data member change: > > > type of > > > 'rte_cryptodev_asymmetric_xform_capability > > xform_capa' changed: > > > type size hasn't changed > > > 1 data member change: > > > type of 'rte_crypto_asym_xform_type xfo= rm_type' changed: > > > type size hasn't changed > > > 1 enumerator insertion: > > > > > 'rte_crypto_asym_xform_type::RTE_CRYPTO_ASYM_XFORM_ECDH' value '8' > > > 2 enumerator changes: > > > > > 'rte_crypto_asym_xform_type::RTE_CRYPTO_ASYM_XFORM_ECPM' from > value > > '8' to '9' at rte_crypto_asym.h:80:1 > > > > > 'rte_crypto_asym_xform_type::RTE_CRYPTO_ASYM_XFORM_TYPE_LIST_END' > > from value '9' to '10' at rte_crypto_asym.h:80:1 > > > > Ok - will take a look see. > Thomas has fixed the suppress rule while pulling on main. For some unknown reason both: [suppress_type] type_kind =3D enum changed_enumerators =3D RTE_CRYPTO_ASYM_XFORM_ECPM, RTE_CRYPTO_ASYM= _XFORM_TYPE_LIST_END and [suppress_type] name =3D rte_crypto_asym_xform_type works fine for me with check-abi tool: {DPDK_NEW}/devtools/check-abi.sh ${DPDK_REF}/build/ref ${DPDK_NEW}/build/ne= w Otherwise I get: 1 function with some indirect sub-type change: [C]'function void rte_cryptodev_info_get(uint8_t, rte_cryptodev_info*)' a= t rte_cryptodev.c:1582:1 has some indirect sub-type changes: parameter 2 of type 'rte_cryptodev_info*' has sub-type changes:=09 abidiff: 1.2.0 version @Akhil - additionally RTE_CRYPTO_ASYM_XFORM_ECDH was supposed to be placed = at the end of the enum. My mistake, I have placed it incorrectly. Would a fix that swaps these enums be accepted? This could potentially remo= ve changed_enumerators =3D RTE_CRYPTO_ASYM_XFORM_ECPM.