From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2B367A055F; Fri, 27 May 2022 09:47:37 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C73D140E5A; Fri, 27 May 2022 09:47:36 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 298BD40E50 for ; Fri, 27 May 2022 09:47:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653637655; x=1685173655; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=CaCgylQvkuhFbSOeiTRzlQf/2rfe0BIKco4hu5KZMXo=; b=nJWiqOaN42MYPk+4VLplWcX8jlzotZ6yZUngjwmJIUxQR81ZF/+DOxBc A3LxXbRlq4XxxQgPkK074M8zyq3l/PnGK3KAOmBLpGbVlCmoQScL5x7Nh 9VHZR+hjs95d6irNb+Ch4eEc6RctzJ/9/00A6z6GtxTC1M9pyeNpKarYh DmK5scdwHxL1Ws8UsnNksrd5rhpc56i9+HUNhmg8NGWhJh/ixW7yOD1c/ VDBKMmaJhelt6tHnoGdltAoA7CJudwZ+ZFJWs3qk1BC/6qM6I+T16TJY8 Ich09Huk3Cxiiz81z+H7wlghwLL1nJaObkJAm8OlTk4KQ7sWREF23xIXU g==; X-IronPort-AV: E=McAfee;i="6400,9594,10359"; a="271983676" X-IronPort-AV: E=Sophos;i="5.91,254,1647327600"; d="scan'208";a="271983676" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 May 2022 00:47:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,254,1647327600"; d="scan'208";a="574406483" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga007.jf.intel.com with ESMTP; 27 May 2022 00:47:30 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Fri, 27 May 2022 00:47:30 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Fri, 27 May 2022 00:47:29 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Fri, 27 May 2022 00:47:29 -0700 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.44) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Fri, 27 May 2022 00:47:29 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FHi/3b+5CTN+Ap/FrRx1lfbiU4y61a8Dg7moXTjY4UpaiG9VTc82UqjTeU847c6/Fthh+KC98xClHQNW0oZXpRzVAqdJ5LQDDIcqKVZ/IakNjZfp1q1VUdaAVLwurxNJjI29kmxZGftA2G6f2CVTWahqg6Pn9yfQtFJVy4gGhVyoU3a005el7MXTeeql2HfZuk3obEanEMnlHw+/F/nV15OWwN3KU6GOs95Jf8ctJfTOakmZCaR0VxIbnpdbN68qRUTN95hCGXeg4DUH2Ugw64AhHakkokFtfajYxeeJGWognMxrG/j3ak2L6le9ZkAT361oYlfc4DodGkzOGVpLrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pU/+ros2H5BA1EMapCid0meLgTm03rfncpUqwUUQLGc=; b=ayYxTrV6OrkfK070O0mLgbHqrNrFVLqXSfy1R0p/fUiv7AlX1/Wba8KaxPYmO5qyzg1Hi0xsE23P9ExF9l8ZrJvOpnf8O5/2ntv6WEgZC+H3HV75e5WpRdaBsOdNsXwVz58vp/fQ+k96SaK/g9yQrAKtsMvRTc6KoVWotkPgOYb00ifFrMxquctkVzhOEFR0KQmwm7vmfSZVQjm+GtU1/WQ2kOqBnpdtTYTuFSRKLbpRftXh6Qr7tgQzJOk9VeL+7BYsJljGP8sNBGxzgWRYIonyCa/PcPmAE1hIQ+V2NEwqK4OiHUQkmGrURv+UYYBtJYVgeB/diL673IUGDa/nbg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5013.namprd11.prod.outlook.com (2603:10b6:510:30::21) by DM4PR11MB6477.namprd11.prod.outlook.com (2603:10b6:8:88::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.16; Fri, 27 May 2022 07:47:27 +0000 Received: from PH0PR11MB5013.namprd11.prod.outlook.com ([fe80::c1de:722f:b4f3:91b5]) by PH0PR11MB5013.namprd11.prod.outlook.com ([fe80::c1de:722f:b4f3:91b5%3]) with mapi id 15.20.5293.013; Fri, 27 May 2022 07:47:27 +0000 From: "Kusztal, ArkadiuszX" To: Anoob Joseph , Akhil Goyal , "dev@dpdk.org" , Kiran Kumar Kokkilagadda CC: "Zhang, Roy Fan" , Umesh Kartha , Ramkumar Balu Subject: RE: [EXT] [PATCH 11/40] cryptodev: remove asym crypto next xform Thread-Topic: [EXT] [PATCH 11/40] cryptodev: remove asym crypto next xform Thread-Index: AQHYbBe2UHM2F4o38UOTiTgBHrrEV60t5jIAgAA66bCAAQG9AIAAB+NwgAAI1ICAAxCQAIAAC5pggAAFlPCAAAkIAIAAA7Ng Date: Fri, 27 May 2022 07:47:27 +0000 Message-ID: References: <20220520055445.40063-1-arkadiuszx.kusztal@intel.com> <20220520055445.40063-12-arkadiuszx.kusztal@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9a767e95-093c-42cc-bed6-08da3fb52540 x-ms-traffictypediagnostic: DM4PR11MB6477:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: zNRxsLmhvYgprTmbvgTHAAI67icfSB70jZSf2B8dkw7qrIakGbzBLVo3W/KTPwNkCrCEOHIpZcJfqoBuopR5P81pKBNNyWBWrK9DmM8/49RbhOnoXcreuhOeVA9515XaWAKTMlY/nlhxCiX0H3HzJku11eNNi5fg0G2zrt9ERyu+w2ylh5sBuzwR3S2Fhxi4t0eFsT/wko3pAVZYx7BVfzIfTqPpU+4js/o8jG0Jkh2WIRhI95iXRUsGLteRetc+CxhHmlzxF/VkfFOuH3YbAyQqWYU2tsRdC7xc5RHmoTOu9JTmWgy53HIHGy13n1cL1UeMjOfILQ5Ju7SrMQfldqAcKFkjgN270inlm3PO0ZsHMkzKbj6puz2CGt9Kjl+0vImIzbysXCHnWOa1jsIrBBlJg41RztxsipmNqb6q8h5QUKVY2p623PZs6c0Ql8Lci59K3fWRffx28ycPFNIFtI7xefrRxrT2skWJemLGMQ680LrBI2T/vTpviXulbxvzjNs2fJi7COPuFGN7rPmsjPc8fP2wi+QtDCsS37UYh73c/W9Q1z4l9jtsEOUinFdbBpOk2ylIP6W818dG734fzZgzgPaoYiUA6agfFxltwzHwHyEILWbFsDGaxw1dwW/fzJlqbUw4dgv8D9wK4zOc71TBZ5Mee81x+8QwLoyQ6lQ1Fg7aGzjqgVEuXvJKAAwJNI2GRjGSt3RJBFmAISu1Lizld/GAGRAmbOorVrfUJy2ldJ/QjjP5XVfGFki7tdY30yvNHn8zhNMaXk8Wf5T+yuwmNZb69Sl3+Eo2l2R6WvY= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5013.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(76116006)(26005)(55016003)(122000001)(53546011)(66946007)(66476007)(6506007)(4326008)(83380400001)(33656002)(66556008)(7696005)(54906003)(9686003)(66446008)(8676002)(64756008)(186003)(71200400001)(38070700005)(86362001)(966005)(82960400001)(8936002)(508600001)(52536014)(316002)(19627235002)(5660300002)(110136005)(38100700002)(2906002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?s9HyH1s1WWCdE/OfJ/aK2Ot7/2CqF65EAHjVx2lblzDrlTC+1MT66UCjXK6f?= =?us-ascii?Q?w5uUM2+TuzlG6lIDJqtXZQDfly9qtbR5tTE0uYD/RQrdungrTGCqtZthtRpc?= =?us-ascii?Q?MdugToqtNaTUD3G7kzaQq1FWBq9lXEjT2hCUvZxQ7duBK26s+wLHG/b35q2Y?= =?us-ascii?Q?LY5qNPf8j+fRsum02Y1kTTl9aGKp+QUgz4Jq4hw9tHvJNHlFNQnrppJTTHee?= =?us-ascii?Q?iDf2kewGTpx6UvTUy9EFQxvw/I8J9Dwy11LJM2IY7Zo/Z4YMev1FYHfy61On?= =?us-ascii?Q?fVPWK9DCgZBVzjq6E4qIxsGHJHY8T3W6hnWDf9BVOGEBvBDui0Hrsc4g/Min?= =?us-ascii?Q?eCQdxb8IrqIhNm2Cq2F0PjWZVHXUbZ5SflIApDO5OiX2/fLICXPz1LpxnYM1?= =?us-ascii?Q?02Nbepm3pvZui2pahZ0n7vUiFNk3WWg2aTKi4ZV1riZlWEqFpFk6Cmsxr2lj?= =?us-ascii?Q?SIJb4/SFL8/SrDEXVwLSjkBaDIACdtIa8WM/R/V+NwLI9un7kbaeeJ3d/CoX?= =?us-ascii?Q?xtLOWgYA+efgcKiit3pl3oGZsiKJd5JiSYXVtgbYJ93KY4t+P+huEjfVCrYZ?= =?us-ascii?Q?MefyV4D4Y+AJAV5Cs3iL6tOLr+tgCMbFaSNJfGlfTysccF5A0ukNi65re6Ec?= =?us-ascii?Q?dnwNtR+lohKd/aHSRRqm6xf/Xq/n077RhTATHbnkH0cvfCOPBmAVVtDRttMi?= =?us-ascii?Q?ZSFH9mGMBunqHQp3hQmPK+xCPx8GXTCH5hMGxkauPDN2uA1HFZviXkxNvnzX?= =?us-ascii?Q?A2lpGYzZQasUFIVNQG3KjneN49uu/La+zSO4/MJLxrKmjLdi/DjHQzPT/E+e?= =?us-ascii?Q?MOws4fjA4p4ZudYIXYpmAK0mfJO3ghPWFYeeJxw48kjO41x88C1lnHLOuwEw?= =?us-ascii?Q?LtV8hVIOHEEKSzSUrgj1NGUW2hrTtRegMmkuW+5lXnyVavlOke20wHQQxAta?= =?us-ascii?Q?zVrHGAddEW7Rs7cA5/kDFUceP9nlFwNBfLISRPjfdqbyJC3BTJXLrR15M+g2?= =?us-ascii?Q?sEnq7iXzyIvK1c6GFtnx6kSIQw0y9Ogu/s/aNECp7Ni6MP3uAGUWTkinH1QL?= =?us-ascii?Q?Prfe5lGCMB9WNlIpgFz6AqP4Em61zVYiL/5wfxDklZIn8Z8VI5cRU0X6u1eC?= =?us-ascii?Q?JEgOwE7Y+dZ5N4HGtn2FSVvUUJeMYYfxYc3g7NEa4s6Ei5RKPNVVXylI2uGj?= =?us-ascii?Q?zp9V1azezKLRkD8eHFVWrtbF7MZ7zMNepoiog8lZbq7rT/MJNLqVCMm6FkiD?= =?us-ascii?Q?ssqxqD+98TXjdCMBE4F3ju+bRIpwYod+Y8u0loF650DCiMyZQxH4IbSW1bf9?= =?us-ascii?Q?QDjTu0dOQB9g9bCtHFa33A6IgCyeJOPWcJJzJ7cyGNp2K6Sz0BJBsxJ+P1v2?= =?us-ascii?Q?D+rmNiU4L4OpV2HZQxk0SxbOmABUIeDKJaz3SLf1difZmbvoU/CkmjEee+Gj?= =?us-ascii?Q?/x0AcdJhePnnwcdu2w1EbW/SBEf2vBwBQXk0vVevnEa3VOGWynGZoUvleaxj?= =?us-ascii?Q?FnUehr00+uwxHmFy+a/P4fGDv6fFI727TlWrVvfOLYxpbXXOnLxY+O+0KKAM?= =?us-ascii?Q?5YLf7o3bMz55uM+p10pBwYeqJpM6qZfA/5mXGKgDb+G/jPLYEtffYJOalEag?= =?us-ascii?Q?dkTZO54/tRvDdnrvhgatGPqJy18VzXz+OUbWeZxDL6KcC9BVfZmeURz/EYxw?= =?us-ascii?Q?wfSqqlf5Jh+k1/AvRMguQPn37QHxc3BAEhT0Ucibusi+39m8xdfmXRvVSrWI?= =?us-ascii?Q?KRBSfjJz5KxznkuN8liTDfTgjMjymjU=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5013.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9a767e95-093c-42cc-bed6-08da3fb52540 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 May 2022 07:47:27.2508 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1XiI40xiFKwsHfSrfn0tk0jdRvBsW/gGifTD7xJDW3nQ3ha9Q8tUnmghPgswxLo9U2QC5EkwYI7FaqyH095xjXfBmh7KPi3DxlUOLIJO2DU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6477 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Anoob Joseph > Sent: Friday, May 27, 2022 9:28 AM > To: Kusztal, ArkadiuszX ; Akhil Goyal > ; dev@dpdk.org; Kiran Kumar Kokkilagadda > > Cc: Zhang, Roy Fan ; Umesh Kartha > ; Ramkumar Balu > Subject: RE: [EXT] [PATCH 11/40] cryptodev: remove asym crypto next xform >=20 > Hi Arek, >=20 > Please see inline. >=20 > Thanks, > Anoob >=20 > > -----Original Message----- > > From: Kusztal, ArkadiuszX > > Sent: Friday, May 27, 2022 12:26 PM > > To: Anoob Joseph ; Akhil Goyal > > ; dev@dpdk.org; Kiran Kumar Kokkilagadda > > > > Cc: Zhang, Roy Fan ; Umesh Kartha > > ; Ramkumar Balu > > Subject: RE: [EXT] [PATCH 11/40] cryptodev: remove asym crypto next > > xform > > > > > > > > > -----Original Message----- > > > From: Kusztal, ArkadiuszX > > > Sent: Friday, May 27, 2022 8:40 AM > > > To: Anoob Joseph ; Akhil Goyal > > > ; dev@dpdk.org; Kiran Kumar Kokkilagadda > > > > > > Cc: Zhang, Roy Fan ; Umesh Kartha > > > ; Ramkumar Balu > > > Subject: RE: [EXT] [PATCH 11/40] cryptodev: remove asym crypto next > > > xform > > > > > > > > > > > > > -----Original Message----- > > > > From: Kusztal, ArkadiuszX > > > > Sent: Friday, May 27, 2022 8:31 AM > > > > To: Anoob Joseph ; Akhil Goyal > > > > ; dev@dpdk.org; Kiran Kumar Kokkilagadda > > > > > > > > Cc: Zhang, Roy Fan ; Umesh Kartha > > > > ; Ramkumar Balu > > > > Subject: RE: [EXT] [PATCH 11/40] cryptodev: remove asym crypto > > > > next xform > > > > > > > > Hi Anoob, > > > > > > > > Sorry, I don't know how I have missed this email! > > > > > > > > > -----Original Message----- > > > > > From: Anoob Joseph > > > > > Sent: Wednesday, May 25, 2022 9:06 AM > > > > > To: Kusztal, ArkadiuszX ; Akhil > > > > > Goyal ; dev@dpdk.org; Kiran Kumar > > > > > Kokkilagadda > > > > > Cc: Zhang, Roy Fan ; Umesh Kartha > > > > > ; Ramkumar Balu > > > > > Subject: RE: [EXT] [PATCH 11/40] cryptodev: remove asym crypto > > > > > next xform > > > > > > > > > > Hi Arek, Akhil, > > > > > > > > > > Please see inline. > > > > > > > > > > Thanks, > > > > > Anoob > > > > > > > > > > > -----Original Message----- > > > > > > From: Kusztal, ArkadiuszX > > > > > > Sent: Wednesday, May 25, 2022 12:06 PM > > > > > > To: Akhil Goyal ; dev@dpdk.org; Kiran > > > > > > Kumar Kokkilagadda ; Anoob Joseph > > > > > > > > > > > > Cc: Zhang, Roy Fan > > > > > > Subject: RE: [EXT] [PATCH 11/40] cryptodev: remove asym crypto > > > > > > next xform > > > > > > > > > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > > From: Akhil Goyal > > > > > > > Sent: Wednesday, May 25, 2022 8:06 AM > > > > > > > To: Kusztal, ArkadiuszX ; > > > > > > > dev@dpdk.org; Kiran Kumar Kokkilagadda > > > > > > > ; Anoob Joseph > > > > > > > Cc: Zhang, Roy Fan > > > > > > > Subject: RE: [EXT] [PATCH 11/40] cryptodev: remove asym > > > > > > > crypto next xform > > > > > > > > > > > > > > > > > - removed asymnetric crypto xform next field. > > > > > > > > > > Rationale behind having chaining in symmetric crypto > > > > > > > > > > was a fact that encryption and authentication are > > > > > > > > > > usually done on the same set of data independent of alg= orithm. > > > > > > > > > > HW usually will be able to handle it in one PCI call. > > > > > > > > > > In asymmetric there is no such relation between > > > > > > > > > > algorithms, therefore next field would be useless. > > > > > > > > > > > > > > > > > > > > Signed-off-by: Arek Kusztal > > > > > > > > > > > > > > > > > > > > > > > > > > > > Please check documentation > > > > "doc/guides/prog_guide/cryptodev_lib.rst" > > > > > > > > > Not all asymmetric crypto xforms are supported for chaini= ng. > > > > > > > > > Currently supported asymmetric crypto chaining is > > > > > > > > > Diffie-Hellman private key generation followed by public > > generation. > > > > > > > > [Arek] And why do chaining when this can be done even with > > > > > > > > one bit > > > flag. > > > > > > > > > > > > > > > I believe it is OK to remove next. @Kiran Kumar > > > > > > > Kokkilagadda/Anoob please confirm. > > > > > > > > > > > > > > If we are removing it, then documentation should be in sync. > > > > > > [Arek] - although, we may keep it for now, I am not dropping it= in v2. > > > > > > DH priv + pub can be done with priv_key.len =3D 0 -> similar as= 'k' > > > > > > in ecdsa when k.data =3D NULL. > > > > > > But I do not see any situation for now it will be useful, it > > > > > > may be dropped later if not application found. > > > > > > > > > > > > > > > Also, currently API does not support chaining of > > > > > > > > > symmetric and asymmetric crypto xforms. > > > > > > > > [Arek] - This is one unlikely scenario to combine > > > > > > > > symmetric and asymmetric. One I can think of was once > > > > > > > > proposed DH + DSA integration for random number. But not > > > > > > > > much else, although we can keep it around for a > > > > > > > while. > > > > > > > > > > > > > > Yes it is highly unlikely to use this combination. > > > > > > > > > > [Anoob] We may need this support when we add EdDSA support. That > > > > > would involve a asymmetric operation after hash is generated > (symmetric). > > > > > https://urldefense.proofpoint.com/v2/url?u=3Dhttps-3A__en.wikiped= ia. > > > > > org_wiki_EdDSA- > > 23Ed25519&d=3DDwIFAg&c=3DnKjWec2b6R0mOyPaz7xtfQ&r=3DjPfB8 > > > > > rwwviRSxyLWs2n6B- > > WYLn1v9SyTMrT5EQqh2TU&m=3DbddkY8ZMMGGHjFFvgGsyhfgWB > > > > > fuX0hpwqTdpgCAo_ngHINhO6zwLB- > > mUxNU8xu6p&s=3D3vFaBffulofGlfAPsjnaaUZa > > > > > V01o6k8XWzwNFWHQzvY&e=3D > > > > > > > > > > And, asymmetric chaining may become useful when we have PMDs > > > > > capable of doing more operations together (like the case with > > > > > EdDSA). So my preference would be to retain the 'next' field in > > > > > asym crypto > > xform. > > > > [Arek] - that is very good point, however to implement EdDSA as > > > > chaining would mean that: > > > > - we need to implement EdDSA internals in DPDK > > > > - and EdDSA (in hash option, where actually picking hash would > > > > have > > > > sense) is not one hash but multiple hash operation, so we would > > > > have to had multiple chaining with operations in between > > > > - and we would have to compute R and S separately. > > > > - If PMD does not support one-pass EdDSA - well this is something > > > > that should definitely discuss, but having any crypto internals in > > > > DPDK is not probably an option? > > > [Arek] - but, I have kept 'next' in later changes. > > [Arek] - additionally if EdDSAhash one-pass used it is enough to have > > field with hash, an that's all - only information needed. > > Normally EdDSA hash is fixed to SHA256 or BLAKE but for EdDSAhash > > option there is one additional hash - so enum in Ed struct should be en= ough. >=20 > [Anoob] I'm also not clear about what would be the right abstraction. As = you > described for EdDSA, it can be just a flag. But we may need to revisit th= is when > we add such kind of algos. So my suggestion was to not remove 'next' fiel= d just > yet. We can revisit this sometime later. >=20 > Thanks for agreeing to the suggestion and keeping the field. [Arek] - I considered few Ed options: - or to have Ed25519_op, Ed448_op, - or=20 EdDSA with Curve_is =3D curve25519 (29) | curve448 (30) By default hash algorithms are SHA2-56 and BLAKE accordingly. But for preHash Ed there would be hash field: Hash =3D [ rte_crypto_auth ] /* When preHash (PH(M)) used this field is obligatory etc... */ >=20 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > --- > > > > > > > > > > lib/cryptodev/rte_crypto_asym.h | 2 -- > > > > > > > > > > 1 file changed, 2 deletions(-) > > > > > > > > > > > > > > > > > > > > diff --git a/lib/cryptodev/rte_crypto_asym.h > > > > > > > > > > b/lib/cryptodev/rte_crypto_asym.h index > > > > > > > > > > 1652a434a5..b355cbe5fa > > > > > > > > > > 100644 > > > > > > > > > > --- a/lib/cryptodev/rte_crypto_asym.h > > > > > > > > > > +++ b/lib/cryptodev/rte_crypto_asym.h > > > > > > > > > > @@ -492,8 +492,6 @@ struct rte_crypto_ecpm_op_param { > > > > > > > > > > * Structure describing asym xforms. > > > > > > > > > > */ > > > > > > > > > > struct rte_crypto_asym_xform { > > > > > > > > > > - struct rte_crypto_asym_xform *next; > > > > > > > > > > - /**< Pointer to next xform to set up xform chain.*/ > > > > > > > > > > enum rte_crypto_asym_xform_type xform_type; > > > > > > > > > > /**< Asymmetric crypto transform */ > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > 2.13.6