From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B21E3A034C; Thu, 24 Feb 2022 18:14:56 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7E2A84113D; Thu, 24 Feb 2022 18:14:56 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 3C3CD40696; Thu, 24 Feb 2022 18:14:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645722895; x=1677258895; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=jXYvzt5YRc/of7KxtFtFhF0K+z6vJzTqm2tDcRF5rog=; b=ekIbJvc99ADt3M4s6FH7j7D/p8VNe+cqKaNkaoXNMaUEsG2OJ+iEjean 8+hrUoRjFsAszQTH4UWsEvAbaUqWHrb68vY9m90QXG7h3xOlLngRFM+Fd oJPY8oip4OAlJHMbGwJGURCCVYMkPnQspU7ravENHtaZy3wVqLPkWzQdE /Tnj1L/yYPc9pA4IVjnXQ3ngGKVBdiTctqXwWxJLSuP7piqoM70M/4tO2 NtY8CMtr8fPKuNnSqDuqpjs0r/YTFHXoPJ9U57nJqWVCHzrDeVGjYedOV 5XUtYNpQdKw5qBd+UBGlAF8A8t+XhiyZAeR4a4URvfH075JaKdZxmemKT A==; X-IronPort-AV: E=McAfee;i="6200,9189,10268"; a="235799817" X-IronPort-AV: E=Sophos;i="5.90,134,1643702400"; d="scan'208";a="235799817" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Feb 2022 09:14:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,134,1643702400"; d="scan'208";a="707531658" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga005.jf.intel.com with ESMTP; 24 Feb 2022 09:14:54 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Thu, 24 Feb 2022 09:14:53 -0800 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 24 Feb 2022 09:14:53 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Thu, 24 Feb 2022 09:14:53 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.172) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Thu, 24 Feb 2022 09:14:50 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c3Bf0Qqu1R41Tbsd2Ft63ThpS3p+bY6D92mhvB1IAuxbIr4Y0OGn08mSjPKOUrNlYCwTzK4aPSUTzNettooGVsj+ALocXBeutg5kZ2+oUrUiVy8m3CgKlQ7B9bZBOOGTqd3jiJ+4PwFkVsYwtb1nzqJi3D5Hne20uETaJk12nqgdQx0TZg0aQ2WH/qC0MVyflIDzPcQn4pLSL4LU0jUwKYRFDHn61/HxMQxTBpl32Nd4CnmSJTpt0dCecgZm0iSN2BlpN2HhdFFiHO8oOwYIPPFPsBOX80Eijl332vDxwIGA9pEQX3Og/IKKkzOFcg8WrrjfLiKPRJlSoOwGvsz4lw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eINImVGeTqKmA/eQfKf141BvuDJi4zRNw1n39WAHRMQ=; b=oW4vN53gr/Pn+EkiHfEsb2HMSnYKRFDig/3d1YKgS3I92a3xyRVmLEr/hjv9eLA9RfvURnk500q907rRi8+oA+Yjg11OJEDkl6aYSn4UzkOuplFLaNpnxqtFTrrYRcONzOBv+uDb+XRtloN1kzsYW7dYf40fN7B+KZoYgzt2DcpoRATv8dR2LepMFvFC+preZfr+HtAfUNuQ17lgj7EIe2GoHli9lYY35xUUwAx1A3b8QmGy/yJ3dGT+76vLX5zfb1TJ0HEGdg2ZBqCJQZUNtjiKlcXTdN5+Ui4V6O5gUhxgALp5W2JDx1/2QcBHQB9z4Q+yvRKoKlNKLRqx3a45nA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5173.namprd11.prod.outlook.com (2603:10b6:510:39::12) by DM8PR11MB5574.namprd11.prod.outlook.com (2603:10b6:8:39::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22; Thu, 24 Feb 2022 17:14:48 +0000 Received: from PH0PR11MB5173.namprd11.prod.outlook.com ([fe80::d011:d026:37a7:4b6e]) by PH0PR11MB5173.namprd11.prod.outlook.com ([fe80::d011:d026:37a7:4b6e%5]) with mapi id 15.20.4975.011; Thu, 24 Feb 2022 17:14:48 +0000 From: "Wang, Yipeng1" To: "De Lara Guarch, Pablo" , "Marohn, Byron" CC: "dev@dpdk.org" , "stable@dpdk.org" Subject: RE: [PATCH v2 2/2] efd: fix uninitialized structure Thread-Topic: [PATCH v2 2/2] efd: fix uninitialized structure Thread-Index: AQHYKZdTBcy1+2PGPkSVlGx92RmgP6yi8Jag Date: Thu, 24 Feb 2022 17:14:48 +0000 Message-ID: References: <20220224154801.819320-1-pablo.de.lara.guarch@intel.com> <20220224155759.819460-1-pablo.de.lara.guarch@intel.com> <20220224155759.819460-2-pablo.de.lara.guarch@intel.com> In-Reply-To: <20220224155759.819460-2-pablo.de.lara.guarch@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.200.16 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e983bddb-e6d9-4fbf-b0d2-08d9f7b92984 x-ms-traffictypediagnostic: DM8PR11MB5574:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ESB6GTAsE66CkuGk9AXWtoP/E6Ew6ej+oaBjjBWNVObWRBggrHu9iK9ymRk968m0ZAofkzu2HBFFkCPbwCqws444JFMvL42R2r7qHimr/QCbMFZJw1azS/SvblhhIjLjf5pJ0UFebo0SM6v7DMJ7KoGL26uP4Du9vE2/qzGPgOxQB9xzy0ORDSHbrCPGN/iN3H0l2OvTAYfVGjVJ0HLkAuz3wSDMNQdeeLLrk82fUGirc/v+dU618pMEX83f++XIi2/vHTemWVAPW3R8Ij6dRsatAop7quDKsnhZtaZyQluMkQSoScIpdysGHNzsr9SWsL+HFTz4sDDE6PmkH19e2vm1f0Iu/q1eS54H+F22WBzXqeq94SKCMYR4e7cpFfpKMgPRQzU3oSiv1VYVKm6k/hD9gGIcubK7fNDroNPp218ZScwk0Of5jBi/iFwnsVDuPjy+uqCNTz6neyw9c0NwSkjAYE6vTzTeaX3nuvLAW+Y5/A8EkBqG1C1mgkPGufavw6w7ub916pVvxxtusa7jrfn3lAgP4/sbCGWN0YzTK88K706SHLfcXgH072s78Sahyn/LSh45uP3pxcLkiMJDXlqwNiahUZDhk9bMwD6vG4u5xoUh4rGpO5kfDP2Ql1VeHysHOG8vNpcqr6XElx6vh0okDLIywJbVw9W6jSxm1GTWo6PO1XnAov2Qa6QMYrUDTF8MBbKyS71Ew7Z9aXyj6g== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5173.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(38070700005)(54906003)(110136005)(6636002)(316002)(5660300002)(86362001)(55016003)(8936002)(4326008)(66476007)(33656002)(66556008)(66946007)(66446008)(8676002)(2906002)(52536014)(508600001)(38100700002)(450100002)(76116006)(64756008)(82960400001)(26005)(53546011)(186003)(122000001)(7696005)(71200400001)(9686003)(83380400001)(6506007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?8ctqHB1J5U8Xd39h2MFxYO3dXyV6YoYffEb5uH6f7WekfoIXxu8AwY5ryhIw?= =?us-ascii?Q?n2yyE2SeMOL2h+gVDT586itWtyce7PjNYQkplytyPHXZVyJLxK5PGy4/4Dkh?= =?us-ascii?Q?Mh+lbAcophLdztLDSwTzs94/+kzgpbcn5AZduECgq0sezAxTBBND/GtzI/IA?= =?us-ascii?Q?2GMGVFXk6ZXmhCFt0GU65E1PGxt3BYEs3nvfdZFUGX5CrjtUj4nR30YfX5Fw?= =?us-ascii?Q?BAZ7h/yD8g1WCmh0zR9ZPoccx+YcwC58eA3E5YCvuPKcM4nJlE30Q+hRYco5?= =?us-ascii?Q?Y0spwXAtswtdiH0X46C71O/KI4rgSvT8IO1fCRdWeY5TweAdBwMGQhgUAnNx?= =?us-ascii?Q?SpnCZH19TL4MAEBSuOCXSAlVwRbEsq70jdvS6r8hBoQe8lQImCtKZQKZathI?= =?us-ascii?Q?eDRAvdukcXdKr1oHsOd/HcKg46WUtj5eSgykUCAbb3rA3AZEUrq95WIrqohQ?= =?us-ascii?Q?QM28YqECGvbTt9vhCrKIJUTGI20In7lSBuXZZPIvhr2ARsPXi3sUswvVhneU?= =?us-ascii?Q?aDxt8/ikpUmLM/cSzgi0eSSrBiLMSn6oZhXkhiIkYPOq/4ITjotEBAfwGSXc?= =?us-ascii?Q?I4ZZ84ILn6fX3QeZpcJEx0OR6BUJYSHFAH7D9nGZZjhrPKAV4MY7DQBRUY3A?= =?us-ascii?Q?qVSFCemzAUMxDCiWR+O19KGathJ0/cp3I/FagNvIFYRG4nwynkMLE7eLibSC?= =?us-ascii?Q?9JvY0bbF7+RhLuqlNQ4ZGx0h9ub17qSS2GOpNVMT8sUFUff1JbnC3mPzwzuK?= =?us-ascii?Q?HlbCaC/m05Nte83SyxnLaEAR58Q2FiZxOgdUHsfmsHsUAkKlePlYvHHyzsDU?= =?us-ascii?Q?XaDmT6PizD7TCE0RldQLkMsFHSKWhyrrm1c1xnFhtqx0DUrIewcz8SeZq/Vj?= =?us-ascii?Q?R2XFJFjocVa/rocKkSd2nr7sfLvhocS9nGNjlRgGb0BcAY7eJfrrQaESYw0i?= =?us-ascii?Q?ZTXjlUW6De06ZrNJCL3QpnCCqWr3QFIVKAhxaESC0YzCMvd12KEweGMRKTD1?= =?us-ascii?Q?zovGs0uwvxVE3w42xdxvRCwkMQVp4N4KldqwIlqbaMbRXhBmzaPNAI9E3UlK?= =?us-ascii?Q?olxBiRfTaaRURYTpcIkCTqWTtgDYV8jEvqREdK3rBARrb8HUD6lyPcKbRU1q?= =?us-ascii?Q?eqLP+5Xyd1SbJ3N4YCTXU4uXqnlddJsu8WBsesx0i+P29Ntd5dhxZbN1PUSC?= =?us-ascii?Q?aUrRuai0et/fkyv8jqE29XLdtlC1ZxGvD3UJmcdWBJ3lFxz7IxOr2I3YfkWt?= =?us-ascii?Q?2/MJp6qwesk7KBSmkmeAPtqV3lxj/83egmGqyeIbo1CDKwshw7FdXRvi+Gqe?= =?us-ascii?Q?QU8LqLFH/lLC1Wsc9qgjedY1yU6VdjxSR0TBzoFKwFrM/ZMBsqNIBRGVWuZ1?= =?us-ascii?Q?DeLBHdZUmNO1BgIol2cg5qytCvl5gaBzWYE19uEiEX76D7y1+LI4UaKTZoLd?= =?us-ascii?Q?gGUyuQGUB5O2kpb/z9oNqZXaY2uz+Keg4vd8+emku3mY/fA74MA1JFk9xNzv?= =?us-ascii?Q?GSEZIn092we7zvGN4C0g1VMDfy+VvwXoOwmlKYuGXEAGjQccvFgsP7gKB8rs?= =?us-ascii?Q?NJa6/Kdxu8zHojCOqc8O5kTIZFxGWLvgdbA9vkZYiy8E/Iccyr4F16tcUwnf?= =?us-ascii?Q?tg=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5173.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e983bddb-e6d9-4fbf-b0d2-08d9f7b92984 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Feb 2022 17:14:48.6427 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9V2Ww/N6JILdv3MqTAmjjbRRqxjilkQ7aqFgm9tG2EcRYu3TCkGrBqeXZru7yt+xY/63bI6UGaIxvmAe8996MA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR11MB5574 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: De Lara Guarch, Pablo > Sent: Thursday, February 24, 2022 7:58 AM > To: Wang, Yipeng1 ; Marohn, Byron > > Cc: dev@dpdk.org; De Lara Guarch, Pablo ; > stable@dpdk.org > Subject: [PATCH v2 2/2] efd: fix uninitialized structure >=20 > Coverity flags that both elements of efd_online_group_entry are used > uninitialized. This is OK because this structure is initially used for st= arting > values, so any value is OK. >=20 > Coverity ID: 375868 > Fixes: 56b6ef874f80 ("efd: new Elastic Flow Distributor library") > Cc: pablo.de.lara.guarch@intel.com > Cc: stable@dpdk.org >=20 > Signed-off-by: Pablo de Lara > --- >=20 > -v2: Fixed typo in commit message >=20 > --- > lib/efd/rte_efd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/lib/efd/rte_efd.c b/lib/efd/rte_efd.c index > 560cd78961..86910e587c 100644 > --- a/lib/efd/rte_efd.c > +++ b/lib/efd/rte_efd.c > @@ -1162,7 +1162,7 @@ rte_efd_update(struct rte_efd_table * const table, > const unsigned int socket_id, { > uint32_t chunk_id =3D 0, group_id =3D 0, bin_id =3D 0; > uint8_t new_bin_choice =3D 0; > - struct efd_online_group_entry entry; > + struct efd_online_group_entry entry =3D {0}; >=20 > int status =3D efd_compute_update(table, socket_id, key, value, > &chunk_id, &group_id, &bin_id, > -- > 2.25.1 Acked-by: Yipeng Wang