From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B6C5BA034C; Thu, 24 Feb 2022 18:15:16 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AB3E341153; Thu, 24 Feb 2022 18:15:16 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 3200C40696; Thu, 24 Feb 2022 18:15:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645722915; x=1677258915; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=o5ZXtRDvzCifbCYcNl8OTI3TeNKEsIhGg2uVUDRkc1I=; b=OoxZ/6EqpnVpWfAYeGDn0Q5Yk4i7acMIWCVsjhRZhKkjmSwjb7c+rheb b5oF5bbGFZVYgWCc/OGnqUWSBLkLaTWI1djdFP73TJwmcAOsgdWpBtAnD vdnDLsfYQfuvo8zAqg4RykG1NwTSEkbKxvuxqcsOz25/9Dzh7zIlaCn/h 5sO+FTZvtT0lm8/IF3AOKbEykhGoqGTNb1kxh+MTAlB6ImGczvAw9okI8 nKFErMsI03DPz36PNXtDl0C6rdOM/oJYPIl5ubGpwNgsv6gmGo+703gcf nZvnnd4eqNmB1LXK6I1gVGld/FHJq1qHrBp7TjAssdSCd/N5HgAJN+RA8 Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10268"; a="235799940" X-IronPort-AV: E=Sophos;i="5.90,134,1643702400"; d="scan'208";a="235799940" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Feb 2022 09:15:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,134,1643702400"; d="scan'208";a="574284623" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga001.jf.intel.com with ESMTP; 24 Feb 2022 09:15:14 -0800 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Thu, 24 Feb 2022 09:15:13 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Thu, 24 Feb 2022 09:15:13 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.170) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Thu, 24 Feb 2022 09:15:13 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PXbwv893EZrqyD8WUdKm78TxT/4xJgY4ZCQfV1y/bUiaXFshaRbSl7zYcdLQpB7HVpgGx+1q1ASv1DXNfZTxJ+8PMVIQsg3qNFgj8MmRhlAd66Z13V154QCzoIQvehdmn/AGiWuMH/tQoRbmQ0n0eTzj3dUqDdhOx1fe9XPvUIK6auWFKZnCFRWZyppB++yNTNZbDHQS/xQwFWJgsXQmii6DM6h+z/zoTT4a06uZ6wM6HRteNyVOVwwAO39G7ww4ha0SaSNL+tXHqZELwTv0UI2QFvyqqfNekRJ+0S/JIpVNGXdzwzhtU7fNZpDEMsHNcflVLsAxuhgUKrtMysh2xw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jb/rdGymlGH4jl597J6PS2of3Lh8DvXHjF0gndtyWco=; b=MVDxDLH8H+eszC4pn4vesA8PZS4sGwn38cjoAYhe2/D26GiSHOy2SN8nywK4cy0AGB0tpxSq4b+F9jsUcmeQ9yVuhBb/DmkzGfiUbIUKh8mS4pK6wCQjWk74HYeTKiP07yl8NqBCV8Y9EUdQ3o9v0mJJOyQ65idK/wKFRAKNlm7Uy1sLChRpBWYWgGgicudtmEghK67SRTHe0NgAcbMr/CT33Pcv1w/sDmKb9jG8kfIi+wWDFA6suN/MgX1aqxoIbJy5FbuZ85Ac00D/1/X8jJBqgIhbuQGtGKJUfx4vKyvpSNZVf+FH8Tfmfh7eOBJoHTVfbwdmFruh04j3jJ0hNg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5173.namprd11.prod.outlook.com (2603:10b6:510:39::12) by DM8PR11MB5574.namprd11.prod.outlook.com (2603:10b6:8:39::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22; Thu, 24 Feb 2022 17:15:12 +0000 Received: from PH0PR11MB5173.namprd11.prod.outlook.com ([fe80::d011:d026:37a7:4b6e]) by PH0PR11MB5173.namprd11.prod.outlook.com ([fe80::d011:d026:37a7:4b6e%5]) with mapi id 15.20.4975.011; Thu, 24 Feb 2022 17:15:12 +0000 From: "Wang, Yipeng1" To: "De Lara Guarch, Pablo" , "Marohn, Byron" CC: "dev@dpdk.org" , "stable@dpdk.org" Subject: RE: [PATCH v2 1/2] test/efd: fix size of constant Thread-Topic: [PATCH v2 1/2] test/efd: fix size of constant Thread-Index: AQHYKZdVjwDHIyjsQkCLlwBzZdF0eKyi8OFA Date: Thu, 24 Feb 2022 17:15:12 +0000 Message-ID: References: <20220224154801.819320-1-pablo.de.lara.guarch@intel.com> <20220224155759.819460-1-pablo.de.lara.guarch@intel.com> In-Reply-To: <20220224155759.819460-1-pablo.de.lara.guarch@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.200.16 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3721d607-102b-410c-d931-08d9f7b9379a x-ms-traffictypediagnostic: DM8PR11MB5574:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: KBpRM6FMGOmMk6e2AqW5InZbHEt+rr+Wo4m+/Dj84EqptrlXvZOgQTm5KlAByRUlfYB8+jecd9XY5l6psYuCrtAQTivOJIkhD3nzqJD0lUL7uTiVUCETi3ihT1Mvpq1y6AwXnF27xUxMYoPMY1Kyp0+jf71583cD9sl0agmZkDk4YATkJAvgTgoXvmiJKvReZxaM4ZMB/12Ntfaze+MDr/9av+D5toNiBNB71LgyEgiZn5NEw51eYoCOnJpbcFtTpQO/JD//ecoYDlIk015rrLfmB2d11ZVC1ev8ZQexW+LY35iJatsbjjAssfiBC1YFysMC7zmvqlFpJXzR1K5bvKf6Y3kgyuTI6dNeWbeNzjBpGAuNFkMyMLzwg6IEZ4KHvVm/tzL/ab0VBFN1w+ll+h1Xm4iwq+4qafBGZgyMyvBzJkplHePKO3ug69Qej7wh7iSrrbbt3hQR7rG6QhvgJ+O1WulBLFmmGswjKNSgqkCfXnN5XagljRNqvsUIKAVOV8fKT5dAt49XitWfJd/LX3FnCZHNQrhHy8MVtq2OxKPvwF64R5MQw0CXJx78+/0L80Zjx3E5XEZcsnyvOWWAdrO1AL9tNT2SxXVqnkN3z6osUDNHs27k09DrMHYHdFLEsynUFD88ePe5rsizcJPmr1/j89cakO49lgXrj1lXgLcJxPnO9kBsAhLRLL/Foo7e3vKUJY0m001dUIGeD8iTZg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5173.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(38070700005)(54906003)(110136005)(6636002)(316002)(5660300002)(86362001)(55016003)(8936002)(4326008)(66476007)(33656002)(66556008)(66946007)(66446008)(8676002)(2906002)(52536014)(508600001)(38100700002)(450100002)(76116006)(64756008)(82960400001)(26005)(53546011)(186003)(122000001)(7696005)(71200400001)(9686003)(83380400001)(6506007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?kT7CIyHzEDwGR0jzI60Cz2oO6GPbhUdv3GeQ9WGV3SztP10ENfd96JYlfXRG?= =?us-ascii?Q?/IgIBCOy848IPjMcJrA5KI4Fnh2yn8M8L+srNdwIb/NykKPYm6/Sj6NhNl+7?= =?us-ascii?Q?4k7Myw9oFbOekJSnLipq4L8n/TW3onK9DPOAOxA/j9JGf1x5e7f4aidokp9/?= =?us-ascii?Q?iLApi8wdjJApeNHS2l9KkiKHOXh7Dr6efeNMFIjnK7OQrUp6msNjM+gSuea5?= =?us-ascii?Q?KKY95hYZBjWoLPZEckoQQBm0PwM4e/xaCFoSetEWirDPrWHV3GFUsd27BLv7?= =?us-ascii?Q?uYXI7MFrYaBPZs0hLTMPgTJf7z39Pb3106SaJ+tv9EzuY8/fpNZjOBmx/GEP?= =?us-ascii?Q?vsnYxwmJGKF/HY3J2xtJD4MwJwXOXbK5WuTYQJiorNehhdGe7a8Oq3FJ9zaZ?= =?us-ascii?Q?ehmLw1ClcBZyhGHWZnn1eSnvzNfdw4u82nh1OViYYZe5cDND2FxfNWv5of1I?= =?us-ascii?Q?o38lwOlsJ5O62ngSCJ7ARXGl41sI7jsxmHyaYxtpYtG1LrmeFI/LKCL4gL+o?= =?us-ascii?Q?F9JvwX2SYaW279HkMvFQZ9JTClp3UTwvcIVHlLzAlu6rB9Av+Ri1U/xD75fa?= =?us-ascii?Q?iB5rB1JQl9lZZR3ICR+KVe67dWBan2fqKdC6OE/gnf7LU9UJsTp7YS2dfuj+?= =?us-ascii?Q?04euh4wRr8b85KamLY2FAGfky+ISatthJfwgCY+80N6S36EQqqaqYW340PBV?= =?us-ascii?Q?QW4uoGuay8eMe8WIjZtJvmR3mMWV2HI/CeRc2UDQkhpw3fsWsIoTZTVr+7CM?= =?us-ascii?Q?PcOvlzPCQlwBG17yIOdmYCJvYxocXuMp25GnsNQs18FuxcOBFkbA+8CjYVan?= =?us-ascii?Q?cFPdLa9LD6hSS5656IOvQnC1QG1bCugpgk0K3n/xmyV6f3Ezcna0oY/lyEUT?= =?us-ascii?Q?NsOdRw3tsAhW08xZlrag+ZNjt+vezpLKjX3KjhvFqF5P2GBXsStrvmTQzgR7?= =?us-ascii?Q?xadlt39h9QzWnN1twhQwFrGDrA2zQiU19E38WMUPkxKyUOA2M28AzUgWRks5?= =?us-ascii?Q?LIpHU/I2tiLDAxjquXul9Hnzi2d1HSZ01mN2sudDuOUDA5ZMeEdrXe14HtIQ?= =?us-ascii?Q?zmEWUElc48KBKYCFjhwIy/BAyif5b8vyiOxowrKcCUhU/dPtqs1/aNPDK1X2?= =?us-ascii?Q?/oSw2+Ih38zMIR4oDhCVKbPbUZrEqVSz7l8ZTYFtf5CSe2ZaWJ692l/CO6at?= =?us-ascii?Q?mpKV73CQ5RdoWcMiMvPfF9TZgMW5cAaXPvRtqVljXfYy2fVs5nhxGKuA/OFi?= =?us-ascii?Q?srvUP/rh+p/zk2wFBU7N/T7vnVMF/fFTUQISgFvu2jmEIiwChDrTg5Hns03y?= =?us-ascii?Q?SRa/FR6zemLcDnIfyWWeijXSKUTaxg2ADJ6cPL3eHuIHrcL9Ha9yheAgKZCx?= =?us-ascii?Q?pPFkwd1WeQC9UU7JDMfN/p7+30lspn+ioVBE4nG93zliDwbisi/BHX6Izb1e?= =?us-ascii?Q?4Z/sB/QOkaKxglQKYuu3+siDTQiFLrAo2ggI8reRoupPN36yja7HpeImq5At?= =?us-ascii?Q?IKBhybDlCaYCuK5b3GEaxSjlW2fVAL9zQuXk7qjulNFlluWTDZVxRLYpn0uk?= =?us-ascii?Q?dUOn5buXQQ1EaD8Ix8wVNiWq8dcTgj62W6zSNbEjSE8c3gq5utlU1W0EeL8I?= =?us-ascii?Q?4g=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5173.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3721d607-102b-410c-d931-08d9f7b9379a X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Feb 2022 17:15:12.3072 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: S5VVfSNKjL9QmLgpfjz9spgNsnogu3shqLDThg3vaOUkf7cRXcGTK+QCdCvg07Q/bnpPjYh6gwKHydeF0SOQFQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR11MB5574 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: De Lara Guarch, Pablo > Sent: Thursday, February 24, 2022 7:58 AM > To: Wang, Yipeng1 ; Marohn, Byron > > Cc: dev@dpdk.org; De Lara Guarch, Pablo ; > stable@dpdk.org > Subject: [PATCH v2 1/2] test/efd: fix size of constant >=20 > Constant value 1 has a size of 32 bits, and shifting it more than 32 bits= to the > left overflows. 1ULL is needed to be able to get a 64-bit value. >=20 > Coverity ID: 375846 > Fixes: 8751a7e9832b ("efd: allow more CPU sockets in table creation") > Cc: pablo.de.lara.guarch@intel.com > Cc: stable@dpdk.org >=20 > Signed-off-by: Pablo de Lara > --- > app/test/test_efd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/app/test/test_efd.c b/app/test/test_efd.c index > 7bea674086..fa29e8f97a 100644 > --- a/app/test/test_efd.c > +++ b/app/test/test_efd.c > @@ -107,7 +107,7 @@ static inline uint64_t > efd_get_all_sockets_bitmask(void) > unsigned int next_lcore =3D rte_get_main_lcore(); > const int val_true =3D 1, val_false =3D 0; > for (i =3D 0; i < rte_lcore_count(); i++) { > - all_cpu_sockets_bitmask |=3D 1 << > rte_lcore_to_socket_id(next_lcore); > + all_cpu_sockets_bitmask |=3D 1ULL << > +rte_lcore_to_socket_id(next_lcore); > next_lcore =3D rte_get_next_lcore(next_lcore, val_false, > val_true); > } >=20 > -- > 2.25.1 Acked-by: Yipeng Wang