From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EE737A0C55; Wed, 13 Oct 2021 15:16:59 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 610D641162; Wed, 13 Oct 2021 15:15:51 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 9B80D4115A for ; Wed, 13 Oct 2021 15:15:49 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10135"; a="290912684" X-IronPort-AV: E=Sophos;i="5.85,371,1624345200"; d="scan'208";a="290912684" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2021 06:15:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,371,1624345200"; d="scan'208";a="524622781" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by orsmga001.jf.intel.com with ESMTP; 13 Oct 2021 06:15:47 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 13 Oct 2021 06:15:46 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 13 Oct 2021 06:15:46 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.41) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 13 Oct 2021 06:15:46 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CIgTR2PUgWt+OrPTuJU4iMwc3sQJLTlWEEuZeRVoRFfeinXW9/J6zVvboX3m6cmjhckws+6/rN2zetC0F0Tg5y12NJaIxq452GsvPseMia+WbiM9BdOz0bmDYgSMNcswj/ZMqNq+dFKNqQkxTVLlLtuwFF6G1E2jVLdjrZiuuOBMuc70qupMnlmANX7VjpmtIkVudszDjciQh9wg+75r5107fFLu7byCxjEwx9R3tzzByeHhQHBpibyMjq5c+JHuHw/orraDeXgvqLOY5nC7Zw/dgGe+bYNiWRt9SG0COjqRqyyijlCaNYL//a2xR7eCPql0sLi2sWOXQnnUeDN1Ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dHcu688IuarplXuzxWZPJQNThK0rVXM4KG3rs9cPa9U=; b=g0KaAmTXBCQtOqjh4zQ02gBernfCB2ziZElhhq9AvZZCaKfaILD8uBB9adZt69YmbYmazbwpteyYh7C/q33fDS8ddoyu2/+MRBzfq/GxmFu8/ptkgoWLWxVkvQGAKknPZkm3WUXIZ1Q/c97FcA4lS4oDKtgwEj40avPV0kivlYhRDrg1C1aNkpFqCSHOJUSjexmiAlSvOMOzecNuJux51JcQXNS0Xk/v8VCyGZcAB0tmfFz1eClgiErG4yAorqUFOs95HoBtqgA1CP2Cgue0+eYvBbkcsjP9EvQ5AE79n7inrDgesf7JLFN8lP77LiJo7I6o/vxV9xKTi1rC+xNy/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dHcu688IuarplXuzxWZPJQNThK0rVXM4KG3rs9cPa9U=; b=JbNBBjjmprZcxSP6d4OH84NdTZ2oOS1+CsgvuvKzhB0bhFM2ncbWgGe++BV1t996VyNip3+MM3b2wMzIHGgbBJWxTYVM5m5Ih96mDxDZOGVl1XU/3WDsDSfOtYiNqEq4JRRdVqVmJXTSXwy13PmpWwDzCr4IvC+ae+CxgKf16vI= Received: from PH0PR11MB5207.namprd11.prod.outlook.com (2603:10b6:510:32::15) by PH0PR11MB4968.namprd11.prod.outlook.com (2603:10b6:510:39::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Wed, 13 Oct 2021 13:15:39 +0000 Received: from PH0PR11MB5207.namprd11.prod.outlook.com ([fe80::f076:f51c:9101:b0ff]) by PH0PR11MB5207.namprd11.prod.outlook.com ([fe80::f076:f51c:9101:b0ff%8]) with mapi id 15.20.4608.016; Wed, 13 Oct 2021 13:15:39 +0000 From: "Walsh, Conor" To: "Richardson, Bruce" , "dev@dpdk.org" CC: "Power, Ciara" , David Marchand , "Burakov, Anatoly" , Kevin Traynor , "Richardson, Bruce" Thread-Topic: [dpdk-dev] [PATCH v8 4/4] usertools/dpdk-telemetry: provide info on available sockets Thread-Index: AQHXv4fkca5Gjlltw0C8v2kkMI9u46vQ6IOw Date: Wed, 13 Oct 2021 13:15:39 +0000 Message-ID: References: <20210915141030.23514-1-bruce.richardson@intel.com> <20211012163908.758767-1-bruce.richardson@intel.com> <20211012163908.758767-5-bruce.richardson@intel.com> In-Reply-To: <20211012163908.758767-5-bruce.richardson@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b6583f9c-48bb-477e-d5df-08d98e4b8d61 x-ms-traffictypediagnostic: PH0PR11MB4968: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2201; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: K1t+j20hLmQUlwEstV1/4Vq6QXGe1/rieRmYrQW8njcbPZLEg4GoFUr6y+XNv5mgTbL2rBwRB/sjjXWgvxbbFC2iCXkxKt246YtyFotEI8XkVQB2kBd1104AmBFqqX7xb0GYEA4l76oB1cX86/41PoUBAFWq0mXmwIIEe5ypSoQS38WMLJQgo0d2yaaZ7Egz/bOHXuZiMSxcbbLWvwjd8uQn9jNy7m7Og9F4nOz4jW3vYpilcQgNdqVZADsDggfVeN11o5hHdZmVVfnF8VjJ3a9DZTsV+wHnw3HR6q83CfKjVsDN07qnBeaqO95zsiD0EBT8HFpFMfGkQf/IHSrVE1+OyTDzsDgs6992hwQVwl6j9/SfoxAil8MHQEuwmHqobQ7nreM5Tu0UU0vxGD1bvs4okIsA9qkjc+nZrDX01rmp0ws7FEcNpM3+mst/Zao+7qV2PulQ39mW7ZBi0ZDIucd9mirylhhU2j7z8DLTg6gWfvv1FspUWTKSL7SXg3A3JCEIJwMuHdfM65UICQ6OVmz+vu3MrRSievfK0JxJgqBNjTnlz00TT1ZoOWia+GP6QKjSv+ui6emaYpuQ0tZmGX+hZ6vOboF2eAUm6DO2yXWry+SuFTTpFMfDS+zsd0v0iIefpdewgvCnwbusnP/iiUWWftsl/ymdGz33qJBpEBaSMnxUhYftBsUOLZ1X6Xfitc6HE1RILbyVb5V2k/8y9g== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5207.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(8676002)(2906002)(54906003)(5660300002)(66446008)(186003)(66476007)(64756008)(66556008)(86362001)(7696005)(38070700005)(4326008)(6506007)(53546011)(110136005)(83380400001)(107886003)(52536014)(316002)(508600001)(76116006)(122000001)(33656002)(82960400001)(66946007)(26005)(71200400001)(9686003)(8936002)(38100700002)(55016002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?P6oLEFwtk4J1+QjjcSU44Eetp1KgyOANvfF5kDl9KU5s26PxVEH7BRNjPOp5?= =?us-ascii?Q?PYMBE0qUK5EZkT9AuXA11wYcWkwUQHhYB+R1EkbRt8juI/bmTGmvo0AblQX+?= =?us-ascii?Q?b0BLAjMmxoTY6XqXY+EhN4fXQIcNZTNlqtw6tN+dFsO/RycPb5EyhvliW2qP?= =?us-ascii?Q?Vh/dZDcA0sVVfUw7bVhUfjDX4+ZqDhhBSIdTiEOynmP6aw4a1QhGutKm8voX?= =?us-ascii?Q?zvqDdE1c4/d12QBlIebGyeDJH0mO26RieCunlCeIOBwjiSV2QOxo0THretT4?= =?us-ascii?Q?jz7QeI3gNcD/7tk6h3mXASZ4m1p5sxUjjRyFlSPrQ0WHo7EulLPBYTblR2mI?= =?us-ascii?Q?l9sf5gpjynPbB92wM/DcoZFc/e9iMKvt0z4Me49NfKhF+ukZcEi3evsIVMEA?= =?us-ascii?Q?ruGilwnkH18IExPM/QK0pTdZVuB9Dhc0A/HHKWT7aQtYvwgSDbZuCgh+xasQ?= =?us-ascii?Q?hR+rpGe7oPAYz56CWrChqKVRURnDQeC42WSHIdFfDodfOCB5Y3VuFzYqhZHO?= =?us-ascii?Q?QHl6AejIWraI9pTBcqj9UUyFOeEu6pv4AQzTtLP2hGh/F6/6kCLnPkKaLRU+?= =?us-ascii?Q?R8cZbLfXu+uE6eus2swQnDGAVaJd0avQpifCkO2YdVO54l3VCVMai3/iMHGH?= =?us-ascii?Q?Wd7dWFXX5zqlGcqtOY0OR/Zi3edSN/iDqbc47W6A7d7w8U02ehfqW6nYJTag?= =?us-ascii?Q?NZkP3+qFr0zYr6KAScXNS3XsOWruAezIOHnFz25ci9kYc55QhugAVRFwDdA6?= =?us-ascii?Q?3j9bl6NraipHTckv+PtUQJJssQ0yVtI2WU5DOcRHGyPJY0BsOO5koI4xXR+x?= =?us-ascii?Q?gSaHpCpsImTUYsdXlql0sY0zWiUItsZ69hpQAo2Q9cWtTBZFm8HhwCH1KnW7?= =?us-ascii?Q?vhCgmMpIiaG9j1LbVz3V2DnuJbTZgalaUVeW2O+/RThf048m5mwdB5RlkjXW?= =?us-ascii?Q?8NSpt6+6rI61E8IJFDQfq587n5g+eNQHCX1YiRFIPqYrZb9UgSnbMSKtUB4i?= =?us-ascii?Q?WwIHKM29XvtACmilz9qo/XvcfI05+3rryKhJ3agCAmrQ1NHseu1vst785HvV?= =?us-ascii?Q?IHWx+XArTUu8EDyfNrpEZ+6XixK+MJRCvV2F3aCL0D5NjzpValdeDWSr01tP?= =?us-ascii?Q?uWZdgnrNqIxsX3d19QJcKTplq9B9T9VKRBiEIHv71R0ZKuJV8n++yaHHfzid?= =?us-ascii?Q?wgiZR1BjGqOig3qsddcvJuIxCQyjNROdwu9N8+u3oNqYGhSdofuybMyEetQY?= =?us-ascii?Q?uSbkheCE8e+22qDxseEyCKa2gHAmcJn0kqiy+NCLdlU3g723OZv8suLB1hXJ?= =?us-ascii?Q?R6o=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5207.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b6583f9c-48bb-477e-d5df-08d98e4b8d61 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Oct 2021 13:15:39.4151 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: D0UXhnGiAIkBXcqx17vz2lG7zoDj/flMyXo3BghVheQXmsOsFUd1vdWmkgsEMXSAtZ7JpFs4zTzHHj3ALJfTAQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4968 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v8 4/4] usertools/dpdk-telemetry: provide info on available sockets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > From: dev On Behalf Of Bruce Richardson > Sent: Tuesday 12 October 2021 17:39 > To: dev@dpdk.org > Cc: Power, Ciara ; David Marchand > ; Burakov, Anatoly > ; Kevin Traynor ; > Richardson, Bruce > Subject: [dpdk-dev] [PATCH v8 4/4] usertools/dpdk-telemetry: provide info > on available sockets >=20 > When a user runs the dpdk-telemetry script and fails to connect because > the socket path does not exist, run a scan for possible sockets that > could be connected to and inform the user of the command needed to > connect to those. >=20 > For example: >=20 > $ ./dpdk-telemetry.py -i4 > Connecting to /run/user/1000/dpdk/rte/dpdk_telemetry.v2:4 > Error connecting to /run/user/1000/dpdk/rte/dpdk_telemetry.v2:4 >=20 > Other DPDK telemetry sockets found: > - dpdk_telemetry.v2 # Connect with './dpdk-telemetry.py' > - dpdk_telemetry.v2:2 # Connect with './dpdk-telemetry.py -i 2' > - dpdk_telemetry.v2:1 # Connect with './dpdk-telemetry.py -i 1' >=20 > Signed-off-by: Bruce Richardson > Acked-by: Ciara Power > --- > +def print_socket_options(prefix, paths): > + """ Given a set of socket paths, give the commands needed to connect > """ > + cmd =3D sys.argv[0] > + if prefix !=3D DEFAULT_PREFIX: > + cmd +=3D " -f " + prefix > + for s in paths: When I tested this the sockets were in the wrong order e.g. 2, 1, 0. If the above paths variable was wrapped with sorted() it would ensure the l= ist was always in the correct order. With or without this change: Reviewed-by: Conor Walsh > + sock_name =3D os.path.basename(s) > + if sock_name.endswith(TELEMETRY_VERSION): > + print("- {} # Connect with '{}'".format(os.path.basename(s)= , > + cmd)) > + else: > + print("- {} # Connect with '{} -i {}'".format(os.path.basen= ame(s), > + cmd, > + s.split(':')[= -1]))