From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4FA4F41C2D; Tue, 7 Feb 2023 11:47:41 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3B8D2410DF; Tue, 7 Feb 2023 11:47:41 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 7114640EF0 for ; Tue, 7 Feb 2023 11:47:39 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675766859; x=1707302859; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=ZlEg7sRMKyFIwUBGp1NhUQwEMsBnNK282zpF+LJa8Mk=; b=jaHG5j7qzeILkvxCbwa4my9PP5B7k99NSxAFZZs0dfjRSBAZwr6y5QTu P+jfO/LWFqZlwtqEdJrr2Ky6YvnG7MJpUPWDrth0yUZzejFFTt0ird+x3 /Lx/9JQn9W0jGGY5Fy+KO9bcSb/p/lhxJDgDI1YbT3NKn50eFh0Y6t6rV D45D9rW6L0fykm0ka9HqD2q/zrAnpt99nDwuFeQyWUqZMNmadfCX0luKW 7wCROfUzsaGDptLpEgi0td6R9W+EiW6SaApzjZJ+yf5xgwZwiM4cT8Xm8 dYRVwlx8+xdsryCG3m9jx3Ym3nUDB9RfMNK1dNeY5/bRUknYqVvHOZs5v A==; X-IronPort-AV: E=McAfee;i="6500,9779,10613"; a="331608907" X-IronPort-AV: E=Sophos;i="5.97,278,1669104000"; d="scan'208";a="331608907" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Feb 2023 02:47:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10613"; a="735506101" X-IronPort-AV: E=Sophos;i="5.97,278,1669104000"; d="scan'208";a="735506101" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga004.fm.intel.com with ESMTP; 07 Feb 2023 02:47:38 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 7 Feb 2023 02:47:37 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 7 Feb 2023 02:47:37 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Tue, 7 Feb 2023 02:47:37 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.173) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Tue, 7 Feb 2023 02:47:37 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=foScGI4Z1WYV0DBHwwaWIT19OFF0KpGeIhSUyfkdUUJYjxeCtwXwC1WUwffi38UcCG0zPhoRHeN9aur49IF9dE692CLi2+Wova9gLv5Oj9/aKFR+tSkja02FdEk3pbi0tXWyKiAFgzO91wzg10rPm767vK5KjhQvKg+n/zUGsf0H+NX4cXZfBrRiEzvaPfuMT0jABaWTSDlJqgorBPjk89ARI9ulP+BGZi4byU5Yv9RHCNOzcZUA8FF4cFhaQLS3/ET7Md46ZoNp2sxeP88OA8IFaXsXOuxW875gFKGciooQvpCvBd9gvATj+nHxKIHTTpTCDT1oFtwiRgyb4wpiTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/NPxEF1XVEBhztG4u0WeQNlx54VJQgxGb+7qcNYjjqw=; b=A8VQPIB93WsLNtq2YcR9v09Rb63jSL8cg2pufW5wc0QzAr4H93k7PG0d7l+0i9EHvTU900GFSD0Umr7LOgvAG3k6xblYszGofq1g3+JWNEki74qRp3eWu4NH4pRu5G348IazMZ513WgvEh9tssaEUvHaxT8Uo3gA47bZzAyMOZlCEPETs/dQNObgvZ0ZNp+STGXe54qv033/GcXYFLhl81RLDrxv328J/wC/mqDsyiAp6wLAuqMo2Do5ctgzd6VdG4EO3mYcgBzoPhnMhU72WeyJwNxe287PoxZGhw0rZoas25JMiC7PsiS5zhANnYoPvkg99Otu7ChsAykji0mVjQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5207.namprd11.prod.outlook.com (2603:10b6:510:32::15) by BN0PR11MB5710.namprd11.prod.outlook.com (2603:10b6:408:14a::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.36; Tue, 7 Feb 2023 10:47:35 +0000 Received: from PH0PR11MB5207.namprd11.prod.outlook.com ([fe80::d1db:30fc:2964:8059]) by PH0PR11MB5207.namprd11.prod.outlook.com ([fe80::d1db:30fc:2964:8059%8]) with mapi id 15.20.6064.036; Tue, 7 Feb 2023 10:47:35 +0000 From: "Walsh, Conor" To: "Richardson, Bruce" CC: "thomas@monjalon.net" , "dev@dpdk.org" Subject: RE: [PATCH] dma/ioat: remove printf within ioat driver Thread-Topic: [PATCH] dma/ioat: remove printf within ioat driver Thread-Index: AQHZN+2IKFjpwOILaEyKYk+pPA0xkK69dCeAgAXe62A= Date: Tue, 7 Feb 2023 10:47:35 +0000 Message-ID: References: <20230203163514.621178-1-conor.walsh@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB5207:EE_|BN0PR11MB5710:EE_ x-ms-office365-filtering-correlation-id: 1a6e30c3-f1e3-4f65-4a36-08db08f8b91d x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: s29kawL2zqF4+p8XB7S0Kc8R2f52wYPnl0Cqa68mgwAv5BEAp6biEsnY8Z4RukOUYyzIHS1oVcvu8co7fhZsZ2nCI8ATqAvwt0eQjqCWqRd6ObeQWqHm9BM5gCjVGeYG+YrlpkxYGDr8VpuGy72ZOgZ+MpPFtzIfE8HMzaY9JamDrVntGLlseF2EUKJVT4/ILYgEQxtrmfK9L2aUVePbRa0x0w+MIbKeuWtK8L8KpsI6ook70754ovdxpnAWaXSabouFdqwJBxT08ZC+6A2tyCbOitJOC5scf6r4m6vaKGv428N6EmrZWqtWyuTuXGLskvBe5kZsp/gvVr/znBuxdZpoy94NgyoaNAXtpc3U1f+UeG4CwntKNmEsjZ1k7vooULnre5v+WVdYDLCK/j4fOcQhlrkBwqoepRXmHpJfEq/XxpkCq9VnHuUxZE2tkF/Rp1G7srVNST0dGjiZT9hrPGz+luyc8pDUu4mEBFO386cgNZK3e+TQEvPvzgBOUVrH3Olmq8vKQkGSrE5HrV2CLbhzLj3gO3+frWcmWrHPj3blld9s5AJ6+8i5fQPub2MH3rYVnTgHSxHbVSF9l61WkcHZ6Njup2g/fSvQ4lSuXpHLGmbrVh38kaPzEdUbqBnoweCyiZrC4HpeDhVQHjU1Vm/0C7H0Cf/r9OcZDnr39f/x+Saiej6dnN593Maj9RENauK69t39RGKcZXybY1RUgw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5207.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(376002)(346002)(366004)(39860400002)(396003)(136003)(451199018)(33656002)(54906003)(6636002)(186003)(86362001)(7696005)(71200400001)(55016003)(2906002)(76116006)(66946007)(5660300002)(66476007)(66446008)(64756008)(8936002)(6862004)(8676002)(4326008)(66556008)(41300700001)(26005)(478600001)(9686003)(6506007)(38100700002)(82960400001)(83380400001)(316002)(52536014)(122000001)(38070700005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?YIcr3rIULV7CwN0+sgjQHpg60j7Szgg677zJHXSEv7Zqqj5m/dfi+63fJgpB?= =?us-ascii?Q?J2Tfc7RtmamhztLv67rGo9m7Dk9d9GgPxsXk2A6jIGwleWEfXGAel360y+ct?= =?us-ascii?Q?L1sTUF4NldkgVW/zb82AJETQdVUXCVqe/62POVFAx8849URpswPDfKFAzVW/?= =?us-ascii?Q?BcxrpYmiAoTn/6ycIpM8JlXJhXNGvjQbszYQb3J9OQkBKtfswCAkeq9kSP5i?= =?us-ascii?Q?tkgNkI++SKb4LM1uS8i9hbaGEaKTMv3pDDiaYacghIuBAmH7OceagKUkeCn1?= =?us-ascii?Q?OChZFNgh192z/NWm5vjWym3B3RPzb5lCoa4n1aFwQcksJyrSqKhKAX5hLNyi?= =?us-ascii?Q?AhrKyP7gq0vOXNEFwBsIGoiVgjkvFRlubAqJGCPoX8B1CcYoSPxCBh/lsGHO?= =?us-ascii?Q?n0xiMCZYjN76y2RKCvyGYb78cZRMeEejPWuH9B5aKAEZnMJ4FlkTWzXXtiwG?= =?us-ascii?Q?Y63AMo73PWtcEkyBURBu8vxH4/BUr8OnCYpoepF5BS+1eLWlG41Zw/UPRya7?= =?us-ascii?Q?2MIaLP7hTG0TzQrcPv2bi4oaO0aS6DNPTX9to/bTpCgrEY6tNa70pjQK0Ypd?= =?us-ascii?Q?KdoYD2sh9c5Xk6dSVEJotm2/rWook4czsqb+ZOiUDYwD7gDXud2kWRyFRD8U?= =?us-ascii?Q?OcvZS8/SDS+abFNsM51JwIAMgN7F4Euj7Zo1Mq6L4pMgNwZnAhiatS3ma5PI?= =?us-ascii?Q?EOgz33EdZJfqzyKpNGDz00kSeK+oGidcbyyUX1hzRKMhNEjkdWG+vy2irwqJ?= =?us-ascii?Q?VirvsLJAycnS17TYma7GSvcYOM7V3V9VFVMmgITSsZHo1BGS9i4ND2FHomeP?= =?us-ascii?Q?lIVWyFUsJLHvHLP1XDHGIxtRp65pc3UnzBg0xiYTPJIpcbQx2w1b2gxpgH56?= =?us-ascii?Q?lT3FvIsbYn1YRvVBlqXcSS7gnkFBCCPjlJFQzdyEQtR4XKk4hsesVvNWkUSZ?= =?us-ascii?Q?ZlG+YchPLnUhnSr3x31ef50CHPVlufIEGuX9FmhmRua21WnZJIdkAQJo4IY+?= =?us-ascii?Q?HY0QoJR7cpm0Kqqthmt8N2aOxuBijJAAetjrtGtQhLW4FDMuB9tFKs7xkcLT?= =?us-ascii?Q?1SW9JmTUulQEHbZpEg2BRoJmHd0v0zVKFwqj18h+7CWbaczTZXuaaei+HOTk?= =?us-ascii?Q?oGd3fIt3HpDYLVPAqCpj2sFnnHoTksT5HEOhNy2WQS17fNFy9lTihdAzqr76?= =?us-ascii?Q?WArC/JYjm/2KRJOEnZARDefEFELNLC5Pf1UTZGh3u7fT2wKq0jIZLS62zNsD?= =?us-ascii?Q?WPG0F0Q3J6/r4OgJhJg9j+XwpGr95J7DtOydAvFqFliY5ogEXxMloIxyTiZO?= =?us-ascii?Q?qPiwACXWVIA2QN0x7cvOMMDeNgLU5JLG07qYEL0SxA5jKHzXoIVpVxGznDgZ?= =?us-ascii?Q?k0KFnKHoBAjTtPcRqX++E61E1B/Jz4Zk374amvFYuIppg3Vbi+tXkN503e8W?= =?us-ascii?Q?vw7OCZ6nutQYJ/5VD1feLKLwJ3dlBRnH/gypFm9R5JU9TQi7BuGo4bpiAVK3?= =?us-ascii?Q?jR1ONzsXjaKDsF8qq6C7pcoOAMWb/XMrbgboMPlxW0pnk81NULg84rePt2vW?= =?us-ascii?Q?dD42UE3zd9rO7VCiAqho2yT7yiSD50etBlJMJT+0?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5207.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1a6e30c3-f1e3-4f65-4a36-08db08f8b91d X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Feb 2023 10:47:35.3048 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: h+53b+fX99iFOLOp7s4RK401CzPWUbSyAFrV7NyT3HmF2KeMFSpYs8lIuxnhDwB9zvxdN2gKVzaW00RWwj4+OA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR11MB5710 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > On Fri, Feb 03, 2023 at 04:35:14PM +0000, Conor Walsh wrote: > > rte_log should be used instead of printf within the drivers this patch > > changes a printf within the ioat dma driver's start function to an rte = log. > > The printfs within ioat's dump function will be retained. > > > > Signed-off-by: Conor Walsh > > --- >=20 > One little nit below, but with that fixed >=20 > Acked-by: Bruce Richardson Thanks for the ack! >=20 > > drivers/dma/ioat/ioat_dmadev.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/dma/ioat/ioat_dmadev.c > b/drivers/dma/ioat/ioat_dmadev.c > > index 5906eb45aa..3fe50ea4a4 100644 > > --- a/drivers/dma/ioat/ioat_dmadev.c > > +++ b/drivers/dma/ioat/ioat_dmadev.c > > @@ -146,9 +146,9 @@ ioat_dev_start(struct rte_dma_dev *dev) > > /* Prime the status register to be set to the last element. */ > > ioat->status =3D ioat->ring_addr + ((ioat->qcfg.nb_desc - 1) * > DESC_SZ); > > > > - printf("IOAT.status: %s [0x%"PRIx64"]\n", > > - chansts_readable[ioat->status & > IOAT_CHANSTS_STATUS], > > - ioat->status); > > + IOAT_PMD_DEBUG("channel status - %s [0x%"PRIx64"]\n", > > + chansts_readable[ioat->status & > IOAT_CHANSTS_STATUS], > > + ioat->status); > > >=20 > This whitespace change should not be needed, and we use only tabs for > indent, not spaces. This should be a one-line change. I will send a v2 with only a single line change. Thanks, Conor. >=20 > > if ((ioat->regs->chansts & IOAT_CHANSTS_STATUS) =3D=3D > IOAT_CHANSTS_HALTED) { > > IOAT_PMD_WARN("Device HALTED on start, attempting to > recover\n"); > > -- > > 2.25.1 > >