DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Walsh, Conor" <conor.walsh@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>,
	"Chautru, Nicolas" <nicolas.chautru@intel.com>,
	Hemant Agrawal <hemant.agrawal@nxp.com>,
	"Sachin Saxena" <sachin.saxena@oss.nxp.com>,
	Gagandeep Singh <g.singh@nxp.com>,
	"Sunil Uttarwar" <sunilprakashrao.uttarwar@amd.com>,
	"Richardson, Bruce" <bruce.richardson@intel.com>,
	Chaoyong He <chaoyong.he@corigine.com>,
	"Niklas Soderlund" <niklas.soderlund@corigine.com>,
	Rasesh Mody <rmody@marvell.com>,
	Devendra Singh Rawat <dsinghrawat@marvell.com>,
	Jiawen Wu <jiawenwu@trustnetic.com>,
	Jian Wang <jianwang@trustnetic.com>,
	"Xu, Rosen" <rosen.xu@intel.com>,
	"Zhang, Tianfei" <tianfei.zhang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	Ferruh Yigit <ferruh.yigit@amd.com>,
	"Andrew Rybchenko" <andrew.rybchenko@oktetlabs.ru>,
	"david.marchand@redhat.com" <david.marchand@redhat.com>
Subject: RE: no printf in drivers code
Date: Fri, 3 Feb 2023 16:38:19 +0000	[thread overview]
Message-ID: <PH0PR11MB52070A66AC241DD8D3989364FFD79@PH0PR11MB5207.namprd11.prod.outlook.com> (raw)
In-Reply-To: <3217725.44csPzL39Z@thomas>

> Hello,
> 
> We have too many drivers using printf() instead of rte_log().
> Please propose a plan to replace or remove the calls to printf().
> If no plan, I could propose one but you may not like it :)
> 
> Affected drivers are:
> 	baseband/acc
> 	bus/dpaa
> 	bus/fslmc
> 	crypto/caam_jr
> 	crypto/ccp
> 	dma/ioat
> 	net/dpaa
> 	net/dpaa2
> 	net/nfp
> 	net/qede
> 	net/txgbe
> 	raw/ifpga
> 
> PS: printf is allowed for tests and dumps.

Hi Thomas,

I sent a patch to the mailing list to swap the printf in the IOAT driver to rte log.
I didn't change the fptintf's within the dump function as advised above.

Thanks,
Conor.

  parent reply	other threads:[~2023-02-03 16:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-03 13:57 Thomas Monjalon
2023-02-03 16:18 ` Honnappa Nagarahalli
2023-02-03 16:40   ` Thomas Monjalon
2023-02-03 18:35     ` David Marchand
2023-02-04  4:38       ` Honnappa Nagarahalli
2023-02-03 16:38 ` Walsh, Conor [this message]
2023-02-04  0:46 ` Chautru, Nicolas
2023-02-06 14:16 ` Niklas Soderlund
2023-02-08 12:32   ` Hemant Agrawal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=PH0PR11MB52070A66AC241DD8D3989364FFD79@PH0PR11MB5207.namprd11.prod.outlook.com \
    --to=conor.walsh@intel.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=bruce.richardson@intel.com \
    --cc=chaoyong.he@corigine.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=dsinghrawat@marvell.com \
    --cc=ferruh.yigit@amd.com \
    --cc=g.singh@nxp.com \
    --cc=hemant.agrawal@nxp.com \
    --cc=jianwang@trustnetic.com \
    --cc=jiawenwu@trustnetic.com \
    --cc=nicolas.chautru@intel.com \
    --cc=niklas.soderlund@corigine.com \
    --cc=rmody@marvell.com \
    --cc=rosen.xu@intel.com \
    --cc=sachin.saxena@oss.nxp.com \
    --cc=sunilprakashrao.uttarwar@amd.com \
    --cc=thomas@monjalon.net \
    --cc=tianfei.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).