From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 77111423F1; Mon, 16 Jan 2023 17:09:32 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 574DA40691; Mon, 16 Jan 2023 17:09:32 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 86C8540F16 for ; Mon, 16 Jan 2023 17:09:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673885370; x=1705421370; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=jrvs230hlynmbxFYM94BEmIXHV3gTpl2TKdKtWXh6RU=; b=aoTmkxyAYrHXpMAc2KMx11mV4sdqBMBXTMhyeji+wolN/8J7sjUVZJfE Q2kzBQ2C2QkAUpuMGT8OXjLHsukeDo9b/rZXI7a58AoO59ELN6wbQWcS9 G02IrT9/aRHd4cOS2pH2NSLjMWj4nVUaywivMYDpRcNuNyOmUhK7tFlXF lX9k6ALiQltESwvYUQvOWGVJUFh91DbLxNZlZx1VXsc63UIFnMdReAavH 51LHrzpEzUn6wPNlZPmyWsYsqFT6oCPWu7nEn4UdHAtKDafLitbFRUctI ny69KZ+d5fQi8wfEkqXZe/Qzj8nHCQ30ywe+mFjVIv2HiWQG4LE7+ZrQH Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10592"; a="312345333" X-IronPort-AV: E=Sophos;i="5.97,221,1669104000"; d="scan'208";a="312345333" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jan 2023 08:09:22 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10592"; a="636584119" X-IronPort-AV: E=Sophos;i="5.97,221,1669104000"; d="scan'208";a="636584119" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga006.jf.intel.com with ESMTP; 16 Jan 2023 08:09:21 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 16 Jan 2023 08:09:21 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 16 Jan 2023 08:09:21 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Mon, 16 Jan 2023 08:09:21 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.104) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Mon, 16 Jan 2023 08:09:21 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cc4XyybBllLjuRcgUjQCPUXsMsFislCwh8FxwP702FvGxa5VWZqFYDHCuTiydVprtQshfm8zSivolJchwfHcYpzJYvdGaxFKHLVdm9J7ovDXaiqWfqGySUAOMrPwW2c3rjboAksk8EnPukl0OYIU2LZ7pPEX+pyDSt8vYKLsRBKLuI6x0InSZS90WWmOmo/edrYkm8S6bwTXzsqPhWcLGF3N/UBP93GryIbKCKv8h9wDoW3r2XFFng43FZC/MUcqMhewtwTr+jWkTqv7AKBshBHr0uHvV6GFp7PyeyMFAdKRDDyi4S4h20QkkZrpQPZKnhKuirX4f1/fgD4DNgrYVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Wg+Yvo+r1BwKq+eqOaLSCkkpcDzvjbMM460MFURwbvw=; b=SkAHATGbtdwAAOPBf71P/GT0ZoI5DvHtASuXBCoejtH0asviBWT20FF/mzBFfnBTZ7rJYeNUep2nSNgOKTcn346z4ryKPyycj2VEc+mbmWklaBZqNqQERQL4LfynKKq9dWa4juM9sdzw+oIHiwtHAxVg2WaZy9G/1ncbOE6xtXnSrHv3R1uKcpkZaMTs0PH5cu01qu7i/iVNXU/XGzDfLw8KBTDplufYyp1jFQi5Z9KNg0JPH7ZoCDy5j2bjLrE3253J/UfFXUu4+eSuplIkKIMBhKgKrbrEWnJQx+BkeZMbwpQxJAIs+RxEB3TFVJrTANlD15R3vEzwQv4Ino7iyg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5207.namprd11.prod.outlook.com (2603:10b6:510:32::15) by BN9PR11MB5452.namprd11.prod.outlook.com (2603:10b6:408:101::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.23; Mon, 16 Jan 2023 16:09:19 +0000 Received: from PH0PR11MB5207.namprd11.prod.outlook.com ([fe80::d1db:30fc:2964:8059]) by PH0PR11MB5207.namprd11.prod.outlook.com ([fe80::d1db:30fc:2964:8059%9]) with mapi id 15.20.5986.023; Mon, 16 Jan 2023 16:09:19 +0000 From: "Walsh, Conor" To: "Richardson, Bruce" CC: "dev@dpdk.org" , "Laatz, Kevin" Subject: RE: [PATCH 0/5] dma/ioat: fix issues with stopping and restarting device Thread-Topic: [PATCH 0/5] dma/ioat: fix issues with stopping and restarting device Thread-Index: AQHZKcCHxoOwbyFboUyULXqQ2j94na6hNU0A Date: Mon, 16 Jan 2023 16:09:19 +0000 Message-ID: References: <20230116153714.554470-1-bruce.richardson@intel.com> In-Reply-To: <20230116153714.554470-1-bruce.richardson@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB5207:EE_|BN9PR11MB5452:EE_ x-ms-office365-filtering-correlation-id: 74f35575-b55b-4339-da81-08daf7dc05f0 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ufRFMsvUzlM9AM0RUkrVNt0YEKBWlAihJYdx5bFW5/MsdCt5WfDKW50Z3gmTyV97FHStCKPvWStLA2p4FPOHD5BaFeEyCegstxX9Eg/gK9CIMxC/2MtnxhOcNwS8N/DbwbvOoEc4g1Zunnkz71XELlTCex/rbf0JiM1cF0dbvzMX3YlxjHviceqTQFfE21DFG67FM8YvoKvrKnbkKk52iGdRPt504tdjAaty6apa1A+AMN7FQcux0ZkcCeSKpUNxxj0XzDIzZmklRMifxxtfj0JtwHx7dGREiWvKft1BikQ+ug3HdS+VbGyeyMtAaDRuoTTg/hsuPiMWC0k68zbxygrvpFhifmlxF+4ZiRUQjkYfoBHxS1GF3UihNyuloJBidT1fXr0y1BuC8PR80A5YZArZ+lteoV1hZ2tkkSIggpsCghS5XIBX/b4Qy5Ezh4oxX0x37AzhNAOdpJA3mbHbld91Wkd0ZJ2O1/q7rHiDawO+NixrPV2vATURvS/NjHCAQHtQ9kB7c4CWhSDKha9TzyCto++blGJh9H7oBuOxhVytqi0v3M38Awc/I/iZApsBXIilJyz0TcDO0XQmWa0dZ6y6ztk3sSBvY28ioyhVWxcIVS+61uUL1p5y3fZvfztKYA+y0crluzpDPVusg9E+Ox/XgI/lWw8PjbntP+v98vikNGgRMjZPnZfc5S+dbyz9 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5207.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(39860400002)(366004)(346002)(136003)(396003)(376002)(451199015)(8936002)(82960400001)(52536014)(6862004)(5660300002)(4326008)(66476007)(66556008)(26005)(53546011)(41300700001)(66446008)(64756008)(33656002)(66946007)(76116006)(2906002)(8676002)(55016003)(6636002)(316002)(54906003)(86362001)(38070700005)(122000001)(7696005)(478600001)(71200400001)(38100700002)(6506007)(107886003)(9686003)(186003)(83380400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Jc1YWrSpV5l6iBPrzK/8ZJmjVPja2PdMKgoHDz4mwu3WMZm6w4yh8bY1k1eR?= =?us-ascii?Q?JKZAtPXH8+AfheUsUNlOHJE6sb5OuGizALh9g9BfltTLX7rMmeGgTZSdVyD2?= =?us-ascii?Q?VRoIi7Iry3+ZUBqqEo5GxF2y+jlmmSuONpgL2iJ65ilAaYVX/jZ/2AUOXypy?= =?us-ascii?Q?CCMWM2aFbEoWtjYlJiYaKxrVRRCXQLJppnq6UtllnGwBJ72+UZ25iZZvMOIz?= =?us-ascii?Q?sB6qTMid+/K2VfXrJs0594qxe4ZjD+Ugk1xrQh1IK7f+alnuTFeCiGHM8+Lr?= =?us-ascii?Q?3FoOC+DyPOMOPnTONusGo8sAkEf4CZ1x+C1T5xN4xKyaG12jsUxEsS3JgsZD?= =?us-ascii?Q?Q7tLII9QjQGpPt6r0fTq7c22SgkOmJtx2W/WSFF2YkR0Uq1Z06vLECJkWGkl?= =?us-ascii?Q?VxaDJzFX96kapnN54op7j4pg6bhWmT07A+uAezvszx6P+Gj3d+dPL+blOqRs?= =?us-ascii?Q?VNb/8swji5TJFZLFjQntGPpgtmkDKpJND5/yZ9et+W/1rpn1iiM8/tK+yrCI?= =?us-ascii?Q?D9RIC5hHHCDxeS4tsLcddgicn5tOf+8Y4Ho4F7a7OHSf+/zCRSagyfKcrhmJ?= =?us-ascii?Q?LXN9AEnvOuUHkW9nJ5XxY5mTTGe8juwJFzGkyTt5drTam1LsAKaXBj89WcV0?= =?us-ascii?Q?mSIs7uRzxrHutzQlHR0stf85STHDUa4VrgayqkeCZA4d+l1L0B5JeFf1y+UH?= =?us-ascii?Q?Rf5aM01QiXvASKCUu0tHSTMTLXPJ93rQUxRkUGwNUdcN8+5fO+mepfQoMg54?= =?us-ascii?Q?B8/k8sCA4z7d2FprpztD4b0hWumIxUMzjB73wqxT+Y9FgFGbio0xE2jucJaY?= =?us-ascii?Q?c7PFFEgUu+JXZkCQubxibCIRUpzGV/XSHsHlN++8P2D7itxLwlrFfz6pNwQw?= =?us-ascii?Q?4Gv5cutVOlBrYBbeCSnSeL6tt1AFlWG6BOAzq4B5mnGrRA5g45haSslYZ7Sr?= =?us-ascii?Q?UfJbSG55lgAR/IQ5Drq69waa35tDfNbbUf0rHaYnGFrUDAe3PUjpqZEK4FKz?= =?us-ascii?Q?1Kuj3WKmGgzN1uQtIMJZhMfk7hw5GhstY137+0v9Hi3Evo0AkMuiOB1f0en0?= =?us-ascii?Q?ZCUy3/6EHiwFTYUwt8WoybytluyjnDJ927uoRl8oOICrzP9N2T/M4nJ8dh7q?= =?us-ascii?Q?wudjpsvhSY0PPbuCdcBowBpALO5z84JT+Y0U3hXTAPfqVnUIMxEoVMSFaN+x?= =?us-ascii?Q?80A1ia8WfMWPlaAD1gzSb7N6WuUJS6OW4+RopsqIhGe8PDUkg5GCqNm6EVEw?= =?us-ascii?Q?slmvE1Hos7sDKjMIwpBMiXe8CzrObtjyJCJ4g+db45Ou1tLjRfk44YdIMAnn?= =?us-ascii?Q?EOwn6GClfZooQ1k9Y+Mb8XYAmEuwxwcUjupVq3K9tKrjRm4DTEjoBrkW0a4o?= =?us-ascii?Q?KooaNDu4NDDmSNYZgz6jyMnuZSfpFpVmUGXLmcP1edU8AvM35wd9QNKd/nxP?= =?us-ascii?Q?gH43r92BpIKnd+LDzQg0YZmkRzx34rv+XYB+on+Kon6V1R8yl2/lmRYIUeVY?= =?us-ascii?Q?gBgvUO1MkenjMUcjqNAjHWOSwUaMa3wv1h/Zlk9muAojGBy2O9I6dbz1qBtL?= =?us-ascii?Q?kD+DTWPOfJkur8u4Q+a9nCIZe3CiSa8/2BHthW0M?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5207.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 74f35575-b55b-4339-da81-08daf7dc05f0 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jan 2023 16:09:19.0726 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: r9beYXTIoBdoN0peHXIlzC4jSvS1K4oV01mFXUmltKRv5OK10XQCUFDF2Z20Dct/qaqhxG2ZvPusVBLMw5x86Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5452 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Bruce, This patchset breaks the dmadev autotest for IOAT on IceLake. Trace below: ### Test dmadev instance 0 [0000:00:01.0] IOAT.status: ACTIVE [0x100242880] DMA Dev 0: Running copy Tests Ops submitted: 85120 Ops completed: 85120 Errors: 0 DMA Dev 0: Running stop-start Tests IOAT.status: ACTIVE [0x100242880] IOAT.status: ACTIVE [0x100242880] Ops submitted: 1 Ops completed: 1 Errors: 0 DMA Dev 0: Running burst capacity Tests Ops submitted: 65536 Ops completed: 65536 Errors: 0 DMA Dev 0: Running error handling Tests (errors expected) In test_failure_in_full_burst:390 - Error, missing expected failed copy, 0.= has_error is not set In runtest:58 - Error, not all submitted jobs are reported as completed In test_dma:940 - Error, test failure for device 0 Test Faileded: 16 Ops completed: 0 Errors: 0 RTE>>IOAT: ioat_dmadev_remove(): Closing 0000:00:01.0 on NUMA node 0 Thanks, Conor. > -----Original Message----- > From: Bruce Richardson > Sent: Monday 16 January 2023 15:37 > To: dev@dpdk.org > Cc: Richardson, Bruce > Subject: [PATCH 0/5] dma/ioat: fix issues with stopping and restarting de= vice >=20 > This patchset fixes a couple of problems with stopping and restarting an > ioat DMA device. Following the two fixes, a series of improvements are > made to the dmadev unit tests to properly validate that dmadevs work > correctly as they are started and stopped, and ensure that no other or > future drivers will suffer from issues. >=20 > Bruce Richardson (5): > dma/ioat: fix device stop if no copies done > dma/ioat: fix incorrectly set indexes after restart > test/dmadev: check result for device stop > test/dmadev: create separate function for single copy test > test/dmadev: add tests for stopping and restarting dev >=20 > app/test/test_dmadev.c | 172 ++++++++++++++++++++++----------- > drivers/dma/ioat/ioat_dmadev.c | 26 ++++- > 2 files changed, 137 insertions(+), 61 deletions(-) >=20 > -- > 2.37.2