From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C48CD4240B; Wed, 18 Jan 2023 11:47:28 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 110C742D3E; Wed, 18 Jan 2023 11:47:28 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id D8344410DD; Wed, 18 Jan 2023 11:47:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1674038846; x=1705574846; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=+tkChFis3UyUU2is5LauN/zcumXsk26U92mdDgc6AhE=; b=lhmAX/W3aFsw0SyOdsm9ySj7HjJRkCfa0rNbi9vSso9blnP+r0zXRAQf DhjP3Bgs5ioCLV6nCyegiTEnWP2LR/rqOXlDgU+Glaz9ur6lOvQeKnDBk PTn9KA2/Dr6HhjcPfO03myB4VjxZTQKGtgLy8/5Iziopdy5LPx1pemA9Q Tv845e39TFhGF0FjoJbDgnSYH+9Ma2SEyoeIhqNOfMZxjo/8MB0L5Fq02 qBJlymabYIYfdBu6BNmPttx9zVjJLf1k9UrvOQwd4lmkRDWClHFecS2WC NROAGrNHjnqCmWiKHEeeFSSTnukH09UqghXFPzacV6cwG2JTJzdoCGD7x Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10593"; a="323643107" X-IronPort-AV: E=Sophos;i="5.97,226,1669104000"; d="scan'208";a="323643107" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jan 2023 02:47:25 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10593"; a="723039893" X-IronPort-AV: E=Sophos;i="5.97,226,1669104000"; d="scan'208";a="723039893" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga008.fm.intel.com with ESMTP; 18 Jan 2023 02:47:24 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 18 Jan 2023 02:47:24 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Wed, 18 Jan 2023 02:47:24 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.175) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Wed, 18 Jan 2023 02:47:24 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QiiYX0PxLJK5i573cdHl0mU45L2GZXUNd30WTmCQ7DoLsOzbsBoJVktdNOBdxY0/DRmfBFkBXHc6SRDPCEFGNC/yaOVFUG12bOAQ0UbA6bGwjeFzXb52ooTJ4ckVE+UzHFuLksn0ObhTVeXo4gy9F5kbKQ/eiYYHvpGnXM8JpHhIH+ZLviiz1TSr8M+b4sRm2rqGER2ju8JBP/sQa/3D3BpsvaGFOwGC869s6KGHfvJzYQUEMnPq6GXxGjsWtpcszsr+KvdO6+BRPrMVe6/6XOPyTJFhlsNTdeS4ACvS+Zg7mu5jHliZdWF/vOueWQ6Nf/SbAaOOLFOCyF+8COfnbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+tkChFis3UyUU2is5LauN/zcumXsk26U92mdDgc6AhE=; b=Ize6IKW7M/kLdzA3CpCB0+roAbwiQQwpOrVgYdha41fmOqctiMXp/4T76I21tdSuiC42jZDEFIb7CeEl04P6GDBZlbQBv126lQLEQjVpPH2uai2rFgKPR7cQA6wHBDRIsmUMmyp8BE2n6K25EfYXvf6budEhL2W39k8ClhieXVJzgnqEG5vWcINAaAEQZrCa2lrkNlJesEcBrIVrTJpgNK9VXiNzHo0XGYU1bxN8Q/FU63JNCcjo+Jn0EFtH1zOG8oos9Y6dspQ8n6C2uHdoUOLMgy7g5NPVcXhZk5BCUvsgvNknUFzx5qugSuyocHJmiHPCuMcy88fDGyzFuuyIKg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5207.namprd11.prod.outlook.com (2603:10b6:510:32::15) by BL3PR11MB6313.namprd11.prod.outlook.com (2603:10b6:208:3b0::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.13; Wed, 18 Jan 2023 10:47:22 +0000 Received: from PH0PR11MB5207.namprd11.prod.outlook.com ([fe80::d1db:30fc:2964:8059]) by PH0PR11MB5207.namprd11.prod.outlook.com ([fe80::d1db:30fc:2964:8059%9]) with mapi id 15.20.6002.024; Wed, 18 Jan 2023 10:47:22 +0000 From: "Walsh, Conor" To: "Richardson, Bruce" , "dev@dpdk.org" CC: "stable@dpdk.org" , "Laatz, Kevin" Subject: RE: [PATCH v2 3/6] dma/ioat: fix incorrect error reporting on restart Thread-Topic: [PATCH v2 3/6] dma/ioat: fix incorrect error reporting on restart Thread-Index: AQHZKdFKMbMql6EpZEujGhu6xUKQz66j/KuA Date: Wed, 18 Jan 2023 10:47:22 +0000 Message-ID: References: <20230116153714.554470-1-bruce.richardson@intel.com> <20230116173738.562322-1-bruce.richardson@intel.com> <20230116173738.562322-4-bruce.richardson@intel.com> In-Reply-To: <20230116173738.562322-4-bruce.richardson@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB5207:EE_|BL3PR11MB6313:EE_ x-ms-office365-filtering-correlation-id: 3897c8aa-104b-40ee-4df1-08daf94160ff x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: srQlqeyypSAVazQCxKkJediO7onbuMVV5/7UsRUCiWWG9yQtoCnFlM85HGDs9skAXeTqpO07aX0zz0QbRsVwJdin1uUeRDO+uEhNHeIOVpql5RQPSjc3pEcsCumDA68UoVBEh21DOLgGMieXycLPB/dZO+VuFCqL5kEnV/79leJYJRZ/myWukuXh24E+KK9ZhgEFnDBbc6mjBiRGhQuyfQbzajPFzvy39cBuYyXdQt5lJFiukCg5tIwpsEHRsK5m5fueV9EUUioLLidKMhfNfgdEStY91RBlBdzYjKMya+QU1i7S7OsGbG09S0jhgfhzKlMvnT+hVOdNo5BdXvWvacsGVBratjwoZEnATkBFuYU2AgBExgencJbFWKBlLt/30p2JEGLVIby8pjYYjHixBtyk8/fj7KnnL6wWpi406gVYChs7mCT/n+OJyDqHuDZByx8mWKT+NflzQsL92e+BQmi2rcCvjgZMGYzJT5YHdTITZeeBuwakMhN+iZ46aMr5XcAYpU0yTwlTuFmrPaR3qGq1o09bg56fH0bqsQ3Hp6YsS1fX85eOwqxMZxEL9suR/P1JmZ09sxyRIrA6U6eXm73eS66xf3Z13d3wXFGaUZ05t1UCb1JTTa87BT5NliZYX3rM+XdhAvlDdzdA0ddJE3EyXWeUNK8NR+P+uBct3dkStWC6SoYseOtx/SkWTasxqincs1hPsPliQPC225Zb2w== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5207.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(366004)(346002)(396003)(376002)(39860400002)(136003)(451199015)(82960400001)(316002)(55016003)(122000001)(38100700002)(86362001)(38070700005)(33656002)(8936002)(52536014)(2906002)(76116006)(4744005)(450100002)(66556008)(66476007)(66946007)(5660300002)(66446008)(64756008)(4326008)(8676002)(41300700001)(26005)(9686003)(186003)(71200400001)(110136005)(107886003)(7696005)(54906003)(6506007)(478600001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?12nUvWS0LGSGuIR0X7PMSyrlajhXS+JngSM7hCrJ8ppFwcZIKw5983b5o4JH?= =?us-ascii?Q?+Ym0YRAOOpyF/PLqDg6hz84xqWvbB9daZPeWAKb6dFHYJHXnd5jwVk5j8Q91?= =?us-ascii?Q?Rb98770KuAYUCjFNs38R2aZOa2qhiLp9n/JrA6mhAH/3FIj8769pmeZyjx7n?= =?us-ascii?Q?hnpWHpTNc0e3jKlk+sO5lC+TUBmS0fI3QDkeztD8s4vQ3rDwgQOqJ5lEoXjB?= =?us-ascii?Q?c+k0/n+uZ/Ds3ePJYBObaHIoeiVkx3sabKKZkkHV6L8APnAjcxfNyqBIFTCC?= =?us-ascii?Q?b4cRzROdWhmxg8bJcWWVYkb18R689Lw3X17VkwN2CpRxAwpk6WMBINJ6Bqtt?= =?us-ascii?Q?rlkFs0+SbfueqwFTT33zrq3PI330SqJEuTWkG8RPmGA9zHtO8h/xWWeMWzc+?= =?us-ascii?Q?UJSmm9HwnzvgP3WTxPV/vp4hZdwwsNmofSJNOOglCrAePdKlB3LJV1CJnaCF?= =?us-ascii?Q?/IB+AiMkkrJ0SCHDzJdGqkBtaQtZPWJqWApfvpFkOnQzhqYXuWWjV4ZipryK?= =?us-ascii?Q?d88j2GAgE8qys+kYaBLSaaDzhKoUNLMFP0d0RfaxjoHj8dPBizntioDC2ipP?= =?us-ascii?Q?RNaePOZ9J7K0xntW8Zfu/yFsv4x07uCuyj5t0YoxsL8InmOo+eZk76LPm2ID?= =?us-ascii?Q?ke3OuuA4eTm4dg3BsSB0VgcDcpyAoEXRaji3KK1qXORFRQeDiTy3OmfP/86b?= =?us-ascii?Q?SlXgvDW3/KczMua3/uuAnLjpkMdh4QturKE7k8767KYkZld623lFR3kUOZAn?= =?us-ascii?Q?VfDfCq2RrSjEg10xOn6TbU6x4m1fZcjKNJxuGcI799uFCtj0IADBFiLlzF+v?= =?us-ascii?Q?luSTxxG6Cp6oQLTysQxATaULHi+g0qLe+sixcxMc0wvkkWVthcWTlzleo9nd?= =?us-ascii?Q?Zw+IsuEUCl8KKdkIT7iiws6oWeTH784KWXGXuw9PqdwwIxfBLsAmDOvL+RXR?= =?us-ascii?Q?b3Btg66LdJvmEvNeT9OtffvLs4UY66Al2Ph/eEPyIv7cOpibY9hg7aB/nl3y?= =?us-ascii?Q?96/Pf6Jme/eXKncwMFz5Q6I8pAHZ8dUadOgqZBWxPK305RSwMuk98KgXx+32?= =?us-ascii?Q?juH0LRbsjp3PLI8rLKKQDrF2j2nB1/AmU/yZ4wUcNvGAoZktbSlVw4Ulp4b6?= =?us-ascii?Q?zROdGNcuZHE4tVevx0l9RFaxXF2ccQDxniL0JUPWNUtUr/u2KDTegPuvLFUX?= =?us-ascii?Q?fLWy3APiQvPyUh9TogEtbmpwOVIoItJORdv4LQaRBoBHZZjsnJt+1Sh78enK?= =?us-ascii?Q?PVnLGZaW5vjPt0SJXQAR3/W5cfQGSp57KhCyA4zKyul9QJExC1xFSCPWBlF6?= =?us-ascii?Q?izVu0ts5y4Su4ciPzBLP+k0lj+a+fONDf3NFlgCsZx2L+N+6yD1Hbrnc41EM?= =?us-ascii?Q?PPr36cdN22wIMvltCV3k7DLGqbQiD4FO4y/csjgikJb7mg4i6xM0PnXRq3xa?= =?us-ascii?Q?Am4WbzQ+DD02M/QhMnqqhlXzvUiEJ89PCu0qgeLR8xh1MUzeBkUWxdv46iMQ?= =?us-ascii?Q?YcwKxxosKuoqGQocDievZlGO7dQqDSLrMGl60zWOOD5DCU5DDC6ywc29vwiG?= =?us-ascii?Q?aOToFGWk+Aq7pB+o2PlfrNAR0XweJDVzhmJCjMw2?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5207.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3897c8aa-104b-40ee-4df1-08daf94160ff X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jan 2023 10:47:22.1256 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: lIuBIc21RmTMvyEPTohNjhB+SsiWlzMLejFxd3ndxy4p0th184fCo8KztT1+UR6biY/e0fwl87YfAyTwp4F7sw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR11MB6313 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > When the DMA device was stopped and restarted by the driver, the control > register specifying the behaviour on error was not getting correctly > reset. This caused unit tests to fail as explicitly introduced errors > were got getting reported back. >=20 > Fix by moving the setting of the register to the start function from the > probe function. >=20 > Fixes: 583f046dd404 ("dma/ioat: add start and stop") > Cc: conor.walsh@intel.com > Cc: stable@dpdk.org >=20 > Signed-off-by: Bruce Richardson Reviewed-by: Conor Walsh