From: "Walsh, Conor" <conor.walsh@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
"Medvedkin, Vladimir" <vladimir.medvedkin@intel.com>,
"Ruifeng Wang (Arm Technology China)" <ruifeng.wang@arm.com>,
Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
dev <dev@dpdk.org>, "Gributs, Paulis" <paulis.gributs@intel.com>
Subject: Re: [dpdk-dev] [PATCH] examples/l3fwd: remove useless reloads in FIB main loop
Date: Tue, 6 Jul 2021 11:55:50 +0000 [thread overview]
Message-ID: <PH0PR11MB5207651FE1D060CAE64E4F71FF1B9@PH0PR11MB5207.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CAJFAV8zxiLQj0O2hw=hcnQ15bEFg5hbZ6P4tomqyjmCMOfTncQ@mail.gmail.com>
> > This patch aligns the l3fwd FIB code with the changes made to LPM in
> > commit 74fb854a3de6 ("examples/l3fwd: remove useless reloads in LPM
> > main loop").
> > This change ensures the compiler knows that the lcore config variables
> > are constant values and the compiler will then optimize the code
> > accordingly.
>
> em can undergo the same change too.
> Can you send a followup patch and I would take them both for rc1?
Thanks! I will send a patch for em now
/Conor.
>
> Thanks.
>
> >
> > Signed-off-by: Conor Walsh <conor.walsh@intel.com>
>
> --
> David Marchand
next prev parent reply other threads:[~2021-07-06 11:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-05 17:05 Conor Walsh
2021-07-05 17:32 ` Ananyev, Konstantin
2021-07-06 1:38 ` Ruifeng Wang
2021-07-06 11:29 ` David Marchand
2021-07-06 11:55 ` Walsh, Conor [this message]
2021-07-07 9:57 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR11MB5207651FE1D060CAE64E4F71FF1B9@PH0PR11MB5207.namprd11.prod.outlook.com \
--to=conor.walsh@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=konstantin.ananyev@intel.com \
--cc=paulis.gributs@intel.com \
--cc=ruifeng.wang@arm.com \
--cc=vladimir.medvedkin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).