From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id E3C48A0C47;
Wed, 27 Oct 2021 15:13:13 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 9C49040DDA;
Wed, 27 Oct 2021 15:13:13 +0200 (CEST)
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
by mails.dpdk.org (Postfix) with ESMTP id D3677407FF
for <dev@dpdk.org>; Wed, 27 Oct 2021 15:13:11 +0200 (CEST)
X-IronPort-AV: E=McAfee;i="6200,9189,10149"; a="228907257"
X-IronPort-AV: E=Sophos;i="5.87,186,1631602800"; d="scan'208";a="228907257"
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
27 Oct 2021 06:13:10 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.87,186,1631602800"; d="scan'208";a="579621403"
Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81])
by fmsmga002.fm.intel.com with ESMTP; 27 Oct 2021 06:13:10 -0700
Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by
fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2242.12; Wed, 27 Oct 2021 06:13:10 -0700
Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by
fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2242.12; Wed, 27 Oct 2021 06:13:10 -0700
Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by
fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2242.12 via Frontend Transport; Wed, 27 Oct 2021 06:13:10 -0700
Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.48) by
edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.1.2242.12; Wed, 27 Oct 2021 06:13:06 -0700
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=WJsu3tl/wpoO620lAkgzXw/U01gnoyGJbZjd2Uj0B5sq8kVN8KhiSEIRZwGZS+rgsrCREYciAAUWWPhpl/RQ7nizCuGu14WUf11I6hrdxBraNAYKhcL59tuHlx3DfLAnS1pe7BJZS3UbcyrAvnMjg5HHB34klh568lY0YrpoGVblCYrjBgZD1PbmHPF+mJxX5Q1vH5Q4pec0c6mviPeCp0tH5j/lDJkHwEE/uoFk2zHBIVSKhybujogiXP86UBKvP3v0SouPAi6ACaNNFurM0qJ3POdDNCgaokXpQTusUlAsnpIyh7iTho2tvPlv7jQyoGIkOK6nNJKo5RO6i4pGgw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=/9hTvKH4fvbVvyqHNxQSGrx9Hy2xQ0RM/640c2moNFU=;
b=htaYtYGNf10urrAheUctAvQya9jVshw7QhVMScxnVD1zfl6YZTlCqD2YcPGhRPQkyK0T1uyLDg6pulXjaC3cg+AAYlIAR8+qE/mWqwpvRAhSsGhVm5bQRA8hOz5TkiYtQpGGEHKrinDSgxkIx+WfLSzLlQhf1zhCQibcvvVVQ2ZxUGEhxQjyFi8Gss4EkTJUF/sS7w3p46rsmabzyQQLHoD4XZjqwjv1JV31nA+VVMGdc4AY9sKP8PG1ipmQznUXUzbCDhpyYYIjBE57NSqcKvB+SsG+zXg1z73m0mURM5vF1VBSYFicqVElCoVvwmKhXGrEQmYn5l3/Q72BXTWmKA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
dkim=pass header.d=intel.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com;
s=selector2-intel-onmicrosoft-com;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=/9hTvKH4fvbVvyqHNxQSGrx9Hy2xQ0RM/640c2moNFU=;
b=oh7xcUR+Z0cHA7XbDigjBrwoaTh5+FDIq8iFq0wPyqYSh0uRkOcdiz3wzwnvR8XblOMS4WJaEq4aCJK4DhBOIL7BOKxWvRTvwuhHb2suKXRscga190lZxls4VWHEvhfz5xI4C46Kbn4+OLL+1NG2woi9bZepMhcQ47XwQ9ck7r0=
Received: from PH0PR11MB5207.namprd11.prod.outlook.com (2603:10b6:510:32::15)
by PH0PR11MB4950.namprd11.prod.outlook.com (2603:10b6:510:33::20)
with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.16; Wed, 27 Oct
2021 13:12:59 +0000
Received: from PH0PR11MB5207.namprd11.prod.outlook.com
([fe80::f076:f51c:9101:b0ff]) by PH0PR11MB5207.namprd11.prod.outlook.com
([fe80::f076:f51c:9101:b0ff%8]) with mapi id 15.20.4649.014; Wed, 27 Oct 2021
13:12:59 +0000
From: "Walsh, Conor" <conor.walsh@intel.com>
To: "Laatz, Kevin" <kevin.laatz@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: "Richardson, Bruce" <bruce.richardson@intel.com>, "Laatz, Kevin"
<kevin.laatz@intel.com>
Thread-Topic: [dpdk-dev] [PATCH] dma/idxd: fix truncated error code in status
check
Thread-Index: AQHXyneCzikkOXdeaUaZrswI4Fb7Oqvm06eA
Date: Wed, 27 Oct 2021 13:12:59 +0000
Message-ID: <PH0PR11MB5207D0A93BD87F37768D5369FF859@PH0PR11MB5207.namprd11.prod.outlook.com>
References: <20211026142045.2996949-1-kevin.laatz@intel.com>
In-Reply-To: <20211026142045.2996949-1-kevin.laatz@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
dlp-reaction: no-action
dlp-version: 11.6.200.16
dlp-product: dlpe-windows
authentication-results: intel.com; dkim=none (message not signed)
header.d=none;intel.com; dmarc=none action=none header.from=intel.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: d6015aa0-69f8-42b3-a827-08d9994b8007
x-ms-traffictypediagnostic: PH0PR11MB4950:
x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr
x-microsoft-antispam-prvs: <PH0PR11MB4950C9C453990B2925933B43FF859@PH0PR11MB4950.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:6790;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 34Ssh217b0Qelr/WAR400Ll191nmsE8tRMp643yfswyi1KZofw+bRG1zSOhn1ItAmJ41OMsDhMLO1jp36/1lmziJg/NINaRb1QUJd7k9mVFMaLCAEGBb0QEwlPUBLA05HdYADN9UNLG4/8PbnL4d87unAQQjdZrsRkyuU/lgC+iXG+oCGV0SFoGv8JRRUkTURi2o0q9hyx15tu8Hy3h6biOtu9gOpfhaF3heUC1f1OPI4TuyvOSESprCiCtVZCqLCF4Mraf9dmgdL+rP/hhdSwPRIeK7xsOMipqRXW4bP6uparHEE9M6K5epBFLNeb++TLe1kiO9uWWCvIwOTzs+glRFNbSGRIjkhUvLGW2XrEz4OLNXMCRhbZvkgYXLZ6caU7OpevHctMEymC289o1Rd6oNBy5cDuFnjNj5k0E8xl1oIX7Yf0YzvvEUJgNLWqFFUjTvIPPzgT2a1ndVcODRbRTjbgk2jGOnhMxiCwGTsiE1NSiHqPDU3pGOHVNyDSAaeIonR+NFwebOWwkbZUQC5LD4rCMcTTIHBE3KVKL0JUd/3wAgY+i6DAOE8VksiIz3/fmbQcWpAU2w16CioF/tNeTpXbb3iSIhwVywX4vlnKH5t3Uzn656qvBn3EPsRgBVxoB+2Job8M4hpaltnRFXBakhWUmiAZ300bvKuBLWtMYNlOKXYXd6B7/WD0HXcUfTclFWYVeJVRWivgQf6RTHzQ==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:PH0PR11MB5207.namprd11.prod.outlook.com; PTR:; CAT:NONE;
SFS:(366004)(82960400001)(8936002)(508600001)(55016002)(122000001)(9686003)(33656002)(107886003)(86362001)(6506007)(54906003)(53546011)(316002)(38100700002)(186003)(71200400001)(5660300002)(38070700005)(7696005)(4744005)(52536014)(4326008)(2906002)(64756008)(76116006)(66556008)(66476007)(66446008)(8676002)(110136005)(26005)(66946007);
DIR:OUT; SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Gw21MGp9KKrnB5PQVkH8WOQcRuVWo6h9TxNwMzBDBzvxmNJtNlf5FVM39jjC?=
=?us-ascii?Q?DqoFUTXGEtAVusPtEQ3MdjwQJChszoNEXHuwrLihkVFT/LLR22ggve3Ly71z?=
=?us-ascii?Q?MdnJxKSbOh80Fir+bY0eCdTUPsPYs42eXaew99mRCiQ5P9bT8/znbyTLwHCv?=
=?us-ascii?Q?Tl/jaqDXDgPNf9PB0w89KF1luB+J0/t+hvBhvoFxIwjyb0qgH/69A2VLnGUa?=
=?us-ascii?Q?zuAs8SJ4wNfplF6IGuKyq0PO0ZLX1ShsAhLa1RfEggbW41T04BumAjAdZ8B3?=
=?us-ascii?Q?zh/PC/FHYd6ie13L1f4xW12om3SHwpKmDHrZL7P0jcg4FW7pOIw+o53ZLP8L?=
=?us-ascii?Q?+QQpDKnjJvRQQ6BaQpHP79k7cbB4Lj8Xxgo0FXBj3mg/CKp2SHtosrMe6nId?=
=?us-ascii?Q?0DutKf1JgiOskNwdjlD5lrI2aACbG3foDIwgOpNrL+qRY37ey+dlGMlhUx5B?=
=?us-ascii?Q?KQBmaB4WntKju9x0UeCE0a8SHY66T9o1oDlhZ6Du5B53qgf8KfyIHZca624K?=
=?us-ascii?Q?03RCSu/L455sF5o50GnWpONFD63egqSZiMpu2skvznGRxdAddbbXRypfOCXn?=
=?us-ascii?Q?8aq9BGdpUhbSSZXfBWptiqBaRAhK5GpfkthVSPCTMQBEuDicCSGfogWlb9us?=
=?us-ascii?Q?XA9KPDfbBy0GHac5VgAwUMcyacvVBqhZavt5lR2zCZqeK25brLTUsw994qkn?=
=?us-ascii?Q?6eMDNRv+M0uYS7iCvoAZDT9FOlQcknwmAGeL1ZLauSSLJvLqzrUbzBD8chko?=
=?us-ascii?Q?D87/GixPD/acmyE1Gz/yHWmmGE6iylsQzePwUs6Y1qYMuOIm74t10IrwxkW9?=
=?us-ascii?Q?L4Z72eShoT8TQ0pDln3VHVWk1c4gvGLP7JAh1qtBqP19UfHIWFDuAnu21sIf?=
=?us-ascii?Q?Huo+ElIDUxeZx/KpY0FDoaC28hauoGzGUWU4usd/Ti1YOWdSWV61ugpfCGp5?=
=?us-ascii?Q?so8aTewcJNsmEvTrwYmomrLgLtH3XOZ06h0u8XxFP7gmF0Ij8+QE3p1ABvJO?=
=?us-ascii?Q?j/BvyUpwm5uwfi1f7sA0gFJXVdAg2uk6RkVScU1WdKjfv2SJj6cUF6TcWMln?=
=?us-ascii?Q?BYVQMuIoXUuNMK+v+CTCA1u0KSwuLnW6oBNp+yJvI478OapMJvEIys0E/i3p?=
=?us-ascii?Q?7R15v3rWw/7b88VmBvGSITm/OG+ZMV0dujO9NNftOyL64GB4DR7nedtWsPF+?=
=?us-ascii?Q?hyi4D5TKIWjraLw7BNAKNQl7b/sL65qobeW0M/bujtadVNrz4A0O+ZTePUuZ?=
=?us-ascii?Q?NM+cs7M3c/Fxn9YDJCT8ZTd8z7l7FCdXQJ8tBAPQiCATwViF30ruqxRcjpTg?=
=?us-ascii?Q?LVbK93dJlQKmwXS7I0ahMzpe8inY8r6l56aLgsyyr4YvkPiT3+MdUiFReyNq?=
=?us-ascii?Q?sLa/rWd1tVhkIOkFyc9zQIOMIZgQy77oI3b68qYhK1JIdGZyLZCEhoSaorm9?=
=?us-ascii?Q?1Gcjh8Ws6IvPGuYE2miQIDpNOxiBltbyBhXkZ1VZyYSDMekMrzZogY7h3j7N?=
=?us-ascii?Q?abW2PxL8rKtoUBOdeAKG6Of6alJ+pR0kXxmJ5kGjbngAzpMAb6JWLQtbAH9b?=
=?us-ascii?Q?7dIsP4uSR4nq7+7tVbthC81cZafe6VxKwRFEKnlDBmgU6jUWva8ysQO0XuYP?=
=?us-ascii?Q?FQ=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5207.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d6015aa0-69f8-42b3-a827-08d9994b8007
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Oct 2021 13:12:59.3841 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ENbBxsiOgbjim4JhlpKa05t7tC57BLtc+QHwOFl7zotMZRRVOx4m3GA8OwsY8lK8Nfwpa/YXfD4fnx/3MUkIow==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4950
X-OriginatorOrg: intel.com
Subject: Re: [dpdk-dev] [PATCH] dma/idxd: fix truncated error code in status
check
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
> From: dev <dev-bounces@dpdk.org> On Behalf Of Kevin Laatz
> Sent: Tuesday 26 October 2021 15:21
> To: dev@dpdk.org
> Cc: Richardson, Bruce <bruce.richardson@intel.com>; Laatz, Kevin
> <kevin.laatz@intel.com>
> Subject: [dpdk-dev] [PATCH] dma/idxd: fix truncated error code in status
> check
>=20
> When checking if the DMA device is active, the result of the operand will
> always be zero since the err_code is truncated to 8 bits which makes
> checking the 31st bit impossible.
>=20
> This is fixed by changing the type of err_code to uint32_t so that it is
> not truncated.
>=20
> Coverity issue: 373657
> Fixes: 9449330a8458 ("dma/idxd: create dmadev instances on PCI probe")
>=20
> Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
> ---
Reviewed-by: Conor Walsh <conor.walsh@intel.com>