From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 53AD4A034C; Wed, 22 Jun 2022 17:12:20 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EC82740A84; Wed, 22 Jun 2022 17:12:19 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 67D8F4069F for ; Wed, 22 Jun 2022 17:12:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655910738; x=1687446738; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=ehA/DP6f+5uWtsFLbnVrEaq8qIeYbWDbw0urPHueOHY=; b=bA0yhjBt10D8ZyKo019adpTt/7rn/IlljSOVbtmaw9L1HpP4xyUY0Nyk KtwH0M1pU6doNBwsesxIMhyNtWbNk59jEMRqu2xjhX2pYZQdDf2r8I9Ng Q3vqbonEeRwePjpMMHgcZg0Pf7NGF3fTCke38OueoD4UbyWHBjLoND+Mg XuLANGdJKIpAoVD6mHLpP4yviVf80FY5NuO+124L1kM1SFjO3fbJDHThT KLR6kt8hYlQw7Rlt91VME1DXWhXzHDb5lE3bN7GhA2RyTLeZTMHBC1Q4w BGvQMlr+U018p324Jt50fsXdWp6hbr4DB13meXFEBFZua3c9X8yhh+Way g==; X-IronPort-AV: E=McAfee;i="6400,9594,10385"; a="263477320" X-IronPort-AV: E=Sophos;i="5.92,212,1650956400"; d="scan'208";a="263477320" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jun 2022 08:12:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,212,1650956400"; d="scan'208";a="730390257" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga001.fm.intel.com with ESMTP; 22 Jun 2022 08:12:17 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 22 Jun 2022 08:12:16 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 22 Jun 2022 08:12:16 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Wed, 22 Jun 2022 08:12:16 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.172) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Wed, 22 Jun 2022 08:12:15 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mJnRFM+GNM/18S3Mr4UFSVocfMWe1JNbO5kyoouyKm+g5Mx/sjA+4wmtQ4+VMN9kmkpwtxCOA93WPY2w1b7QYKRVH8zVdIsOfVcYb7SanTl7vbTcmR0tqobtNJarj1GdMAsFnn56hA9z+NiZ4Ei6SDMrIpPSndJYHW3+MNRNuvn2pqjXL5vwiQ0fIJRSDdoLjlV1gDMgomjINnDo0TwFOf+ogjme3asgdHGc2soSEzz42D4tIQF7csfe25ArDU+NRxFX3mLFYzAbEDviaEQ/Z0O+v3w6+HV1t5xMcjOWj7QJJyoozQoTxOI9FNHSaWpBLie0g56IevTLY3tn/Mwarg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ehA/DP6f+5uWtsFLbnVrEaq8qIeYbWDbw0urPHueOHY=; b=lQLR5rUdBp/C8f76HeplJ/F6XPEfSv2Wbgl/3ZyY2ezRfrXjdzLmI1e67ADajKcMfxa4H3F0NAUWeN+2lmckoZ/5KGjlliB3Y339RYLgNRBCNc0YcibVBQKO9cLQiAu990MEWTsC10/jv7NrciBJEzw8Rg3cG3tZt1vcPp9NSQevjgXjPBelUtwb+HrEFnX8KhjCFRscPbrXBDUQA/wkSfbsgkEK5lzxp5HQ9SmFr6kfS10xoU5SfNlaccLBqeIYu6MjXFQBM5ASY01YHPAQ27USWgmYTbTIQ2J4qt3k0dQ3rVUx5+P8isjO6HWhKStnTDW+CrQj8h3NDsZgi6QvNg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5784.namprd11.prod.outlook.com (2603:10b6:510:129::22) by MN0PR11MB6060.namprd11.prod.outlook.com (2603:10b6:208:378::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.14; Wed, 22 Jun 2022 15:12:14 +0000 Received: from PH0PR11MB5784.namprd11.prod.outlook.com ([fe80::2de4:72f5:cf30:ba97]) by PH0PR11MB5784.namprd11.prod.outlook.com ([fe80::2de4:72f5:cf30:ba97%8]) with mapi id 15.20.5273.023; Wed, 22 Jun 2022 15:12:13 +0000 From: "Danilewicz, MarcinX" To: "Dumitrescu, Cristian" , "dev@dpdk.org" , "Singh, Jasvinder" CC: "Ajmera, Megha" , "Liu, Yu Y" Subject: RE: [PATCH v6] sched: enable CMAN at runtime Thread-Topic: [PATCH v6] sched: enable CMAN at runtime Thread-Index: AQHYhUczIf+zfkEXq0GJKwMsGYbyta1Z0XfQgAG3LYA= Date: Wed, 22 Jun 2022 15:12:13 +0000 Message-ID: References: <20220620135630.975370-1-marcinx.danilewicz@intel.com> <20220621081607.993440-1-marcinx.danilewicz@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c0c63838-d772-4e8d-a1dc-08da5461966b x-ms-traffictypediagnostic: MN0PR11MB6060:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: St0uPDkrWbqFbjXRf+uIE+pHzlRcSQ7mgMfrTDJv+IR3w0Cv2GvPfZOP1Z69w+5qZw1Xpw09D0elRyaY3ieDucsWLBRZ/ye4xQbBze2RBH7r/uvrC3aL3bnVBgei0HX3WWWo3c5Uo0Dq+McuaOAV4kU14IoQuaTSE11otJ8S1nxwAp/gdzi3QQFvMgZNKSqipc3TtkkilLoFb/G9UwaXAois0RU0t6P25I4dgiI+46reQ5AwjslDcUPm1VIKblGUjdTzMGVMuapjJpzTptSUwc0NNoXQlWfvpvcPUO6fSMcwZQ53Fi9BGqB3says/vFXxbnsE9GEHN9ZvXotLI/icgdQlJRQJKSMii7/fZf2S2Ptdm7xFBfYfUAkeNEXX4962U2yztXSOE1fALE0UDAoFbciQEjrgIH6ldIx0VvnjdphxPEubwUFwB/q/BJXmp399IrxmEnDsBXWraw8M5xCkW9GlBJ4WIh77FgsrFaZ0s9csIeVmQRHLdhQ6puLkLVSgkXnbGq4+pJlpOEbZWwXbhbr0Bj/Tp6Wbx3dcLHfYK8aY6dFNB0iOaISqCBX2VBcbbo/cFgG9nKfbcdhAE2C3/ZFm2hjww8RR5zk59YG41T5p6rQjSwvF28LqU8m1cuafH3p7P2Vc2NngFTT3hMTem81oPsbZ2PPX4fE8vqrFV1Ez9a3QPZ9Pxhbgph2p6LrvlcGzSBFQnKiL4hIRzvkxeEl3SnRMtWCX/+wSW38DGVrm0ywSa1dDk3rkjj8KBFECTSr5DAkav1MYyo2VWdRkg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5784.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(396003)(366004)(136003)(376002)(39860400002)(346002)(55016003)(8676002)(478600001)(4326008)(64756008)(33656002)(66946007)(110136005)(316002)(52536014)(71200400001)(66476007)(41300700001)(186003)(7696005)(66446008)(54906003)(5660300002)(6506007)(9686003)(76116006)(66556008)(122000001)(86362001)(8936002)(38100700002)(6636002)(82960400001)(38070700005)(107886003)(83380400001)(2906002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 2 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?AE1dLyjtN03SYPpqGAh3HA4Hun3TewL4017la9C4zk5i8m5YvjiaGRLQocrc?= =?us-ascii?Q?vd7BQ5D4HQSyG9okjb/sgqHGDtefB386LgTkt3XCog3ghRMfR9l2CD2myab8?= =?us-ascii?Q?lG+9dwI1dyTHAMFrp+wUKm/+aVjmgtDvcEMk/k2UO3qor7YWPge4bkBNt/hS?= =?us-ascii?Q?gQ4G+9VwiWVX30ytK3s3dh1g2ZpVBj3hLYgimKPXjH6EJwxzFXQfHitXG9/c?= =?us-ascii?Q?bQvBEXYP/7a+Jmo6161BOgX5zqUdAI1PUR5v0ElG0cFeaitJ5SfQh4iJ4+tt?= =?us-ascii?Q?vATIZoifLdcadAAIzPBqLQKzfw5tIC9MFLUHmX4b4I+xyFXlxm0sOlWhz0GO?= =?us-ascii?Q?Uw8nKxXfzJiQ9kctNtnuFK35l93vzWdYxRbBDFQPY1WqtSGx8NBgQcST2WuY?= =?us-ascii?Q?8Wnqj7pKxg6B0iGUQizNZAfpMCmTX29F5q/1ZqGrszX4wWsDCzpCHQ0Ivie1?= =?us-ascii?Q?ew/nzlqfHM0OxSI4lgzrDyMW6uBVaw0skAZF6LJG5E3CZykV3aYP9AYzn/F/?= =?us-ascii?Q?SgEV9xQXMi0yEzoMCp+TKeDj6Upyk6nr1i9tT4eeMAKhntmKVYTiE6Ibd7QB?= =?us-ascii?Q?zDqSLhv/E0j6zlz8caRtAcPjKhnthxOFWbYrkHv9aHPQTRTzV+ia9xijXxHz?= =?us-ascii?Q?e1KZt233xUxSyjIoRZHLvxNSimy5k2UMJMTUdxwBZ6Xsxl/n4YEMjjNCSWYW?= =?us-ascii?Q?Uhkr+3sYUsHP28gddISh9rS4o0whKJh9bYGCVkb3xp14QlXgYcJ2QfVNZPN3?= =?us-ascii?Q?o7FS6RdlgDRbR4yI2hAfmtEnSoNAGoNZG6x64xkWXUazw99VZxqrFLGbwP/M?= =?us-ascii?Q?32rxi8vbBVpMiLU6XpdrCXZ2X1hSsBZCaqwjtpbAWeKeKdTHQR62PSOqRJGq?= =?us-ascii?Q?H97oypDWyvVFK8IANWBBVY45s+saXLmNl1V2PYuYkDbPQZ0N/Rd86XEATIqW?= =?us-ascii?Q?BmCPa2cpkvrGdU1Fk1Lr3CQr7X/UgpxxuIaN6dt0bc4FKQkWbeWYegj++nGC?= =?us-ascii?Q?1WBGDj1Wu7P7fbol/hZ0val7LdcYP0IRPIwDrXvVx2aO2dQVrNo/jO2kbeZS?= =?us-ascii?Q?hj6yo9FgEfLtCowYly4YNtWxn/fLm85BlY3xIUmV5ojJcZ2eQMYswRZ828Od?= =?us-ascii?Q?WDvus1cRP6txdCbH8bXGB3DAFYaPBC9UNZJKWch2/q4Xa40rJg3LCzooeV70?= =?us-ascii?Q?Zvcu75gWl85+98Sj5ppfaZufqsOstBFzjMxiYaV92ND89xMGKYPUFRtot85v?= =?us-ascii?Q?H4PLVk23JJRmOAy9a42B99XvQ5qEupzPMuiJJ6igIyikQ+YRgoSXNLXgumYk?= =?us-ascii?Q?vWBYrKRPSuMKvuQYnrwWAAkxn2Vi43DwECmwDFyXQZafyHQ2F3thmwpbivxZ?= =?us-ascii?Q?sgLZiyuT6M4cjSwTJnWFn4VPlQMKN6IemZ5Vp7X2rmDZ6ZT6E5xGdsiQ9H5b?= =?us-ascii?Q?M/yiAk6qg0D+WPQklD085TivFwUIkQRekHatG7FUCeKQBmtfLIgDO+ukMCtE?= =?us-ascii?Q?MuP3UOVx4uxIsRU8Dv8EnF57sEYQ+2WvPg7YllfFpBC8O7NyseUVS8UIK0Ot?= =?us-ascii?Q?AuVwpdWhHNe78Er7polQE3apU36X7H2TP8SYO0Gp3cgUFN0ke6wjNA3JqtBh?= =?us-ascii?Q?w0WYeAx3mffHQr4BxQLIdzhGperZ+3XEOdbDSMyULMZxF/EEqrfZ30K+kz/2?= =?us-ascii?Q?G2/ktqbaxklk2GCjuPY1zSiamWsHgqSxxEndNwPk4bPU3I2yy98EqFoKweXY?= =?us-ascii?Q?QEarn/98HK3ivAD2l8NTeNVqWs/TgphJBK2Jru0qw7UnbwStJzbeF1fssDoG?= x-ms-exchange-antispam-messagedata-1: OtAPw9RcFsW2lq1BTA7i/Isr+Thf8tPgdYM= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5784.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c0c63838-d772-4e8d-a1dc-08da5461966b X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jun 2022 15:12:13.7450 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xDHXR08sDk+IHHhflPx0sQf8dlz4PS6cLMkdJbYofxZ5Zj7AsOo7BWOEa0jpV6C+oMIaK4nnxqygMvJdDYIIDVgVaZlzPe7sCUme7ectX/0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB6060 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Cristian, > The code changes in the library (rte-sched.c) look good to me, but I do h= ave > some questions for the qos_sched app and the Soft NIC driver on how CMAN > gets enabled/disabled. That was open q from start. We finally found a time to discuss this. =20 > How do we control whether congestion management (CMAN) should be > disabled on enabled (WRED/PIE)? It looks to me like you are always enabli= ng > WRED by default, which is incorrect: we should have CMAN disabled by > default (in init.c). Cannot disagree. > My preferred way to configure CMAN is: > a) CMAN should be disabled by default > b) If the CMAN parameters get configured in the profile.cfg, then and onl= y > then CMAN should be enabled according to the configuration. OK > In init.c, we can safely set the subport CMAN parameters to NULL as the > built-in default when the profile.cfg is not provided, so we can safely r= emove > the WRED params from there. Agree > In cfg_file.c, we need to have a good way to disable/enable CMAN. Let me provide something and then you will have a look at it. > In profile.cfg, please remove the WRED lines as opposed to commenting > them out. OK > Is this OK with you? That's perfectly fine and looks good. =20 > Also, have you tested the qos_sched app and the Soft NIC driver with all = 3 > configuration files? Obviously yes, but not the last time. And I will repeat such testing as the= last thing. Kind Regards, /Marcin