From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B55F5A0548; Thu, 2 Jun 2022 11:58:06 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A156540691; Thu, 2 Jun 2022 11:58:06 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 6C2FF4021E for ; Thu, 2 Jun 2022 11:58:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1654163884; x=1685699884; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=I/YTwcrjyjTZCvbmzufglZLEgI42Bn9CyCa+MTMTHI4=; b=aQlYb2MqnINoyykf7h2kSzNlyHlQ7NQ2huZswOsKCJ8Hj5JUU4tc7zSM d8fjLq3uoKHZfg3ojykkFncUljZv6uJNV5ZZWwOPdKwHtyFKV9jHZrkYK TKXHI+Nns4aIr7jzk/lriZt4k7EsTzkuMxF4x2hrCP2fGp+zQt2BAvAeJ R01SaMFbyUoO1IjOYRcLLXVM1kddYpDUYOzry+ogis/2twQINGxcxq7xd FzhZUC0su3Htq2plO0Ixl5q+SrDpV38Er8T4KwPZ33HbOjI325HaCPVwz rULNcNIv+41HoYIbQO9CbsCfPMpMVkrA0Na1RGDRSLfFrh1Sg3A+bwiGR A==; X-IronPort-AV: E=McAfee;i="6400,9594,10365"; a="338943921" X-IronPort-AV: E=Sophos;i="5.91,270,1647327600"; d="scan'208";a="338943921" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jun 2022 02:57:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,270,1647327600"; d="scan'208";a="582017142" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga007.fm.intel.com with ESMTP; 02 Jun 2022 02:57:54 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 2 Jun 2022 02:57:54 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 2 Jun 2022 02:57:53 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Thu, 2 Jun 2022 02:57:53 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.174) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Thu, 2 Jun 2022 02:57:53 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cscQBG/BnanO/DM1odLCXrbrR6C9J5JqsAcE2xsjWlpv1LHc6tSc0/YPvX3e8HNlbvFdoyBfGKXtqhFIWWS1lWnMTPO4ZUr9nJ1EgC/wti5Oqhoua6mvHXAkv9p6jFg3KiipPL/l3oPrJfyg8GWEPPcIFEa5M7gsWQXCe934dD7RW7m6TzuOKv2Pr+MvCdD2yVn2qye2zCP9OQ23UdUSjBYRcTQfPuJrkDeKgqq2oC6fVqK7KkidSZ/lP1MADSfDMiMJ4AeTxK0dt94jXby6Pw8gg6D8ENz/XguKMwlg/FtB+aY0lPeJVC8KDlBlawzj1RnlBxcuVxNK3JNZJrXajA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ni3E1j2TZMZyGnq6ntY+l9Ipo8dN0AFooOfMxIKbp6c=; b=X/7yc89vN8r+nbIcVnpFDTjyL6hkiaqTd7kDReUitl+zv3EwID7OCfRnRlWTcO33XgCHKlPH3BZ8vE1k4kshsvCGxV7Pwjvjuqq2Bu5HWw5Uyl8pzEjzxsSeluO/FFjTtOuvYZL2RBwkCrp+8jX3+VyHW2pCAGYERcaaaZiHEm1bLy5w78F1a4ibR/vjqIPAtvUgxEO4ZsGfZA6hjvLwVDhFsoaYSVdkg7s59dG7iJrnzXWjDIjERzqcuRs/j9zk/eCBPplhbzqyAtOSJg8SALKIUkhPeTR6MFqxcb9YOLdajnvzZYSNjenYnbjLEUInjvIaefgp7Kff0/ox70YaVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5784.namprd11.prod.outlook.com (2603:10b6:510:129::22) by MWHPR11MB1327.namprd11.prod.outlook.com (2603:10b6:300:2a::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.13; Thu, 2 Jun 2022 09:57:51 +0000 Received: from PH0PR11MB5784.namprd11.prod.outlook.com ([fe80::2de4:72f5:cf30:ba97]) by PH0PR11MB5784.namprd11.prod.outlook.com ([fe80::2de4:72f5:cf30:ba97%9]) with mapi id 15.20.5273.023; Thu, 2 Jun 2022 09:57:51 +0000 From: "Danilewicz, MarcinX" To: "Dumitrescu, Cristian" , "dev@dpdk.org" , "Singh, Jasvinder" CC: "Ajmera, Megha" Subject: RE: [PATCH v2] sched: enable CMAN at runtime Thread-Topic: [PATCH v2] sched: enable CMAN at runtime Thread-Index: AQHYZgGyjgFuks/050iPI+ktClNfX603YKGggASc8mA= Date: Thu, 2 Jun 2022 09:57:51 +0000 Message-ID: References: <20220511135304.258809-1-marcinx.danilewicz@intel.com> <20220512131036.507178-1-marcinx.danilewicz@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f5b39611-2afe-450b-59ae-08da447e5b49 x-ms-traffictypediagnostic: MWHPR11MB1327:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 6PTwMzndteoPDY5AHfu1WU6bxXf2vddKivEAZFLvJmCmlkj/YGY+7Bc8Oq1UMgB4b0vlwsqqja52Q25wnwbLnRPZd+VU9DRYpQFI5ZkMnqyYDgYUdVe+1jM8UqE7OHOEtdJh4R+Uh8ket/J1DSCUy1zdcdD571ZwQVmamHXd5Z+6A8fM+cLfwV6tRINx4Vu+kh25m8CeYTK4197UjZsojnU+zEhxU3G3uabtFSueDO4YzsEYC/0zMplimFfkuiiq6PrhPuvWzeq+0UmXOfqzkQleZAuWpKBqV0vn6ivUfs1EivF3VFNCYGtNzDhQLYUVNJzwjz5tvLy5LNk2iqNochbFF4l+Nr8TZtIji5UTh+US6DmfQPCO1rAOS0k5nACsJ9vraSpC3TFqfetapAOaKrrY4+l/no9ZBivltiOhqSJn4hrdm84JC0yd33lStvF10BJ9xo54uDrpYf7hOR+6V5+axCJkwRV4BZPj3w+G6V726slRjFAvnpTTy5lYTM+/vGuknpC4IFZM3rIahOiPZp3OmYJN599x/uI4MDzzCg+oTi0rWwns82G7kxDtPL1Qryt2Wq7XcdkQuZ9919t00zB5NSfKAN+u3DMmEEMcHMUQfofUOcq6B8n4aMBirwMhM3gjeDlp1qBN+uGtPhFZ9UW2/CxGE6W5gugeMTfn8QzpPbnU/IaZ4viXV465Ux65eiZ2OCcl+QIDGCIQrOulwQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5784.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(8936002)(107886003)(86362001)(4326008)(7696005)(6506007)(76116006)(186003)(82960400001)(66946007)(6636002)(66556008)(66476007)(71200400001)(66446008)(64756008)(5660300002)(110136005)(83380400001)(2906002)(508600001)(55016003)(38100700002)(8676002)(9686003)(38070700005)(33656002)(122000001)(52536014)(316002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 2 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?xnbyVjuyZ858OCxfZoBCy6ujNy/SYXAfldFodWpXjUZExlX+KUgSrhSrdBm8?= =?us-ascii?Q?k4Do9xXbwJPR6bElt83WccLYI/FyqW3SlH24rmE6AX1MXtBuU7nSqkaXNwFk?= =?us-ascii?Q?L7QSHWG9LhWSmfzwUNqgl5nwpoNJzALj4om52didp1pY/iiJDLdZ4VIb3mJE?= =?us-ascii?Q?2bXzYHqzbAN9R4VaLKwdbn7AOQws2EVcKCPBMyqD4WExk0tTFu1pGfldj5cr?= =?us-ascii?Q?pmj6Y9JsE7T5G9xuDQiMgrotAK2FeKo4ZovTtUc1uCy9bEbvJ2Z06OAKB1y6?= =?us-ascii?Q?8MGmApAN6gnP3W5Pm/yuUOiTODxq0ogMKDab9fjRZiBUayWBrZQM24NP9+8D?= =?us-ascii?Q?hpOzS6C0BqPU7ZNXlttJeQF9PE+Ec/I7J4ud6S2atS+pumeUUdsZdZcEesQZ?= =?us-ascii?Q?SxEyqN61WSbdCkolqZfak3Q44WD9tEttYWdFrAt+y+xZmrQxznLw4E1+nPlj?= =?us-ascii?Q?Dq/f8l6yXzy754taxsr1nUZ4PLAd93dHphPaFsYlbUg7EmOLwJ0x1GSQ4S7B?= =?us-ascii?Q?fDMofrZavMT00SGFGgkApohZSPnChFxj37rLRiF+Va+fCQdV2zmI6LmYnidf?= =?us-ascii?Q?/fAYcBuctZZ3Z9+dVti+2Rtg6Rozg2/0v6gilT25uJiX2irwpsqsaiQmjMgQ?= =?us-ascii?Q?EcUIzvNiD81/1bWXZNKcreWfwyrjOxR93U/9clQnYm/Y4auBOs0sEHbJFxdA?= =?us-ascii?Q?qQBdE8j3cUbtAMw4S4Q0vgd0t89eduwjZSh7QLX27e5FyrUf8rcyrlEGfEIl?= =?us-ascii?Q?X2wZTW9BkWlHwDm8KFNB3KHSmCCY2hIj7mijpj0pvLEJvCiMuF6VTA434etl?= =?us-ascii?Q?N/V4MT4hpBWxoayqWEPUN+8u0sPBGdftWuIW6ZqEfVjDO2OLZYR+xYRv12ua?= =?us-ascii?Q?ZikMFDfqPbs0Y2SEN+HkADhO70T/Vbqy37S6HKc5LCjZ8KTTHTfduwH6Oyuz?= =?us-ascii?Q?BmJ9xEiD5wnKW6UvWec+IpJDq3Dxin00qpPlqPQ5sNFXs6YXUq4nAJ4SdW/n?= =?us-ascii?Q?YaKt6FupFrJUIx6ZeNCZ9HjUXmQKmma+tS2lBcByuKfR428UQ2x88b9ZFScx?= =?us-ascii?Q?LTSivsy20/84b+M6h83OeyFYWZYPR037UiDgPq9l7VqMS9CSTtvi4Sf1VQb2?= =?us-ascii?Q?AdwCenpYnCZqWrq+m5kDeTxkT0M22TVbL7Wz6nMQzhV2Wwx8usgNTDaIcOs/?= =?us-ascii?Q?imn3ARucVjvX1mIIPeydoHA3gJ6R/SwOcWRzikXDuySAPxPRygrZdsLYON/L?= =?us-ascii?Q?+lzFx4D1QGLTA0NVTx0GplNCvp15bifQtmUfNDGKtAtNSIXc/d6VNx+0ji+V?= =?us-ascii?Q?BdLdHpsjkZMmcFRsGu0S93VnBSJVUaF9z0OBR4g0w23JEUZ8sc10VcPxhThO?= =?us-ascii?Q?WCRp/IBgwky1toQJyiC23di/CAB0oPeV3adMAZH5HUT83T8G0RvGmManVNGL?= =?us-ascii?Q?WLrdu+6BaBU9GzykiA5ZzsThxbAZIv6l9bYUEJ1v5k0xusqADzxXidqUO/QQ?= =?us-ascii?Q?hH3ZP0+daHf3pxHMO7A39kjB5vIG5MoBPx+Cr4rGPRlIWQMpAAz5rDr0bEx8?= =?us-ascii?Q?gfla5qZOOuUMq/NYVdXa2ZMXdeYpDOQxiWYYSsAWhj+WMBnjpzXLikvCUQ9c?= =?us-ascii?Q?9AbFdqzEKKHjp3kgFM5qgsSf5IUYaq1tUUgxV4xVVRPN1XqqxkhvMHIM7Vr8?= =?us-ascii?Q?mEQ8WXYkXE2GicwCuDL3wxSKPa2Z+SEBc3bg8APoD6H6zZfnto51memd9eUJ?= =?us-ascii?Q?QToO9l5RZKsLbOKlEAtivHYEUXc45rw4hJ4jIS4TaN88peErtZX3WgqDK+w3?= x-ms-exchange-antispam-messagedata-1: UjeIGqZubtJ60jbAVnnMIefmLQ2qOKW/vao= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5784.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f5b39611-2afe-450b-59ae-08da447e5b49 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jun 2022 09:57:51.4292 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: sDSOxOk/KRyLbEd/ysnFo+/N9BPE4dwRkjmHAPv0DRiY4TrA0cl2rgA5i4wBD61F+rI1dGwWsg2frHxjiMv7dFQF8g7HbmEPDxPFDk0BzdM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1327 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org +this time to dpdk.org , to test removal of automatic footer Hi Cristian, < snip > > > +++ b/lib/sched/rte_sched.h > > @@ -128,6 +128,8 @@ extern "C" { > > enum rte_sched_cman_mode { > > RTE_SCHED_CMAN_RED, /**< Random Early Detection (RED) */ > > RTE_SCHED_CMAN_PIE, /**< Proportional Integral Controller < snip > > Can you please explain why you need to add the new > RTE_SCHED_CMAN_NONE value to this enumeration and what is the ABI > breakage that you are trying to avoid? >=20 well, it was third value for cases when no RED or PIE is configured from co= nfig file Initially I have found this error: 1 data member change: type of 'rte_sched_cman_params* rte_sched_subport_params::cman_= params' changed: in pointed to type 'struct rte_sched_cman_params' at rte_sche= d.h:166:1: type size hasn't changed 1 data member change: type of 'rte_sched_cman_mode rte_sched_cman_params::cman_= mode' changed: type size hasn't changed 1 enumerator insertion: 'rte_sched_cman_mode::RTE_SCHED_CMAN_NONE' value '0' 2 enumerator changes: 'rte_sched_cman_mode::RTE_SCHED_CMAN_RED' from value = '0' to '1' at rte_sched.h:128:1 'rte_sched_cman_mode::RTE_SCHED_CMAN_PIE' from value = '1' to '2' at rte_sched.h:128:1 Error: ABI issue reported for 'abidiff --suppr devtools/libabigail.abignore= --no-added-syms=20 --headers-dir1 reference/usr/local/include --headers-dir2 install/usr/local= /include reference /dump/librte_sched.dump install/dump/librte_sched.dump' ABIDIFF_ABI_CHANGE, this change requires a review (abidiff flagged this as = a potential issue). Then I moved RTE_SCHED_CMAN_NONE to the end of existing enum, as advices. T= hat removed error above. In that moment, I needed quick fix for discussion about change for showing = approach. Not final fix. < snip > > The library expects the struct rte_sched_subport_params:: cman_params to > be NULL when the CMAN is disabled, why is this not enough to detect that > CMAN is disabled? I suggest to keep the current approach. Ok, I'll try to use NULL instead. Kind Regards, /Marcin