From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6C6A3A00C4; Mon, 30 May 2022 13:59:34 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 579DC42B89; Mon, 30 May 2022 13:59:34 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 0AE29400D6 for ; Mon, 30 May 2022 13:59:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653911972; x=1685447972; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version:content-transfer-encoding; bh=hwe1ZLFPDLld0sViUHI1Z3sYHimuoXSjMyhLlte7Zuw=; b=FzBf3alkjvuay5DsQNTSHWZgeXVWGWepQGiNrlbYg0h9qZJtgSK0byZn A23jJMA8SWzIvlElsEtYEDCO1Htstk4wnYuwfdny1kTKAMGGZ7Vi5ijkg 4A4tRtrxcAg6DO9O9UmMnEOgxj3CXWZbut5yIa/w2MAUWDkmboLnl6hbt qZ5snCBob8mBcKgj7mWPTFZaFTIyafWJyN2C9HtuPnto0R8exy4v5rFeG VBEHl+yu56jm81jNhfZmqfqmXgfzFqTeKF0hJ7bgYoEk2p3zQv8Ms7kD+ Z1rIfBAvi1DXiTQnQJNTGsSOvsNCk6u15E7EAtmMFUsCpwBZ69jRkZwIC A==; X-IronPort-AV: E=McAfee;i="6400,9594,10362"; a="255469375" X-IronPort-AV: E=Sophos;i="5.91,262,1647327600"; d="scan'208";a="255469375" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 May 2022 04:59:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,262,1647327600"; d="scan'208";a="719869146" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga001.fm.intel.com with ESMTP; 30 May 2022 04:59:30 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 30 May 2022 04:59:30 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Mon, 30 May 2022 04:59:30 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.168) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Mon, 30 May 2022 04:59:30 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RgFtvvx2J5AXZLzvvgqKJbVUXldjWIV0YcsPWk1Ov5XGdMWbl1GGrcfT97v6CKKfYHti8MKTjomWptFRPOQlcRM0tiAUC/1kYR0WQtBrJArxobEB69+6Z1Wyp887b9b4UazlHnSqKOFM7RljFC3sZ0BQ7Em2EGJrQIx/OJqckzAzvOufMzvj9XIh8MigFRD1OQeFkB4uRB2JsgCQO3PwbQp81QDG9PUO9egPS/9upWBySczEWyjphZF2UrU/PWbxJMfCoPyFXEV/jBQHuL5OEF1vaEWIwTM1NyOhvGJYP4/iXckYEXTJBm/h9nu9GZJHjT9BwFJ7WuScZ4jP6SHv4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NEGKhRAT2QyjnZRO+JFTb5fyDDz9b1AWoYCFw8VjuPk=; b=MoRNzW4InmbPUXwcWuaAE8QNA8biSfcacDUnpUfhH+Y4GSe3gtAO7ap1gKU+YjaSBA6a2pd6bU6va+ljMl/H2rIbRsF6Q3TJV1qApJ33dSZAshOzrPfVnwyqun+/88AxoLa0vBg5x8+xzUVYhxr7lv1Kq3BCl+DIBwEprPbCZxp7661rtlJFXLNYFJVp/cNSuAKZ5hYKc6fIwad6MSXfWvA/+w+uuT28zk8RWJCoEEWbg5L/jRq4rT4m4obvffaUyWC6cwHIHnSc2hT+5VPhcBcdf3g/nwX3myx2YFwzsXKGl9pKCSSBHadZeFL/t2bT/x39jZU2J8A7SXZHjyCU3A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5784.namprd11.prod.outlook.com (2603:10b6:510:129::22) by MN0PR11MB6256.namprd11.prod.outlook.com (2603:10b6:208:3c3::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.19; Mon, 30 May 2022 11:59:28 +0000 Received: from PH0PR11MB5784.namprd11.prod.outlook.com ([fe80::2de4:72f5:cf30:ba97]) by PH0PR11MB5784.namprd11.prod.outlook.com ([fe80::2de4:72f5:cf30:ba97%9]) with mapi id 15.20.5273.023; Mon, 30 May 2022 11:59:28 +0000 From: "Danilewicz, MarcinX" To: "Dumitrescu, Cristian" , "dev@dpdk.org" , "Singh, Jasvinder" CC: "Ajmera, Megha" , "Liu, Yu Y" Subject: RE: [PATCH v6] sched: enable traffic class oversubscription conditionally Thread-Topic: [PATCH v6] sched: enable traffic class oversubscription conditionally Thread-Index: AQHYdAGgMporU/PU1ESxr15HtPRuLq03OUOwgAAXF8A= Date: Mon, 30 May 2022 11:59:28 +0000 Message-ID: References: <20220527000900.795357-1-marcinx.danilewicz@intel.com> <20220530084520.827724-1-marcinx.danilewicz@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3331fce8-a54a-47d0-8049-08da4233d95c x-ms-traffictypediagnostic: MN0PR11MB6256:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: i0rc/SdXijhNimEzF1frG7CBA/7nS/Cqc9ap653YXGXLed7uXNQK9+8S67JSd7KqgR1h58tMJFO8efa6FgVrWNVhhamcVhHzrvGqY5E+aNgViuxKgBRtXc50CEcxTw7BMmEd1KEuN9ljlp3wM/1SxvT4eXCjR6/S790QU5eKTLJxpXPcJqpVInDWtG0lc5anpAaRCIkP6oZ0khOiq4Lvb+GGN9Yc9ImOLi02kRX2pNAY0fBvEeStYhwz0zyS/mJJ3FriqL14eXsGLfOfWRp5fSSyzsiFuo9emQqxKeCvHJMvjgrnyIZJjB7rj7OAYSSJjsqxpWdxWR48z2ORhVwJhz141FMFG61ik9SA9+zU7ph810AcEV0BbHFp9FPM8NPuyicQ2R41ETwzRnESog99L7VJ+d3n9FOh9/5q3EDYIyNWvpERPAFCwGglPlX3a2p2vUebjfEFnmL+ZCzElU0IOEP/bnyPWf2gDLe9ubB9fnVgcuBhKbMVICnP2SiMTt6z45nz+QdAccRKJqG2eZAZse4ZDW4tvUrEx0SZszWAd5Vr2bdQS2N8t+LvLbbSSCK6J/XImgISCUDEGs4lk5u29p9YZNxxDW0REHb88G8BQGxpTSGYV10a6H9+kqWjrP/rWEITH/DLePbmSZXQp1c4dHRlCjHz+j3SBH1895I7sk7EAiTRYQkND7dGqQmYnkHJ+cAiDFLLT9fC/9AfUBFM2A== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5784.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(66946007)(5660300002)(4326008)(8676002)(64756008)(66446008)(66476007)(66556008)(33656002)(76116006)(71200400001)(508600001)(186003)(83380400001)(107886003)(8936002)(55016003)(86362001)(9686003)(52536014)(122000001)(38100700002)(38070700005)(82960400001)(4744005)(6506007)(7696005)(54906003)(2906002)(6636002)(110136005)(316002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 2 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?IxxylXaSH0U2YO9WdXCaK/yCCWzzEMMmxSHa/XGM2H5hrOtSOCZDDTVvG0q5?= =?us-ascii?Q?6CatbjxFS2hNPcuyDKzZeqzTBTLxDA3cB8L+PpvRWO1XWwPYIsrEf71qLuLQ?= =?us-ascii?Q?p7w6Qcpx1Oxg0wWna/QbgX2hpPGoZPsYxsTSQVpMeOvkFJpBXBHgRKuri9cD?= =?us-ascii?Q?dVqnWUxE/mR7Tq44QOuX+G7B2/oWYXXRR3do/OOL+4TJDiFm4CXTSkLyvKuw?= =?us-ascii?Q?XTly1vGSfh7MrLFDi9Tgb8nFqUijY9PR3i7nGYaQkrNgCC5hrzkGFU0/jF6r?= =?us-ascii?Q?DClWXo4UX7SnvBi6wJc1OoA25YVAzb43R7QkJsvkLIFLKiw6SXGzWuvJ98Cy?= =?us-ascii?Q?DTb8olhQEzHW2+fXzS1xY0tijkFRW1Om540Qy3gfA+bxNTJe8EC1A1eKDErI?= =?us-ascii?Q?MUknxyMUMMukITbsp2rTthEJJ+QXd92XOmiSICFlXvfBsNZkmxDFZ+sKxD51?= =?us-ascii?Q?kq8w6ZeBfXTQtuMJupTiLeyo4iado3wAOA39mbPsVOvFyubk0x3Q2ZvBbCKb?= =?us-ascii?Q?sAzaT2SP8HoDWDAPisB3plfEnZl10mmdrAUKrAHrFBGI4m2vYbgZWEg62VfV?= =?us-ascii?Q?AqKrJ8BbjtTD9nDhvw8M+PMCjuwKEKZqFTjFQDMX+DayYVOxlw/4G0shVwen?= =?us-ascii?Q?NbC2N33wOliWsdzdkiTPBJJ+vw56XWhlYeGLfGoV7C6IkrDuP/EIBOl23zlW?= =?us-ascii?Q?kyVkf8NK6Np4IdE1+k7KDoLNbAPHkO3sTxAfYLNlnZsfa7vkBXGsqF9zA8kY?= =?us-ascii?Q?UBZZVcXHgvTLT/Z2HjP/w6rv8h26ypETAn7TqNgRPaRPNvNjCa9rt5ZUHc7/?= =?us-ascii?Q?rsbrnP5KQvpwHG+AJOARbePEPrkd5D+dE6LaAy+9IiRr9Hvd1wwUlaewAnKN?= =?us-ascii?Q?im1iTnDVd+NMj21wUK9yAoPAgCWuL4xN6OSiUOu+91u+/IAdH9n3bsMr0Bwm?= =?us-ascii?Q?+paKwdwA4gDLziNGLKFarMkJ9mKbCTamSORPjm9WKutz5Y67ZVk6aSECpJBb?= =?us-ascii?Q?/tPKeH9BH3vf36HW9ct5j0TRqwgXOXhqgAX0go8912hNEsxI9DE8tYKgl/Ac?= =?us-ascii?Q?RkdaVIBkLxNqZRHngjGDDInmN+LDDJhcjsk9d3jUXcKx9YoyoN0ISPxEazfq?= =?us-ascii?Q?4w7O2KanfBHlYrZmawuytxkHVRzeVz9uLcrKabfJCUhTjMzqoPRH0Gl6+a0t?= =?us-ascii?Q?18noGvsL/ZXgRoFKiO+QxSyGpAKZAfTvGm9aYjbLjQttyKrGoub1oTbeLNCP?= =?us-ascii?Q?OCAjbsz03kyizq8+1aORwpgLWQs+vEzOKkCp6t1OOMdfajelLE8Vj7Z2nhho?= =?us-ascii?Q?Hw99OCBq3IryU19DFAmmZo0slx9eZnhPpNhxjEneRUB8HDb06oFIvTAhKMD2?= =?us-ascii?Q?sPoJbaPW50A/nMG6qVb+j8LVD4kH5SFGmJ5IUDEoiHdo2NBHxRL4m1R6DqEV?= =?us-ascii?Q?knn3rHbwWfqpY7VsXPY7+HdTWcWfJtu4ofXBUZIXHWBjvzwctS1w0UGA8wgW?= =?us-ascii?Q?kW74l89MvVqG/2/nCmMeB4JC1FTPl2nV0TIwD3mXiYoB5iA4Mf0GEXmJG00l?= =?us-ascii?Q?zQmccrI4sryiE3ynttCtta9nRbNvmySJsuo93QefcUs2etcMHaaMwcdMalni?= =?us-ascii?Q?SEegEmQlx3+RmBPibioFGah4OU3NUbspjN+6z+x6wayGGNvS8/YD6M/WTETy?= =?us-ascii?Q?ZQe2T+soA5SmMqixgOn5i9UFiYLRaRzh5oXPZuZKNVpSfxiCe9HKOOoAdm8D?= =?us-ascii?Q?nHWBZqRkAq/Zg/LF/HSwgyJESDTjZrWxEE5h7CZK/kHxeos7E+Hdr62keT1G?= x-ms-exchange-antispam-messagedata-1: Hd73pKW9qOUbSzzZ160dpTw0UJyXAiVNzpc= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5784.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3331fce8-a54a-47d0-8049-08da4233d95c X-MS-Exchange-CrossTenant-originalarrivaltime: 30 May 2022 11:59:28.3204 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: H7Nukn6e1Yg4CHn54mzi/9tdH6mihhcnccYLvZn61QvQqD6pTFziFrQt0ZksNErvpJY+FkC9zaGSmHjfTy63gdZ2z44CUKHtL6aCV745Qfg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB6256 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Cristian, Thank you for comments. Please find my response inline. > > Signed-off-by: Marcin Danilewicz > > --- > > lib/sched/rte_sched.c | 96 > > +++++++++++++++++++++++++++++++++++++++++-- > > 1 file changed, 93 insertions(+), 3 deletions(-) > > > This latest version of your patch only contains changes in rte_sched.c fi= le. > Since there is no new API in rte_sched.h, how are you going to configure = the > traffic class oversubscription feature? > = I agree, that's my omission reviewing my changes. BR, /Marcin -------------------------------------------------------------- Intel Research and Development Ireland Limited Registered in Ireland Registered Office: Collinstown Industrial Park, Leixlip, County Kildare Registered Number: 308263 This e-mail and any attachments may contain confidential material for the s= ole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact = the sender and delete all copies.