RE: [PATCH v2] sched: enable CMAN at runtime

["Danilewicz, MarcinX" <marcinx.danilewicz@intel.com>]

Hi Cristian,

Please find answers inline.

<snip>

> > Log: v2 change in rte_sched.h to avoid ABI breakage.

<snip>

Lessons learned, so I have fixed also positioning of this above.

<snip>

 
> > diff --git a/lib/sched/rte_sched.c b/lib/sched/rte_sched.c index
> > ec74bee939..db14934832 100644
> > --- a/lib/sched/rte_sched.c
> > +++ b/lib/sched/rte_sched.c
> 

<snip>

 
> Same comment here: yes, remove the #ifdef ... #endif, but no need to
> change this code fragment, as it sets correctly the s->cman_enabled flag,
> which is then the only flag used by the rest of the code. Again, no need to
> have a CMAN_NONE in the enumeration, as the same is achieved by setting
> params->cman_params to NULL.

Yes, with that approach this is better.

<snip>

> >  	qe->stats.n_pkts_dropped += 1;
> >  	qe->stats.n_bytes_dropped += pkt_len; -#ifdef RTE_SCHED_CMAN
> >  	if (subport->cman_enabled)
> >  		qe->stats.n_pkts_cman_dropped += n_pkts_cman_dropped;
> -#endif  }
> 
> Please don't forget to remove the __rte_unused attribute for the
> n_pkts_cman_dropped in the function parameters, right?

Nice spot. Looks like this was there for some time.

Regards,
Marcin