From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 54AC0A0540; Mon, 30 May 2022 16:03:39 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 450F340694; Mon, 30 May 2022 16:03:39 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 03AE2400D6 for ; Mon, 30 May 2022 16:03:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653919417; x=1685455417; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version:content-transfer-encoding; bh=LgZPmte/cv6XC4WWjncoARHKkzA5eovryEl7JeeOWf8=; b=VtKRZfCqOEzoFvxxzjQY1/hWm+P/CjWugDU7yUrV+MroylFRuPRT1D3F jAQo73iJvE7HPzrOxbr1EgxVeVYbvey/+ry7xiayBaj/q8sLWfF66lO79 +3oRA/b0g0qUdJodBpI9ms0Ynq0wiYzKLaeFi4e5V0oaqiPc3w8aaZaBn yJ4S2AXVB4q1wK1ZXei626LWvqyByKQQ0txFeFG64acdVUIXWPQFFTyTW AUnSRZmXeZ/wAIkoRBjfrnEA0idCEhLDeyjgQ0YRd/l1OeWSDx58Gbh6Y 27zBz/LL7layYoIvCwb5LAEvIH4z339yUnprAWm+N9q6oDhVOtC5THfcI Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10363"; a="338046358" X-IronPort-AV: E=Sophos;i="5.91,263,1647327600"; d="scan'208";a="338046358" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 May 2022 07:03:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,263,1647327600"; d="scan'208";a="561936026" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga002.jf.intel.com with ESMTP; 30 May 2022 07:03:35 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 30 May 2022 07:03:35 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Mon, 30 May 2022 07:03:35 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.170) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Mon, 30 May 2022 07:03:35 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OjZElVZkflmFmCE+fz1X2MbSL5stYPyDu3Tsuvcer2F+vkQZwzOIOUT6jhPAQQ79Z9qCji1VthY2Y/olbwP8b/mTJBoWnqMrLXjye0Cxn2Hg/udWUxU3tYMzLlomlmjfYLqtRaAhslpHpspdRNxZHrVho0/RsmWE+8x1/YwXf0t+i9Pf2wLgQh3iJ/WKRMMNX9onXBvyVbPzwzW1ewg73wS5E3u1TvJbftG1+XprBLEI0C3ZrkjVLBWvKR2ijl3s1c/WQJxskgvoQgx2ifxejspS5hdw0l+lOJksrK+iIHu61OHtUFsOL6ISa74ygoGyt+HjpO1ayFqwtGGJOp5Ezw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fbxPHEZpruKrNg1vvVrI52RU3mjvInHyB6Svz5ww2uw=; b=lfw/nQsjh6zQ7XhLn7LfwwzbNRrfSEjPe6zrLKSLubhF+y6LATmyRDGWojB7M2o14TcutfT5Iu9l7d5gckmprg3FukOu7Ccjkyi8q59tBiacZHIWwgpNJG8lOQUqvmvYszioTAYWfiXZRUx0AeKIXucPMrsbI4MjnEpnwws7i88S6c9Q2oWO2roYYpA0u6p8Asl3NP1HLsN+uPvElJuOLtFKkle4cAjRekX7G98V6XxFl3f/3Sw5ZJoehXTrjFxg/+ddDR9C7lHSf9fc98cR3s/5LrN5WbJ/ZUjy1+WXtFR9nFG+kThRc99zKQPi6GV+LCcp0oyt+ZrfJv0dzZxbyg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5784.namprd11.prod.outlook.com (2603:10b6:510:129::22) by DM5PR11MB1996.namprd11.prod.outlook.com (2603:10b6:3:13::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.18; Mon, 30 May 2022 14:03:30 +0000 Received: from PH0PR11MB5784.namprd11.prod.outlook.com ([fe80::2de4:72f5:cf30:ba97]) by PH0PR11MB5784.namprd11.prod.outlook.com ([fe80::2de4:72f5:cf30:ba97%9]) with mapi id 15.20.5273.023; Mon, 30 May 2022 14:03:30 +0000 From: "Danilewicz, MarcinX" To: "Dumitrescu, Cristian" , "dev@dpdk.org" , "Singh, Jasvinder" CC: "Ajmera, Megha" Subject: RE: [PATCH v2] sched: enable CMAN at runtime Thread-Topic: [PATCH v2] sched: enable CMAN at runtime Thread-Index: AQHYZgGyjgFuks/050iPI+ktClNfX603YKGggAAseBA= Date: Mon, 30 May 2022 14:03:30 +0000 Message-ID: References: <20220511135304.258809-1-marcinx.danilewicz@intel.com> <20220512131036.507178-1-marcinx.danilewicz@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9b5fa2f5-6fc1-4049-983d-08da42452cf4 x-ms-traffictypediagnostic: DM5PR11MB1996:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ICT+Hqw2B1d6H1d2kG31wOTgrozxh+APqb+8QXwZejK5oifk68uuMB1bEY8+GfPFg56i33YkiAsmKs2kqnVTKRw4QbVy4myY8bi2wfktenfAwjCQ3L+8eZyj/ivEQgqBeSmJhZqTjzIGwLx5CL8j87fWfles18UTXvpv+gEsmnirrmw738uPMpoCAmPxEMylHza0C4llRIdpI8/5+5THSUkVGDdPechNW/5w3hzEhGWGtk8ewYEluVcSiYHbsBHZU65+aN2VZBB049MjdTNpw6/GuQcDscB+fGvHfC0i8oVRtaB8rFJUZQSkDZcP8GdCeW4FCUjXqrdmjcpwSx/cBAAfULD5h2ObMpId+RHAVErfEMVekbjdxmFKG5iIFHsdV9481Rhu1Ol22Qhadu2MTFthVtCkYNJfJHlWWWAKPHCDSsNx1I2MSRfrg2H3oG787O0zUQB/EV3wpaGgQwbBjEfs9nZnWYStaShzNQtbTTRvBVX22IevFkEomD0G82M9KAF04JOcTsSLuXEfTcHlJOr48IA1wn/5SV+ZEjiN2u0lZ1h8l5Ba52weOlfWahOaPvvqxEEEM6RGAdk8RUWAANX7bQ673kQ38L3DD+qLyQsJclq8SCbquyWO0OQscHHEQbNBIWsIqRgo8Llt+7d9IEtNWD/WaeImWQsDVb4SY9zRjYRv5ugjxEEhsJR5gIiMsH9lnUkaOODeg1PIQeWERw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5784.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(38070700005)(122000001)(86362001)(83380400001)(508600001)(76116006)(110136005)(82960400001)(66556008)(66476007)(8676002)(66446008)(64756008)(316002)(71200400001)(4326008)(66946007)(55016003)(6636002)(6506007)(52536014)(7696005)(5660300002)(33656002)(186003)(107886003)(38100700002)(8936002)(9686003)(26005)(2906002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?EXuJpMmDW8qETNDJnqN0tfJBdyAvgjVlukNkjqpA8PA1LZWuCq8jKoqgBcnG?= =?us-ascii?Q?e4C1wWaK78NJ7ubZwRFyHjGbeICHNP3pNTghWgMgcTpzYBkQKlVDjs+PWy1l?= =?us-ascii?Q?CJqwYu/yvHd/CD96Zgb8mxADU+M5uSTuIvrcZl8xg1Y9+SEOziFHjecakSVE?= =?us-ascii?Q?wZ+rafqa1jXMFlRqtIuU026S3ecK8zTGHOBlSkzJOnCugUzZ2xrpkZK96WRn?= =?us-ascii?Q?Y3/CPFjYQX7/PqdZHoiQNfuHqKRdvhD9E/3Ld9CYJD+S0viqRCsiYtF/mC/H?= =?us-ascii?Q?MHM/YIwf897UieyidqR282Dp6rykXBowy2OhoYSH9Vogb5NmScqFlxp69SWE?= =?us-ascii?Q?EJkkRWdouTQiPxppDcpL6InfJXNRZt2pK320eBH9QMyCDTvzjTDvJvHK4weP?= =?us-ascii?Q?Q8sxoFYxiCuJobKhc8cWdjOqbXYZj7tRUgwQYJwO9bEw1BveEFOz57nisUCK?= =?us-ascii?Q?7UmogD4rBhEWS0XWY87Id8davafrB90kpDVZo+vMUZpMoRh8GR6kdDg/C3qy?= =?us-ascii?Q?3hrqt9W+2FIOwS4t0RO4UjEcJcI4MxfvA4gU/L4PxU7CmdDqIaQIURDvzzne?= =?us-ascii?Q?v1H2LMXbiF8OK25yWH/ViblRdhv5MLra8UfGNSqj4oCvnBlDAVTf+9x1FRhv?= =?us-ascii?Q?E66nmRD1Rpf6o90Z/oChHpmBYNfgNnjEG79KpqTlFCbdoi6ICTkIpRqejfKT?= =?us-ascii?Q?26NEvaCcnlSA/H3DYQ2xl5Aq+tQ/02gklFL04isPyuRY9t3sG1M57pRSR/ON?= =?us-ascii?Q?jDUE1iOpEahC/rFkZgfhGWHrVnRVWWTIyBhINRYpf35F6zXMbZ2EEeoRtrb5?= =?us-ascii?Q?aTOjSx7VczhGw+n3ZwCmnCAj9dmXVTY2MMcHvHPLuS7GcgxvYn3w6CV3sfyo?= =?us-ascii?Q?4luXl52DIQXxv/omAvnbklQFhGiVLiqMI9Yvr4hmmKN/rKfpM49UFiHPfXFa?= =?us-ascii?Q?FzU5DdhmRdPwF6n5IKmzyotqqCGYLQXBcjfww150A4Ne+snuS2Vfice2zVCh?= =?us-ascii?Q?HFGqD1ZtGTmghPXsiRRgd01m+hP1gaPedWohoijavlZzwR1o4kW/0y2TSV04?= =?us-ascii?Q?dAtjR4DOy7/xs+9R5dutEI0sqruL9x+AvXAESAC+mT1faM5so8Zr4c5zKl1m?= =?us-ascii?Q?8RPzMUWDOYvXvwmTiU001rV0QAzf3YaSGJzzib1BDoWsVnNJIJvesaFvBSE6?= =?us-ascii?Q?hR4FGzRNDlJxo/ambJKuisWcfLoD/s1LHKySRpRB2OZtzjn6O2uOd5JSMHQK?= =?us-ascii?Q?Dj4F0P2AXDZb1kMVfRZT5d4siBww5fMxid6t3bs4BrBA3VfwPbWWCTSJzokq?= =?us-ascii?Q?dJOp20Hxu8M4j5t4ObdGv7fD6VPb/F0dhZJeHgCA8S/4P7EjVrWuJ4Bnmy8Q?= =?us-ascii?Q?0XmZyc/yS9cZzySuEqj7Ev/MM2xLow6BMwf3saI+x9rhwMFtF13WlWTojF/W?= =?us-ascii?Q?QFlsyaa+PsOf9k4J5J1UgtpAgklHEOmXOOzGTptUM2htfZ4EqabouRlnUzaE?= =?us-ascii?Q?6pbe124LKYRS4AfOGSY7iv92Wm143jc2oUoOZPCyIJ6COoquaUVocd2XLYU+?= =?us-ascii?Q?+q0bQiffbKZZNAJFL23iwtoynGf20CxojFjcA3XxEcd32WYjHWs9CadT4Hr8?= =?us-ascii?Q?ZJqZsXz7NRJ1/gpNS1+mgq8Z9+YjIHo8szTqaFDBXY972pqc8x4/stisdoxy?= =?us-ascii?Q?Ppo5f1zFjpAljAvTEJS9RAV/tpNGCxa+BrOa1C5Q7UM1CTBhd79ABmNzTxgw?= =?us-ascii?Q?A1SG9oiKvF/3UkQ7wHeiktCHGPl5/Nc=3D?= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5784.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9b5fa2f5-6fc1-4049-983d-08da42452cf4 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 May 2022 14:03:30.0281 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: KOlytnNcys3CVbIL5Ehn9weutEo72fGe9OZbCZ+vnhF5Hc3PQu0JlwuusVa+gzMZ/TbDALOvcDpVTKBQldev2RTxVH9E9b/5do3awzvPzds= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1996 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Cristian, = > Can you please explain why you need to add the new > RTE_SCHED_CMAN_NONE value to this enumeration and what is the ABI > breakage that you are trying to avoid? > = > The library expects the struct rte_sched_subport_params:: cman_params to > be NULL when the CMAN is disabled, why is this not enough to detect that > CMAN is disabled? I suggest to keep the current approach. Well, that above was just another approach. I'll have look to follow your a= dvice, because there should be a third case when no RED or PIR config was f= ound in files. = So I used third enum to detect this case, like here: > + else if (params->cman_params->cman_mode =3D=3D > RTE_SCHED_CMAN_NONE) > + return 1; Also I got this advice to move RTE_SCHED_CMAN_NONE to the bottom to remove = ABI warnings, because structure in header file has changed without change i= n map files (?) for that? Here is some more detailed log with errors: 1 data member change: type of 'rte_sched_cman_params* rte_sched_subport_params::cman_= params' changed: in pointed to type 'struct rte_sched_cman_params' at rte_sche= d.h:166:1: type size hasn't changed 1 data member change: type of 'rte_sched_cman_mode rte_sched_cman_params::cman_= mode' changed: type size hasn't changed 1 enumerator insertion: 'rte_sched_cman_mode::RTE_SCHED_CMAN_NONE' value '0' 2 enumerator changes: 'rte_sched_cman_mode::RTE_SCHED_CMAN_RED' from value = '0' to '1' at rte_sched.h:128:1 'rte_sched_cman_mode::RTE_SCHED_CMAN_PIE' from value = '1' to '2' at rte_sched.h:128:1 Error: ABI issue reported for 'abidiff --suppr devtools/libabigail.abignore= --no-added-syms --headers-dir1 reference/usr/local/include --headers-dir2 = install/usr/local/include reference/dump/librte_sched.dump install/dump/lib= rte_sched.dump' ABIDIFF_ABI_CHANGE, this change requires a review (abidiff flagged this as = a potential issue). Kind Regards, /Marcin -------------------------------------------------------------- Intel Research and Development Ireland Limited Registered in Ireland Registered Office: Collinstown Industrial Park, Leixlip, County Kildare Registered Number: 308263 This e-mail and any attachments may contain confidential material for the s= ole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact = the sender and delete all copies.