From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 47662A00C5; Mon, 19 Dec 2022 06:56:44 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2AFA140698; Mon, 19 Dec 2022 06:56:44 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id DABB840695 for ; Mon, 19 Dec 2022 06:56:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1671429402; x=1702965402; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=KM3GKVgL0gFYlPv26edhQMjR75a+UfN70IacTetms5g=; b=l+YkQalkzW/WqflMiSxJVyqiZbHM8dVbnlXxwViHW/3yALupBg8X982n rXny3OYRpQfnqNZu5mDxQKYCV/KUPiv89u0HAvtQw9j147vyJEue0axNQ FbFyWD3TP021RudorH4YkiViEuRfKAiWH1yofeK2N6h9k7SDTKOTQrNKO qZiY+8U8nze1dpVSSV4jm5yXLaxD4qxptdYPcqIBvw0FstdjwXyXHaaJe 4BVebzK67WzMsYhg45PmW7YkV9KEkULE5JjZZ91XkQPNSCneVnB+6Ma9u ev+0oRPvVo98H2WenSiStkOO8TSc7RZjSdnWqdKbwiV+E3n657euLZQsN w==; X-IronPort-AV: E=McAfee;i="6500,9779,10565"; a="302700968" X-IronPort-AV: E=Sophos;i="5.96,255,1665471600"; d="scan'208";a="302700968" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Dec 2022 21:56:41 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10565"; a="650440568" X-IronPort-AV: E=Sophos;i="5.96,255,1665471600"; d="scan'208";a="650440568" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga002.jf.intel.com with ESMTP; 18 Dec 2022 21:56:40 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Sun, 18 Dec 2022 21:56:40 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Sun, 18 Dec 2022 21:56:40 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Sun, 18 Dec 2022 21:56:40 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.108) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Sun, 18 Dec 2022 21:56:39 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jh1Y6bkPuZIuLMmX64ZqIAkWt/suD9BAIkkYEpdAxwqM6GuGoZeCz200yWD3Nh0x4Z/IfeVnWc/wmzBimkPSPkTEFalLKi8LAN6ymzO2cTjaqRVrNYUC+ZDmxa85w2+kzj/VmunfAiQdmQ0yA9/0IUHqSaBbzNH0mfhvYWMDRVF9r2ghEun/BAls8mjHhZfdSQHIZGhSKpoR51Yw+UWRQmexmwd1gJ6WQ5ZljSNs1IoLmWWL4igJz9ttbWCIzXCvkKJVJ/Q5rnoB3F+RjK0TL66oTNqb2wOuDOj1rw9h/RLUADlI3CQGqxeUJYm1dClL5mChctGPhjNByg1TmV3NOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iAr94GuQXuwE13ZFqlFVZin8Wlj0mvHU/Ac5GPKoGVY=; b=aIJ4GDU74rVi/Aau4lzjCzdGmUV4s5+GwpnCM54+DC3WAL3nLOC9B28kYiqM2KnrAMgZrz+l4wzczO9fV8/87r09mWpg0vKX0HdjheDQKUATPf+vttCqbCvBlhezKRZT8eRpSzpIO8HKcdnITQ3cwsnwxaz5Y/ajEjwHBz6pCGH0WuICdDehBSKb/b/ASvH3KHGiOAYdsQS61GEYeapEfoGCiEUf4nx/IcR4gzS4PsCDSYSdY86Q6n28v2hCqNqIc3B9cUnTX4aQPrKrCILZkIMtsZnQMdjbJN6u7Xl0/DazOsKD+wv3Yos/6lXu35McAmkW1UWNWOF7UK3qJr/gwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5832.namprd11.prod.outlook.com (2603:10b6:510:141::7) by DS7PR11MB6016.namprd11.prod.outlook.com (2603:10b6:8:75::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.16; Mon, 19 Dec 2022 05:56:38 +0000 Received: from PH0PR11MB5832.namprd11.prod.outlook.com ([fe80::ef44:2061:3d86:6b21]) by PH0PR11MB5832.namprd11.prod.outlook.com ([fe80::ef44:2061:3d86:6b21%9]) with mapi id 15.20.5924.016; Mon, 19 Dec 2022 05:56:38 +0000 From: "Gujjar, Abhinandan S" To: "Naga Harish K, S V" , "jerinj@marvell.com" , "Carrillo, Erik G" CC: "dev@dpdk.org" , "Jayatheerthan, Jay" Subject: RE: [PATCH v3 4/4] eventdev/timer: change eventdev reconfig logic Thread-Topic: [PATCH v3 4/4] eventdev/timer: change eventdev reconfig logic Thread-Index: AQHZE2tuODkY3p32n02ByD16I2KprK50tJhA Date: Mon, 19 Dec 2022 05:56:37 +0000 Message-ID: References: <20221214070440.921488-1-s.v.naga.harish.k@intel.com> <20221219053315.2538180-1-s.v.naga.harish.k@intel.com> <20221219053315.2538180-4-s.v.naga.harish.k@intel.com> In-Reply-To: <20221219053315.2538180-4-s.v.naga.harish.k@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB5832:EE_|DS7PR11MB6016:EE_ x-ms-office365-filtering-correlation-id: d89adbd1-9b81-4d4f-e06a-08dae185cb11 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 2uySNu7fHvlLAiw/DZmLLnU7MY3Mzc3FIRMwGkalfHm5X8qDRck9ZCGnZnuWXseMQW5oAdUaiCzMc0kqrCRbbXS8vCSyP2FIogh71HmGj0S0cTzz+oyTwZKOsYRVrP3udWZF8+gy1zwHIx+EFOxKs6fWXXLVkUYOYhm592kJu582rgcpi2i1z3j9hud2taQ0gD+E1atEQrlIgoMHQXt5Z8RAhEuIcgFBeUOa7mCKMwyDUVUsINxsOs1x27cjwTxj17PF1DV7wZS0nws9Z2NsDTUCE38rc9XKlnZAe4q5Iix1lgK5ZFjfttHX8PVAXrcWFiERh7t2OJwqz3eqx+Ad5kwqIL3wJN+2Uq+O73fpInp5YsvfWgWUtr9x5w0gDLG+5E8aR2SVl3CGUhe/vbi8DQzuGNNAop50yzbXCT4UO6y8IYn47NiYPUSmkmTRR6wQ9LQG8JaJN6id4gTIxLjPpztL751u4QouVEZ7TFdb0HhWA03MqDn+DCXIVyFNXUDX0PsR7Z0Z8e45r4XNN71n5Idi2BiuAQ/CcM7JqnAhEf1dkmyHwVBa28DZKBWr7c1nrePiaUOExgeReGUU0CSEwdFzqKNwPm4X8MAmr1ILzkqC1wEyBBj7THJfbmk1wX2bKKwPyHFPYyItp/G1frdJUoW10lOqD9wo2ae0YN4w4I31zQscSKscNV/B37ODNkJKR98bk4kjriywQ6fHBasj/A== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5832.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(346002)(376002)(366004)(396003)(136003)(39860400002)(451199015)(8676002)(5660300002)(4326008)(110136005)(54906003)(52536014)(6636002)(76116006)(66556008)(66946007)(2906002)(66446008)(64756008)(66476007)(71200400001)(478600001)(6506007)(9686003)(186003)(107886003)(26005)(41300700001)(7696005)(53546011)(55236004)(86362001)(55016003)(83380400001)(82960400001)(38070700005)(8936002)(316002)(38100700002)(33656002)(122000001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?0bP6mCThsLquNEISH49TZqxZr6RcxlF7+7FZdaYfIxYIBSSslS9nqseZwoAu?= =?us-ascii?Q?XNh8OdPvDVRV6jIz53a2CeQWp3WVsg16/z4lXYkS5limcLO0FnWkp7/wJ0Mq?= =?us-ascii?Q?QJpYKBd3ymfyWR0O07BHJzoiZ5wfxZxjQtBuTbZ9Yetk3UAvD1XxOOSfnokX?= =?us-ascii?Q?7kfqNcxLCyhuDpQJ9Ay83IeiXlxdPX/KAZiaDfaBkKzjLtr/nciMLZr4dHdm?= =?us-ascii?Q?JD+52F0CIudyboZXfoezfr2qk7DZbtkV2Kj8Au/Kz6vq+/4SOPMgzXpUINCB?= =?us-ascii?Q?j9xDc2wmpnd/U4rqMgujB6Fi9BQ0mccmWUW17Sq7qUgYnRiE3H54ulGD6nUv?= =?us-ascii?Q?nveW3mFvgX6AKvjOm1OH564hpTUa7r2esCCZo0phFgG1PHWBoH95FEys5X88?= =?us-ascii?Q?Y5aEBqADH038FEGrgRRq6SClllAni4BndKtC+S+td2XaXsVxoW0J9K0s8w78?= =?us-ascii?Q?9/eAwh4/cbIJcNeqKZ8H1aPWcWlIn079dy9lZ0DCU2SJfnwXgIAYqVG3erhF?= =?us-ascii?Q?LDOlbcST+alHNSkQ6E9AOjiXSVGI9985mZKmNG1lshz8Nnl1189rVzPAZEqJ?= =?us-ascii?Q?zYVjxbhaKovB8+Q6I0epH4Upd3XIly/na4gs4Q1VqERh63PSpPBW0/ivuMUX?= =?us-ascii?Q?QHiEb0bPW+CMR4YXo5yP2OeRqpnXokiOYdxgPgcJFnw2MuFwnuie7sZtJAeF?= =?us-ascii?Q?OEpKCDLOS8xG6HMsUMQXkqyvJlJZ1Mi2BseAmtAFa/KdhPX9tbMl5UnhKLbA?= =?us-ascii?Q?r1nZx//jJJFgN4X7eNcBt6mMBwNChnGGmJnBDINLwT7KaoHNacKZobxQJZae?= =?us-ascii?Q?fqJ1tMUWamxsaVbr6XCHH+BEk/WXPkFiJ3pPmc32l1lfk8Mcx4wUTEoa4YCT?= =?us-ascii?Q?j95KATa9xrs02nSCINydV1E319gulbLyACZmn6SBtB9G/0qxg5lO217IUZ+F?= =?us-ascii?Q?nz1Qx/ccMqIXkjZtdbOWQUqI+LwRndzHPKcPFPTjcJuVCUMMcEp5WR+mlRT7?= =?us-ascii?Q?d64BUCh+UnPCw/RU/6QrlQuiXHwHgldN3ej8PKVFJewJ4l9AgpRW9ld9fbmf?= =?us-ascii?Q?OnnUgvwbABsoYYETVsHUiXaJh4ZkmXIqItPtU6sJE1XRkDRBvpl5gWVkjpLF?= =?us-ascii?Q?FYMitBulv0ooYMeWSiXx6I7idb6jobQ6w9HEwkPEiI76wKFAGYgI5QuHbAh5?= =?us-ascii?Q?aOM5QunZ54C+xZ2PqRnhpV9QXTLgiAGtdLgCOEvCHb8amNq61dH0Is/ADOv3?= =?us-ascii?Q?TwqE+qNBJysw0LQB/k0AmPOqoWITBdEZ5bP0pkgVx1IZ77NYlwIqzGpeg1ir?= =?us-ascii?Q?y/fP4KAbkkIDBBGUeGRPlZV8MX9lzdwnHoejTceIzL15W8/MIUvepr1IPhTN?= =?us-ascii?Q?BHAIUhD5wjVBUJLcSuz/e75ZZuC8XNhB05gQf/y/iyT7mb9P5301PMh4h69r?= =?us-ascii?Q?huRs+ShQQ9XpOn9SJHwlP5HbjDG9fHWgOZr5xm0aveto4IH9FakOQqWeUeR+?= =?us-ascii?Q?THnm5ef8AQLB+i3nsv8nETGpV7uAJWL65VscaRw2wC0aVVzF/c2JxVynqSPH?= =?us-ascii?Q?ckSKA2gXAgeWxI589um2IqHYBo9HNtNBHDPwgK7qUOWOUKUmODu8VNa1XXqw?= =?us-ascii?Q?yw=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5832.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d89adbd1-9b81-4d4f-e06a-08dae185cb11 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Dec 2022 05:56:38.0036 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: k3SqM0KGzK0OFlyxKuzmWkAC8l3q9roVuPch8j+6sUUs5uJRB38qRb6/ayU0NSLVpapDyOCzTEI6BpdkNj9Hz7epnK6xq1zkBzp3U8jLjTs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB6016 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Naga Harish K, S V > Sent: Monday, December 19, 2022 11:03 AM > To: jerinj@marvell.com; Carrillo, Erik G ; Guj= jar, > Abhinandan S > Cc: dev@dpdk.org; Jayatheerthan, Jay > Subject: [PATCH v3 4/4] eventdev/timer: change eventdev reconfig logic >=20 > When rte_event_timer_adapter_create() is used for creating adapter instan= ce, > eventdev is reconfigured with additional > ``rte_event_dev_config::nb_event_ports`` parameter. >=20 > This eventdev reconfig logic is enhanced to increment the > ``rte_event_dev_config::nb_single_link_event_port_queues`` > parameter if the adapter event port config is of type > ``RTE_EVENT_PORT_CFG_SINGLE_LINK``. >=20 > With this change the application is no longer need to configure the event= dev > with ``rte_event_dev_config::nb_single_link_event_port_queues`` > parameter required for timer adapter when the adapter is created using ab= ove > mentioned api. >=20 > Signed-off-by: Naga Harish K S V > --- > v2: > * fix build error in documentation > v3: > * update doxygen > --- > --- > doc/guides/prog_guide/event_timer_adapter.rst | 17 ++++++++++++++ > lib/eventdev/rte_event_timer_adapter.c | 23 +++++++++++-------- > lib/eventdev/rte_event_timer_adapter.h | 13 +++++++++++ > 3 files changed, 43 insertions(+), 10 deletions(-) >=20 > diff --git a/doc/guides/prog_guide/event_timer_adapter.rst > b/doc/guides/prog_guide/event_timer_adapter.rst > index d7307a29bb..3dc7144798 100644 > --- a/doc/guides/prog_guide/event_timer_adapter.rst > +++ b/doc/guides/prog_guide/event_timer_adapter.rst > @@ -139,6 +139,23 @@ This function is passed a callback function that wil= l > be invoked if the adapter needs to create an event port, giving the appl= ication > the opportunity to control how it is done. >=20 > +Event device configuration for service based adapter > +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > + > +When rte_event_eth_rx_adapter_create() is used for creating adapter This has reference to eth_rx adapter please update it. With the changes you can add ACK. > +instance, eventdev is reconfigured with additional > +``rte_event_dev_config::nb_event_ports`` parameter. > +This eventdev reconfig logic also increment the > +``rte_event_dev_config::nb_single_link_event_port_queues`` > +parameter if the adapter event port config is of type > +``RTE_EVENT_PORT_CFG_SINGLE_LINK``. > + > +So the application is no longer need to configure the event device with > +``rte_event_dev_config::nb_event_ports`` and > +``rte_event_dev_config::nb_single_link_event_port_queues`` > +parameters required for timer adapter when the adapter is created using > +above mentioned api. > + > Adapter modes > ^^^^^^^^^^^^^ > An event timer adapter can be configured in either periodic or non-perio= dic > mode diff --git a/lib/eventdev/rte_event_timer_adapter.c > b/lib/eventdev/rte_event_timer_adapter.c > index a0f14bf861..5ed233db00 100644 > --- a/lib/eventdev/rte_event_timer_adapter.c > +++ b/lib/eventdev/rte_event_timer_adapter.c > @@ -88,7 +88,20 @@ default_port_conf_cb(uint16_t id, uint8_t > event_dev_id, uint8_t *event_port_id, > rte_event_dev_stop(dev_id); >=20 > port_id =3D dev_conf.nb_event_ports; > + if (conf_arg !=3D NULL) > + port_conf =3D conf_arg; > + else { > + port_conf =3D &def_port_conf; > + ret =3D rte_event_port_default_conf_get(dev_id, port_id, > + port_conf); > + if (ret < 0) > + return ret; > + } > + > dev_conf.nb_event_ports +=3D 1; > + if (port_conf->event_port_cfg & > RTE_EVENT_PORT_CFG_SINGLE_LINK) > + dev_conf.nb_single_link_event_port_queues +=3D 1; > + > ret =3D rte_event_dev_configure(dev_id, &dev_conf); > if (ret < 0) { > EVTIM_LOG_ERR("failed to configure event dev %u\n", > dev_id); @@ -99,16 +112,6 @@ default_port_conf_cb(uint16_t id, uint8_t > event_dev_id, uint8_t *event_port_id, > return ret; > } >=20 > - if (conf_arg !=3D NULL) > - port_conf =3D conf_arg; > - else { > - port_conf =3D &def_port_conf; > - ret =3D rte_event_port_default_conf_get(dev_id, port_id, > - port_conf); > - if (ret < 0) > - return ret; > - } > - > ret =3D rte_event_port_setup(dev_id, port_id, port_conf); > if (ret < 0) { > EVTIM_LOG_ERR("failed to setup event port %u on event dev > %u\n", diff --git a/lib/eventdev/rte_event_timer_adapter.h > b/lib/eventdev/rte_event_timer_adapter.h > index cd10db19e4..4b757773db 100644 > --- a/lib/eventdev/rte_event_timer_adapter.h > +++ b/lib/eventdev/rte_event_timer_adapter.h > @@ -212,6 +212,19 @@ typedef int > (*rte_event_timer_adapter_port_conf_cb_t)(uint16_t id, > * > * This function must be invoked first before any other function in the = API. > * > + * When this API is used for creating adapter instance, eventdev is > + * reconfigured with additional > + ``rte_event_dev_config::nb_event_ports`` > + * parameter during service initialization. This eventdev reconfig > + logic also > + * increment the > + ``rte_event_dev_config::nb_single_link_event_port_queues`` > + * parameter if the adapter event port config is of type > + * ``RTE_EVENT_PORT_CFG_SINGLE_LINK``. > + * > + * So the application is no longer need to account for > + * ``rte_event_dev_config::nb_event_ports`` and > + * ``rte_event_dev_config::nb_single_link_event_port_queues`` > + * parameters required for Timer adapter in eventdev configure when > + * the adapter is created with this api. > + * > * @param conf > * The event timer adapter configuration structure. > * > -- > 2.25.1