From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 951B0A00C5; Mon, 19 Dec 2022 06:49:15 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 887D341101; Mon, 19 Dec 2022 06:49:15 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 9DF4241101 for ; Mon, 19 Dec 2022 06:49:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1671428954; x=1702964954; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=ycPfJMtXk3/TBvOXbRDo+YXdcYmRfH/UDnk/AaN3pt8=; b=W8vTvRktq8FbQxn8mnkTShjc5VPZAWyUbXfYCaLMKuTxNKruSAImcP9d 0FZ66sCO7EnzoQf8CzMmuRHyEhI9ivz5LoSpIDKJR1Kp0FwZKFTEezZzn 9Zg5XGNDrd53LhToIhLasyrHX23fURwjDkASLmsSwePJBdZS6eoc7rbs2 7VtvsdCiwpHE3EGLwLbis1Gw6Kkfx5ZfUCWHbjWvjKScM+yEZzFGpSQlo nETuBDhfhvmLGQcxV1NH2g0S8wUC/HfsdookNQOALhbPRllyqMtiNOuZX agk2JBYsmlTLFyI7dO9KfcUYFTPhksFOXqAuE8W7W7D5ciaixAITfBCB6 g==; X-IronPort-AV: E=McAfee;i="6500,9779,10565"; a="383620570" X-IronPort-AV: E=Sophos;i="5.96,255,1665471600"; d="scan'208";a="383620570" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Dec 2022 21:49:13 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10565"; a="757494923" X-IronPort-AV: E=Sophos;i="5.96,255,1665471600"; d="scan'208";a="757494923" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga002.fm.intel.com with ESMTP; 18 Dec 2022 21:49:13 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Sun, 18 Dec 2022 21:49:12 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Sun, 18 Dec 2022 21:49:12 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Sun, 18 Dec 2022 21:49:12 -0800 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.41) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Sun, 18 Dec 2022 21:49:12 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fdX8NWavV/pB5bXUI4pwasQcPu+ABCCcrDbcQHlNfzdfCJIhRDOh5bZc0bipcfNcd/ilbU3JvPRx98SqqM4GbUpM33XDNhBG+EAlzVEu0fcoOp2CWPFQgsdIwxiogqpcelEIpLb0XeYSHiNGF9837LyLqAq1YPecKPSBuePnCH6yjc5Ri4C8ygFU422bGWp9SjumlTtp8NiNDGSrGb2nmtMwHUZz+pBXOKlArmKjGzCmKw889y4IdKjaINJp69USxeAoqhJJw4wiK6AnObb/bbd1muelSEBLrFEy75S7M8EF54JH4xqVZ8XFpSlB3ojupn1hwYUoy36sewxPvgE4Pw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QXPk396aSot2X0E+s0KdbAMmbjt2mB536hMwhvvO0B4=; b=FyuanixGO/dryNGA+beq25+dqF6nHF9eGw4JOE+Av73ddZdNJ8I5ctO8YHCkx5pxue2oYjtqMplWGIwlTJZHrJPMJEVWKZP8BmS7o18vgXVB4JoNVT3IHU9LNWU5OkJ+KlRdLlyuLEysQX+DZZtf6pzPnbeFSMBpx8s6Lg+fTyrf3ifGuU5rO6QIn45XERfXkZY47+kncD+B0xxficKCUH8BuFqoBMy/Wx7SvpseIYLBii2JV6zWGO7KEmLMUOAnE7H94sOGAYdftFnIw1pivlatbHznSzyo7Psxv20Boqh/3giXWYxZS4I/vMlcFbZhjG7joOVneaLzLmrzM+5m9w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5832.namprd11.prod.outlook.com (2603:10b6:510:141::7) by MN2PR11MB4533.namprd11.prod.outlook.com (2603:10b6:208:264::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.16; Mon, 19 Dec 2022 05:49:10 +0000 Received: from PH0PR11MB5832.namprd11.prod.outlook.com ([fe80::ef44:2061:3d86:6b21]) by PH0PR11MB5832.namprd11.prod.outlook.com ([fe80::ef44:2061:3d86:6b21%9]) with mapi id 15.20.5924.016; Mon, 19 Dec 2022 05:49:10 +0000 From: "Gujjar, Abhinandan S" To: "Naga Harish K, S V" , "jerinj@marvell.com" , "Carrillo, Erik G" CC: "dev@dpdk.org" , "Jayatheerthan, Jay" Subject: RE: [PATCH v3 2/4] eventdev/eth_tx: change eventdev reconfig logic Thread-Topic: [PATCH v3 2/4] eventdev/eth_tx: change eventdev reconfig logic Thread-Index: AQHZE2ttjb0qw8K9T0WzYVAxiOYw+a50tGCQ Date: Mon, 19 Dec 2022 05:49:10 +0000 Message-ID: References: <20221214070440.921488-1-s.v.naga.harish.k@intel.com> <20221219053315.2538180-1-s.v.naga.harish.k@intel.com> <20221219053315.2538180-2-s.v.naga.harish.k@intel.com> In-Reply-To: <20221219053315.2538180-2-s.v.naga.harish.k@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB5832:EE_|MN2PR11MB4533:EE_ x-ms-office365-filtering-correlation-id: 37025fd8-c256-432a-f90d-08dae184c030 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: mmUPrrJPhR1Tkf0fVREo7w8FbnaCC84T2YNbV+grrI31AVjT1xnywoKTIK/qJyHy40ydT8CJIBRTbb5jbNEUGK9ol+gPvrN8quBOzNmFkAdKHA9awFLOpVmT0ERcJavhrRBrm7ZJCO+IZTBCBOY0LiH5fXqEy72VfcXXjV5NuT2wtV2jLONyNdx6aUWQD2u1fNyfhOUD1XPqyQAmlHXaIUwP/uZ7QYZP9ZsuNvnVB0VUEHu7lCHSfRA6ujh6HMRH7nDnSR4Zp/YFx2QlB809mLjTH2anJPT5dmzkwNeuUtv3MxFriShuj7NurpFHgfQJj8NIuX5C2CT4DUoeudRappyhe6W1JOxAzJ41W11bIBtEnzksgP+EMyv9LAi+5ty9EQORjCFN/DuHQBA1jd8CgmoTqGFKkFUry4nuPGqMIJLaQouTAfZMslGEw3n7OXyeHB+VAzpxtKuQsi6sc6NTfN4wlKUOKXLhHC//nds/+nWNRDnSuhsZbWEFJrP/rnbLDJXjMG93orwKywGwa/wr2m6A33ZYt2hZlMJM9h2tLQ+jJc6kw9YoDIKCu3gR5DMcWzRgsKg4lk5HIUpT+llornGTd5WMh9ritDMJtRplOBuR6g5isiMg5dbOi38d3QfyVeD4pZkY8Xzkj4DnoGqjUR2kBuL3VcCFi8VTD/WdkLtgBHlxIcpa4eOCirwe8RT2WC7BxK3dtxBlnzgZzXqpeg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5832.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(396003)(366004)(136003)(346002)(376002)(39860400002)(451199015)(107886003)(478600001)(33656002)(71200400001)(7696005)(6506007)(55016003)(86362001)(186003)(9686003)(6636002)(66556008)(26005)(316002)(66476007)(66946007)(66446008)(64756008)(54906003)(76116006)(110136005)(38100700002)(41300700001)(8676002)(4326008)(83380400001)(2906002)(82960400001)(52536014)(55236004)(53546011)(122000001)(8936002)(38070700005)(5660300002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?m1dZvtrJybFpjxzLEn2qlhWT7YxIb5LGXlEt3K8Rfh7PyWyX0qVoWVq2XEJt?= =?us-ascii?Q?xRe4Uo8McBeZ8eHUeK3qtf+j362pfAnVumVNZM7WHgVRxTlX1SIk5oRQSpfT?= =?us-ascii?Q?3a8TqWU1Uj85QThzT4Xnnr6QMHgStQgcCLSD0Du0L36XAZCbZLC18AytZDJX?= =?us-ascii?Q?HQm3VEL1+DWSVF6XoOPC22+efF1MAHEPnHb6cJiMWw6GtDdIAuStoDIYg5tQ?= =?us-ascii?Q?A5SO0rkvA5bH91acysGHT1bGvr3P4i/0k2ju4c1hwQcQ86JJczJt21Bux4HX?= =?us-ascii?Q?xxl/EeBaivJUbsmM0gtLCyFrtn0rLG9i8fvG8mOafk38nb3Gl9vG5oT+yPVF?= =?us-ascii?Q?HzVJsU+JKVNeX3jqMDXcRzi5VnFITcGdi+bZQpXhfkWzjIwzfwWgEKTD8WBX?= =?us-ascii?Q?SNeEQRICaWfzOuqE/GTsdSGU+MmCEwSC1eyERQTtx3e+eJWkKQ+sXykCTRS6?= =?us-ascii?Q?cx2lyZzcoAnGiomlcKyKGmFB1CzeW9Kgmd+VfIVQxLQUEN/UPdG6FzQdF1NC?= =?us-ascii?Q?xOpd4eCZsGbUMAg86EEb92CoUpTFt3Hdb38XFXGTzXbOLyHdDBXmHniu7e1c?= =?us-ascii?Q?Ek6TpjxhqKiUR/hQl+ySPVU4zacYapU9ScD+AdWhJ15N9jMz323MTTjDUUvf?= =?us-ascii?Q?yYwVhTtBABWfr9zG7UgNxL9hKdtHZw/nuOhkY5vYizpCL4MDJ5vL/o2HYGTY?= =?us-ascii?Q?95WA+YjrlCyCfBvWSW02E0KucT+nPotXMZhZnRkRCo5B1WHFLAj3kNSXijrb?= =?us-ascii?Q?7x8DeOlH6uZGJRgU0qk6WmTPTdJJteR53BM+nP0xeGKZ01ocbPsZTx1rt2jU?= =?us-ascii?Q?l519qqHO/X1fh3MheyJsUUjebfpiafJtU8eKDdJJyHcfWvM4iAPVmbfsXjtx?= =?us-ascii?Q?WnyYWwNUnYS94NlmNAj4CIiFxJw9blZ+Dh55qxtIIMXafyq8lL6FUY+Z28r1?= =?us-ascii?Q?Bs3sRyW8XTIODeO9Kq2gbNcP38wS6va1yVc9c5rTWkVhbOBg42KanDSGAC7e?= =?us-ascii?Q?AqGnIZkYwGF2piJbXRdMcePF3A9sl+szA4Tdy+FBHB1Yhpgj5eR7K476jXcK?= =?us-ascii?Q?uEAY6efV1FFGpKD29OeavrhukCzS0nCISshro9MsadvKU0Vt1XPQz9VjK6ax?= =?us-ascii?Q?m56CncrPf54DvKXI7o62wCIBClKWNyD9zZ/oFDD6uqYC7gc7DH6LMmW+eJxI?= =?us-ascii?Q?qOCWKqSu9o7FJwpiaHpi5VLAp/f22AMeA80wqsNpbtgi83PqdxyGN88mV+rV?= =?us-ascii?Q?NdzJG7wHsI7xGc9wuHCBSfvPprP8wdQsjFy9HDibjtEoGDqinvCLWjhHF6zI?= =?us-ascii?Q?osPPuuhjH2gzRAsvlqjHFP0RTml05dYIrd4ODfNHGSCD4oqeL+o4H8XSI38R?= =?us-ascii?Q?yZ7vMFHGcnD4KvZ2Lzcex1X6KkiyFdkHdh+pa2DFt5gvyLcgdXjzYrySvdjl?= =?us-ascii?Q?0N8BmGBQG3QDyVyPgFlzYlxDaCf8HpThVh51T8JVP8ekbPy25LV7q/i2x+oA?= =?us-ascii?Q?y9x5Z3UOzoxskyWIF/6cP33l3TFpUJL1wy5+hNnjN8wRSFbkmP1YVziGJqbR?= =?us-ascii?Q?CvEv//zap0a4atch+9c2j4V8VRjJeRqCB2KhMZYtFo5KduEo/YUu7SMGIT+E?= =?us-ascii?Q?Nw=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5832.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 37025fd8-c256-432a-f90d-08dae184c030 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Dec 2022 05:49:10.2401 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: KkL+nhrtmOw2MH1GIFSpNeBj+l2PBmjFhxr117LqBuZXkJZwDoXP3j/d4DwDtn51GOWV3sAkg28OEBwpnxt0Pe9C7hC6BLvMDG7dY6lU/Pk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4533 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Acked-by: Abhinandan Gujjar > -----Original Message----- > From: Naga Harish K, S V > Sent: Monday, December 19, 2022 11:03 AM > To: jerinj@marvell.com; Carrillo, Erik G ; Guj= jar, > Abhinandan S > Cc: dev@dpdk.org; Jayatheerthan, Jay > Subject: [PATCH v3 2/4] eventdev/eth_tx: change eventdev reconfig logic >=20 > When rte_event_eth_tx_adapter_create() is used for creating adapter > instance, eventdev is reconfigured with additional > ``rte_event_dev_config::nb_event_ports`` parameter. >=20 > This eventdev reconfig logic is enhanced to increment the > ``rte_event_dev_config::nb_single_link_event_port_queues`` > parameter if the adapter event port config is of type > ``RTE_EVENT_PORT_CFG_SINGLE_LINK``. >=20 > With this change the application is no longer need to configure the event= dev > with ``rte_event_dev_config::nb_single_link_event_port_queues`` > parameter required for eth_tx adapter when the adapter is created using > above mentioned api. >=20 > Signed-off-by: Naga Harish K S V > --- > v2: > * fix build error in doc/prog_guide > v3: > * update doxygen > --- > --- > .../prog_guide/event_ethernet_tx_adapter.rst | 17 +++++++++++++++++ > lib/eventdev/rte_event_eth_tx_adapter.c | 2 ++ > lib/eventdev/rte_event_eth_tx_adapter.h | 13 +++++++++++++ > 3 files changed, 32 insertions(+) >=20 > diff --git a/doc/guides/prog_guide/event_ethernet_tx_adapter.rst > b/doc/guides/prog_guide/event_ethernet_tx_adapter.rst > index 905cb445e0..8e6cc87b04 100644 > --- a/doc/guides/prog_guide/event_ethernet_tx_adapter.rst > +++ b/doc/guides/prog_guide/event_ethernet_tx_adapter.rst > @@ -56,6 +56,23 @@ and needs to create an event port for it. The callback= is > expected to fill the >=20 > err =3D rte_event_eth_tx_adapter_create(id, dev_id, &tx_p_conf); >=20 > +Event device configuration for service based adapter > +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > + > +When rte_event_eth_tx_adapter_create() is used for creating adapter > +instance, eventdev is reconfigured with additional > +``rte_event_dev_config::nb_event_ports`` parameter. > +This eventdev reconfig logic also increment the > +``rte_event_dev_config::nb_single_link_event_port_queues`` > +parameter if the adapter event port config is of type > +``RTE_EVENT_PORT_CFG_SINGLE_LINK``. > + > +So the application is no longer need to configure the event device with > +``rte_event_dev_config::nb_event_ports`` and > +``rte_event_dev_config::nb_single_link_event_port_queues`` > +parameters required for eth_tx adapter when the adapter is created > +using above mentioned api. > + > Adding Tx Queues to the Adapter Instance > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >=20 > diff --git a/lib/eventdev/rte_event_eth_tx_adapter.c > b/lib/eventdev/rte_event_eth_tx_adapter.c > index 88309d2aaa..c780ee1264 100644 > --- a/lib/eventdev/rte_event_eth_tx_adapter.c > +++ b/lib/eventdev/rte_event_eth_tx_adapter.c > @@ -316,6 +316,8 @@ txa_service_conf_cb(uint8_t __rte_unused id, uint8_t > dev_id, >=20 > port_id =3D dev_conf.nb_event_ports; > dev_conf.nb_event_ports +=3D 1; > + if (pc->event_port_cfg & RTE_EVENT_PORT_CFG_SINGLE_LINK) > + dev_conf.nb_single_link_event_port_queues +=3D 1; >=20 > ret =3D rte_event_dev_configure(dev_id, &dev_conf); > if (ret) { > diff --git a/lib/eventdev/rte_event_eth_tx_adapter.h > b/lib/eventdev/rte_event_eth_tx_adapter.h > index 645b87b78a..889e09981e 100644 > --- a/lib/eventdev/rte_event_eth_tx_adapter.h > +++ b/lib/eventdev/rte_event_eth_tx_adapter.h > @@ -142,6 +142,19 @@ struct rte_event_eth_tx_adapter_stats { > /** > * Create a new ethernet Tx adapter with the specified identifier. > * > + * When this API is used for creating adapter instance, eventdev is > + * reconfigured with additional > + ``rte_event_dev_config::nb_event_ports`` > + * parameter during service initialization. This eventdev reconfig > + logic also > + * increment the > + ``rte_event_dev_config::nb_single_link_event_port_queues`` > + * parameter if the adapter event port config is of type > + * ``RTE_EVENT_PORT_CFG_SINGLE_LINK``. > + * > + * So the application is no longer need to account for > + * ``rte_event_dev_config::nb_event_ports`` and > + * ``rte_event_dev_config::nb_single_link_event_port_queues`` > + * parameters required for eth Tx adapter in eventdev configure when > + * the adapter is created with this api. > + * > * @param id > * The identifier of the ethernet Tx adapter. > * @param dev_id > -- > 2.25.1