From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D15A8A00C3; Wed, 7 Dec 2022 07:55:51 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BC3E9410FB; Wed, 7 Dec 2022 07:55:51 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id ACF78410D7 for ; Wed, 7 Dec 2022 07:55:49 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1670396149; x=1701932149; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=Cc3OjQg7hbEwENbpOSIYM1C5gkmFEA3bXQuPeBi3OI4=; b=N49W9+kYKfLNZPOhSOL+EoYh3d6llhM4epMR3lmHOGQXU0ockeyu9Nem uYFXIiWYj4QUjzvOJt6aBvYu74Mjj0mFszXyF1se9/GBklZp+t16coa2R udCZsuqiU96oE7fek0ucEQ2UK07NynFsUqaA2LZP8bxZ2dJZZz4YSkPuX Ggsh97NtN90RQn04A9c8ZMqQiWf1C007qzSDVYG0tQfCgT/99ODpfmq/0 vTudLG/cQtDySfAw4Ui2MtidSPwwlrkxs9w9nWopFEWjyG7mxubKOl3Jw H/SBEH6F1VWRNGmaYZ41PeArCphI2XqvUe+5t5B/iw2uFgW5YnRAK8Uwu A==; X-IronPort-AV: E=McAfee;i="6500,9779,10553"; a="315533821" X-IronPort-AV: E=Sophos;i="5.96,223,1665471600"; d="scan'208";a="315533821" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Dec 2022 22:55:44 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10553"; a="752970523" X-IronPort-AV: E=Sophos;i="5.96,223,1665471600"; d="scan'208";a="752970523" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga002.fm.intel.com with ESMTP; 06 Dec 2022 22:55:44 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 6 Dec 2022 22:55:44 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Tue, 6 Dec 2022 22:55:44 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.47) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Tue, 6 Dec 2022 22:55:44 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UQOja6ML3hncyhmR11+Ols+VaJpJzpSaeOvoE+3muYuxbvRsQADaYVx2wV2rqZAoIyZrm6Hj7NmEoE0hCMzHqrAx3OYrdscjc5InTvSyKWBfClrHJ2KG300g4/BdZzoutxmaBfO/3QikG5RPRa39Vb+TP9f0PuHnxrhnMAhUxHdKu+hLlMImtpDxTWj/2Gs6pkle9kUUoIU2SqNXwYOrJ5GqMerxJL1r5AMZpQbhrGwHSvpqfF11TGU+1IBxxJOoaHNZXMQQS8+d0+1EaGYhPzlnecfmNkK6BdCqOFgb40bcIYgc9S2Dqb2YuiJW64A2VDULlwWkbdB2bnjRjdIBCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gYCKKTvs+9OFC+7W3OvgbXE9c8uPWdZvjWhChEvT57w=; b=dGnv4R+cL+ws79FEP/V5e30WcEKYsx/idpvgXeoktyE3+fVLn+8lXVOFntIZ32mgM2Ww4rztRR6tFG4vJZ+nKt2Z32nPMJrPNtlea324fx1CWFzWZe0szue/26npHkrwdWwlxECvo6GhRce/1kTlX/dg2sD7y/nMGI6RRj4QVv7oBqL5cZ1diKpfSfT/djMUHC4lRHyOSB2cqmly+WbhQoUxqag3YvXsz8aHt5Kf4b9m+uc5AgyfJxG9NyjFE8HViwRfrlw75Cv3pJIxfkAD9fdXGATIhr5vfvkO9atbo26Ix0tcIvgdWOdLCthadfV5flBZH9qC20tSY188YOi2aA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5832.namprd11.prod.outlook.com (2603:10b6:510:141::7) by IA1PR11MB7677.namprd11.prod.outlook.com (2603:10b6:208:3fd::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.14; Wed, 7 Dec 2022 06:55:42 +0000 Received: from PH0PR11MB5832.namprd11.prod.outlook.com ([fe80::ef44:2061:3d86:6b21]) by PH0PR11MB5832.namprd11.prod.outlook.com ([fe80::ef44:2061:3d86:6b21%9]) with mapi id 15.20.5880.014; Wed, 7 Dec 2022 06:55:41 +0000 From: "Gujjar, Abhinandan S" To: "Kundapura, Ganapati" , "dev@dpdk.org" , "jerinj@marvell.com" , "Naga Harish K, S V" CC: "Jayatheerthan, Jay" , "vfialko@marvell.com" Subject: RE: [PATCH v3 3/5] eventdev/crypto: fix wrong offset used while flushing events Thread-Topic: [PATCH v3 3/5] eventdev/crypto: fix wrong offset used while flushing events Thread-Index: AQHZCggecAdEVq7K1EyrKFkfu+JGR65h/cIQ Date: Wed, 7 Dec 2022 06:55:41 +0000 Message-ID: References: <20221201064652.1885734-1-ganapati.kundapura@intel.com> <20221207064945.1665368-1-ganapati.kundapura@intel.com> <20221207064945.1665368-3-ganapati.kundapura@intel.com> In-Reply-To: <20221207064945.1665368-3-ganapati.kundapura@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB5832:EE_|IA1PR11MB7677:EE_ x-ms-office365-filtering-correlation-id: e4194f6d-c7da-480d-c5f7-08dad8200e6b x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: zCGML0btsbVGvYWMrPx9ttSHMNpmMXYvd021vmLp7rrQ0fY5YaR99rgfQSkxO+JCTcnxlMdeTcwAhgGZtKq8P1B/2Vwnw4P1qvchm5poppLpHQofsiNNwsqz3hhS2zrk6z7tKdpdEknXtDKS2GOTSE/e693AMukOabSw85blnOnAoLxLp5tSzKofGPLpxDt3+biv/brysX8HO5FAk305K/gkBFPyrWJEL5GpnfJ99xFOXeSJGo9olcm/SiBHVmhSiuUHE0WVuTG8r+EkgiJPifblfgPslBVe1rI9iCm7H//Dgjr9bQtiAwvIPV2NPzx1QL6vT7Vq6zEqo6jUy/BUVuDTNw+Wq+HjPwykt7R585TdBa4O5mTNP0D78E7iXDFdMju8uyjrJ+fRQRe8Vsekqa0LeVIgZBYNfA7PW8H/YiG15fwVhAEecCS9MWtwbp/7e+PfT6/X/wSOXosPHq9BSHg3dSsWa2pTHY6m0pl4Zoq8T/9YBY3nHMmPMiiEMPWu2U5HMRs8RBwfeYIVhmTqcHhMuM474Nlwul8yde0YPg/V29q0yz/m6Jv+DgmEn7+V1na0sHpv4Jg+ZPNF0Hbq8kPK5eh2z8mAz/L/2nAhNTgD8xMQpYrRId5Ca8GjXU/2uYktdx3F+aRiEFvibQ7ZQF+wydltOhlMeaK2+PIJOsE2oMC3c9Xx32naznax7AGdUL1cIu6pHPdb0QW8NqcQeA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5832.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(346002)(136003)(366004)(396003)(376002)(39860400002)(451199015)(54906003)(86362001)(8936002)(41300700001)(2906002)(33656002)(4326008)(5660300002)(38070700005)(38100700002)(83380400001)(122000001)(478600001)(71200400001)(66556008)(66946007)(316002)(6636002)(66446008)(110136005)(82960400001)(76116006)(52536014)(55016003)(8676002)(55236004)(6506007)(7696005)(53546011)(9686003)(186003)(66476007)(64756008)(26005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Op0SKc08G3w9H3gIH2WyJFdzgtb3iDLoCGxwptINZCg4uWoAKg4OoojYl1he?= =?us-ascii?Q?2msJ3kEqgfASn887IqXmMjpNgC/6rTAP0kS6DkHL7HI2gEEIbhnzdo0qf3T6?= =?us-ascii?Q?bY6zXBsnRcnduvJFe0NBr/8jzVxaTOTizqpf1SS72yFq+sGMxgJwXZDeEXs9?= =?us-ascii?Q?Nu7HmEWV2Mkbi+wvwfnEVXJtEXoctSgHlj8XMk9dsf/Zfbfq1ZK7iRRP2q3+?= =?us-ascii?Q?qYAivr35O64J4rl9evf4tpXETl45i7tZ/wHhm04FA6iIoSjQrj6jZZ14AAug?= =?us-ascii?Q?WXIxZ5Am6ir+rSx8NPHpZV+tFrArc1L5H0le/m+dMDP0+oeql6qo6aGkEdz3?= =?us-ascii?Q?xvOfuPGbbAgRy1Z1oGE+TgWYEKKW4o2QRydQz87uZkSaDrywifXYiM66Vhvo?= =?us-ascii?Q?GI4nN/a+AR2/il8M861N/V6tFQNGXTS9elcg4TAJu3Jr0TP43a8shcuxp4OR?= =?us-ascii?Q?/iIoP3aMZMPiRubYTVaPHe5KL8zcOmC/PTvwDaNcebciKbL3IRwEdkbSgn0q?= =?us-ascii?Q?cKIXMQmp/X28AjU9iDfoRNGcXBCQI/c59DTANYavKzw3HmA7+F/Zj9Ye0Qf9?= =?us-ascii?Q?VbYHnVrA6+ceIQJEfrRNR5PoNj5Sb0SvlHFGa+H2GGMOisj7LMXvfpn6NeO+?= =?us-ascii?Q?lhfaz8HlVU757nT2JvrvpfzxlsM6cR5QQvOb2rT+wrwsD73j5nu5O23M3lR8?= =?us-ascii?Q?fjGwZAiFi1Qk8DH+gKzvrmCm4O8Oqex1Pyx5cdG/1jx+uAT67OwbnFpDUZhG?= =?us-ascii?Q?yZXUYGsUMZ7lkmUx6usOEhLE0IZaomFdK34LckAL5HKNTWgGN69/HGtOoJKA?= =?us-ascii?Q?FZkqBbm7p7+E3+xgfZyprf9si8PMNEGLRlaxqOrwMnIa9yRyUImuafIx5CUa?= =?us-ascii?Q?b6zulVFr97b32PEVgOLJZ6PBAN2P2cJibQa7gD96Bvr0koKYOLXt3c/8marn?= =?us-ascii?Q?SlZb5P4XWT8cBaNE+hy6GuDU1BbJNfhPJqMhPryokZT8KVTOIT+fiKz5AFDN?= =?us-ascii?Q?Mccr8jXrGK6UrmMp95KSYZk52rP9mtD/qc/t5aD5fe2JVGdiSztQz1oGZGC2?= =?us-ascii?Q?n4UglF5IlYTyBaZLJB6ljS+25iGrk2z31Y/StZTnxWW0TGRxtMsGmKCNZ9gJ?= =?us-ascii?Q?Gkpd2xYdUboduiM8bjFTFgWfJBmTEDlCNtRWDuvDqzECpzAbXBu5HJH6zi0e?= =?us-ascii?Q?YIKA5D234tGrMpJoZ5ydjq0d1iGFlEogE56zE7AVRMFQAl+MumT4o8K7Uj62?= =?us-ascii?Q?eIKC9h4pLXGWKUJBOJMi1ltHMs2Da3OXigbSdSLbUHSaUVf5A1Rs/4gFSzJA?= =?us-ascii?Q?9o+bWyR1EK1MgMAPfUPSFp6WKgX6gkh5wG0i/4y66FkFj/pQ8C+3mI/xHo07?= =?us-ascii?Q?zZ7xFp3VHgeyAsbsgtXzr2VSnSDvUcjfuurzooGfwLkUifGOlyr7AADNj0iI?= =?us-ascii?Q?hH0OR6c79RvHBCnHzV19u+LomUdRa4dfh8YOywq3k9fWJx3O2A273K33rodA?= =?us-ascii?Q?dWjOdCaezRwmztd2rbllb5wP6dmpnkGC1WrT1z3wnRDxpLZFkHU+/t3+WZxu?= =?us-ascii?Q?K4ydpVH+49eut6cXgYdJaujvTwU5qWSzEWlLE/G4jgbjWE0d5d13geVS8hB6?= =?us-ascii?Q?YQ=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5832.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e4194f6d-c7da-480d-c5f7-08dad8200e6b X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Dec 2022 06:55:41.8374 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mvr7hg7pNNWDT+zo94bARcb2OzY13XP9qLZ/y3iE0nr4W3R42VFVZPGcBxoeLAlmqOv3jqkV0VHd6mqy/YvBiI/e+4TKULU5Bm35+cJFpN4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7677 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Acked-by: Abhinandan Gujjar > -----Original Message----- > From: Kundapura, Ganapati > Sent: Wednesday, December 7, 2022 12:20 PM > To: dev@dpdk.org; jerinj@marvell.com; Naga Harish K, S V > ; Gujjar, Abhinandan S > > Cc: Jayatheerthan, Jay ; vfialko@marvell.com > Subject: [PATCH v3 3/5] eventdev/crypto: fix wrong offset used while flus= hing > events >=20 > Events enqueued to eventdev from the beginning of the circular buffer. > This leads to invalid or already freed events getting enqueued to eventde= v > from the circular buffer. >=20 > Fixed by enqueuing the events to eventdev from the head pointer of circul= ar > buffer. >=20 > Fixes: 7901eac3409a ("eventdev: add crypto adapter implementation") >=20 > Signed-off-by: Ganapati Kundapura > --- > v2: > * Updated subject line in commit message >=20 > diff --git a/lib/eventdev/rte_event_crypto_adapter.c > b/lib/eventdev/rte_event_crypto_adapter.c > index eaff577..c08984b 100644 > --- a/lib/eventdev/rte_event_crypto_adapter.c > +++ b/lib/eventdev/rte_event_crypto_adapter.c > @@ -669,7 +669,7 @@ eca_circular_buffer_flush_to_evdev(struct > event_crypto_adapter *adapter, > else > return 0; /* buffer empty */ >=20 > - nb_ops_flushed =3D eca_ops_enqueue_burst(adapter, ops, n); > + nb_ops_flushed =3D eca_ops_enqueue_burst(adapter, &ops[*headp], > n); > bufp->count -=3D nb_ops_flushed; > if (!bufp->count) { > *headp =3D 0; > -- > 2.6.4