From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E688AA054A; Tue, 6 Dec 2022 17:25:51 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D5A7440687; Tue, 6 Dec 2022 17:25:51 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 38C5A4021D for ; Tue, 6 Dec 2022 17:25:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1670343950; x=1701879950; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=DE1voNqW/thACF00FCJRo7/eS2Sky72noEERzdRyfmw=; b=bF5IZ0UpjJYryCWSZsITCJFLTqmAcg68VCUTe6+yAfyBLcLu7s/u/NnL QqrNxpYeOTg8RDpfahsq2YvsugDC9nNUlZjPQFSJlAqvLzxkgliM4VGgk rth+wVEp4sz+b4LadHMVFYC7eqXdbIKuQyoX1n0UHqkFu4wW9dKFboHyN 8JH3bPiZgmwxpWFaNstGGSVtHeaKM1gs8CxDvf/qfIKLiteqpeeX6WczR IJp4sKT0IaLh8hYW3TgdjOR/2GRM7VPsssxiUWoxiAHqGH/5tWX3e7veT XbL16YBd30MCj4u1ZA+mFEnJT0PD1k46RuKxjK4TqnRW5l0pbTTWRWRc2 g==; X-IronPort-AV: E=McAfee;i="6500,9779,10553"; a="343692916" X-IronPort-AV: E=Sophos;i="5.96,222,1665471600"; d="scan'208";a="343692916" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Dec 2022 08:25:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10553"; a="714858000" X-IronPort-AV: E=Sophos;i="5.96,222,1665471600"; d="scan'208";a="714858000" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga004.fm.intel.com with ESMTP; 06 Dec 2022 08:25:48 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 6 Dec 2022 08:25:48 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Tue, 6 Dec 2022 08:25:48 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.100) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Tue, 6 Dec 2022 08:25:48 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Caz9+Z3drMxLzJlffIw/BqJ86pUpampmR+NiLJRbk/RcgVUJA5SgdA9ievBcIZLa4mJ0vbgaEChrPs3ipGhGu7rxeeDQwjGznIgHkUFW+ZXnsZhrPno03hN5Cndqp+ZbfLK+QhNTYcYgAPiVyoNnTRc0qGIuEYi31ljCQ3C8KNDlT1kv4zg2aLF7zzqNJeavV3hZhlVne5ooaRPf/zluBD3W4k3/jI7tZxuk+JCxwulncOEVYO0/Pqd8LRGWX5lJTPieUThYJD+DZpCplyQzYgU2Xl0XnUkgb66hGwUone9AVeJnRYTrxqtmSmM2HuefulViAblpsSHCVdfw5EF7Sg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=s3USeGEO0LfvZiXMLvHQeMsdjThEvsRSsHnJgQug52E=; b=I4pl9Cux3UfHaNMOomsOZYYedJ0hqcU3Ze8s6FAcwxLGt8NPNDAhRcNX1X0o3jTGg0RHVrshpZIISnvFfAgDXRtPShRM14BDQBYkVIibddaEE5zD93nttXUZoN4oXAVGc+AWSZDJKgPtdTFrSSZwC1rVME1FwA2gu817JwMwRMs2btXqF6pLPQH14OobAxKkf6OsjuqdQb8PRDp7yPs75ET8bRkEd16YK4ag96p9JLZzEAVdvNQR6LBU41+sWRCWN3dQrfJ9fz+mdnH3+ohoLDIy3NZWx0qkHy6HCofzCRhLbkt1dLAk+1NY8EZ/gfuKvEylQysL3TAmiqSbTZc1uQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5832.namprd11.prod.outlook.com (2603:10b6:510:141::7) by PH0PR11MB5611.namprd11.prod.outlook.com (2603:10b6:510:ed::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.14; Tue, 6 Dec 2022 16:25:46 +0000 Received: from PH0PR11MB5832.namprd11.prod.outlook.com ([fe80::ef44:2061:3d86:6b21]) by PH0PR11MB5832.namprd11.prod.outlook.com ([fe80::ef44:2061:3d86:6b21%9]) with mapi id 15.20.5880.014; Tue, 6 Dec 2022 16:25:46 +0000 From: "Gujjar, Abhinandan S" To: "Kundapura, Ganapati" , "dev@dpdk.org" , "jerinj@marvell.com" , "Naga Harish K, S V" CC: "Jayatheerthan, Jay" Subject: RE: [PATCH v2 4/5] eventdev/crypto: fix overflow in circular buffer Thread-Topic: [PATCH v2 4/5] eventdev/crypto: fix overflow in circular buffer Thread-Index: AQHZBVC50EaitvItXU+Tv7cx4Cj9A65hEmKA Date: Tue, 6 Dec 2022 16:25:45 +0000 Message-ID: References: <20221130171014.1723899-1-ganapati.kundapura@intel.com> <20221201064652.1885734-1-ganapati.kundapura@intel.com> <20221201064652.1885734-4-ganapati.kundapura@intel.com> In-Reply-To: <20221201064652.1885734-4-ganapati.kundapura@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB5832:EE_|PH0PR11MB5611:EE_ x-ms-office365-filtering-correlation-id: ded09130-23a6-403c-24b0-08dad7a68740 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: AGaiUYQ2Od4wdx/bDQQBfMX3SY+/S1wgD40gPNz3TB1L8Ad6+Ki7NAAlzeH0REHDrlkpG6hg6D/FnxqyPN5l7Yf6mppKBLDM5PAY46RjTFGbUO76lHEELbNN4DeEGeVdP+PnX/dGCUQ3CBf5cfXGSKZOeCeMBuxmzfUfQ/Ofwcw32OzPwuWjJPo9PW09M/1gyn8AeExcvi/oAIfdasTwIGpaj0a5Ds2yluxs2PI22+JGP/dT9Xvco2tFbpR8TIjuQ6XPmwSfr/8pFFwf1JSqELDIkoWJG/qGkritPzQaP9oUvQvtdi7TQvE0AYthJMunarzTQ5dJKlHajo3Y9rTa+YYymDwY3oujq33K+f8RqUvsIQ2WFBXoUNc55pOJf2REbAv8t5K2yiXztEMP1mRwKMI5blISn8TCOXnKodPq1Y6lm9z7m9lmt3CXqL2d5P2YymAIkdbmgpJERp7RV9dxxpBAy8cbewW74Tj9S8pLEOifqPN40EJLvUKqCWoyCKA1bmJc/np3nllff/mohOG0iyLjBPu5y6NjA8FUi8DbdcobQukMYeuOWt6aQ1vkDgiNqedcicgtltcTnTUTzghwTfe0usRWoQg+crLYnm3EKzdH74E4eKJHGpMMJxmD/d4T3ehj7Xh97yVsG5f98uIjv+mHkzLtjmxvVR0hB8aLUipIebRgPO/QWag12D+jGi3iR51dxwfbZFtMsWInXIsC7Q== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5832.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(136003)(376002)(366004)(39860400002)(396003)(346002)(451199015)(38070700005)(86362001)(4326008)(8936002)(2906002)(66946007)(66446008)(66476007)(66556008)(76116006)(41300700001)(8676002)(64756008)(38100700002)(122000001)(83380400001)(33656002)(110136005)(316002)(6636002)(82960400001)(5660300002)(52536014)(478600001)(55236004)(186003)(55016003)(107886003)(9686003)(6506007)(53546011)(26005)(7696005)(71200400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?zXKGXcxKXddGAz4t30r1cXAb7hGZYIqaHCTA5t5hl5uOdHyg8iGeyHl7lxI7?= =?us-ascii?Q?yMCsyntpGBbKmQfx3MB3NwWbxYBFGKylun5g1gEsM3IE7GV1WtMlWljt+ZBA?= =?us-ascii?Q?P0njnrMqwJSRWWRwihzIPpIHk8DrKstg1PVHY1biwkVsLpfgdtjlhTYWQlM0?= =?us-ascii?Q?k8lWKgcdtierhf4RNDDShodfpN9IezwDyDo2+ogHRr6nFzvuILu4GC9y3nAc?= =?us-ascii?Q?mkMJ6EFivU9FEdGcARG/O6pvk2e0J6oNmljFXSV8cAfMAaCEHU7wy0c3hshV?= =?us-ascii?Q?NKu0qEuJmhbd1ySVlKNvZZ+NfEnZEkMFyGWi2TTDWg2WWJVfKgVvb1g/m2KW?= =?us-ascii?Q?EhP4bO0oFS8v103xuCU6xMTRAdToPCQOYAgewLUnLOUW3i+LgkSmozDL3bJa?= =?us-ascii?Q?P18/mnu9dd/rKr5YeZVSPxjn2Ij+wWvddXq1fjXKEUfhd3lGiIik3JperuO3?= =?us-ascii?Q?mxWbBUoe6owUikI5GSL9JXvgCSMnAUlLR8NE0caVxBqi6C6ArQ5XurrT/Dy/?= =?us-ascii?Q?UjFORUchWSnKFsOUbYPRim5xNrM/3zQV3jnsaJuaZrS7hSvwkIEkFZhq9z4Z?= =?us-ascii?Q?PXqFTMP6Vp+UOZcL1DvGxL6nMvtwF0o/GPyKMFFwWQCTWwq1GfuG0wlJgxwZ?= =?us-ascii?Q?zpgr/wN2cEt+JfwYann3cmmyAWUe+ipHlkimZT+P5C/hP4Zc+E0Idcn2r7j4?= =?us-ascii?Q?2UIR6bTc4P1AAftMA2ep4Z0sbCf/mP4uH/W/An8A/OEkC7KsnEnyUqIFCtAT?= =?us-ascii?Q?eERYFiCaj4c3FXV1Qf+boEzBeoHPPnfes4w5y0rRERGQFbX2vO8Y1pOa2Ull?= =?us-ascii?Q?JjXETqF+BMa6LTuBTBJWmeX6yuHalCOE/jUBQxOOVPfPexIICdspmA25iUe7?= =?us-ascii?Q?NjfhMZ4ypoWqL2aKVT8YxKKP4zmsppKTDLQdgQZFgMFehmj8+VbnjG0w1B2Z?= =?us-ascii?Q?x9OzuqjNTMyA6pOWJTqrENRJLP3DYoMe/tbRiRBKd/Qy+Ry/kR57VU/nvcwm?= =?us-ascii?Q?9Kei8WIkU+0HN+iKdKayFKywxkF+OdSYJ+3yIlt5Yp0S9OwfaZGi2FBumtwv?= =?us-ascii?Q?Xr1Tu+yZstduIt5mfdxXcSUsA98D9/JAnQviaVCAlx86rCtvQ7KfwKaBLDAZ?= =?us-ascii?Q?MgjEaP7K4v1DVDkubfr5XNek4S58BZRCyZdeAyuLg0tyRYJGH9hYtMKVimXk?= =?us-ascii?Q?oEdw6KX69a0Z9f6910pM+/3IKVrZn7EbXZOYDIn9A0TPtcRTQRkWMAmDPKvh?= =?us-ascii?Q?NHJOf8q5MmBQ3B7C9iqZuH12won+dfYYxj5xCi8YmFmrl4YDN5BAzCsoxodM?= =?us-ascii?Q?f/dv+TtNeeW/Ox5qiPWdFnDgskbJpEnXSAE2lF3VGk/l4kb298lEhsP4Yrg3?= =?us-ascii?Q?B2uDkcve2xt1fBhOgoAx0yVPng9epnx/SOY8itkn/lZlBLkg4vtB7G3OxsQn?= =?us-ascii?Q?Q7kBVYZgp5PATM5Dzn/vdKaB11vPVMJTvqxGAFOmbbgy1w2n/UJWYZXaMHL8?= =?us-ascii?Q?wOkCF58ZcGzvhdsDTkNxmwHSR3Iek/ooB0HAH3sDopkPtKyrE6RUsXHlx+Wf?= =?us-ascii?Q?krhFiRHecyhERWo5ECH5ESqhPEoVP8YAtjZmsHB1ohVb/WMyDs5uXpnSKdx4?= =?us-ascii?Q?vQ=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5832.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ded09130-23a6-403c-24b0-08dad7a68740 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Dec 2022 16:25:45.9548 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: kJm7+Z2uJJ1THZPSuDOciV+PpxSlzbCmYSq59oYfakFpaV8FkN+1H0znkFO3WcE2A3sl/++d/0tmv1MJm+byGK8DDvYVJL5H8yxELRsGGq4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5611 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Kundapura, Ganapati > Sent: Thursday, December 1, 2022 12:17 PM > To: dev@dpdk.org; jerinj@marvell.com; Naga Harish K, S V > ; Gujjar, Abhinandan S > > Cc: Jayatheerthan, Jay > Subject: [PATCH v2 4/5] eventdev/crypto: fix overflow in circular buffer >=20 > Crypto adapter checks CPM backpressure once in enq_run() This leads to > buffer overflow if some ops failed to flush to cryptodev. Adapter is agnostic to hardware, replace CPM with "crypto device" Rephrase the commit message by adding:- In case of crypto enqueue failures, even though backpressure flag is set to= stop further dequeue from eventdev the current logic does not stop dequeuing eve= nts for max_nb events. This is fixed by checking backpressure just before deque= uing events from event device. >=20 > Checked CPM backpressure for every iteration in enq_run() >=20 > Fixes: 7901eac3409a ("eventdev: add crypto adapter implementation") >=20 > Signed-off-by: Ganapati Kundapura > --- > v2: > * Updated subject line in commit message >=20 > diff --git a/lib/eventdev/rte_event_crypto_adapter.c > b/lib/eventdev/rte_event_crypto_adapter.c > index 72deedd..1d39c5b 100644 > --- a/lib/eventdev/rte_event_crypto_adapter.c > +++ b/lib/eventdev/rte_event_crypto_adapter.c > @@ -573,14 +573,15 @@ eca_crypto_adapter_enq_run(struct > event_crypto_adapter *adapter, > if (adapter->mode =3D=3D RTE_EVENT_CRYPTO_ADAPTER_OP_NEW) > return 0; >=20 > - if (unlikely(adapter->stop_enq_to_cryptodev)) { > - nb_enqueued +=3D eca_crypto_enq_flush(adapter); > + for (nb_enq =3D 0; nb_enq < max_enq; nb_enq +=3D n) { >=20 > - if (unlikely(adapter->stop_enq_to_cryptodev)) > - goto skip_event_dequeue_burst; > - } > + if (unlikely(adapter->stop_enq_to_cryptodev)) { > + nb_enqueued +=3D eca_crypto_enq_flush(adapter); > + > + if (unlikely(adapter->stop_enq_to_cryptodev)) > + break; > + } >=20 > - for (nb_enq =3D 0; nb_enq < max_enq; nb_enq +=3D n) { > stats->event_poll_count++; > n =3D rte_event_dequeue_burst(event_dev_id, > event_port_id, ev, BATCH_SIZE, 0); > @@ -591,8 +592,6 @@ eca_crypto_adapter_enq_run(struct > event_crypto_adapter *adapter, > nb_enqueued +=3D eca_enq_to_cryptodev(adapter, ev, n); > } >=20 > -skip_event_dequeue_burst: > - > if ((++adapter->transmit_loop_count & > (CRYPTO_ENQ_FLUSH_THRESHOLD - 1)) =3D=3D 0) { > nb_enqueued +=3D eca_crypto_enq_flush(adapter); > -- > 2.6.4