[PATCH] build: fix missing crypto vec limits in version

[PATCH] build: fix missing crypto vec limits in version

[Volodymyr Fialko]

Add missing function `rte_event_crypto_adapter_vector_limits_get` to
version.map.

Fixes: c1749bc5ee10 ("eventdev: introduce event cryptodev vector type")

Signed-off-by: Volodymyr Fialko <vfialko@marvell.com>
---
 lib/eventdev/version.map | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/eventdev/version.map b/lib/eventdev/version.map
index dd63ec6f68..1a7fffd17f 100644
--- a/lib/eventdev/version.map
+++ b/lib/eventdev/version.map
@@ -20,6 +20,7 @@ DPDK_23 {
 	rte_event_crypto_adapter_stats_get;
 	rte_event_crypto_adapter_stats_reset;
 	rte_event_crypto_adapter_stop;
+	rte_event_crypto_adapter_vector_limits_get;
 	rte_event_dequeue_timeout_ticks;
 	rte_event_dev_attr_get;
 	rte_event_dev_close;
-- 
2.25.1

Re: [PATCH] build: fix missing crypto vec limits in version

[Zhang, Fan]

On 12/6/2022 9:23 AM, Volodymyr Fialko wrote:
> Add missing function `rte_event_crypto_adapter_vector_limits_get` to
> version.map.
>
> Fixes: c1749bc5ee10 ("eventdev: introduce event cryptodev vector type")
>
> Signed-off-by: Volodymyr Fialko <vfialko@marvell.com>
> ---
>   lib/eventdev/version.map | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/lib/eventdev/version.map b/lib/eventdev/version.map
> index dd63ec6f68..1a7fffd17f 100644
> --- a/lib/eventdev/version.map
> +++ b/lib/eventdev/version.map
> @@ -20,6 +20,7 @@ DPDK_23 {
>   	rte_event_crypto_adapter_stats_get;
>   	rte_event_crypto_adapter_stats_reset;
>   	rte_event_crypto_adapter_stop;
> +	rte_event_crypto_adapter_vector_limits_get;
>   	rte_event_dequeue_timeout_ticks;
>   	rte_event_dev_attr_get;
>   	rte_event_dev_close;
Acked-by: Fan Zhang <fanzhang.oss@gmail.com>

Re: [PATCH] build: fix missing crypto vec limits in version

[Jerin Jacob]

On Tue, Dec 6, 2022 at 2:58 PM Zhang, Fan <fanzhang.oss@gmail.com> wrote:
>
> On 12/6/2022 9:23 AM, Volodymyr Fialko wrote:
> > Add missing function `rte_event_crypto_adapter_vector_limits_get` to
> > version.map.
> >
> > Fixes: c1749bc5ee10 ("eventdev: introduce event cryptodev vector type")
> >
> > Signed-off-by: Volodymyr Fialko <vfialko@marvell.com>
> > ---
> >   lib/eventdev/version.map | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/lib/eventdev/version.map b/lib/eventdev/version.map
> > index dd63ec6f68..1a7fffd17f 100644
> > --- a/lib/eventdev/version.map
> > +++ b/lib/eventdev/version.map
> > @@ -20,6 +20,7 @@ DPDK_23 {
> >       rte_event_crypto_adapter_stats_get;
> >       rte_event_crypto_adapter_stats_reset;
> >       rte_event_crypto_adapter_stop;
> > +     rte_event_crypto_adapter_vector_limits_get;
> >       rte_event_dequeue_timeout_ticks;
> >       rte_event_dev_attr_get;
> >       rte_event_dev_close;
> Acked-by: Fan Zhang <fanzhang.oss@gmail.com>

+ @Thomas Monjalon  @David Marchand

1) Sanity is failing as follows
### [PATCH] build: fix missing crypto vec limits in version

ERROR: symbol rte_event_crypto_adapter_vector_limits_get is added in
the DPDK_23 section, but is expected to be added in the EXPERIMENTAL
section of the version map

This patch is added in 22.07. New patches should be experimental.
Right? If so, Please change to __rte_experimental and move
EXPERIMENTAL section. If  I am not missing anything.

[1]
[for-main]dell[dpdk-next-eventdev] $ git describe c1749bc5ee1
v22.07-473-gc1749bc5ee

2) Change git log as eventdev/crypto: .....

Re: [PATCH] build: fix missing crypto vec limits in version

[Thomas Monjalon]

17/01/2023 17:25, Jerin Jacob:
> On Tue, Dec 6, 2022 at 2:58 PM Zhang, Fan <fanzhang.oss@gmail.com> wrote:
> >
> > On 12/6/2022 9:23 AM, Volodymyr Fialko wrote:
> > > Add missing function `rte_event_crypto_adapter_vector_limits_get` to
> > > version.map.
> > >
> > > Fixes: c1749bc5ee10 ("eventdev: introduce event cryptodev vector type")
> > >
> > > Signed-off-by: Volodymyr Fialko <vfialko@marvell.com>
> > > ---
> > >   lib/eventdev/version.map | 1 +
> > >   1 file changed, 1 insertion(+)
> > >
> > > diff --git a/lib/eventdev/version.map b/lib/eventdev/version.map
> > > index dd63ec6f68..1a7fffd17f 100644
> > > --- a/lib/eventdev/version.map
> > > +++ b/lib/eventdev/version.map
> > > @@ -20,6 +20,7 @@ DPDK_23 {
> > >       rte_event_crypto_adapter_stats_get;
> > >       rte_event_crypto_adapter_stats_reset;
> > >       rte_event_crypto_adapter_stop;
> > > +     rte_event_crypto_adapter_vector_limits_get;
> > >       rte_event_dequeue_timeout_ticks;
> > >       rte_event_dev_attr_get;
> > >       rte_event_dev_close;
> > Acked-by: Fan Zhang <fanzhang.oss@gmail.com>
> 
> + @Thomas Monjalon  @David Marchand
> 
> 1) Sanity is failing as follows
> ### [PATCH] build: fix missing crypto vec limits in version
> 
> ERROR: symbol rte_event_crypto_adapter_vector_limits_get is added in
> the DPDK_23 section, but is expected to be added in the EXPERIMENTAL
> section of the version map
> 
> This patch is added in 22.07. New patches should be experimental.
> Right? If so, Please change to __rte_experimental and move
> EXPERIMENTAL section. If  I am not missing anything.

Yes new functions should be experimental.
You need to add a comment in the .h
and the attribute __rte_experimental.

Such issue would have been seen earlier if the new function
was used in a unit test or a test application.

[PATCH v2] eventdev/crypto: fix missing crypto vec limits

[Volodymyr Fialko]

Add missing function `rte_event_crypto_adapter_vector_limits_get` to
version.map.
Fixes: c1749bc5ee10 ("eventdev: introduce event cryptodev vector type")

Signed-off-by: Volodymyr Fialko <vfialko@marvell.com>
---
v2:
- mark function as experimental

 lib/eventdev/rte_event_crypto_adapter.h | 4 ++++
 lib/eventdev/version.map                | 1 +
 2 files changed, 5 insertions(+)

diff --git a/lib/eventdev/rte_event_crypto_adapter.h b/lib/eventdev/rte_event_crypto_adapter.h
index 83d154a6ce..2a69290097 100644
--- a/lib/eventdev/rte_event_crypto_adapter.h
+++ b/lib/eventdev/rte_event_crypto_adapter.h
@@ -595,6 +595,9 @@ int
 rte_event_crypto_adapter_event_port_get(uint8_t id, uint8_t *event_port_id);
 
 /**
+ * @warning
+ * @b EXPERIMENTAL: this API may change without prior notice
+ *
  * Retrieve vector limits for a given event dev and crypto dev pair.
  * @see rte_event_crypto_adapter_vector_limits
  *
@@ -610,6 +613,7 @@ rte_event_crypto_adapter_event_port_get(uint8_t id, uint8_t *event_port_id);
  *  - 0: Success.
  *  - <0: Error code on failure.
  */
+__rte_experimental
 int rte_event_crypto_adapter_vector_limits_get(
 	uint8_t dev_id, uint16_t cdev_id,
 	struct rte_event_crypto_adapter_vector_limits *limits);
diff --git a/lib/eventdev/version.map b/lib/eventdev/version.map
index dd63ec6f68..c155af6d50 100644
--- a/lib/eventdev/version.map
+++ b/lib/eventdev/version.map
@@ -110,6 +110,7 @@ EXPERIMENTAL {
 	rte_event_eth_rx_adapter_event_port_get;
 
 	# added in 22.07
+	rte_event_crypto_adapter_vector_limits_get;
 	rte_event_port_quiesce;
 	rte_event_queue_attr_set;
 
-- 
2.34.1

RE: [PATCH v2] eventdev/crypto: fix missing crypto vec limits

[Gujjar, Abhinandan S]

Acked-by: Abhinandan Gujjar <abhinandan.gujjar@intel.com>

> -----Original Message-----
> From: Volodymyr Fialko <vfialko@marvell.com>
> Sent: Wednesday, January 18, 2023 11:22 AM
> To: dev@dpdk.org; Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>;
> Jerin Jacob <jerinj@marvell.com>; Akhil Goyal <gakhil@marvell.com>;
> Volodymyr Fialko <vfialko@marvell.com>
> Cc: anoobj@marvell.com
> Subject: [PATCH v2] eventdev/crypto: fix missing crypto vec limits
> 
> Add missing function `rte_event_crypto_adapter_vector_limits_get` to
> version.map.
> Fixes: c1749bc5ee10 ("eventdev: introduce event cryptodev vector type")
> 
> Signed-off-by: Volodymyr Fialko <vfialko@marvell.com>
> ---
> v2:
> - mark function as experimental
> 
>  lib/eventdev/rte_event_crypto_adapter.h | 4 ++++
>  lib/eventdev/version.map                | 1 +
>  2 files changed, 5 insertions(+)
> 
> diff --git a/lib/eventdev/rte_event_crypto_adapter.h
> b/lib/eventdev/rte_event_crypto_adapter.h
> index 83d154a6ce..2a69290097 100644
> --- a/lib/eventdev/rte_event_crypto_adapter.h
> +++ b/lib/eventdev/rte_event_crypto_adapter.h
> @@ -595,6 +595,9 @@ int
>  rte_event_crypto_adapter_event_port_get(uint8_t id, uint8_t
> *event_port_id);
> 
>  /**
> + * @warning
> + * @b EXPERIMENTAL: this API may change without prior notice
> + *
>   * Retrieve vector limits for a given event dev and crypto dev pair.
>   * @see rte_event_crypto_adapter_vector_limits
>   *
> @@ -610,6 +613,7 @@ rte_event_crypto_adapter_event_port_get(uint8_t id,
> uint8_t *event_port_id);
>   *  - 0: Success.
>   *  - <0: Error code on failure.
>   */
> +__rte_experimental
>  int rte_event_crypto_adapter_vector_limits_get(
>  	uint8_t dev_id, uint16_t cdev_id,
>  	struct rte_event_crypto_adapter_vector_limits *limits); diff --git
> a/lib/eventdev/version.map b/lib/eventdev/version.map index
> dd63ec6f68..c155af6d50 100644
> --- a/lib/eventdev/version.map
> +++ b/lib/eventdev/version.map
> @@ -110,6 +110,7 @@ EXPERIMENTAL {
>  	rte_event_eth_rx_adapter_event_port_get;
> 
>  	# added in 22.07
> +	rte_event_crypto_adapter_vector_limits_get;
>  	rte_event_port_quiesce;
>  	rte_event_queue_attr_set;
> 
> --
> 2.34.1

Re: [PATCH v2] eventdev/crypto: fix missing crypto vec limits

[Jerin Jacob]

On Mon, Jan 23, 2023 at 3:05 PM Gujjar, Abhinandan S
<abhinandan.gujjar@intel.com> wrote:
>
> Acked-by: Abhinandan Gujjar <abhinandan.gujjar@intel.com>


Updated the git commit as follows and applied to
dpdk-next-net-eventdev/for-main. Thanks

eventdev/crypto: fix missing symbol in map file

>
> > -----Original Message-----
> > From: Volodymyr Fialko <vfialko@marvell.com>
> > Sent: Wednesday, January 18, 2023 11:22 AM
> > To: dev@dpdk.org; Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>;
> > Jerin Jacob <jerinj@marvell.com>; Akhil Goyal <gakhil@marvell.com>;
> > Volodymyr Fialko <vfialko@marvell.com>
> > Cc: anoobj@marvell.com
> > Subject: [PATCH v2] eventdev/crypto: fix missing crypto vec limits
> >
> > Add missing function `rte_event_crypto_adapter_vector_limits_get` to
> > version.map.
> > Fixes: c1749bc5ee10 ("eventdev: introduce event cryptodev vector type")
> >
> > Signed-off-by: Volodymyr Fialko <vfialko@marvell.com>
> > ---
> > v2:
> > - mark function as experimental
> >
> >  lib/eventdev/rte_event_crypto_adapter.h | 4 ++++
> >  lib/eventdev/version.map                | 1 +
> >  2 files changed, 5 insertions(+)
> >
> > diff --git a/lib/eventdev/rte_event_crypto_adapter.h
> > b/lib/eventdev/rte_event_crypto_adapter.h
> > index 83d154a6ce..2a69290097 100644
> > --- a/lib/eventdev/rte_event_crypto_adapter.h
> > +++ b/lib/eventdev/rte_event_crypto_adapter.h
> > @@ -595,6 +595,9 @@ int
> >  rte_event_crypto_adapter_event_port_get(uint8_t id, uint8_t
> > *event_port_id);
> >
> >  /**
> > + * @warning
> > + * @b EXPERIMENTAL: this API may change without prior notice
> > + *
> >   * Retrieve vector limits for a given event dev and crypto dev pair.
> >   * @see rte_event_crypto_adapter_vector_limits
> >   *
> > @@ -610,6 +613,7 @@ rte_event_crypto_adapter_event_port_get(uint8_t id,
> > uint8_t *event_port_id);
> >   *  - 0: Success.
> >   *  - <0: Error code on failure.
> >   */
> > +__rte_experimental
> >  int rte_event_crypto_adapter_vector_limits_get(
> >       uint8_t dev_id, uint16_t cdev_id,
> >       struct rte_event_crypto_adapter_vector_limits *limits); diff --git
> > a/lib/eventdev/version.map b/lib/eventdev/version.map index
> > dd63ec6f68..c155af6d50 100644
> > --- a/lib/eventdev/version.map
> > +++ b/lib/eventdev/version.map
> > @@ -110,6 +110,7 @@ EXPERIMENTAL {
> >       rte_event_eth_rx_adapter_event_port_get;
> >
> >       # added in 22.07
> > +     rte_event_crypto_adapter_vector_limits_get;
> >       rte_event_port_quiesce;
> >       rte_event_queue_attr_set;
> >
> > --
> > 2.34.1
>