From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1536043E6F; Tue, 16 Apr 2024 11:16:52 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7D4ED402AE; Tue, 16 Apr 2024 11:16:51 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) by mails.dpdk.org (Postfix) with ESMTP id DD6354029E for ; Tue, 16 Apr 2024 11:16:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1713259010; x=1744795010; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=XfLQY0RyCSKzArVD7CRUWnw23PAkBxPqbK4Gmp5RvDk=; b=VxrbzgpTG/GpNVFgT5JVZQoPmj1bsb41Gj4EN5Sez4gB5wuf6rXFgyLX DxAhbbd15ptjGm9z9ha/aADR9nOFMU0cblG5wzWrbIu6m7fIpwhz5xEr7 ojo+shoWyZGtUml6ybKL4aM2m3UCMukObLT0vWCGXlKbwrkyYU6KSIn09 aplALdFEc/3xj2fPMXtLmVcJNyeEaJMp5kF5rwDcHvIbGUKCKDZ1eTbDO B+i+8IYXzrI3rlX2uFCBYjbQV45o8Lgx6cLEez58j3HcY+pZVKemPQXIW f6uXLB21gUL/wXpoQW0/ArZpFphvxE0GOa5BfEGUu9TfVV/9pGsqZiBlP Q==; X-CSE-ConnectionGUID: 3SRZkr2kTjC3SSlQoHbXBQ== X-CSE-MsgGUID: pyQ4Oj8ITcSRGzf2YPr78w== X-IronPort-AV: E=McAfee;i="6600,9927,11045"; a="8605621" X-IronPort-AV: E=Sophos;i="6.07,205,1708416000"; d="scan'208";a="8605621" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Apr 2024 02:16:49 -0700 X-CSE-ConnectionGUID: 2p83XX0BSGGT4E3PxQgqeQ== X-CSE-MsgGUID: CCgqKepBTKm5Ca9nqVl7OQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,205,1708416000"; d="scan'208";a="22197947" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orviesa009.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 16 Apr 2024 02:16:48 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 16 Apr 2024 02:16:47 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 16 Apr 2024 02:16:47 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Tue, 16 Apr 2024 02:16:47 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.101) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 16 Apr 2024 02:16:46 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W7TO0gM7qjCXQdXmnf+8kgaqDGnJdV9Lvse60CfW0Wmy5PWftJTV+52hamAUwAZKIdOs/Kir9AUrOBCxQeBytfI7YhUpami0OrZS1k3fUGBPt21xzOyrN8zAUjQVIy5jd7PE+JBkfSBwfH/RnQuqmPwPS4FSWSNVcA6k/gEhp9rvLjP9bLQE/X9Sa/AoJEH15gaV5O7MoS6BIhiIL9zcxZ7uKzmjyVur2z5AOOYBEGVsdQLJ6fimsdlnyCnIccsxvCzO7gpZunxBzQw7PUf4f29Hu1XlGXLdPdArvD4vZYqDA+YKZRrfXDFk12cs5KFL5IlEjf7Bu8vhaYerC+ODFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GgLT3RJUqnTSO7RBBuqqJHJANAg1V/aSNQCIzk0Qvoc=; b=Nu1ojvCcUf5zC8NfUcYJuQDCDcui0GRWkwRxX/PX8XkMms3L1cjiZKigjp5mSA0aSvmEkNcsLpDv6Nhf/kWTmL7CugNQr+KhV0tR6FRt99dZpKd/e6/zza2/IaXbxcReibMrqaS8GcaB7Yg1WSd+8MmRLS33r+pQf4seI+IbyKrDUL0yPg+JGRcWp6Dp0vdbn4eVDnuh46IqmGtwxNA5UWq5TmN3CDJOSjQ2a1BDKDVvTX1mL/owF3NNptZ5e0Tw3hqNddiU5J/n1DxmA5eWXOU1vQaUAfo2UfJeJxImmVYFVVtqeDq5cgZYRVwHs8QA+4qIuDe5eWpqgn6hufUK3Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5832.namprd11.prod.outlook.com (2603:10b6:510:141::7) by SJ2PR11MB7475.namprd11.prod.outlook.com (2603:10b6:a03:4c9::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.49; Tue, 16 Apr 2024 09:16:44 +0000 Received: from PH0PR11MB5832.namprd11.prod.outlook.com ([fe80::c338:32f0:7c75:67d8]) by PH0PR11MB5832.namprd11.prod.outlook.com ([fe80::c338:32f0:7c75:67d8%7]) with mapi id 15.20.7472.027; Tue, 16 Apr 2024 09:16:44 +0000 From: "Gujjar, Abhinandan S" To: "Kundapura, Ganapati" , "dev@dpdk.org" CC: "Power, Ciara" , "gakhil@marvell.com" , "fanzhang.oss@gmail.com" Subject: RE: [PATCH v1] crypto: fix build issues on crypto callbacks macro undefined Thread-Topic: [PATCH v1] crypto: fix build issues on crypto callbacks macro undefined Thread-Index: AQHaj9XZakvTgAIDWkOcitTUgk09N7Fqnd0w Date: Tue, 16 Apr 2024 09:16:44 +0000 Message-ID: References: <20240416081222.3002268-1-ganapati.kundapura@intel.com> In-Reply-To: <20240416081222.3002268-1-ganapati.kundapura@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB5832:EE_|SJ2PR11MB7475:EE_ x-ms-office365-filtering-correlation-id: 402625bf-d729-413a-9dd4-08dc5df5ef78 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: TzHvE1MZHU4hwz3OQab8ci4S2e72mrk/2VSTanfYqP7VFiAlyxCEp6NPIcVUZpC5Phi77n1MId25viXuVDtrwlcFAVAQmxzoKB5D1YHEvkZLuZ8BoRMMn7kO4VwArmCJQ8UBVHR4e19mZ4PP5VX1mYCnH02Ezu2S1rATnLDhNwTsMMkyYqouSa4enyJo1tjKOPIToTinwMQ0ErYvpAoTMLmHZx8v7mOpHDoRKipO0FMsG1LyYpXa7mYhL8bLQPhya5YVN8BImfrBy184WgdTgkOaf9doi+W9g5cTddv6B9hKE+pB8AKTjExaWwZFdPTG9gjpDpN3SY+yqFhpEDG4+14c27v5+MI3A7L+BNhjJmex1vUQ6how0TZO36GI6UMVMdcomyyNh9MgUkto1t5IKLq/LvvyoB9W8flxFnUdtacP6krlC47R8DduBCt9XiYaAkUfQ8y0YS6D+OUPs0MoJJ4Oc9QCRxueMeJgcbAuMGUCLckGSiXeef6vBdggmDSQqTAhqpNiKbYHMBs3ZNMa594gEPNWfHH/gK4wWOeTLlcZWg9ZG8jOZbz9H0ELWGPLYZ74hLRPaTQLRofqWqP2YpFkL37W41fhrcWXxGJu3tRg98g123/CMOITPKnW9BjjzrlDpRSbNdpxbUq6FVK4SlODYLBOhnewyD40coOxB34bDNDqj7eWNPpIpZc7q1XQnhq65nlKJm/FZ0jjn/Iqug== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5832.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366007)(376005)(1800799015)(38070700009); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?m4+Qim0UYvV7eMFDNae5jgF1DcfP+ekLnxBireEjmPAllzacXj44CI11iwKy?= =?us-ascii?Q?yfwlOtnu4Hc3CtAc2U/wf3R+JSVWwoolhij2OrgLPVsjXFwYLxHi7H+pDJ9Q?= =?us-ascii?Q?LH7/tzvh07Hqhog8fMvZasZwpJncZvee/HkYyT2TdzSh+SCAN57TSQZYdi6+?= =?us-ascii?Q?olgrXZxO9HQeHdfJJeMHFbfj2KcGvAbw2eWFJ6nUQnCTJ75AJFQI83uamdai?= =?us-ascii?Q?q6IKGhXsWxnVDG+Zidv0QR5psoxAk4N9LTjLr6QmiWkhRf1EJpikKyYo02vG?= =?us-ascii?Q?t4+qNhu11oxkQkZYHkmTGXvttuZ7htjWY6LaxJkuUAQeF4G9djVztUEO8Inp?= =?us-ascii?Q?McvMgI4MBBnq+jzExhc3IoDOjf5dfXuwdIpoM6cy5rWvEorCRfdLT9K7OPGK?= =?us-ascii?Q?FrMJ40nAhEY06e7vSAb87zwmnlVTnspEM9HlztnZas8yF/jqYdr+dJp58z0v?= =?us-ascii?Q?XQvDBitDrqZUrkLIHRDoUZoXcYW0Hp5Jqpd5kBUY7T6KWtVpdGoOhVlSFxmG?= =?us-ascii?Q?STkEKhxej5Lpol3j80Cki615NieOXbS31VIhezWu+ZUjsw1gq6LqQqgaouKt?= =?us-ascii?Q?4DaVWSzFFvxnYugxylfuSVmRJVkPUMFlhOv/REXa1T0kzp4fkT1KlB1jFATo?= =?us-ascii?Q?6LB/OKE5AaplDF7VemHqHKNPM5hh2OL5FOARooxU5GkVKkWBOEIq4VOxA7s0?= =?us-ascii?Q?JhgOhDhvNc8eyEjOU7NwqpG7HZIWV9zIEWKbfEkaXR1z0SKUxzXRf0CT7e1M?= =?us-ascii?Q?Guva5NkdX9OvxIq7ntWlt90pRkr/nXSDrTCS+xIGvg+J3KuDQinUORY3Wd6Y?= =?us-ascii?Q?NWyXjiG4Jtn6bRyWAYiCa59wwIoTiq+BXb/+tchfAmJHH6rTN4aZsGjPnSPC?= =?us-ascii?Q?5kJ6cqFQ8lxdSiHzkV+aan2IoEWbDFOr8L8EG0FEr0DnOLxpMYXxR72aYMdv?= =?us-ascii?Q?FpE+IPH0ehPbS3bGV45IZiFaFrOIOGcDN2PVQqaIhGCyYlHHYX17l+BHln65?= =?us-ascii?Q?EXDgw2rO9xQaTGkOO7aufWQG93IddNrngkCzk/z6KK4fZ2aKRErdfrbD5Unc?= =?us-ascii?Q?zJpVoa5yJOoq9ocvrOIMtOtnmPgjk4Jp/gzofaXWFb22+WqzpNwKxvWB4O1M?= =?us-ascii?Q?1Sdh+pP3d8QCtprB487JmVS3gty6cFybpVtQdQVks50wrYwXgVSRWB8BLNY1?= =?us-ascii?Q?x5KVqjHJRyVy0kAdZ7a6xJrn6nxpJ5zzGBNwPl41dToGn0sPJqHnkkeTAUUo?= =?us-ascii?Q?EOl3ixHqYcHtVsH2Ramn1oF3/1m7F3WdIpmyT1YXKC4Ez+g/UqxWB+IncWM1?= =?us-ascii?Q?6TmSBzPT7wTJ7D1sOpxQyBa1RjiROOh7d7FiZIBochP8HJcwN1crtQ/RDzG5?= =?us-ascii?Q?A9j+uNyiFDabDluuzw2OvdLi/pOXOn7c62//YX0PzNW2uEV4iQ6GUJmbKvDV?= =?us-ascii?Q?Qoip64X/R5nIaVrccpv3wuF3d6RRcLVtIRhuAic4W3ByabQbcSV1P3DCA92n?= =?us-ascii?Q?GRt7ExMa3n6Keut7mz3Bwq5fTN3El4bhWVY4uZPXN0zp+9Hh32ba95uR5eQe?= =?us-ascii?Q?0gdGT/GUtJjNPCZHn9alqBzjTkd63Q552fX9UgpT?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5832.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 402625bf-d729-413a-9dd4-08dc5df5ef78 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Apr 2024 09:16:44.5355 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: pQDUUQ4ZVik91kShkA031tGZmw+QFovwVceGSGxqj7b9QwisUyipnWwQxs3B2PjUf+LP0BTmj+phT9WigWpWkXDUg5EFWe6u4JdnNFOddvA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB7475 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Kundapura, Ganapati > Sent: Tuesday, April 16, 2024 1:42 PM > To: dev@dpdk.org > Cc: Gujjar, Abhinandan S ; Power, Ciara > ; gakhil@marvell.com; fanzhang.oss@gmail.com > Subject: [PATCH v1] crypto: fix build issues on crypto callbacks macro un= defined >=20 > Crypto callbacks macro is defined with value 1 and being used with ifdef,= on > config value is changed to 0 to disable, crypto callback changes still be= ing > compiled. >=20 > Defined crypto callbacks macro without value, undef to disable >=20 > Wrapped crypto callback changes with RTE_CRYPTO_CALLBACKS macro to fix > build issues when macro is undefined. >=20 > As callback head nodes have valid pointer, this patch checks the next nod= e from > the head if callbacks registered. >=20 > Fixes: 1c3ffb9 ("cryptodev: add enqueue and dequeue callbacks") > Fixes: 5523a75 ("test/crypto: add case for enqueue/dequeue callbacks") >=20 > Signed-off-by: Ganapati Kundapura > Acked-by: Abhinandan Gujjar =20 > diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index > 1703ebccf1..1a592f2302 100644 > --- a/app/test/test_cryptodev.c > +++ b/app/test/test_cryptodev.c > @@ -14547,6 +14547,7 @@ test_null_burst_operation(void) > return TEST_SUCCESS; > } >=20 > +#ifdef RTE_CRYPTO_CALLBACKS > static uint16_t > test_enq_callback(uint16_t dev_id, uint16_t qp_id, struct rte_crypto_op = **ops, > uint16_t nb_ops, void *user_param) > @@ -14784,6 +14785,7 @@ test_deq_callback_setup(void) >=20 > return TEST_SUCCESS; > } > +#endif /* RTE_CRYPTO_CALLBACKS */ >=20 > static void > generate_gmac_large_plaintext(uint8_t *data) @@ -18069,8 +18071,10 @@ > static struct unit_test_suite cryptodev_gen_testsuite =3D { > TEST_CASE_ST(ut_setup, ut_teardown, >=20 > test_device_configure_invalid_queue_pair_ids), > TEST_CASE_ST(ut_setup, ut_teardown, test_stats), > +#ifdef RTE_CRYPTO_CALLBACKS > TEST_CASE_ST(ut_setup, ut_teardown, > test_enq_callback_setup), > TEST_CASE_ST(ut_setup, ut_teardown, > test_deq_callback_setup), > +#endif > TEST_CASES_END() /**< NULL terminate unit test array */ > } > }; > diff --git a/config/rte_config.h b/config/rte_config.h index > dd7bb0d35b..b647a69ba8 100644 > --- a/config/rte_config.h > +++ b/config/rte_config.h > @@ -72,7 +72,7 @@ > /* cryptodev defines */ > #define RTE_CRYPTO_MAX_DEVS 64 > #define RTE_CRYPTODEV_NAME_LEN 64 > -#define RTE_CRYPTO_CALLBACKS 1 > +#define RTE_CRYPTO_CALLBACKS /* No Value, undef/comment out to > disable */ >=20 > /* compressdev defines */ > #define RTE_COMPRESS_MAX_DEVS 64 > diff --git a/lib/cryptodev/rte_cryptodev.c b/lib/cryptodev/rte_cryptodev.= c index > 886eb7adc4..5f3b17a517 100644 > --- a/lib/cryptodev/rte_cryptodev.c > +++ b/lib/cryptodev/rte_cryptodev.c > @@ -628,6 +628,7 @@ rte_cryptodev_asym_xform_capability_check_hash( > return ret; > } >=20 > +#ifdef RTE_CRYPTO_CALLBACKS > /* spinlock for crypto device enq callbacks */ static rte_spinlock_t > rte_cryptodev_callback_lock =3D RTE_SPINLOCK_INITIALIZER; >=20 > @@ -744,6 +745,7 @@ cryptodev_cb_init(struct rte_cryptodev *dev) > cryptodev_cb_cleanup(dev); > return -ENOMEM; > } > +#endif /* RTE_CRYPTO_CALLBACKS */ >=20 > const char * > rte_cryptodev_get_feature_name(uint64_t flag) @@ -1244,9 +1246,11 @@ > rte_cryptodev_configure(uint8_t dev_id, struct rte_cryptodev_config *conf= ig) > if (*dev->dev_ops->dev_configure =3D=3D NULL) > return -ENOTSUP; >=20 > +#ifdef RTE_CRYPTO_CALLBACKS > rte_spinlock_lock(&rte_cryptodev_callback_lock); > cryptodev_cb_cleanup(dev); > rte_spinlock_unlock(&rte_cryptodev_callback_lock); > +#endif >=20 > /* Setup new number of queue pairs and reconfigure device. */ > diag =3D rte_cryptodev_queue_pairs_config(dev, config->nb_queue_pairs, > @@ -1257,6 +1261,7 @@ rte_cryptodev_configure(uint8_t dev_id, struct > rte_cryptodev_config *config) > return diag; > } >=20 > +#ifdef RTE_CRYPTO_CALLBACKS > rte_spinlock_lock(&rte_cryptodev_callback_lock); > diag =3D cryptodev_cb_init(dev); > rte_spinlock_unlock(&rte_cryptodev_callback_lock); > @@ -1264,6 +1269,7 @@ rte_cryptodev_configure(uint8_t dev_id, struct > rte_cryptodev_config *config) > CDEV_LOG_ERR("Callback init failed for dev_id=3D%d", dev_id); > return diag; > } > +#endif >=20 > rte_cryptodev_trace_configure(dev_id, config); > return (*dev->dev_ops->dev_configure)(dev, config); @@ -1485,6 > +1491,7 @@ rte_cryptodev_queue_pair_setup(uint8_t dev_id, uint16_t > queue_pair_id, > socket_id); > } >=20 > +#ifdef RTE_CRYPTO_CALLBACKS > struct rte_cryptodev_cb * > rte_cryptodev_add_enq_callback(uint8_t dev_id, > uint16_t qp_id, > @@ -1763,6 +1770,7 @@ rte_cryptodev_remove_deq_callback(uint8_t > dev_id, > rte_spinlock_unlock(&rte_cryptodev_callback_lock); > return ret; > } > +#endif /* RTE_CRYPTO_CALLBACKS */ >=20 > int > rte_cryptodev_stats_get(uint8_t dev_id, struct rte_cryptodev_stats *stat= s) diff > --git a/lib/cryptodev/rte_cryptodev.h b/lib/cryptodev/rte_cryptodev.h ind= ex > 00ba6a234a..b811b458d5 100644 > --- a/lib/cryptodev/rte_cryptodev.h > +++ b/lib/cryptodev/rte_cryptodev.h > @@ -1910,7 +1910,7 @@ rte_cryptodev_dequeue_burst(uint8_t dev_id, > uint16_t qp_id, > nb_ops =3D fp_ops->dequeue_burst(qp, ops, nb_ops); >=20 > #ifdef RTE_CRYPTO_CALLBACKS > - if (unlikely(fp_ops->qp.deq_cb !=3D NULL)) { > + if (unlikely(fp_ops->qp.deq_cb[qp_id].next !=3D NULL)) { > struct rte_cryptodev_cb_rcu *list; > struct rte_cryptodev_cb *cb; >=20 > @@ -1977,7 +1977,7 @@ rte_cryptodev_enqueue_burst(uint8_t dev_id, > uint16_t qp_id, > fp_ops =3D &rte_crypto_fp_ops[dev_id]; > qp =3D fp_ops->qp.data[qp_id]; > #ifdef RTE_CRYPTO_CALLBACKS > - if (unlikely(fp_ops->qp.enq_cb !=3D NULL)) { > + if (unlikely(fp_ops->qp.enq_cb[qp_id].next !=3D NULL)) { > struct rte_cryptodev_cb_rcu *list; > struct rte_cryptodev_cb *cb; >=20 > -- > 2.23.0