From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 54699430DE; Wed, 23 Aug 2023 08:17:09 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DFE8D40A79; Wed, 23 Aug 2023 08:17:08 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 6D9AC406BA for ; Wed, 23 Aug 2023 08:17:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692771427; x=1724307427; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=KQdo/BtfgjgAbEIowb2dd8xx0SfpwpyqUpw3hhZipvA=; b=Z4ONybXo8hNnhwZYGALiHirpjH+NO68w1ZqLxs8HGAyx5xqdgJwKWunG aXRX/OY8+UTnG+tX1Q3VTw1V3tNc/a2RdgbsoBdRFto388j8llDGoXQV6 GQo/omP0/PkyoiPAR8o4jijd8urURyKRPSHnwX/VA4oywYNkCOzy+vVHD MkO5EtcYIw553DUoWrnHKoLuy0iPt10HHBCNOXmic+IrsdmRfpOJ+iphN qC1jpzM4yadOGvnp9rYy7SIbXOGBRNXAu7b1QbmryUgQzEo9J7bKmY6YP 2FN8PRGX8K7xSuRVgZ2seIfNj9RfzW3RDkS7X71rQzcr9xeMBCsPsD3kx A==; X-IronPort-AV: E=McAfee;i="6600,9927,10810"; a="372967280" X-IronPort-AV: E=Sophos;i="6.01,195,1684825200"; d="scan'208";a="372967280" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Aug 2023 23:17:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10810"; a="1067348050" X-IronPort-AV: E=Sophos;i="6.01,195,1684825200"; d="scan'208";a="1067348050" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga005.fm.intel.com with ESMTP; 22 Aug 2023 23:17:05 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 22 Aug 2023 23:17:05 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Tue, 22 Aug 2023 23:17:05 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.105) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Tue, 22 Aug 2023 23:17:03 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EkHDqdxdYIQno8YgHSZCck2XHdS9/c3LOUd4QvHt3ph/4swaWnQaF/xfXJTYImrqg9gaxTUzBwlJEYm4v8J6amKBlsWqbtOPOg6uHNPEyWaSCJbw6uTw4AmME+21o3otwycrdOAdrE5P634qLrpXzOrTKwk/FkR5ojBjXuunimMTnQVn+haIAC2SBvbtxZISSvrseImay7JUx0VIlIdL64KI4wi8rAwYUKfgPCBcybx2ZxNXIV1T4TwRXcivJWBRlGhEH80PPSdugaAe57EBraRSa1c0OCtl0HS2ccOHNAGbe0vIOZUKi+KPhv0eKLqpTNw17e0hIujjQaZ1Dq4FQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VykX3YrBpEeJdXjNChIhXqZlbWvdQ8q3gLcAfbawD8s=; b=EIbA8hdYU5BpI1OSmhmfiD5DkwQj9z/qswXrntDh6F25MwL86qAiliLYDR6cHF7p8iFD9lSsN8pkz1SKKoI6dwuuoLgmLbz0bojZFYkSU9bhUmRpNVEiNDBuqJopvWoHATCgrXvYUmUwqj38xV0/oL3YayIUhd20FUTPOxVCPUbvQlbOCozeY+6txA2DdAXSbblkFHsQ45SSJ/LmCNuflS4SJVOxuhbb9UDbBY1FO+gKv58pbuqxpDgTPWuIX7SQLaDkZBc1HZSnhkzlAq2cHK0VqXGkyUz+IxXG5/9nZ+VuvAukIE3mDcXLRXeePuqJCwDvRMBU2fPioWa4AtB2ow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5832.namprd11.prod.outlook.com (2603:10b6:510:141::7) by IA0PR11MB7331.namprd11.prod.outlook.com (2603:10b6:208:435::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6699.25; Wed, 23 Aug 2023 06:17:01 +0000 Received: from PH0PR11MB5832.namprd11.prod.outlook.com ([fe80::765e:559b:400b:cc5c]) by PH0PR11MB5832.namprd11.prod.outlook.com ([fe80::765e:559b:400b:cc5c%7]) with mapi id 15.20.6699.022; Wed, 23 Aug 2023 06:17:01 +0000 From: "Gujjar, Abhinandan S" To: Anoob Joseph CC: Jerin Jacob Kollanukkaran , Shijith Thotton , "dev@dpdk.org" , Aakash Sasidharan , Akhil Goyal Subject: RE: [PATCH 3/3] test/event_crypto_adapter: fix crypto null dev creation Thread-Topic: [PATCH 3/3] test/event_crypto_adapter: fix crypto null dev creation Thread-Index: AQHZ1Pr8ALNULBTCh0Gjlpsu+floqK/3TrYwgAAR5gCAAANK0A== Date: Wed, 23 Aug 2023 06:17:01 +0000 Message-ID: References: <20230822131649.3509986-1-asasidharan@marvell.com> <20230822131649.3509986-3-asasidharan@marvell.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB5832:EE_|IA0PR11MB7331:EE_ x-ms-office365-filtering-correlation-id: fbf209b9-cbcd-4d03-1898-08dba3a09052 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: m3zdduYSwYgU6axVsAMTErFJvE8b7+dkg4kww+g904IJ+p7jsnzGgT1P6egWFMJIFSPvwjFEphxW4w4xvLYHSNrxji2SB7k8aaDX30QIljHRQVIorIZAl2n2dZsUM4o4EyjubeYQtYmh2WBPpb++A7m1FG+oNgdIX8KWYiwAuncNTRoGn7sCSNLmWrriqs7k6LcqRYKdrSVzTWRxJSV2TDw1uKnUP7zkSb/mbJSSQF0F3EUUtTand+yS79mEL4aUvRRtBWl/baXY4FJykxxQjoFIOSa3M/vyA2B2Uee0vSFHsgRL0xELuYrQbGqq2SvNSQ9GGDCRPDnrH9fJjj9PaARczXAtfudbVYEePDKzLAmqjiW+q6fJqFYPojJgtk+WjZsc7QK0APIZEBEEaH4J4EfXRMp4R8H9c5WjXv9CVtxMwKw96719qpMSdCU6mMAkcF+7Lx0LnU4AJc8M7rdnENxbl7ZfSovD4TotdlhHTCsQN2LdRB5NavCr1ltN+tzciyaG/JYoSX90gcS2EIzz8EUJm48D2++b7qRiDcsNWbHf5JZHwLc2KH61+4Ho4aVC5P6kivXbbHg+Bm67+nRPBCkRpjtyZWkKaHFd0o1XD1wrHFoG2VEg3siGg+KznWz/ x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5832.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(396003)(136003)(39860400002)(366004)(376002)(451199024)(1800799009)(186009)(55016003)(478600001)(71200400001)(83380400001)(38100700002)(122000001)(38070700005)(2906002)(7696005)(6506007)(53546011)(9686003)(76116006)(33656002)(86362001)(64756008)(54906003)(82960400001)(52536014)(66476007)(8676002)(4326008)(66446008)(66556008)(6916009)(316002)(41300700001)(5660300002)(8936002)(66946007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?u/OFtGHRRfznlhEIqUkJo1MgL94M0RvcMcnNN/HkFekrAjyILHLhfoC1DBHB?= =?us-ascii?Q?7HUqVilYGWTsb7v0Pej8ZxeRPL2iWWPteiKnogymTb134oaDxWJ+UITrz5x9?= =?us-ascii?Q?0C7bOkYcxZoTcRxi1OwuxQsCDisHGZ7o7ZmJpxhab9F9tr17O/hj7eFnu0c6?= =?us-ascii?Q?hUoS1AeE2sJTHzRwsh6/G2xf7g/SwXAL6GYu+Hu5/rBo4ngr6JsBL1Zot9Vy?= =?us-ascii?Q?sDZeJOA3Y7ze9wmaNwgsGW0AA66d/RQ95DcJpfMUmpAF41rQf1LKNSZ/n4+A?= =?us-ascii?Q?u26BAfZfCSKpM/WKW2SrUmD8CnxnP+P3qEvH/ZG6Cw+ys9HFWzKGqOa3OqqQ?= =?us-ascii?Q?DopORURLHXjrwMutxnMAnHczsP2s2+loZnROOrTirI35JfD8FMlTKyYZA/Bh?= =?us-ascii?Q?fqAsLxOrZF+6eWGeJzLel3iP2uDeNGTtrGjuPGsqjJ7gVwlpfhii8pl9y3F/?= =?us-ascii?Q?cl8wMDqVRr4qtpJ0GwYkBbFNW82z1OkXyyTuVTnFkR7LtgisrHAIzG68eRWc?= =?us-ascii?Q?ORocDZ5QwsvXqg7COHqagZQ7oW9FJVYpRC3u+bV6CuNNP1WMyDJlXAINvOte?= =?us-ascii?Q?iFvN2Mk8HyPjdrYQ+V/XeIhKal9px1tRjr9nzjhP9W/rE6LM1CEYRk0OP9PE?= =?us-ascii?Q?c3JB0J7E1BxOiMP6GOSSpXbmvwEqmK+Yj1/V1RFdrV1v/Em4J6Yzt/KJ4Fjq?= =?us-ascii?Q?APxdZc0JjEapIybuETrICgI0fmwoVZpbz4pX909aNNFpt8JkeIE9WyYI5Nck?= =?us-ascii?Q?F+2mtj6VDHoKnPwetS/6q6Yde5S6gpUjEvJ2c+RJ0xe72W86NY4V1r2idvb6?= =?us-ascii?Q?uhr6tlTSeiQn/dNnxpwkwT4+kYxUrkjJ37VUCOKJB8XISps4oHCDZrelFSZT?= =?us-ascii?Q?/ABDXQp0iYt3BnZqDPHI+OJse+ksz/hht8hNMNtMQRUgTeqqGrHX1SSGVGlE?= =?us-ascii?Q?5RcXsz3/a5JP4YyCPjCP35s23ppBbdDw46AVdsuOBXRE0I6pu0mv5iGmHlEi?= =?us-ascii?Q?X//z9d+C8x/f/IyAAhs1Ixkiu9jbNd06tuhyb1Tc5hoZg8Qx3jSH/QuRFNqn?= =?us-ascii?Q?BdDTDmkXYF5sUMaL7gDFNkOFh+AYmDbrpOaW9wChNOgEYvwGchBpXRIu+7M4?= =?us-ascii?Q?aUO/1NI2SkPsIC+L1reerU4MKhtxScsY3Go2DmHptCQQ8y2IawewFOeiF7Ju?= =?us-ascii?Q?caeGnSMjCORMP2WzNHPzaqATdjCyla1CLqKqWCfFDDDiFCQCAq50kMrfmJCN?= =?us-ascii?Q?kRxz1lHcMxXOWIxjy/xypzSQraW8Hapl/p+71K/JSoDgUHOaK8yrRUjH4Y5O?= =?us-ascii?Q?yKpik05izLCH/8GltQe2ke0qYfj0S+0LwbK8X6ONcl1kSJmjDOXuMGzZRzQk?= =?us-ascii?Q?XxqtoVwQV88z7i4Gw9nAKl2PeCyEN+FiR5wV4m5eO46+WVTQ3rPyF3KPnlOw?= =?us-ascii?Q?3t1yLfETBKap+dX4Zbj4CKpaIWV21wo1CdzYwtoEYmIR0CuXVIFVJFs9MVWA?= =?us-ascii?Q?mDhJUXHldWp5XAknBTQAYeO8aIJ1g9dQK0kweU4dPb4IrHoNzhTUR/Dmv/Mc?= =?us-ascii?Q?GR95reY+Ue+1qXwieaQ=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5832.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fbf209b9-cbcd-4d03-1898-08dba3a09052 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Aug 2023 06:17:01.4390 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dlJwihCzy+p2RH0InS5N8BqKWk9B24tTNkXSJnhYd3OXJyBayPv2Zi4UR5dbyKdMbGi9rhj/Oe07waOl9u9UgAC4wYIyK02aPcKmpWpPgE0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB7331 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Anoob, > -----Original Message----- > From: Anoob Joseph > Sent: Wednesday, August 23, 2023 11:17 AM > To: Gujjar, Abhinandan S > Cc: Jerin Jacob Kollanukkaran ; Shijith Thotton > ; dev@dpdk.org; Aakash Sasidharan > ; Akhil Goyal > Subject: RE: [PATCH 3/3] test/event_crypto_adapter: fix crypto null dev > creation >=20 > Hi Abhinandan, >=20 > Please see inline. >=20 > Thanks, > Anoob >=20 > > -----Original Message----- > > From: Gujjar, Abhinandan S > > Sent: Wednesday, August 23, 2023 10:19 AM > > To: Aakash Sasidharan ; Akhil Goyal > > > > Cc: Jerin Jacob Kollanukkaran ; Shijith Thotton > > ; Anoob Joseph ; > > dev@dpdk.org > > Subject: [EXT] RE: [PATCH 3/3] test/event_crypto_adapter: fix crypto > > null dev creation > > > > External Email > > > > ---------------------------------------------------------------------- > > > > > > > -----Original Message----- > > > From: Aakash Sasidharan > > > Sent: Tuesday, August 22, 2023 6:47 PM > > > To: Gujjar, Abhinandan S ; Akhil Goyal > > > > > > Cc: jerinj@marvell.com; sthotton@marvell.com; anoobj@marvell.com; > > > dev@dpdk.org; asasidharan@marvell.com > > > Subject: [PATCH 3/3] test/event_crypto_adapter: fix crypto null dev > > > creation > > > > > > Create crypto null device only if no other crypto devices were found. > > > > > > Fixes: 3c2c535ecfc0 ("test: add event crypto adapter auto-test") > > > Cc: abhinandan.gujjar@intel.com > > > > > > Signed-off-by: Aakash Sasidharan > > > --- > > > app/test/test_event_crypto_adapter.c | 7 +++---- > > > 1 file changed, 3 insertions(+), 4 deletions(-) > > > > > > diff --git a/app/test/test_event_crypto_adapter.c > > > b/app/test/test_event_crypto_adapter.c > > > index 00b20fa443..0c56744ba0 100644 > > > --- a/app/test/test_event_crypto_adapter.c > > > +++ b/app/test/test_event_crypto_adapter.c > > > @@ -1072,11 +1072,10 @@ configure_cryptodev(void) > > > return TEST_FAILED; > > > } > > > > > > - /* Create a NULL crypto device */ > > > - nb_devs =3D rte_cryptodev_device_count_by_driver( > > > - rte_cryptodev_driver_id_get( > > > - RTE_STR(CRYPTODEV_NAME_NULL_PMD))); > > > + > > > + nb_devs =3D rte_cryptodev_count(); > > The test is intended to do on NULL cipher with NULL PMD. >=20 > [Anoob] This test is intended to verify any cryptodev with crypto adapter= . > Why do we want to restrict the usage with NULL devices only? No such restriction. Please refer below comment. >=20 > > Right now, the test does cipher with " RTE_CRYPTO_CIPHER_NULL". >=20 > [Anoob] It has support for asymmetric cases also. Well, I was talking about cipher algo used in the test in the context of ke= eping it simple to verify the crypto adapter as it is agnostic to any under= lying device. Not sym vs asym support. >=20 > > With this changes, does this test work, if you provide any other > > cryptodev like AESNI, QAT, OpenSSL other than NULL PMD? >=20 > [Anoob] If NULL cipher is supported by those PMDs, it should be. Because, > this being a standard test application should stick to standard semantics= and > so shouldn't care about whether the PMD under test is NULL or QAT. If NUL= L > cipher is not supported by the PMD, then the case should get skipped at > capability layer. Or are you saying that crypto adapter is only supposed = to be > used with NULL PMD? It is not about supporting other PMDs. This is about keeping the test case simple with minimal conf overhead so th= at it is easy for testing and maintaining. >From the code, I see that few PMDs supports NULL too without much changes t= o the app. It should be ok. >=20 > Also, what we have seen is, if there are other cryptodevs (like cnxk), th= at > would be the first cryptodev. And the test application is only testing CD= EV_ID > 0. So creating a NULL crypto PMD when other PMDs are available is pointle= ss. Sounds good. Acked-by: Abhinandan Gujjar >=20 > > > if (!nb_devs) { > > > + /* Create a NULL crypto device */ > > > ret =3D rte_vdev_init( > > > RTE_STR(CRYPTODEV_NAME_NULL_PMD), NULL); > > > > > > -- > > > 2.25.1