From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DC1BAA054A; Tue, 6 Dec 2022 16:44:24 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 67EE940687; Tue, 6 Dec 2022 16:44:24 +0100 (CET) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id CC9084021D for ; Tue, 6 Dec 2022 16:44:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1670341462; x=1701877462; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=tKIyY5p4siYc5Xy70gWRFJ0orIqXT0Vjhadxpqon3/8=; b=Cu12hNzAERvGXO4ukldWk8OmEhCTdzN2Yq4DKZmAEah9IiH85v1BrYOp K17kHZ2CPh5ciHGY9qwRA5hJDsKprEdLJkOP8xtMqb8HDQaRd2wsYznrv u7P37nCTriabWlKP4QKcppjdS1FzGzXEU0GNVDXeE6m7SN7KxSf4Z9LD2 rHGblQIqGwBWQsJ4MA5DKlNM0+00Jgjx2E27uIUUio3oZlvzrPeLYt3B1 +mmgGvTiFnNNCvF2bPv6DQMF4Q1brgLf6nSxuZFpovjUa2593DgmF4sRx Ac04C9CwCz2RvxLDH/WZqINLlxNxULKsaHWy8EkDYMmCsHR+XwbeJPkzw w==; X-IronPort-AV: E=McAfee;i="6500,9779,10553"; a="378817309" X-IronPort-AV: E=Sophos;i="5.96,222,1665471600"; d="scan'208";a="378817309" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Dec 2022 07:44:21 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10553"; a="648373965" X-IronPort-AV: E=Sophos;i="5.96,222,1665471600"; d="scan'208";a="648373965" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga007.fm.intel.com with ESMTP; 06 Dec 2022 07:44:21 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 6 Dec 2022 07:44:21 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Tue, 6 Dec 2022 07:44:21 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.47) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Tue, 6 Dec 2022 07:44:20 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Dtba/Ra/aLg3XQflBtToyWs+psHoYC+Qrwkd/Ndkhr+aR2e+ZLD8rLR6oWGXnZpO9JRyOBucLhFQ6LC0na4Ac8l2Mu34GKaVP1CWxphdgk1cDQzlekZKs7SAOiJWRp5Wb/XxYGJWnRsvfVV60/v+4xw2sEHym/pu8eHV3Zu8DwipIKil2dK712RQ21OjeDu2sCD8h26x3oCgRyc65h16N2xAKA7h3iwyvWWY/C6C/GEUKqwzKopVcpGP1hNlNWbnuMna+M9dLJopCo+QBMax/9IJpHeFzRAroEHtbzflODayPRtI8cDv7N95DQJJBS1xFMBjJz4iJmlI3X/Nx8xobQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=r6SGn1ktmAxI0hwp+KgdAClMyxjjPnJfjwTENzLmodY=; b=Sj/OF79T0mZl0UonXEwynMTEdoE+UoQ5+72AqkDkRBK7ZFDlV++w9vlNyRfNdJamjzkY5w0c50Y890r2uR0RUfiTXXsWF52mBTmwODUP//NHI/tT03mzgMaLKsYSrXF9xM2CG0oBIaBjI9gqqhwlOhciGnhLq0b9GsaLROaJDF8qM6oEEwAJQzbpYDGf3zaFQf0dyirqDBVurkvi+ySpkbYSOHMvlNqOMgo6IP0hmhQU3CE5BtM8Q7+TI5UsHq9QX6QDFLLcFn6Dvy6DEq2nFOpTk6mIIkHPKbjkZDn1asCRTW2YdoHxoVHrVPhDwnLIfllSjOthybN/SGXhuCnKwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5832.namprd11.prod.outlook.com (2603:10b6:510:141::7) by IA1PR11MB7871.namprd11.prod.outlook.com (2603:10b6:208:3f5::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.14; Tue, 6 Dec 2022 15:44:19 +0000 Received: from PH0PR11MB5832.namprd11.prod.outlook.com ([fe80::ef44:2061:3d86:6b21]) by PH0PR11MB5832.namprd11.prod.outlook.com ([fe80::ef44:2061:3d86:6b21%9]) with mapi id 15.20.5880.014; Tue, 6 Dec 2022 15:44:19 +0000 From: "Gujjar, Abhinandan S" To: "Kundapura, Ganapati" , "dev@dpdk.org" , "jerinj@marvell.com" , "Naga Harish K, S V" CC: "Jayatheerthan, Jay" Subject: RE: [PATCH v2 1/5] eventdev/event_crypto: process event port's impl rel cap Thread-Topic: [PATCH v2 1/5] eventdev/event_crypto: process event port's impl rel cap Thread-Index: AQHZBVC3oQ6WhjvCkkmDc2uv704rgK5hB7og Date: Tue, 6 Dec 2022 15:44:18 +0000 Message-ID: References: <20221130171014.1723899-1-ganapati.kundapura@intel.com> <20221201064652.1885734-1-ganapati.kundapura@intel.com> In-Reply-To: <20221201064652.1885734-1-ganapati.kundapura@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB5832:EE_|IA1PR11MB7871:EE_ x-ms-office365-filtering-correlation-id: 601813ea-954d-4b10-419d-08dad7a0bcee x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 736kxWk0o1LpuiKA+/wsPNvo/oAK3ZQMyeZ5zG83n9FyDH712lmamJj6q4XO7/GJTqSA7gf16L1uVjQLm5HI28FgfIirybQUxSh3AHZGWEYf1rDMOylWpdtbqYr4krhd+4txPXK9i3rL2W77BSVT4nNCOyWMRMuEWAmMnatbGHnGhVKihi5NLC2bNeb/t/yq0NprUUwLTpJ6pgfTqNn44byh7yRAaSQhARJotshfHyA4mpNCVnCGAbKKaMdCb/z3SQvLtvvZgAUjD4bf61YKg6lg4yQFKTgOtEs6JXPOsTZhP2k6kKWSd4txO1YObeE3uFWywBrT76s7dOrjjudK+NcVfIfNnbLLzSxADadiXE+VDXWx98eq8MEiR3i1bbdHczGKKh2rlEG6Csr6EO2F/pa4VT8YWE9EYfNp5lRel0eiez50QcfC1G9ZHSWQu4lL/265RMTUdLoA9Vt/0OYvYVML3+QxmrDonNWf/06dCvWCAzh5L7hWN0H7Swj6bAV8hSiNkfrBtyOeTsNRBBl78ihrPSxr/TVSLz8vn27O/5ArRkeU9aok2BFWKmMJVkL7n/BjDt4Ii/SJEc3rbfZkogzemicY16GOduAfmJe4oCKgrjHDY6p+s5OWKeEJdhwOozQLpTjdakOeUIOqSKDcfBIANPFYOs7bd0E+VwwhQrCaAUkd09cHUuWeEsrincUtk6F+J46zGu0oxZmCzmyeYw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5832.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(396003)(376002)(346002)(136003)(39860400002)(366004)(451199015)(2906002)(82960400001)(478600001)(38070700005)(33656002)(41300700001)(4326008)(64756008)(8676002)(66446008)(66556008)(71200400001)(86362001)(5660300002)(8936002)(52536014)(55016003)(66946007)(66476007)(9686003)(76116006)(110136005)(186003)(26005)(6636002)(122000001)(38100700002)(316002)(107886003)(83380400001)(55236004)(7696005)(53546011)(6506007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?H/ZmXNF9I1hDAOTsKWI2/1mT/JlnsPUhE6CG/m8AbDUc78/BanA0VaVzX1hw?= =?us-ascii?Q?Fez4IKcm2dg0LhAZM3H10QwvwyTX//0u2sK9ob7k7RlY+kPlmnXJbcf2SZ8S?= =?us-ascii?Q?hTdC/jlJTDtoOijNoI3kB7+YLa8Qaucq76+ymdoHPT0tu8J4bQJWm48o7kSc?= =?us-ascii?Q?ulpas7SSlw2UmHJ1BsylC9wRpMF+zebxsXSENG2xEII2Ni9dgNrFDLu9wAGw?= =?us-ascii?Q?wziJiLlScEjfwtn9sACDWLLHJqkDecBH5mPZ44BcYh61GEKG8kUyIKgoUQZQ?= =?us-ascii?Q?NSdbSSgYV8GPErgvBs0J/6T0/FfsPevDBpFdBgPGWwymAqHnVPEZfgbbqDku?= =?us-ascii?Q?MC/ahpfGwWwW4YUHDwd+CAVdmffyJl8vcZ6Em9mNmWqHaPspe19gd4RnV86m?= =?us-ascii?Q?YppRfe1yvtVOf4TdUOY6kDoGEJ0ZlF5OyWOuvEmBrTkBSUllwj9D0nTbjg9N?= =?us-ascii?Q?PYrFYuRPu50TsP/R9MWuU9ZbU3/fqdu2P5jJ6CnTb+2bIhd/ngi72kxJARns?= =?us-ascii?Q?c/joymKmJ6/HhqHVoqOb1V4tTJYLCgw7AgQ9fr09WoZURjUr5I16izDOGRuq?= =?us-ascii?Q?B8OJP/dFwDEF902gtZ0uixxPqgpFmcJ25Tdp2s5atMt7rZfejEwTRc6vOEi1?= =?us-ascii?Q?W3R5AMtS1J2DD+89Lg8AmE+WYo2x876PkpqJSO8M2+HVV4J53NFDpjUKZktB?= =?us-ascii?Q?OmYwOre8NadsPa8X1mRM/+6WVhABUgHwQW3ZRcXhVSuoF31/RRIYFfAKc9DY?= =?us-ascii?Q?NukPOSbNSOEvj6C61zwLBHCHbv3DSKVpI5jdvfQ4Y5kEAy5xl+1Mrn+mPfOX?= =?us-ascii?Q?2B7fPCetZ5GLeDgvjbvZIYxneL2BqXdhmnVBRhXQkCMLW6ZEKjCIA0ydyf4s?= =?us-ascii?Q?QV6g/vke6eLBZWiQVIAl2727yWNxw5Dn+7xbGpVuzRYtmvg95TjF9KdeCW1Z?= =?us-ascii?Q?+P22DUqGyVBN6J++Zau/QBceB8zaCdRDITMTI2sG4do97jnHJuKyq01yWtEo?= =?us-ascii?Q?2n599XXnE8t2K4hqTfx3U1IHhUCcd6b01dqGyHGiz3vt51av460ZckLm+cnd?= =?us-ascii?Q?eYAOFzYx6Wwgd69/lHmQDdzJiIkPe2d10YIIl+z54lkLNvlz/rKOsedCtnLV?= =?us-ascii?Q?r2nPK+/CBhj46YNab+gvKi8dcc0BmLofByUn8QHXLlE7fPij564h0znuBAlH?= =?us-ascii?Q?SP8rXeznQHUC9SitSs00KU1S3dNj10TNnLtptjH9+GfRu2qA8xKOOKeswXVU?= =?us-ascii?Q?vIrkXwD9kXwVUOESrlEt3HJiP83z5ZVj3nkT8v3WMySKck3nCPlosEhsHM4z?= =?us-ascii?Q?iaTEY7yYExV87f7LXRjXuYIOQ6fKgovz4iDZewIHpdyuDK4sD1Flk8nmhjKd?= =?us-ascii?Q?7uzBXCrG8jD5moZICVfLWO7ZSgj6u/jSsIuIv1LePceBmmT4bm7k3Vvg7QhD?= =?us-ascii?Q?qREP48YhfqA2lEI8oQ9/5mV4EGPrNRgs66+LHfuF7sWF5hfeb9ezRB4Y43HN?= =?us-ascii?Q?anyFZsA5HHb3uCNzvYE5g0I/RDQnPbFf/yrmICWkY/XpGZwNKLA/zc2s53/a?= =?us-ascii?Q?A75pgN1UgY8DXg8WpbGSAKMK+TtTzn2IGK/L6s1Vxz0DsdVVvDc1UMLovZPE?= =?us-ascii?Q?Hg=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5832.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 601813ea-954d-4b10-419d-08dad7a0bcee X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Dec 2022 15:44:19.0191 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: SDB5rY8mcRny54Cpae14HlBlLckTUrzkdDZOlz8E5aIi/bqz8iwUquuQbQzmZzF6v1aNGniXl4iTleRKqUunvyLPjriD5xkYJsb6ZFeTPXQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7871 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Kundapura, Ganapati > Sent: Thursday, December 1, 2022 12:17 PM > To: dev@dpdk.org; jerinj@marvell.com; Naga Harish K, S V > ; Gujjar, Abhinandan S > > Cc: Jayatheerthan, Jay > Subject: [PATCH v2 1/5] eventdev/event_crypto: process event port's impl = rel > cap >=20 > In the current implementation adapter queries event device's capability f= or > implicit release support. >=20 > This information is used to decide whether events are enqueued back as NE= W > or FWD events. >=20 > This patch updates the adapter to query the port caps for implicit releas= e to > decide on events enqueuing back as NEW/FWD events. >=20 > Signed-off-by: Ganapati Kundapura > --- > v2: > * Updated subject line in commit message >=20 > diff --git a/lib/eventdev/rte_event_crypto_adapter.c > b/lib/eventdev/rte_event_crypto_adapter.c > index 3c585d7..1c0a22b 100644 > --- a/lib/eventdev/rte_event_crypto_adapter.c > +++ b/lib/eventdev/rte_event_crypto_adapter.c > @@ -53,7 +53,7 @@ struct event_crypto_adapter { > uint8_t eventdev_id; > /* Event port identifier */ > uint8_t event_port_id; > - /* Store event device's implicit release capability */ > + /* Store event port's implicit release capability */ > uint8_t implicit_release_disabled; > /* Flag to indicate backpressure at cryptodev > * Stop further dequeuing events from eventdev @@ -320,7 +320,6 > @@ rte_event_crypto_adapter_create_ext(uint8_t id, uint8_t dev_id, { > struct event_crypto_adapter *adapter; > char mem_name[CRYPTO_ADAPTER_NAME_LEN]; > - struct rte_event_dev_info dev_info; > int socket_id; > uint8_t i; > int ret; > @@ -361,17 +360,6 @@ rte_event_crypto_adapter_create_ext(uint8_t id, > uint8_t dev_id, > return -ENOMEM; > } >=20 > - ret =3D rte_event_dev_info_get(dev_id, &dev_info); > - if (ret < 0) { > - RTE_EDEV_LOG_ERR("Failed to get info for eventdev %d: > %s!", > - dev_id, dev_info.driver_name); > - eca_circular_buffer_free(&adapter->ebuf); > - rte_free(adapter); > - return ret; > - } > - > - adapter->implicit_release_disabled =3D (dev_info.event_dev_cap & > - RTE_EVENT_DEV_CAP_IMPLICIT_RELEASE_DISABLE); > adapter->eventdev_id =3D dev_id; > adapter->socket_id =3D socket_id; > adapter->conf_cb =3D conf_cb; > @@ -837,6 +825,7 @@ eca_init_service(struct event_crypto_adapter > *adapter, uint8_t id) > struct rte_event_crypto_adapter_conf adapter_conf; > struct rte_service_spec service; > int ret; > + uint32_t impl_rel; >=20 > if (adapter->service_inited) > return 0; > @@ -866,6 +855,17 @@ eca_init_service(struct event_crypto_adapter > *adapter, uint8_t id) >=20 > adapter->max_nb =3D adapter_conf.max_nb; > adapter->event_port_id =3D adapter_conf.event_port_id; > + > + if (rte_event_port_attr_get(adapter->eventdev_id, > + adapter->event_port_id, > + > RTE_EVENT_PORT_ATTR_IMPLICIT_RELEASE_DISABLE, > + &impl_rel)) { > + RTE_EDEV_LOG_ERR("Failed to get port info for eventdev %" > PRId32, > + adapter->eventdev_id); You need to free memory allocated for adapter + adapter->ebuf before return= ing error > + return -EINVAL; > + } > + > + adapter->implicit_release_disabled =3D (uint8_t)impl_rel; > adapter->service_inited =3D 1; >=20 > return ret; > -- > 2.6.4