From: "Liu, Mingxia" <mingxia.liu@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Xing, Beilei" <beilei.xing@intel.com>,
"Zhang, Yuying" <yuying.zhang@intel.com>
Subject: RE: [PATCH] net/cpfl: fix a compiler issue about virtchnl opcode
Date: Thu, 9 Mar 2023 03:03:25 +0000 [thread overview]
Message-ID: <PH0PR11MB5877403A00FA30CB2FB12274ECB59@PH0PR11MB5877.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230308184143.32a8a6d0@hermes.local>
> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Thursday, March 9, 2023 10:42 AM
> To: Liu, Mingxia <mingxia.liu@intel.com>
> Cc: dev@dpdk.org; Xing, Beilei <beilei.xing@intel.com>; Zhang, Yuying
> <yuying.zhang@intel.com>
> Subject: Re: [PATCH] net/cpfl: fix a compiler issue about virtchnl opcode
>
> On Thu, 9 Mar 2023 10:31:42 +0000
> Mingxia Liu <mingxia.liu@intel.com> wrote:
>
> > iff --git a/drivers/net/idpf/idpf_ethdev.c
> > b/drivers/net/idpf/idpf_ethdev.c index db58157ba3..59883af8a8 100644
> > --- a/drivers/net/idpf/idpf_ethdev.c
> > +++ b/drivers/net/idpf/idpf_ethdev.c
> > @@ -1058,8 +1058,8 @@ idpf_handle_virtchnl_msg(struct idpf_adapter_ext
> *adapter_ex)
> > struct idpf_ctlq_msg ctlq_msg;
> > enum idpf_mbx_opc mbx_op;
> > struct idpf_vport *vport;
> > - enum virtchnl_ops vc_op;
> > uint16_t pending = 1;
> > + enum virtchnl_ops vc_op;
> > int ret;
> >
> > while (pending) {
>
>
> Why does order of declarations matter here?
> Compilers are free to reorder this.
[Liu, Mingxia] Unused changes, v2 was sent.
next prev parent reply other threads:[~2023-03-09 3:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-09 10:31 Mingxia Liu
2023-03-09 2:41 ` Stephen Hemminger
2023-03-09 3:03 ` Liu, Mingxia [this message]
2023-03-09 10:38 ` [PATCH v2] " Mingxia Liu
2023-03-09 12:10 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR11MB5877403A00FA30CB2FB12274ECB59@PH0PR11MB5877.namprd11.prod.outlook.com \
--to=mingxia.liu@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).