From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5FDF442D94; Fri, 30 Jun 2023 12:46:12 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 38C7E40EDB; Fri, 30 Jun 2023 12:46:12 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id CA605406B5 for ; Fri, 30 Jun 2023 12:46:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1688121971; x=1719657971; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=i00j3qyrMAJJsEUHbqvgJfy2HS5SHxXBeXNxcVMZCpA=; b=SrweWQAK5ecvXlUG2DH70j784qOeP1WacJ7Qa7WcYbuJ+tfDkJnkJWMA HUI4hBNn7AuvzyX1gxJ6//vXGss3/fNLYHzFWaVtUir64U7UZkZlEJUnB diY3X3XecEECr6kUhQsAI/hRlK7spYVRnywYfdoJWWmi08JFeXzpblKsD BNjBHaK4LsPMZFKZCUul9X2wc0VxX1oTW+1yvpGu1LKVC6LXEdRrHLnAO 2m1Bo3zjeJ9pnmvoeE98t1xxNd/60JV6S35KTLmLYjiA1odSOlekKWBN8 xyoexlxhNmVYksOV2H28QAhjZGFMxvcX8lP+LoEVkASOMYJr0XeLlBYbM g==; X-IronPort-AV: E=McAfee;i="6600,9927,10756"; a="352188848" X-IronPort-AV: E=Sophos;i="6.01,170,1684825200"; d="scan'208";a="352188848" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jun 2023 03:46:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10756"; a="783044550" X-IronPort-AV: E=Sophos;i="6.01,170,1684825200"; d="scan'208";a="783044550" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga008.fm.intel.com with ESMTP; 30 Jun 2023 03:46:09 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Fri, 30 Jun 2023 03:46:09 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Fri, 30 Jun 2023 03:46:09 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.45) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Fri, 30 Jun 2023 03:46:07 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K+He1qXmylji4u2urCCKPAhVdqd3OneF3+UmwfS+BPw9d0qWRG3i3a3XCBx7LqHkFyB5xGiuMuc5FnhfkulyM2bLdYb2MoPXVTuHuKSw4j8iOcDsUv7lC16Uq2dLqdhmWIlL4REcZFgRlQ0r8hZi5W4J0KomID24oQw/5VczxaUM3ryHV7UHYkLlquz2jWqvomx3xE8zFZkqANTHiXzq5JpoY2WNBqaNXZo5E0h/ITKZ0QKRuGpO7OZlC1BRNempmcErPMsIzz398N9rhwEMU1IfSZ0pUl+BikHg5xkzvY5vyGj4zXbmvPD+ykURVZD9VgCXzl0LMhhKq0T9k24jug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/gW0jfyNq2t1WV4l62T0Zau/MvS/SU9rER8G25aNCyk=; b=LENje4Awy7y6D0cIbv03E2zioCKp35CmQTALXPLYK9S+b72cfCpf0rQ0uJsRifEuQ05A/B073U7tcPqit9NbYRxdJUsk+ObQw5IrSntIgVe6o2CLE2SdTki/d9JXhISOgFUS0xTEmjdj0D/hSkIJbMKiH7PBx+Vd/+IvcnOL49G0ma/Da+bvmPzIOlHwFVGRGmh1qT0EislaI7jyUB5OjVz/VbSLrC1Zn3zA8Pilo2ZMnZdRIDkG3DpPhliLN1rIzzgrObiodwRWhSSGgJ8V7E3i9SkPlq0g+edRvESGsbwQUOlywcoZGBRt1cR569rdtaYLUPVKcXj4noAfEMcA+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5877.namprd11.prod.outlook.com (2603:10b6:510:141::12) by PH8PR11MB6949.namprd11.prod.outlook.com (2603:10b6:510:227::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.24; Fri, 30 Jun 2023 10:46:05 +0000 Received: from PH0PR11MB5877.namprd11.prod.outlook.com ([fe80::da1b:ee87:709:3174]) by PH0PR11MB5877.namprd11.prod.outlook.com ([fe80::da1b:ee87:709:3174%5]) with mapi id 15.20.6521.024; Fri, 30 Jun 2023 10:46:05 +0000 From: "Liu, Mingxia" To: "Zhang, Qi Z" , "dev@dpdk.org" CC: "Wu, Jingjing" , "Xing, Beilei" Subject: RE: [PATCH] net/idpf: refine idpf_dev_vport_init() function Thread-Topic: [PATCH] net/idpf: refine idpf_dev_vport_init() function Thread-Index: AQHZp/HXMmiBtqQLlE6fvsrekcYc/6+jBYEAgAAAYYCAACotkA== Date: Fri, 30 Jun 2023 10:46:04 +0000 Message-ID: References: <20230626140606.490871-1-mingxia.liu@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB5877:EE_|PH8PR11MB6949:EE_ x-ms-office365-filtering-correlation-id: 3fee9475-f992-4cb5-8db4-08db79573443 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: yBRpnrHYVqJSf7IXhMYfBwc43wQBXi+NVD2uEJ3bZ3eb6gHZewm0VuGhkFzKUERJvsSEzI7dOZGWBI6sK/lr+jSLak8gRpYqn5Uv31TsuZNeffjMdwsnZlXBN4yZb6SExi/m1Zp7VGq36+XKXfrAxbjUGS6F2ESvLBna4LpSNv0O5UH9yWwOl8jmBXYnBcZxmlVa4XjP5juVMTB6E7Tl52SkwR5S8Yz0eWaeiql/SlLpamP7TZKykcXHFnBjXIcR6/MH+WKsAsBf1oD+V9LbYwsuLQEwsSB09jkSCq2qX6UMeK++LXEjdIaJr/mCtwZ8RttXJQ0KmKnJ6VvFzwmbJ2FoqeQCnr3LV2LVcaVHPiyAKeeQIUBxhSU0kxQUzocY6CoHNS822HvH17KLtqNz4wjP5elXjn/g4YBf16PuEAbRtRLWCfIW53jtU33PAZiUHEDTqEoJa2YJ1xP5cx3zTh7H9niE9QWtYCQjFHNQwsdcu/YFDmcZ7b/5Q42D6K5oPm00rGkGr9PZu498s3JK7xWuZS14es5gE7eAVfc3pqnk9WM8/yOSe/jSjaQ5F3fRjTIPYt6FzrUUB3bLgcwnocYw4bST2rsnt2wvn0myJrna+wXZrDUjgSw3rNFBmezV x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5877.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(346002)(376002)(39860400002)(366004)(396003)(136003)(451199021)(66476007)(66556008)(107886003)(71200400001)(54906003)(83380400001)(6506007)(110136005)(53546011)(478600001)(9686003)(26005)(66446008)(7696005)(2906002)(186003)(33656002)(52536014)(82960400001)(38070700005)(122000001)(55016003)(5660300002)(8676002)(4326008)(86362001)(66946007)(38100700002)(8936002)(64756008)(76116006)(316002)(41300700001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?uEoTturZpj0jf6QXR2GegZJJR7TTlZC0z4qYGXMSrbYqMPjqI52bjC6wmgtL?= =?us-ascii?Q?pU8gsXC0N4GXB/+LCHQ0urL455Aqc6MfQMamYG2zweMOgYTfFx8C6kdSApFs?= =?us-ascii?Q?pGbSsERrfXlbffG0rkeiJDvZABjAtg+OSlh5rKXsLPni3XpB2BGfP8YUPzvl?= =?us-ascii?Q?mTs0YFrt6kUpG436CNZ15Ia9krhD2379KlOXdJMcuuc6bzMgjDATUYNETrl2?= =?us-ascii?Q?XqURdqtrJ962JLGnBbnuoGcmH8AtjVFPuoI2luoevuaqNM29w4AoatzUxxX6?= =?us-ascii?Q?NL5cODTrybrTsNqryCAc8HTTfNb7RFe2YEAouulSbe2235y12MBpPMIewyBg?= =?us-ascii?Q?+lkees2WWktJ8E0GPxXqH5xdodHnlAoyR2ldcxkb8hsatWACvTWaGZ0X7TII?= =?us-ascii?Q?yq9ihDS1ANour0BbO2zHRqb/LupdQ8FLW7ci4zInTs2y1qEbZu1iXR6zXw5h?= =?us-ascii?Q?QRbIqyaFrcGz5jiTIbD09bcfX6lQMgFGUHKM2ouoe+T9LVJEw9esxf43/oid?= =?us-ascii?Q?lbs7dZS0LhqxMTowiPiGL8/dGvm84RL6aKE4MyY1sW4IaMaVcCwXrpHbcXbf?= =?us-ascii?Q?OLmB10RjxmA6Om4ykWUB74GIB+U2HCYoqJGeCsEnPzOViLkRQS/nFd5CNrdd?= =?us-ascii?Q?+XRUYhoRkRJqCZkUSHmezE46yM/8mxBBdDoL5Jy92aKx1Qayk5dIuvAhT1j4?= =?us-ascii?Q?MSAyyU7oHRTguqUz0yS97jqDo1Sq/DUfoZP13i3Pyu6Fo90zgy98a+GpDhRM?= =?us-ascii?Q?uYpYCiPalljOGn4pYT9fe2wEIItqWbGBNUYQ3xrq8k/MDBQIxwYdqfYdL44A?= =?us-ascii?Q?8lh+yIPjqyzH3pFGr8TW+qfCxcGXgJBURFHDhJgUk/Fkpui1eUGbuiud8I3t?= =?us-ascii?Q?qTg58A2CiIJQ3+V0q2Vm0MYZu1iWMsOPgiKbEYcF031YCg560q5mJil4TZ4J?= =?us-ascii?Q?vyLw/s8Vh5xrGtXdibzScAZC+UtLh1U0h6ZIMhuU4zgfzchmXofIem4pn1Qy?= =?us-ascii?Q?pX9lvL/fBdzo9JWLO6VbPB2tz7piYiKJNZNHWv5xn4TmCOJD/cj6YxQPljXm?= =?us-ascii?Q?bFFbzSmSoTPtyE2YvrieEUH3htfirhbDOQtSwpqQQX3xlOJcultlZ0XyjtZG?= =?us-ascii?Q?YcZIQWN967JzosQXsuF17rW3tsGnTBkJ+iIo55bUMZRrfXQakP2euyz+fIEQ?= =?us-ascii?Q?xT6NQLpM18cWrfLjzTdIH1XtFtD0fxWEoAwmDhHxTz4g/AnGZ14vowt1+QMv?= =?us-ascii?Q?NR9+aWJS5rrU5KibpU/mZOyUe5vBiLb2HL9oFxmu1YyoHs9w7DXj4uFUDQjj?= =?us-ascii?Q?1IvnLFheXmQFbIxfqk5V4HjVQ9VIb/RYUX8TIJg/Ec9Teafb65rLx32L5qJf?= =?us-ascii?Q?QtmJqDu+4ahBmslYZqqgAIqo3htD2MMaEJCwOss+zRO0dS0ZpIEk4v/VllmQ?= =?us-ascii?Q?/RvgSyhE+jaFH9KDLK/4pkJKk9jWpYJPHMKIIWS+ATtQzMQ0w8dQRMipUWad?= =?us-ascii?Q?pTotVZt1XVXddkGLS3ypKbCiC4xNPoQlNs6yn7YwxJPD5N/RLkei273Huuky?= =?us-ascii?Q?3yo2ImI5QnQZTDm1QJJ2ycarOS5SUriGlf/iWMGm?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5877.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3fee9475-f992-4cb5-8db4-08db79573443 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Jun 2023 10:46:04.8642 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6P1BDNfzMWAaSGDtmiAhI0/Mcp+fgIrYCdeQA/Xigg4k/jipd2AEBDQcs2wt9Hur6ORAQDrGOZQML8ziiZMIrw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB6949 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Zhang, Qi Z > Sent: Friday, June 30, 2023 4:14 PM > To: Liu, Mingxia ; dev@dpdk.org > Cc: Wu, Jingjing ; Xing, Beilei ; > Liu, Mingxia > Subject: RE: [PATCH] net/idpf: refine idpf_dev_vport_init() function >=20 >=20 >=20 > > -----Original Message----- > > From: Zhang, Qi Z > > Sent: Friday, June 30, 2023 4:13 PM > > To: Mingxia Liu ; dev@dpdk.org > > Cc: Wu, Jingjing ; Xing, Beilei > > ; Liu, Mingxia > > Subject: RE: [PATCH] net/idpf: refine idpf_dev_vport_init() function > > > > > > > > > -----Original Message----- > > > From: Mingxia Liu > > > Sent: Monday, June 26, 2023 10:06 PM > > > To: dev@dpdk.org > > > Cc: Wu, Jingjing ; Xing, Beilei > > > ; Liu, Mingxia > > > Subject: [PATCH] net/idpf: refine idpf_dev_vport_init() function > > > > > > This patch adds 'cur_vports' and 'cur_vport_nb' updation in error pat= h. > > > > > > Signed-off-by: Mingxia Liu > > > --- > > > drivers/net/idpf/idpf_ethdev.c | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/drivers/net/idpf/idpf_ethdev.c > > > b/drivers/net/idpf/idpf_ethdev.c index 801da57472..3e66898aaf 100644 > > > --- a/drivers/net/idpf/idpf_ethdev.c > > > +++ b/drivers/net/idpf/idpf_ethdev.c > > > @@ -1300,6 +1300,8 @@ idpf_dev_vport_init(struct rte_eth_dev *dev, > > > void > > > *init_params) > > > err_mac_addrs: > > > adapter->vports[param->idx] =3D NULL; /* reset */ > > > idpf_vport_deinit(vport); > > > + adapter->cur_vports &=3D ~RTE_BIT32(param->devarg_id); > > > + adapter->cur_vport_nb--; > > > > Can we move below two lines to the last? > > > > adapter->cur_vports |=3D RTE_BIT32(param->devarg_id); cur_vport_nb++; > > > > so we don't need to revert them in error handle >=20 > Btw this is a fix, please also add the fixline. > > [Liu, Mingxia] Thanks, new patch has been sent. > > > err: > > > return ret; > > > } > > > -- > > > 2.34.1