DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Liu, Mingxia" <mingxia.liu@intel.com>
To: "Qiao, Wenjing" <wenjing.qiao@intel.com>,
	"Wu, Jingjing" <jingjing.wu@intel.com>,
	"Xing, Beilei" <beilei.xing@intel.com>,
	"Zhang, Qi Z" <qi.z.zhang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: RE: [PATCH v4 1/7] common/idpf: fix 64b timestamp roll over issue
Date: Wed, 24 May 2023 08:36:49 +0000	[thread overview]
Message-ID: <PH0PR11MB58775F148CAC54A738352A8FEC419@PH0PR11MB5877.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230519083110.809913-2-wenjing.qiao@intel.com>


> -----Original Message-----
> From: Qiao, Wenjing <wenjing.qiao@intel.com>
> Sent: Friday, May 19, 2023 4:31 PM
> To: Wu, Jingjing <jingjing.wu@intel.com>; Xing, Beilei <beilei.xing@intel.com>;
> Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org; Liu, Mingxia <mingxia.liu@intel.com>; Qiao, Wenjing
> <wenjing.qiao@intel.com>; stable@dpdk.org
> Subject: [PATCH v4 1/7] common/idpf: fix 64b timestamp roll over issue
> 
> Reading MTS register at first packet will cause timestamp roll over issue. To
> support calculating 64b timestamp, need an alarm to save main time from
> registers every 1 second.
> 
> Fixes: 8c6098afa075 ("common/idpf: add Rx/Tx data path")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Wenjing Qiao <wenjing.qiao@intel.com>
> ---
>  drivers/common/idpf/idpf_common_rxtx.c | 126 ++++++++++++++-----------
>  drivers/common/idpf/idpf_common_rxtx.h |   6 +-
>  drivers/common/idpf/version.map        |   2 +
>  3 files changed, 77 insertions(+), 57 deletions(-)
> 
> diff --git a/drivers/common/idpf/idpf_common_rxtx.c
> b/drivers/common/idpf/idpf_common_rxtx.c
> index fc87e3e243..b487c2a8a6 100644
> --- a/drivers/common/idpf/idpf_common_rxtx.c
> +++ b/drivers/common/idpf/idpf_common_rxtx.c
> @@ -4,6 +4,7 @@

/* re-alarm watchdog */
> +	rc = rte_eal_alarm_set(1000 * 1000, &idpf_dev_read_time_hw, cb_arg);
...
> +int
> +idpf_rx_timestamp_start(struct idpf_adapter *base) {
> +	rte_eal_alarm_set(1000 * 1000,
> +			  &idpf_dev_read_time_hw,
> +			  (void *)base);
> +	return 0;
> +}
> +
[Liu, Mingxia] 1000*1000us means 1s, better to use macro variables, such as "US_PER_S", will be more readable.

  reply	other threads:[~2023-05-24  8:37 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-20  9:19 [PATCH 0/7] update idpf and cpfl timestamp Wenjing Qiao
2023-04-20  9:19 ` [PATCH 1/7] common/idpf: fix 64b timestamp roll over issue Wenjing Qiao
2023-04-21  7:15   ` [PATCH v2 0/7] update idpf and cpfl timestamp Wenjing Qiao
2023-04-21  7:15     ` [PATCH v2 1/7] common/idpf: fix 64b timestamp roll over issue Wenjing Qiao
2023-04-24  9:17       ` [PATCH v3 0/7] fix and enhance idpf and cpfl timestamp Wenjing Qiao
2023-04-24  9:17         ` [PATCH v3 1/7] common/idpf: fix 64b timestamp roll over issue Wenjing Qiao
2023-05-19  8:31           ` [PATCH v4 0/7] fix idpf and cpfl timestamp Wenjing Qiao
2023-05-19  8:31             ` [PATCH v4 1/7] common/idpf: fix 64b timestamp roll over issue Wenjing Qiao
2023-05-24  8:36               ` Liu, Mingxia [this message]
2023-05-19  8:31             ` [PATCH v4 2/7] net/idpf: save main time by alarm Wenjing Qiao
2023-05-19  8:31             ` [PATCH v4 3/7] net/cpfl: " Wenjing Qiao
2023-05-19  8:31             ` [PATCH v4 4/7] common/idpf: enhance timestamp offload feature for ACC Wenjing Qiao
2023-05-19  8:31             ` [PATCH v4 5/7] common/idpf: add timestamp enable flag for rxq Wenjing Qiao
2023-05-19  8:31             ` [PATCH v4 6/7] net/cpfl: adjust timestamp mbuf register Wenjing Qiao
2023-05-19  8:31             ` [PATCH v4 7/7] net/idpf: " Wenjing Qiao
2023-04-24  9:17         ` [PATCH v3 2/7] net/idpf: save main time by alarm Wenjing Qiao
2023-04-24  9:17         ` [PATCH v3 3/7] net/cpfl: " Wenjing Qiao
2023-04-24  9:17         ` [PATCH v3 4/7] common/idpf: enhance timestamp offload feature for ACC Wenjing Qiao
2023-04-24  9:17         ` [PATCH v3 5/7] common/idpf: add timestamp enable flag for rxq Wenjing Qiao
2023-04-24  9:17         ` [PATCH v3 6/7] net/cpfl: register timestamp mbuf when starting dev Wenjing Qiao
2023-04-28  3:24           ` Zhang, Qi Z
2023-04-24  9:17         ` [PATCH v3 7/7] net/idpf: " Wenjing Qiao
2023-04-21  7:15     ` [PATCH v2 2/7] net/idpf: save main time by alarm Wenjing Qiao
2023-04-28  2:46       ` Zhang, Qi Z
2023-04-21  7:15     ` [PATCH v2 3/7] net/cpfl: " Wenjing Qiao
2023-04-21  7:16     ` [PATCH v2 4/7] common/idpf: support timestamp offload feature for ACC Wenjing Qiao
2023-04-21  7:16     ` [PATCH v2 5/7] common/idpf: add timestamp enable flag for rxq Wenjing Qiao
2023-04-21  7:16     ` [PATCH v2 6/7] net/cpfl: register timestamp mbuf when starting dev Wenjing Qiao
2023-04-21  7:16     ` [PATCH v2 7/7] net/idpf: " Wenjing Qiao
2023-04-20  9:19 ` [PATCH 2/7] net/idpf: save master time by alarm Wenjing Qiao
2023-04-20  9:19 ` [PATCH 3/7] net/cpfl: " Wenjing Qiao
2023-04-20  9:19 ` [PATCH 4/7] common/idpf: support timestamp offload feature for ACC Wenjing Qiao
2023-04-20  9:19 ` [PATCH 5/7] common/idpf: add timestamp enable flag for rxq Wenjing Qiao
2023-04-20  9:19 ` [PATCH 6/7] net/cpfl: register timestamp mbuf when starting dev Wenjing Qiao
2023-04-20  9:19 ` [PATCH 7/7] net/idpf: " Wenjing Qiao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=PH0PR11MB58775F148CAC54A738352A8FEC419@PH0PR11MB5877.namprd11.prod.outlook.com \
    --to=mingxia.liu@intel.com \
    --cc=beilei.xing@intel.com \
    --cc=dev@dpdk.org \
    --cc=jingjing.wu@intel.com \
    --cc=qi.z.zhang@intel.com \
    --cc=stable@dpdk.org \
    --cc=wenjing.qiao@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).