From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C11D7429D4; Mon, 24 Apr 2023 10:50:03 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B324842B8E; Mon, 24 Apr 2023 10:50:03 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 4FD76410DE for ; Mon, 24 Apr 2023 10:50:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1682326201; x=1713862201; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=QVPVYJEccbZ/V1V3P5UNsezx6UbTH16sH9GffNi2l5Y=; b=XuBbdcM/2YgL6MfJE8uN6vGOk4VM+ajiRJDVCyzIkLC3pRAMBi+Qt2Fb azTmp3yYxxQqmciCEk8BfXDa7YdieHvCWj04H9YSYu8+SIVvB7uwkQsW3 f9NqZnJwpv4MWJqVF9XKA4uexxn9+aNTuYoLa1HxeGfLUrUKuFOzsuRcW 0zrM7MwrhAI12ouFtGAAPksJvPaAEFUITQKVKl6dDdEdskws0VicJf3d7 8JF7sRuOGPVuQi8PGW0MovRcjGlOz3Ds/i/C0URW+fELVB7smWQQOmWFk 5jm9qEE2zev/tfZoleBnofnxwn35UOeTE1+e+RNnq7RNd66otrZxQo1g5 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10689"; a="326007320" X-IronPort-AV: E=Sophos;i="5.99,222,1677571200"; d="scan'208";a="326007320" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Apr 2023 01:50:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10689"; a="867399143" X-IronPort-AV: E=Sophos;i="5.99,222,1677571200"; d="scan'208";a="867399143" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga005.jf.intel.com with ESMTP; 24 Apr 2023 01:50:00 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Mon, 24 Apr 2023 01:49:59 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Mon, 24 Apr 2023 01:49:59 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Mon, 24 Apr 2023 01:49:59 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.105) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Mon, 24 Apr 2023 01:49:58 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fx981O5hk1o03EE1ESkShK0Pq1m8OGQuIuiqlJs55td3y6cCROFJNJ+H9deK9CuNtgRcVLPX9yJtLXls1tsTLPyTKA4wx69cqaqlC6P1w7iWXXI/yTcUkW1HsdmO33kqLRyKryjYDDEn9Ats0JlHg17DRnFgd9oV+hAIlOCrD3IpgDlkGAs4TPeN+wmWOffyYaDF5Zsq2K2mchh+mywrSirZCGVOQ0hyLoOLR5U+BuYPD+hO4Z/hzMBPFJxQirjmhjJzMA+OYDonmlgUm4V/gXP8H5qFcLGSdomTOiAQCZ4EnZyivUrSey2wTOcS/HRZ+Xv4t6Onm2u3ofZXK1pY9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nlYEtYdXe6vVbhLFLnhtXQZAKtlpobXG9+D2gkVies8=; b=cAAQ4Ua3YXdWk3frkvOeOXr1IKdRywdI3V3SFglsw9fbY3/qCN962wqa4FN06JJbwJIxdQkPrS9SFPm8qqjx8XYh3iB5Oa9roNu7/p3LWozRS1leRFHRHe5C5WGkzrCYy+J+tUtq2JDadj9mOB8GOs4I7Ey1w3Sq812k6ZT38lnsB702QlRyLz83K18lG19EtvHZa48exQci8fXVk9QRQ6vd5j9L1YkDHqio9Kw1Si6wiiYNg9z/5P6ABpxH8X7TC3E5Fasc+0/Ak5xbtgg9cscybk/DyJMGIKI71fri6Wdarvj3lcG/K48IITflHu5Eb27GA0uL7XpGUg5F62sMkA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5877.namprd11.prod.outlook.com (2603:10b6:510:141::12) by DM4PR11MB6168.namprd11.prod.outlook.com (2603:10b6:8:ab::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.33; Mon, 24 Apr 2023 08:49:51 +0000 Received: from PH0PR11MB5877.namprd11.prod.outlook.com ([fe80::da1b:ee87:709:3174]) by PH0PR11MB5877.namprd11.prod.outlook.com ([fe80::da1b:ee87:709:3174%2]) with mapi id 15.20.6319.022; Mon, 24 Apr 2023 08:49:51 +0000 From: "Liu, Mingxia" To: "Xing, Beilei" , "Wu, Jingjing" CC: "dev@dpdk.org" Subject: RE: [PATCH 03/10] common/idpf: support queue groups add/delete Thread-Topic: [PATCH 03/10] common/idpf: support queue groups add/delete Thread-Index: AQHZdCDX46y0y7Lt1k+xQsPjGRcIYK86KwdA Date: Mon, 24 Apr 2023 08:49:51 +0000 Message-ID: References: <20230421065048.106899-1-beilei.xing@intel.com> <20230421065048.106899-4-beilei.xing@intel.com> In-Reply-To: <20230421065048.106899-4-beilei.xing@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB5877:EE_|DM4PR11MB6168:EE_ x-ms-office365-filtering-correlation-id: 38db36fd-9dd3-4de1-0efc-08db44a0de2c x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0YmSgf1Ot6XaITxDR1cciedO3vBFz+LgbKoxaPykysQEIdBEpxEVy1jagcZTlGxlTlaFba21RiRrHsxcLg4LzSTIHxefpqu1+pWNHc4bVVv81KDEoCw8fUKjOdiDdOLZokwgM/6GA0gR7LYN3JTBfOKhkkxJhZ2rWH9TWjlibhf1TBFRK8RANsumMtscYM+QRODJ0MsDgHt2r/W4yrMRUeD0/gFTSKQAh5EuuZsi/WCE/WpTJY8UQ++s22JqhEn3rDJeilUsF9ed1aRqhBIRhr8sVPnCiFamtd5KTYYey6cSdRLNPD7HTWvAE3BRb23raUDbb461xc+ttMp2PJV9kUPjTv8uD8MDBLpm7FebdKxodmo6Ohv+LEI6UNkkLhLBTfGkyH6DavRFmVz6Ng6vPLsBgY8ehbYgMHZzg7s6BPxnYJK1LQV4yGgTlDPkjmZSI2mtr9E4f8fAuyfrYu1FylDiKNCbs0JO7zV1Mxv7eVQ8ZLPc4paaHNPAAvTWwTYA4ISkL9EPxuQnoc5UMyHDFSxcu+WfEgZywrDEzhNsRkqb8A9hk4xRTgnbyXAGsZOp10e9Rm8zzj2e54EvQM7SN7zkejjXtNKY0PybJmFLeTXEbJRBRSvQycBc4MlrhSG7 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5877.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(39860400002)(396003)(366004)(136003)(376002)(346002)(451199021)(26005)(9686003)(53546011)(6506007)(186003)(55016003)(6636002)(110136005)(33656002)(86362001)(478600001)(8936002)(38100700002)(5660300002)(52536014)(8676002)(83380400001)(316002)(82960400001)(64756008)(66446008)(66476007)(66556008)(66946007)(76116006)(4326008)(38070700005)(2906002)(41300700001)(122000001)(71200400001)(7696005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?hR6xMDZ/xFmdsbeMHl3gCOCi1LMT/hxhNAWGJNXIaP1Ay2gr1i09eCVIsF1C?= =?us-ascii?Q?nAJe8i5d7qQXuY27s+Ha6Wpq3xfVg0f4EuH//jisG8JRbwDyFD9qPT4kGvAe?= =?us-ascii?Q?WOaEu6yQKNqCT+aQxqP/6ACOmZ7BJTm5fuD8xt3WAFsJzjG1oe6JjJ+Xsbkg?= =?us-ascii?Q?3nTPykVNp+eLj5IFu8LOQDebU/zpQ9Lyn+VHeJUlC12k5rG6r+aP04n56SqE?= =?us-ascii?Q?FSpOQv/24reNg1O9wRc9t2jAXr7qZLoy7ckv9NFoMQGWnqz2o9Rl8829J3Dj?= =?us-ascii?Q?KXd/OY78tomOmJHlc/WWSeDNZW3o5y3v1vSclxFHSPks+n3Ew4aqLDw/eVoh?= =?us-ascii?Q?CGHxfbsGPMzo16B7DIaQE1SjO4XGtR1Np91m0ymAhgQpORzxc1q3lF0hzw7m?= =?us-ascii?Q?DW7wkoENB4WD0oq5yP58Lb0A5hYc3N+RturqAM4mB8FZ8jR+ej39ULls9gFm?= =?us-ascii?Q?0hK5iTEunrUJdoZ3YCCtUzeQSDzWYVLsUuztXczAx053NUapjVa9WwI8FKqf?= =?us-ascii?Q?0jZt6B232p9IPaFH8BgnoTbeWkbnEVdHcPScYKRNvT08uii3huzJp2Ls6g9/?= =?us-ascii?Q?ehzujVwRmAO8t0bt8E7yMAYHNUGr1lHSnAjtdaqCLz+C6ZnYPhuJZrL4ebgU?= =?us-ascii?Q?1kR3Bqvh0fLgfcLI7/q+CIkHmbvVnYO0fvmK2QNyImne/1BPmah/03LJ/iEI?= =?us-ascii?Q?FTTCz7a+R22AY4Om4bxoAJgM5/JxBN0cwSyaUbWOFQg4bG9j+JHkC5Ubn03s?= =?us-ascii?Q?etvgzCFxCdFQqgi32MSkwqYL3RCQ7Rusjt4Iuk8QkKrwD+Qywx4hx3PLneYy?= =?us-ascii?Q?LC0W3RyF3Opc5cZRaoMyJgsRn8C/TzGW5q/N7jpwfcno9v07XT0zo3JcGjKM?= =?us-ascii?Q?Whc8hFmQCC8EAkXF/b9BZaDTaD7zjg795lVgo4dBFeG7HO4Mp3VzN259ykP9?= =?us-ascii?Q?rV2OeY+iuXyp/UFpiiVQBRcboVEMeQ+u9YgWw5Upja714+cCnP26MPHUOueT?= =?us-ascii?Q?fZDjNCRX5g6tX3eT7I16zMJVpNivFBdpFdgwUiK8jz+J6gb53ltcj3L79mB3?= =?us-ascii?Q?mmFHx7nuiJ/5W6+vTVVjdMs/pJIiSp1pYwnSQqf3P04q5S/ipLO0xUrP6qpd?= =?us-ascii?Q?xLmnXTRjsbfMfRBumiK4XwuXcxCu7dHrX4WZ3NmG1PzluAqlSOxVaplpwHod?= =?us-ascii?Q?yau0QjO7EWhygJ9rqNS+pOHggN93NPMQceE7NA4nrujLrHrJ1f4tyLoFh5pC?= =?us-ascii?Q?b4DOoyxnTW+yJ8QmFjQyKd0tty43Io7CXTmD+DhVObbuBsWpKy9BIyR2DRHD?= =?us-ascii?Q?nZFWmXkEf9enV4/JwKeIsY2ePvPMQKxUOFjcTMp2tqFqlx1kcNbyothdh6NV?= =?us-ascii?Q?WCTNOdOOLStH1jG8f/zQN9xNSIcvc3Ka/2w0G2wAaZzCFwdJcSVPDH1J2YWr?= =?us-ascii?Q?cfr794HCcc+ogEpQyzTtPDARQwY8nqveMjh3qGkHisMW6OGDI7bwgByKwnGH?= =?us-ascii?Q?pnI/aNBJj8iqvEE3I9YcFGWj3vWeaZ7ZbV0z3RcjZxZ3+u9lIAuXCqOWGhLi?= =?us-ascii?Q?q7rVo+RiRva5i2Z1OexSgb2CJPrZ7ZVBpcEA0JzH?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5877.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 38db36fd-9dd3-4de1-0efc-08db44a0de2c X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Apr 2023 08:49:51.5332 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ZllDjpcRs5r5uhB87sT8ICCc6SIhmY7XfbtD/YF6owCDe7mJGW7u9zel/e1pNuri+c5lfuxIwMMiN+1mHMEKjA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6168 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Xing, Beilei > Sent: Friday, April 21, 2023 2:51 PM > To: Wu, Jingjing > Cc: dev@dpdk.org; Liu, Mingxia ; Xing, Beilei > > Subject: [PATCH 03/10] common/idpf: support queue groups add/delete >=20 > From: Beilei Xing >=20 > This patch adds queue group add/delete virtual channel support. >=20 > Signed-off-by: Mingxia Liu > Signed-off-by: Beilei Xing > --- > drivers/common/idpf/idpf_common_virtchnl.c | 66 > ++++++++++++++++++++++ > drivers/common/idpf/idpf_common_virtchnl.h | 9 +++ > drivers/common/idpf/version.map | 2 + > 3 files changed, 77 insertions(+) >=20 > diff --git a/drivers/common/idpf/idpf_common_virtchnl.c > b/drivers/common/idpf/idpf_common_virtchnl.c > index a4e129062e..76a658bb26 100644 > --- a/drivers/common/idpf/idpf_common_virtchnl.c > +++ b/drivers/common/idpf/idpf_common_virtchnl.c > @@ -359,6 +359,72 @@ idpf_vc_vport_destroy(struct idpf_vport *vport) > return err; > } >=20 > +int > +idpf_vc_queue_grps_add(struct idpf_vport *vport, > + struct virtchnl2_add_queue_groups > *ptp_queue_grps_info, > + uint8_t *ptp_queue_grps_out) [Liu, Mingxia] Better to unify the abbreviation of "port to port" , this pa= tch ptp is used, in the next patch p2p is used. > +{ > + struct idpf_adapter *adapter =3D vport->adapter; > + struct idpf_cmd_info args; > + int size, qg_info_size; > + int err =3D -1; > + > + size =3D sizeof(*ptp_queue_grps_info) + > + (ptp_queue_grps_info->qg_info.num_queue_groups - 1) * > + sizeof(struct virtchnl2_queue_group_info); > + > + memset(&args, 0, sizeof(args)); > + args.ops =3D VIRTCHNL2_OP_ADD_QUEUE_GROUPS; > + args.in_args =3D (uint8_t *)ptp_queue_grps_info; > + args.in_args_size =3D size; > + args.out_buffer =3D adapter->mbx_resp; > + args.out_size =3D IDPF_DFLT_MBX_BUF_SIZE; > + > + err =3D idpf_vc_cmd_execute(adapter, &args); > + if (err !=3D 0) { > + DRV_LOG(ERR, > + "Failed to execute command of > VIRTCHNL2_OP_ADD_QUEUE_GROUPS"); > + return err; > + } > + > + rte_memcpy(ptp_queue_grps_out, args.out_buffer, > IDPF_DFLT_MBX_BUF_SIZE); > + return 0; > +} > + > +int idpf_vc_queue_grps_del(struct idpf_vport *vport, > + uint16_t num_q_grps, > + struct virtchnl2_queue_group_id *qg_ids) { > + struct idpf_adapter *adapter =3D vport->adapter; > + struct virtchnl2_delete_queue_groups *vc_del_q_grps; > + struct idpf_cmd_info args; > + int size; > + int err; > + > + size =3D sizeof(*vc_del_q_grps) + > + (num_q_grps - 1) * sizeof(struct virtchnl2_queue_group_id); > + vc_del_q_grps =3D rte_zmalloc("vc_del_q_grps", size, 0); > + > + vc_del_q_grps->vport_id =3D vport->vport_id; > + vc_del_q_grps->num_queue_groups =3D num_q_grps; > + memcpy(vc_del_q_grps->qg_ids, qg_ids, > + num_q_grps * sizeof(struct virtchnl2_queue_group_id)); > + > + memset(&args, 0, sizeof(args)); > + args.ops =3D VIRTCHNL2_OP_DEL_QUEUE_GROUPS; > + args.in_args =3D (uint8_t *)vc_del_q_grps; > + args.in_args_size =3D size; > + args.out_buffer =3D adapter->mbx_resp; > + args.out_size =3D IDPF_DFLT_MBX_BUF_SIZE; > + > + err =3D idpf_vc_cmd_execute(adapter, &args); > + if (err !=3D 0) > + DRV_LOG(ERR, "Failed to execute command of > +VIRTCHNL2_OP_DEL_QUEUE_GROUPS"); > + > + rte_free(vc_del_q_grps); > + return err; > +} > + > int > idpf_vc_rss_key_set(struct idpf_vport *vport) { diff --git > a/drivers/common/idpf/idpf_common_virtchnl.h > b/drivers/common/idpf/idpf_common_virtchnl.h > index d479d93c8e..bf1d014c8d 100644 > --- a/drivers/common/idpf/idpf_common_virtchnl.h > +++ b/drivers/common/idpf/idpf_common_virtchnl.h > @@ -64,4 +64,13 @@ int idpf_vc_ctlq_recv(struct idpf_ctlq_info *cq, u16 > *num_q_msg, __rte_internal int idpf_vc_ctlq_post_rx_buffs(struct > idpf_hw *hw, struct idpf_ctlq_info *cq, > u16 *buff_count, struct idpf_dma_mem **buffs); > +__rte_internal > +int idpf_vc_queue_grps_del(struct idpf_vport *vport, > + uint16_t num_q_grps, > + struct virtchnl2_queue_group_id *qg_ids); > __rte_internal int > +idpf_vc_queue_grps_add(struct idpf_vport *vport, > + struct virtchnl2_add_queue_groups > *ptp_queue_grps_info, > + uint8_t *ptp_queue_grps_out); > #endif /* _IDPF_COMMON_VIRTCHNL_H_ */ > diff --git a/drivers/common/idpf/version.map > b/drivers/common/idpf/version.map index 7076759024..aa67f7ee27 > 100644 > --- a/drivers/common/idpf/version.map > +++ b/drivers/common/idpf/version.map > @@ -48,6 +48,8 @@ INTERNAL { > idpf_vc_irq_map_unmap_config; > idpf_vc_one_msg_read; > idpf_vc_ptype_info_query; > + idpf_vc_queue_grps_add; > + idpf_vc_queue_grps_del; > idpf_vc_queue_switch; > idpf_vc_queues_ena_dis; > idpf_vc_rss_hash_get; > -- > 2.26.2