From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0C46541BAA; Thu, 2 Feb 2023 08:19:45 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F005542D30; Thu, 2 Feb 2023 08:19:44 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id C32EB406A2 for ; Thu, 2 Feb 2023 08:19:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675322383; x=1706858383; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=LEdbz2lb8wRg3xjG/QdTlPds97GjhktvnMX7VPs1Yis=; b=N2ZDfDGpQS+DWVZaxGD1h55Qas6/qgcLrvx8DDK+EdksVm9Ngq7R7j0F mFn34PqbcFwNqPSgrWV/dHoLVn+I4aIIpw6c7BWTq6IwTTo9zSdC5FI+o QgnssMwC2omje0CROwfB3Gi6SD6NSq/yXYJrTskWJ+8pbB1asG6V7ADuX GGla4bJmAHWQV55Vjpa9xuMZGUVt+5FeM/AUNX+cC57dLIK8FJUk8jmxF 3gelZVzjqsrvJLtSOczoECPjH/9k2pUGrBRhO4/2oKkRL0MX2OnHp93Fn 52G8YmA1GfAwkGfO1jMxrAYjiSUowNa4eeICUkcVdRh74FjG0XKKPO2kX w==; X-IronPort-AV: E=McAfee;i="6500,9779,10608"; a="312021517" X-IronPort-AV: E=Sophos;i="5.97,266,1669104000"; d="scan'208";a="312021517" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Feb 2023 23:19:42 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10608"; a="807874243" X-IronPort-AV: E=Sophos;i="5.97,266,1669104000"; d="scan'208";a="807874243" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga001.fm.intel.com with ESMTP; 01 Feb 2023 23:19:42 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 1 Feb 2023 23:19:41 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 1 Feb 2023 23:19:41 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Wed, 1 Feb 2023 23:19:41 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.100) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Wed, 1 Feb 2023 23:19:41 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FoPoIR4WJ2RfobfbN8HzJ8yQn8YJTiUkx9T0Coyag8i/n2zlahl5+03DgU1RPRv4WCadmWyRdwM8+0Z5RiEuSH6Nwvq+OdB9Q+ZTVeCyCv7WwOP+h3VuYgvNnh96huzAUPqF4Kk6crLUfEYdchQ9j1AU50AERlyzx+tHZPy55+MDTNfxHgbY2AuOmujtktjkeqD/v9KXHRSPK8wArEv4RswmqttaIQ+pqm89wWw4AhEuLwMucL5ABzDyqJCRJRdpAtYcS/SY06FqKICcen6l9Dh3/IchKZLlC46TSdEGFeGa5IXyJFgnZqnfV3phX8RNbWAhoJJAMZsQjZ5EgVCKQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mtSP3UpnitgLBOxGdezRwviUEU2v56j5YmTQQYLZ0OU=; b=LUwMW70dkdoMfQ4SRKheebrA+bdE2ezu0xqB2bPAljbQrGKuDpy6+wBgr0KUQ/Rj5C9ZxUli1NT9S4G0BmfhmrsoNI6tCXSU//KHyQoPIF1HTTCDHiyUR4o+vRGhvOliZ7FA0vnuGIOBJ9bUQ/9eHHmVjX823vukbLnZfLWVSxLmp1F7OFXacoO18jCin49uagczKrolAAVt/kGUQ85CiANtbkgbPyB9nDXAC+Ow7BWAoNpnblRLo9ugyItlUUZoh5XvScyliEGRr8PKK+P4fOYts7UYN1D8PLoRUssqcfZh+0xttkoTNd+a/59h3kvOlo1dZxERvnfA53aMPBLUQA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5877.namprd11.prod.outlook.com (2603:10b6:510:141::12) by SA3PR11MB8047.namprd11.prod.outlook.com (2603:10b6:806:2fc::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.33; Thu, 2 Feb 2023 07:19:34 +0000 Received: from PH0PR11MB5877.namprd11.prod.outlook.com ([fe80::8c1c:6df6:533f:282c]) by PH0PR11MB5877.namprd11.prod.outlook.com ([fe80::8c1c:6df6:533f:282c%8]) with mapi id 15.20.6064.027; Thu, 2 Feb 2023 07:19:34 +0000 From: "Liu, Mingxia" To: "Wu, Jingjing" , "dev@dpdk.org" CC: "Xing, Beilei" , "Wu, Wenjun1" Subject: RE: [PATCH v3 3/6] common/idpf: support single q scatter RX datapath Thread-Topic: [PATCH v3 3/6] common/idpf: support single q scatter RX datapath Thread-Index: AQHZKxReEovIhnsfkUiPRQ3c7h0dh667G3wAgAA7tdA= Date: Thu, 2 Feb 2023 07:19:34 +0000 Message-ID: References: <20230111071545.504706-1-mingxia.liu@intel.com> <20230118071440.902155-1-mingxia.liu@intel.com> <20230118071440.902155-4-mingxia.liu@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB5877:EE_|SA3PR11MB8047:EE_ x-ms-office365-filtering-correlation-id: fe5a3f39-1e59-4652-1db1-08db04edd5d4 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 61JNAAG31Fk+cPKAdnfksUYmN265Cu4tZsGbm8E8LEXQ7mWfLDWp4zOQC+9rCG1ZExu3UtZvY7yyHJJUFZINXIS+qq0cF45cn/s284zRB4lZhpqAN3zxBhK51D6d4HbnRz61ynAqFinroXfeipCNQoCBuDkBiMCGTAp0LT+GJBQKXs3dSJEK7wTZmEVu5yOfPYUm5aETksOjR+insS/KTQ0JM+PtIYDCUvBAODA//amvZ5vC/2uDJoAg+uC2QdR3LNxvmPhZoslylLyk8UNLchrprbT6wUYrbFjjHX1RTznmw9kTRngp63U7gPmv9Iylv3IWKOUF6sEc/Qiy34MPsegSPSz5kU05gnHUlmK/5s1AICHL8icU/OKV0A3xqpWbUIWU1xaukNZsmRcmJUqUUmVKCju5polq1HwJFXYoya9sDzyE1LaupSNziJ0D9eLSbrYWgPfarUrBI7Lqd39ZbEGsb4z9n7E3dF6iFBVdaG0JKag7abqmMKRV3Uo7w6PuLC1JcYdi09cpCeNPHPWmPMvyoXNzJNWqLaBVlOIvOiY4lAiBc1tr185VkREN2QVdA2rPjv+Nt+vbTCY1FC8zGXBfT4UfO0Ab7op3DrfIjTBXpl28pk3fQ7Nn77SkqklvmmeertoIJNczoURak7utHbd6S+L5RmxPmN9VipEoYWv+8t3IRKgAgxNO9YRB3l1aJKL4jp5Diq9ETYqa65zNpA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5877.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(396003)(366004)(376002)(346002)(39860400002)(136003)(451199018)(54906003)(110136005)(5660300002)(41300700001)(66446008)(316002)(76116006)(2906002)(7696005)(71200400001)(8936002)(52536014)(9686003)(66556008)(107886003)(6506007)(66946007)(26005)(478600001)(4326008)(186003)(66476007)(53546011)(8676002)(64756008)(83380400001)(122000001)(38100700002)(82960400001)(33656002)(55016003)(86362001)(38070700005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?rzTgY6K66pOh/u+M6+VDAalN0fay+juUAkVzMQntZl6CPkILbNv2O3vEKVCi?= =?us-ascii?Q?BCVCY005uKYi5Mt/5WEetDMTRV5WQgs6qxeDE7nGFSZe0cQOKh3LT10PxXMF?= =?us-ascii?Q?dIMHCXQOzK+wLGrM/vtrMFn6MbXEkGqxKoi1JHIcDy9CJbhm+9Vg2VXv685y?= =?us-ascii?Q?1Tp4wcjTL6i3N1Bw5/SZ9nhDq3e86PJw9k0cqFz+UZ3WixC1eAPjrUt7VM2c?= =?us-ascii?Q?1PSvUeINkoPIw7dxCPLPo+9aMEFZruaA1Cw53edbApd2kSQkTquttV50Sx9f?= =?us-ascii?Q?L5U0otyZD6HkWQ1sMmKZK0xK14iCIVwG1YrCa2Jy4hdbBlrPWkerLjuLJmmJ?= =?us-ascii?Q?Kf8B966HX6lBYBfXor4rtY6X39inrfDcU1V1hGrldn8I8bNHMiyRce1vzRNW?= =?us-ascii?Q?r1fmG9YT490XH670TIKzUY+HRqRDo/RtwqrlXOFFVEO3/J/1LXDPmzUqKJoY?= =?us-ascii?Q?23+VuwEz03hsSULooLLXuuGDubuz2KY/Xgy3908nwv62ZWXmHR3Nct+uPsma?= =?us-ascii?Q?NKJgJI+hnjHHypMCqSQSdwmZwRKK1IFZAet6U0NOo6mp30+hn1QoU+4U6GYH?= =?us-ascii?Q?qPngchNMi6hrCN63U2ffy7JJEj/pk6LO2LPrdP4uaw4sa56A8RpGs0/WXKbR?= =?us-ascii?Q?30fxAFUISfOfLBD8G+4LBJUIzKnsMJaiNCndiOzwZnaf+VW5jvq/dIbMdvdb?= =?us-ascii?Q?xcKovlRPewBpe3rQDrPI7aARuzgtmYoMOgAjXyCuPjnYx48niiQXUstU7FrX?= =?us-ascii?Q?jVApHwVgYLwINqrtQKkZHmvBWl/EOReZYPHZL0irB6CjG4so4O/srpK5rlV7?= =?us-ascii?Q?xJGQH0Dw+9ni/CIzbHdQYTCnPaKQpAW5zb22N8R6iaJha9N6WGc9Ih1vBDkK?= =?us-ascii?Q?G2Ua+lxi0OQXMw4ABa239bJPcDK4Ot8pHW9g2s9Kp47VBa5YkJVJ6ErJdKOT?= =?us-ascii?Q?82OnPO6vWicEbKTMuieQo7aeqhcaVclJIwvsYxPPH151ZudD/3rsmGEx22DW?= =?us-ascii?Q?WkYnNwqwk/+K65pTKZBapLUd6rgGghiXSopPH5SmDEFU7HNKkQk6u+VPxnDT?= =?us-ascii?Q?bESBecgPxdQmrFd3IBTUvnZQVMTbb1niyrvfFRLPQ5c0aYyomaAzwt+Ucaya?= =?us-ascii?Q?ZwGVw4o8rIi88kU4u52k79TLamhHbM7mADzWt/QN9JlR/wt8zZZaEPAdjbQm?= =?us-ascii?Q?Bhz1zSCB3BYUGTsig8sOao6Z0Igs4asi40QpLAuSQs0Od2OMO6ihGlYfVLCs?= =?us-ascii?Q?9c6tTnv8AwNGzt07G04XeXyVuZjc0IWgz1SCHA0d1Jt9+v4DrNf8tZsprd2V?= =?us-ascii?Q?OnUKP2Qx9wWYJqUHx6NiYWTVPf15TdWIVBSieQpB7SSfkQVdei5d2VRo7Ih8?= =?us-ascii?Q?+503GyAUWJzzVgGEnjbzNd3qa4IW1yp9ZcH/dEbndElSiO5PK77MyU1j4Gm8?= =?us-ascii?Q?oTRAKw9DR0BeCyEZmL5mVS0aOFjaACnPbyFUCqMrCPW5gyBGbRIX9XpvX8nf?= =?us-ascii?Q?uoDKOWyoXt7mtYoVXlqOA32In3SdGRTCBhW78Z2u+JbQCnCvqv/GoKauDH9/?= =?us-ascii?Q?PonREwlN5PVsM3G5iTc++zagNQrzmYh8ke2yV06w?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5877.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fe5a3f39-1e59-4652-1db1-08db04edd5d4 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Feb 2023 07:19:34.3797 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: TzMZIhbOlvK24EcrElIsTCjPpfUTLS+KTIImMU36RpLSsn578lAsQC/2FskxjaCWHdroFhhbwvzmSEW+f9/+Kg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR11MB8047 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Wu, Jingjing > Sent: Thursday, February 2, 2023 11:46 AM > To: Liu, Mingxia ; dev@dpdk.org > Cc: Xing, Beilei ; Wu, Wenjun1 > > Subject: RE: [PATCH v3 3/6] common/idpf: support single q scatter RX > datapath >=20 > > > > +uint16_t > > +idpf_singleq_recv_scatter_pkts(void *rx_queue, struct rte_mbuf > **rx_pkts, > > + uint16_t nb_pkts) > > +{ > > + struct idpf_rx_queue *rxq =3D rx_queue; > > + volatile union virtchnl2_rx_desc *rx_ring =3D rxq->rx_ring; > > + volatile union virtchnl2_rx_desc *rxdp; > > + union virtchnl2_rx_desc rxd; > > + struct idpf_adapter *ad; > > + struct rte_mbuf *first_seg =3D rxq->pkt_first_seg; > > + struct rte_mbuf *last_seg =3D rxq->pkt_last_seg; > > + struct rte_mbuf *rxm; > > + struct rte_mbuf *nmb; > > + struct rte_eth_dev *dev; > > + const uint32_t *ptype_tbl =3D rxq->adapter->ptype_tbl; > > + uint16_t nb_hold =3D 0, nb_rx =3D 0; > According to the coding style, only the last variable on a line should be > initialized. >=20 [Liu, Mingxia] Ok, thank, I'll check if the same issue exist otherwhere. > > + uint16_t rx_id =3D rxq->rx_tail; > > + uint16_t rx_packet_len; > > + uint16_t rx_status0; > > + uint64_t pkt_flags; > > + uint64_t dma_addr; > > + uint64_t ts_ns; > > +