From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4375141B98; Wed, 1 Feb 2023 13:34:46 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2AE58406A2; Wed, 1 Feb 2023 13:34:46 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id ACE754021F for ; Wed, 1 Feb 2023 13:34:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675254884; x=1706790884; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=IluG6kWUawSzapkvkDxPHxpjwmeqvUjSo/vUab11o34=; b=A9rmTAmX4R/T/chNYH3u7ouQgEfSxWnLK138jQQ3J8CaMuWhbT4StBu7 G7MUbo9qFct2zfJw25cXx3NGPFdZR+3ww3p+FjhCaYMJBr3IxaWft0SD9 JFthrEvPPwRwlzpdvLI201beYGigmKv4zWDtREyqDDyV3xadQegy5w6xS Vmi8d5qTQ18feafdd3AI2K/eC3hcNXXp4JMCBIFAkvOFGxEsEr5Hsi9np 5b2PE2T6ZHM6U5hgo7fB01Ir5wVk9hz1mLiM474U+GOgXb5hk3JgpoV0M boOI7yH8yf8f5U/5uaWwKfJAad1FEROXjXCrilo+D4Vk3YQxggK26+FQV A==; X-IronPort-AV: E=McAfee;i="6500,9779,10607"; a="308470875" X-IronPort-AV: E=Sophos;i="5.97,263,1669104000"; d="scan'208";a="308470875" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Feb 2023 04:34:39 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10607"; a="664878151" X-IronPort-AV: E=Sophos;i="5.97,263,1669104000"; d="scan'208";a="664878151" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga002.jf.intel.com with ESMTP; 01 Feb 2023 04:34:38 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 1 Feb 2023 04:34:38 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 1 Feb 2023 04:34:38 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Wed, 1 Feb 2023 04:34:38 -0800 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.169) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Wed, 1 Feb 2023 04:34:37 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hGa8MovU3CYkr0rhSydVScU1dX5AaRaMiWU+aQ6pAj+kKaKisoFp/PGKYaQ284RIsdTGzhSPaO4VsqPx51J/nCwlDXn4C38rPfGYTaRbF92xkWEdCOkO0iqR7hJRMRdjUCODzeSSrvFTiSU1+h66UFzumkbaEOtl1LsYmT6UyAhTNZuF020d3pDgJwUABjMevur96V6z/xP14kLZ5t82GlGGO2AzlxSGwVgsNH1uEhbHAGutWZw8nU7svTIfMOhVOqWNjuWqjudgC4Go54fIY3ai5V1rR4Cwc0BMOjyANO3MeFB2aouxWHzQ1/vNgWyUvLhv/hCnL0Q0mGo0jycISA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=E106rsInd/Olj7kTHqpVNJKDFwBZ9rtO4znJ+aJpQHI=; b=CsDL/TtOjcn4EU+fLz3W6rST5/ik7aH7Sb8myLl/qrmpsICOT8TNL2ZmqWJjderrw2tFtzIaYgVXKPj4/oc3OHomenOhAXYQBZ96B2QR8mo5m585Ze0YuJF1E7Nvz8vPp/GbqGXFJc79GNUJb5SlFJ2/7CdYX++pniC0m/9XKoLn1Kf6dVlCPPwjPyxONhQJx/maqMC97Fs5ZvlsH3UgulfrA5f3a2tlLq/SXPiVCp92BwUQB37UvuBld4lAsQ/zDsMRzpowoqr5Vmi36UkICCJYuRu5JuwBCfCtoeu2XRChfrGrnJP7WuteHj+NV0G4qB3pwMpqk3FdUB36FkDrjQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5877.namprd11.prod.outlook.com (2603:10b6:510:141::12) by PH0PR11MB5610.namprd11.prod.outlook.com (2603:10b6:510:e9::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.24; Wed, 1 Feb 2023 12:34:36 +0000 Received: from PH0PR11MB5877.namprd11.prod.outlook.com ([fe80::8c1c:6df6:533f:282c]) by PH0PR11MB5877.namprd11.prod.outlook.com ([fe80::8c1c:6df6:533f:282c%7]) with mapi id 15.20.6043.038; Wed, 1 Feb 2023 12:34:36 +0000 From: "Liu, Mingxia" To: "Wu, Jingjing" , "dev@dpdk.org" CC: "Xing, Beilei" Subject: RE: [PATCH v3 1/6] common/idpf: add hw statistics Thread-Topic: [PATCH v3 1/6] common/idpf: add hw statistics Thread-Index: AQHZKxRanTwCkIc+a0W33orspyiSM6653dQAgAA+hoA= Date: Wed, 1 Feb 2023 12:34:36 +0000 Message-ID: References: <20230111071545.504706-1-mingxia.liu@intel.com> <20230118071440.902155-1-mingxia.liu@intel.com> <20230118071440.902155-2-mingxia.liu@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB5877:EE_|PH0PR11MB5610:EE_ x-ms-office365-filtering-correlation-id: 14ce0b25-f12c-495f-5ae4-08db0450adf3 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: wCi2Fec+KEYhOdHx6bV9zvgTZ/xAHoD//fsnHsos1A6MvsN8PcWxHSBqbhUHbbZ5fQjjHq/q91OIit+BzOeVZsNxp1HtmBWVeLZdms9BYUrxE55zIwS9l1tXzb5fOsiU+V5JglhM6PRWTfUc5dWNPx72kONa6pdKBNvBIogg4fPCyHqe9J4yPclTR3PgZWhGdTah3hXy+WKdWP8WblPJyvqsLGNC6mDJ9llb4olhuiV6drqsahN4JO63HcDbiwFmOZ1lsTd8cKotld6a2Lnpotu9lT44NEwlYUJW5zTvoQDhYtEqXQqv9uY9xFezGeDYghMvZjeW5eBWZaDSVBONMsFp7eErek6C/RnLpKH1tuw/gQQtACzCzh2rfVea+8sHmsIDstRLVAhtUi/dK7kBhbV0Y/oPJYBQnRwM5N6lBNyI0oN2ZOPEJ0hGQd/jQ35Kvzw5zaOAfmHnBufNMTMntrB3LLXHPwmkSm52wK2PfbzRwL6HDRBcI5wb5RQHZgwZTLhpXANd9lGyX4+WIKlMsZg68sEAL0EaQF5HoCh/KpBTtYGPuz6FQrWKbpfNnUEMh1+2tZhAGKn9yyt19bPmRrUrlW4Y09B7Vu8+ayjCCZL/5x+El5nGAfBGn7wNRDWoISZgl4odKgqeggvBlw8ojWaSySJiwdm0/p1tpCKgCtFXrqWpSrf8ihWyrHocO67p x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5877.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(136003)(39860400002)(366004)(346002)(376002)(396003)(451199018)(66946007)(66476007)(4326008)(66556008)(66446008)(64756008)(76116006)(41300700001)(8936002)(8676002)(83380400001)(53546011)(6506007)(82960400001)(52536014)(316002)(110136005)(38100700002)(5660300002)(122000001)(71200400001)(38070700005)(55016003)(33656002)(186003)(26005)(86362001)(9686003)(478600001)(7696005)(107886003)(2906002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?qtZimVgHqSITns0KhkSHSuu2osQ9zeoAMFoE1flhS/qYYWUg0qdAZt5objXg?= =?us-ascii?Q?6TG4lUAXZcRD830bsY8EA+6MykK6bNksiB++FWcSKkDKKFxPWOTY/BvwHy55?= =?us-ascii?Q?ruApJiJcLaBQXmpevgJJDZebtvjWSZRK2iwKtyPWFqWDF1E+fdic2sTCYy68?= =?us-ascii?Q?kjHzH3xyFei78n/F0xBrsiqG6kDf05NVZkSO2lIxgl3az8IFfyGUXV2Urv8Q?= =?us-ascii?Q?n2A4ncrPCK6lKVddpS7rCuynjeYw5QOUowy/RAkYTQ0lKH76XlWtLXlEdbKH?= =?us-ascii?Q?YXDfpaTMnl0FTKwmaZM98SsveSwhnJ2H8ZavBaLc7q4GQldRxAJVehI9qp2Z?= =?us-ascii?Q?UV8y7Iqi5c+hb6tc+AtuTNTM68A3owQ95TPiLSlzc8k0NNm+tAIuPWtS2XHP?= =?us-ascii?Q?7lvUYHTEamy3u6IaEiiMBGEuar0inpxae4zQUzVp3omL1JNSQhHMoYB96dJk?= =?us-ascii?Q?totfxBhKFH5m+0mw6i1SYwyksrxld9g5YuMgJ9V6OiQDfo/xno+rY3/UNGLp?= =?us-ascii?Q?UlEtT7R3Nic6+OjJv3tTG4iCwffuWhPD8p8ksDUN4sP/MVKxLsZpAzj6D2A1?= =?us-ascii?Q?Ql5QGRH4pEUxxHguIESLQ4FpRuT/SirrSIYdXoQNra4TlkGk8EqZNpB8ufdE?= =?us-ascii?Q?tjaBKCVbz4UiMbBnVNOSVShueip/6WPxsLZoymg7PoM8DsvN6dIhFzuZAU1p?= =?us-ascii?Q?zp9S2l0rRNkY+3j/7ZhM3yHwb8mSXUtZQM8QDNl/j+JciOjP64KyWS+qeg6P?= =?us-ascii?Q?lutZCjAm+npNQ0bHD8ePK3yr+5YT8MfWsZGMMzRjXu9iTCt4W41+ALnY6p3d?= =?us-ascii?Q?4AkrLYHSFPualb1VyggVnWZMsINWa5jSq1kxapVET0TOWAAJxmKSX57RoOJP?= =?us-ascii?Q?93lLO10sztMdTOj/S5F88De9J+jjeqqMzgj0oe+bWueBybd5jpeAbGYiAtOq?= =?us-ascii?Q?k9Qdoz0ZGN84SWq4A1gVBzD1+oAP+kxxKFxBGVeeUu69fmbfxZirVbwUp4JQ?= =?us-ascii?Q?GWSKpUJJ1SOnN/7/JGhfxTLocXwMPx6reZOcww97+w/lwzfJgCW6tq9wye/9?= =?us-ascii?Q?8YQT8xlfK23j86oGxoIwpnRiJmIArBdJ8clXeVSlWC7IHsZ3Cb4k6uR0tz2p?= =?us-ascii?Q?pLBFSOcd3/3J6zNY8nlf+YDF4BjlAadYwMVDuuQRtNFu0F/2xr4IkVTxzieB?= =?us-ascii?Q?35apfsm9x/0FSz1BdCPXRBw/eR5tKc0XIxXCsNoeGJ4bNaQo22YC25U/zrQZ?= =?us-ascii?Q?jRRsNJou4f3RTdf0u+BrSzAeaWekSXrNRKgKpd8m7hteFcK4S7uWLaAgH7rI?= =?us-ascii?Q?g+z+iu5zwUwpyhSEdw9e6Fc9+wXg3qJvdx7ZwXYznoPIVHoo2+zWAZZroVwG?= =?us-ascii?Q?cYJlSVG4+JxvogjvEd4s5zIH5eoTbAg2qM5ifDHiQV+kv99L4qXAu/ZScyrh?= =?us-ascii?Q?C1NsDYGNreKQgIBlEUs1GQ31NYUi3cxcNzzKDZIdwSgeeKkWy4QiUOUrJcUL?= =?us-ascii?Q?M+p2jSnQ8W/8Lz9K4F8somW3G4DCxoIJXyTak9al3w1XIz+iJc7avqkvRf1P?= =?us-ascii?Q?aMVQ2jx5TIzlb4AjryI51BFSu7Z0+4g5bpm9EnOo?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5877.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 14ce0b25-f12c-495f-5ae4-08db0450adf3 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Feb 2023 12:34:36.4890 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: vq3Fo/GWHnUNQSQp/zOix/sz5lxZQRt71M8qUOg2oV8qEafTTIF+MQH73mjKB8xvtZmnIKCSzVIhI68DXkzC4A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5610 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Wu, Jingjing > Sent: Wednesday, February 1, 2023 4:49 PM > To: Liu, Mingxia ; dev@dpdk.org > Cc: Xing, Beilei > Subject: RE: [PATCH v3 1/6] common/idpf: add hw statistics >=20 > > @@ -327,6 +407,11 @@ idpf_dev_start(struct rte_eth_dev *dev) > > goto err_vport; > > } > > > > + if (idpf_dev_stats_reset(dev)) { > > + PMD_DRV_LOG(ERR, "Failed to reset stats"); > > + goto err_vport; >=20 > If stats reset fails, will block the start process and roll back? I think= print ERR > may be enough. >=20 [Liu, Mingxia] Good idea, I'll delete the error process of rolling back. > > + } > > + > > vport->stopped =3D 0; > > > > return 0; > > @@ -606,6 +691,8 @@ static const struct eth_dev_ops idpf_eth_dev_ops > =3D { > > .tx_queue_release =3D idpf_dev_tx_queue_release, > > .mtu_set =3D idpf_dev_mtu_set, > > .dev_supported_ptypes_get =3D idpf_dev_supported_ptypes_get, > > + .stats_get =3D idpf_dev_stats_get, > > + .stats_reset =3D idpf_dev_stats_reset, > > }; > > > > static uint16_t > > -- > > 2.25.1