From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8798D42D94; Fri, 30 Jun 2023 12:46:59 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7796F40EDB; Fri, 30 Jun 2023 12:46:59 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id C226040EDB for ; Fri, 30 Jun 2023 12:46:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1688122017; x=1719658017; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=bLSWbgmmA9wGa8w65TuKr8uYKXb0y4ZuHYk3kb36/A0=; b=mitvw0NphT4Yfq228zjzQqKnftsnHeEYXETiGeEk/Zp3T1adpE6MZTcI KsbIXJGtp91/C1GOgR58r6I6h8GEe1VY3H8vcmI0nzMvRt/GP8Y5m9CL1 fg35qZ5oOfCeMQFfBYoHZIsA1HGm7hIGufk2SJEsPDMkxdy0jL2W4tDRM 50HIoTZRRjzLCIrGoeu4SE3A1onUCc0dPFuGc9yzshy/Oxt3fAD+i8MAT 8zUoXgBqCFexZvEtm5YRdKijR0okbowzoMFY3xFks2J5lFU+PEX9TNaB0 6JkZQl3WiBjRgwtPbsv6mLQQdBc+A2cD1zS9dz4BN6LfMLU+WBqrqhxU3 g==; X-IronPort-AV: E=McAfee;i="6600,9927,10756"; a="352189135" X-IronPort-AV: E=Sophos;i="6.01,170,1684825200"; d="scan'208";a="352189135" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jun 2023 03:46:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10756"; a="783044596" X-IronPort-AV: E=Sophos;i="6.01,170,1684825200"; d="scan'208";a="783044596" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga008.fm.intel.com with ESMTP; 30 Jun 2023 03:46:55 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Fri, 30 Jun 2023 03:46:55 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Fri, 30 Jun 2023 03:46:55 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.172) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Fri, 30 Jun 2023 03:46:53 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mF1xxnf+Q7Rx2L98m1O6bFl8so/8CRE4h375IwKbibx2527sq7xebx15HiFW1SO0zh9OkyKZiPY2s2FHMk5q/8xBJP/gCQOnp7AFWfBCQU1024mMThFrcLua0EAoKRk1v23D/zRmzxcP4NB/ZbfxMh1/keCvOE6dw/xVJQNkS9s+in5YfsUzlhU0CBNpTcdctfHgz0qRRWDEQpaU4nOCfAJyjtPGQs9EkWi1FF/6uDfTMjGUV5jbSGnkcdPlA2KMwlQh3EW7C+iwLHGmMkO0DKSGienDjGnZM7iDAJm6tTSEAOqEsBdIRIXicobI2xrKrl3NEzVY6EUjmZWP6yCiAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zZ4att/u6eMzy4J+HT5ZUnZg4p66bFDCKiofxH0lMUY=; b=h4BmXkTjU6meIFjAN3nnCJcMMASI5ForRICbHvVWt2TZ8d5APbzqP3uEVPkitamzElMWb6InpqmVy+jrOXRG/nsL3Z2PLu8A/Kdjfnxrf2eu4SS/LXxF3TW/BdHURaZcK2UqsOMTyqr2idIATU3ywUYsxtQfr5fBGwPfMbGvKRu1uxLig6XnoqxeKnoJYKZ84cGGhSMvJpDyAo4QuppCaUW7ixzFz8KuxsvlJgRmPtlgEND57E7oX9GpAOe4FDnD0PjFqyF7+S+sKZaZ8PS1eD0HPkR/a9qyjUdy/Az3jAU+lq2GqUHEEHsRfVKu+tzTSKLg6a0eo9drDbfMp9xTwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5877.namprd11.prod.outlook.com (2603:10b6:510:141::12) by DM4PR11MB5343.namprd11.prod.outlook.com (2603:10b6:5:392::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.23; Fri, 30 Jun 2023 10:46:52 +0000 Received: from PH0PR11MB5877.namprd11.prod.outlook.com ([fe80::da1b:ee87:709:3174]) by PH0PR11MB5877.namprd11.prod.outlook.com ([fe80::da1b:ee87:709:3174%5]) with mapi id 15.20.6521.024; Fri, 30 Jun 2023 10:46:51 +0000 From: "Liu, Mingxia" To: "Zhang, Qi Z" , "dev@dpdk.org" CC: "Wu, Jingjing" , "Xing, Beilei" Subject: RE: [PATCH] net/idpf: refine dev_link_update function Thread-Topic: [PATCH] net/idpf: refine dev_link_update function Thread-Index: AQHZp9nsh9lHWE19EUiKlODgyaD/cq+jCbIAgAAmxHA= Date: Fri, 30 Jun 2023 10:46:51 +0000 Message-ID: References: <20230626111454.489844-1-mingxia.liu@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB5877:EE_|DM4PR11MB5343:EE_ x-ms-office365-filtering-correlation-id: 32684a67-9497-43fb-d3f3-08db79575026 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: v7hYr3A/K7hEOrMfn3C05QNIJxbfPdB04K1+rAbOU2OPzsoWkMA5zHeoa4unfthiC7Tpk00ljE/K07K8Cx+TYdvgcKBpcmEn0thsC9WlEI57qT+sHx8x7fGLoGNM9SBMgIvHdZ5Jrz247F7pShyezGXyjLfipUfm9bI0XRLcBBkwuQkgjPzjxe9gu4pntm1WGU4FOK3JPyWu5si+7UEXe0VOwBh+BnZGcuDmMuN+nOqJuzWaBrBxYEIuROVQnFVBUfB9IaTEYwOK3TozhQP7qdxZWHb1FtqTWjSwOdsMa8NPEvNFz5sZ2G5qhVLfaKyicLKsDEQBZFxkApO9iSfRYdouIV13Unq0l4aIEMxqBBrI2ku/9IycLdYRVUEnH17uX59mB+QPuo60rbtLQK1mJuHlah5vr3jNgIu6oPZRU8r12Tve+EAV+oP3E3LYkB+eo9GSTL9FJ1TY+oY/ky+i8F1UU5mZEKtZhHqAE4BhiKzt2RmmyaLDE5Rl709Rl1YzEAA8vTftHPCw+Fdt7YY9/LWMFC8s4aupvfBAUcsQSgtSTx+Xu3grYIal+5T9BXgk3jlFO1Jxxm8QRwA1PHHfJTF+qNfE1Yh/isWxXjVPPQtDxrv2C4OVxc9PkvdaeoeI x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5877.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(346002)(396003)(366004)(376002)(136003)(39860400002)(451199021)(66556008)(66946007)(76116006)(66476007)(66446008)(53546011)(8936002)(26005)(107886003)(186003)(6506007)(8676002)(55016003)(41300700001)(9686003)(110136005)(54906003)(64756008)(7696005)(71200400001)(4326008)(316002)(478600001)(2906002)(5660300002)(52536014)(82960400001)(38070700005)(38100700002)(83380400001)(122000001)(86362001)(33656002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?TOsuE2btZt03sUID0kRIe73/VozYbsSzzIVfJJEnRhmYkGy7Rv+SaFMjqhvu?= =?us-ascii?Q?8+J8LacVbEqj5XCfZW4aEPYqVlJPeXZsjY+0gEiRn1bg9kK9nKSItd0vKO3B?= =?us-ascii?Q?cissw1mkXzytaCvNGvY4OGzz4msAdwgy3IEtz8SvWuphKNtM1nSJ1TjIWOOX?= =?us-ascii?Q?s01iHUIo/pyyDIypfYayalNt0zXYsvkLneOHZmsndoAKemzc4cO3DV6czW5N?= =?us-ascii?Q?8WQfQeTiQhogYqswQxssxbZT8Gds+RUEW2fYF+m+1c8ZJ484l5QfQmfXVSSO?= =?us-ascii?Q?x4Cjf6tf5nmYlCukr3VrockqfHly07dN6JTw/riqJsPzUgoqv/oqlTIy1UFl?= =?us-ascii?Q?P59ZRpD7q6HdWHOOR/BRQv2LnohvCoUl4kO28z3qQlPd9kj+Q+ujFbSn1Yp+?= =?us-ascii?Q?5Bl1t9FineVtYgFg9xMjlHgzINcT4Zg7iRIcuwfU0GHZoqHSib5vO/MugAxa?= =?us-ascii?Q?2J84h5qnGFm6oGqFDjgmzGSzLL4YH7Ul9W0iX/LE84csw21gwBi3hIujozQs?= =?us-ascii?Q?2jfyGq4AWxZIfDLn0ScAQTY48XAp0Ay/0HpcUnFVvs1BYP1OeQ/dZfQZr8I4?= =?us-ascii?Q?cKQdctUYuVrLdHKgEFk140qVFq88RmYDzCUqUHuImUHCZVEF46EaaMAZEG88?= =?us-ascii?Q?3K2kr/H+qb606Z+20VrGIcGiEw4pWTLLUoD7XIcatFf185asJG7m0MlgOo+d?= =?us-ascii?Q?F2KvkwEvRHFDxTTwJqInl8eOjnBoSkaV0tfgCo7M8LPwsTBj4SD9hPCPpbyz?= =?us-ascii?Q?ZT+lTWUqfNn391N834pD+3e+62MP/lvqv+oP1tyiPRLs5498knYCUWB8P6LW?= =?us-ascii?Q?SxaVbgiGTaDyz9sXeMJrH1e4JYBEjuc/E126S+27O+DMJm67wTU6QqMzCumK?= =?us-ascii?Q?rN25zpS/HqcnhiItgIC2TsN0EquDsCCQbTL/6RTxh9ABPYPNyRmiM5VP+L3b?= =?us-ascii?Q?9PjFUWFFGoixN06rkZnTxeIQBfmahx6juZm7t2kTQbDZ6AEQQ0OnsgviivSF?= =?us-ascii?Q?rjXRzC1hvE5WAnEeSslRnIzAHT45pWrjwfibyD8NU8rl+vsBfQfJgPV6jWHd?= =?us-ascii?Q?9hl+4bxsHEBP8KIkO3Kc13jwCmkJ4cf0LKUNAA0XkE7UQ1iB/u6Ty5QjFjHd?= =?us-ascii?Q?IDv4DSfh9J5DE9/K5tAPXtiJt8ZnPmDqHJsMdyA/4tuDRFJQx4aHY42yDta1?= =?us-ascii?Q?Qd77Au3fTVyegU7HXakjZtHbGBygTL5dhsnhF1YC4szrxXZ67VHodQTDnusk?= =?us-ascii?Q?/tlJjeArAjyuQTbiKYZRMOQfzomdZqESVIkNgeZJ7IHY83afcVg6Fzd1qZKK?= =?us-ascii?Q?CzNgm4e5ZkAvlxUFbuc0uoV6CxmZ3m7m4pRjaZ8nm06ggXvTUZJf0DS/Jrb6?= =?us-ascii?Q?Has+lLzAJGB3PG/6/B7dDZ5eXIDRVIi8jnbiUCIk2QKLzaGI15AUg+yaqHHq?= =?us-ascii?Q?BbwztuVsAC3zJ6zYyofkxsFEDiNZqk5jPVDi+tzO3MXUYQL8m9LET73DyXZL?= =?us-ascii?Q?lWiU4FjtNRnlQNL/t+7+Km9hGuvCBfa0p5mAR5usp6NHkiK4d7iapS5jHF/m?= =?us-ascii?Q?1p3912IFaGYdnDeulbP0o+eFSiMzohUTIblTTAU4?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5877.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 32684a67-9497-43fb-d3f3-08db79575026 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Jun 2023 10:46:51.6860 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ghpAgzIMCaaHWUdUQTelF93UxUMNEqnB0QceMDQdmT62oih2oh86HRu5AehWv6bDtkr/jHyBgI8HjCz8aUTu5w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5343 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Zhang, Qi Z > Sent: Friday, June 30, 2023 4:27 PM > To: Liu, Mingxia ; dev@dpdk.org > Cc: Wu, Jingjing ; Xing, Beilei ; > Liu, Mingxia > Subject: RE: [PATCH] net/idpf: refine dev_link_update function >=20 >=20 >=20 > > -----Original Message----- > > From: Mingxia Liu > > Sent: Monday, June 26, 2023 7:15 PM > > To: dev@dpdk.org > > Cc: Wu, Jingjing ; Xing, Beilei > > ; Liu, Mingxia > > Subject: [PATCH] net/idpf: refine dev_link_update function > > > > This patch refines idpf_dev_link_update callback function according to > > CPFL PMD basic code. > > > > Signed-off-by: Mingxia Liu > > --- > > drivers/net/idpf/idpf_ethdev.c | 63 > > ++++++++++++++++------------------ > > 1 file changed, 30 insertions(+), 33 deletions(-) > > > > diff --git a/drivers/net/idpf/idpf_ethdev.c > > b/drivers/net/idpf/idpf_ethdev.c index fb59655555..bfdac92b95 100644 > > --- a/drivers/net/idpf/idpf_ethdev.c > > +++ b/drivers/net/idpf/idpf_ethdev.c > > @@ -30,6 +30,23 @@ static const char * const idpf_valid_args[] =3D { > > NULL > > }; > > > > +uint32_t idpf_supported_speeds[] =3D { > > + RTE_ETH_SPEED_NUM_NONE, > > + RTE_ETH_SPEED_NUM_10M, > > + RTE_ETH_SPEED_NUM_100M, > > + RTE_ETH_SPEED_NUM_1G, > > + RTE_ETH_SPEED_NUM_2_5G, > > + RTE_ETH_SPEED_NUM_5G, > > + RTE_ETH_SPEED_NUM_10G, > > + RTE_ETH_SPEED_NUM_20G, > > + RTE_ETH_SPEED_NUM_25G, > > + RTE_ETH_SPEED_NUM_40G, > > + RTE_ETH_SPEED_NUM_50G, > > + RTE_ETH_SPEED_NUM_56G, > > + RTE_ETH_SPEED_NUM_100G, > > + RTE_ETH_SPEED_NUM_200G > > +}; > > + > > static const uint64_t idpf_map_hena_rss[] =3D { > > [IDPF_HASH_NONF_UNICAST_IPV4_UDP] =3D > > RTE_ETH_RSS_NONFRAG_IPV4_UDP, > > @@ -110,42 +127,22 @@ idpf_dev_link_update(struct rte_eth_dev *dev, { > > struct idpf_vport *vport =3D dev->data->dev_private; > > struct rte_eth_link new_link; > > + unsigned int i; > > > > memset(&new_link, 0, sizeof(new_link)); > > > > - switch (vport->link_speed) { > > - case RTE_ETH_SPEED_NUM_10M: > > - new_link.link_speed =3D RTE_ETH_SPEED_NUM_10M; > > - break; > > - case RTE_ETH_SPEED_NUM_100M: > > - new_link.link_speed =3D RTE_ETH_SPEED_NUM_100M; > > - break; > > - case RTE_ETH_SPEED_NUM_1G: > > - new_link.link_speed =3D RTE_ETH_SPEED_NUM_1G; > > - break; > > - case RTE_ETH_SPEED_NUM_10G: > > - new_link.link_speed =3D RTE_ETH_SPEED_NUM_10G; > > - break; > > - case RTE_ETH_SPEED_NUM_20G: > > - new_link.link_speed =3D RTE_ETH_SPEED_NUM_20G; > > - break; > > - case RTE_ETH_SPEED_NUM_25G: > > - new_link.link_speed =3D RTE_ETH_SPEED_NUM_25G; > > - break; > > - case RTE_ETH_SPEED_NUM_40G: > > - new_link.link_speed =3D RTE_ETH_SPEED_NUM_40G; > > - break; > > - case RTE_ETH_SPEED_NUM_50G: > > - new_link.link_speed =3D RTE_ETH_SPEED_NUM_50G; > > - break; > > - case RTE_ETH_SPEED_NUM_100G: > > - new_link.link_speed =3D RTE_ETH_SPEED_NUM_100G; > > - break; > > - case RTE_ETH_SPEED_NUM_200G: > > - new_link.link_speed =3D RTE_ETH_SPEED_NUM_200G; > > - break; > > - default: > > - new_link.link_speed =3D RTE_ETH_SPEED_NUM_NONE; > > + for (i =3D 0; i < RTE_DIM(idpf_supported_speeds); i++) { > > + if (vport->link_speed =3D=3D idpf_supported_speeds[i]) { > > + new_link.link_speed =3D vport->link_speed; > > + break; > > + } > > + } > > + > > + if (i =3D=3D RTE_DIM(idpf_supported_speeds)) { > > + if (vport->link_up) > > + new_link.link_speed =3D > > RTE_ETH_SPEED_NUM_UNKNOWN; > > + else > > + new_link.link_speed =3D RTE_ETH_SPEED_NUM_NONE; > > } >=20 > What about >=20 > /* initialize with default value */ > new_link.link_speed =3D vport->link_up ? RTE_ETH_SPEED_NUM_UNKNOWN : > RTE_ETH_SPEED_NUM_NONE >=20 > / * update in case a match */ > for (i =3D 0; i < RTE_DIM(idpf_supported_speeds); i++) { > .... > } >=20 [Liu, Mingxia] Good idea, new patch has been sent. > > > > new_link.link_duplex =3D RTE_ETH_LINK_FULL_DUPLEX; > > -- > > 2.34.1