RE: [PATCH] net/idpf: refine RTE_PMD_REGISTER_PARAM_STRING of IDPF PMD

["Liu, Mingxia" <mingxia.liu@intel.com>]

> -----Original Message-----
> From: Zhang, Qi Z <qi.z.zhang@intel.com>
> Sent: Friday, June 30, 2023 5:08 PM
> To: Liu, Mingxia <mingxia.liu@intel.com>; dev@dpdk.org
> Cc: Wu, Jingjing <jingjing.wu@intel.com>; Xing, Beilei <beilei.xing@intel.com>;
> Liu, Mingxia <mingxia.liu@intel.com>
> Subject: RE: [PATCH] net/idpf: refine RTE_PMD_REGISTER_PARAM_STRING of
> IDPF PMD
> 
> 
> 
> > -----Original Message-----
> > From: Mingxia Liu <mingxia.liu@intel.com>
> > Sent: Monday, June 26, 2023 10:06 PM
> > To: dev@dpdk.org
> > Cc: Wu, Jingjing <jingjing.wu@intel.com>; Xing, Beilei
> > <beilei.xing@intel.com>; Liu, Mingxia <mingxia.liu@intel.com>
> > Subject: [PATCH] net/idpf: refine RTE_PMD_REGISTER_PARAM_STRING of
> > IDPF PMD
> 
> No need to mention the PMD in the title as its duplicate with the prefix.
> 
> How about
> 
> net/idpf: refine vport parameter string
> 
> >
> > This patch refines 'IDPF_VPORT' param string in
> > 'RTE_PMD_REGISTER_PARAM_STRING'.
> >
> > Signed-off-by: Mingxia Liu <mingxia.liu@intel.com>
> > ---
> >  drivers/net/idpf/idpf_ethdev.c | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/net/idpf/idpf_ethdev.c
> > b/drivers/net/idpf/idpf_ethdev.c index 3e66898aaf..34ca5909f1 100644
> > --- a/drivers/net/idpf/idpf_ethdev.c
> > +++ b/drivers/net/idpf/idpf_ethdev.c
> > @@ -1478,9 +1478,9 @@ RTE_PMD_REGISTER_PCI(net_idpf, rte_idpf_pmd);
> > RTE_PMD_REGISTER_PCI_TABLE(net_idpf, pci_id_idpf_map);
> > RTE_PMD_REGISTER_KMOD_DEP(net_idpf, "* igb_uio | vfio-pci");
> > RTE_PMD_REGISTER_PARAM_STRING(net_idpf,
> > -			      IDPF_TX_SINGLE_Q "=<0|1> "
> > -			      IDPF_RX_SINGLE_Q "=<0|1> "
> > -			      IDPF_VPORT "=[vport_set0,[vport_set1],...]");
> > +	IDPF_TX_SINGLE_Q "=<0|1> "
> > +	IDPF_RX_SINGLE_Q "=<0|1> "
> > +	IDPF_VPORT
> > +"=[vport0_begin[-vport0_end][,vport1_begin[-vport1_end]][,..]]");
> 
> Better to use "<>" to wrap a symbol
> How about " [<begin>[-<end>][,<begin >[-<end>]][, ... ]]"?
> 
[Liu, Mingxia] Thanks, new patch has been sent.
> >
> >  RTE_LOG_REGISTER_SUFFIX(idpf_logtype_init, init, NOTICE);
> > RTE_LOG_REGISTER_SUFFIX(idpf_logtype_driver, driver, NOTICE);
> > --
> > 2.34.1