From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1583D42D94; Fri, 30 Jun 2023 12:47:34 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 03CBA41611; Fri, 30 Jun 2023 12:47:34 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 243C041141 for ; Fri, 30 Jun 2023 12:47:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1688122052; x=1719658052; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=F1FDENezszT25KNa0G7rydtg6dhKPuHTIRENWsmeAN0=; b=lwzSKCKlHuHwobZxi66s1ZBK3AMVGOObgMZYS+NM+GHFHlPo9CFc0xzH q05Cx+DEToPV6ybsOV1tzkcVl+TF5gZw6CHOMWDON+273ebpOmRWx8Giz CVwq7aCAu+oBJye8/oMaztqL7slT5KeekVzVv53h8SJ+4pqo9MSH4P4ru A1Q1A/RqzMacvnW3tyIxE21HodkjpGWF6EAu9up+Wt11qR16uE6jdO5gU aXWk7Si4GXvEBQtfQtMTlwpp48JmFPCsZLrkY7GaQ0sPCcaEGxJzWIcE4 IIv/aJUFdx313B7+1f5bX5irhkkrVZHfpKTOGtQ2WPw5/kiBqWxHt7Qzo Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10756"; a="393094478" X-IronPort-AV: E=Sophos;i="6.01,170,1684825200"; d="scan'208";a="393094478" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jun 2023 03:47:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10756"; a="717769903" X-IronPort-AV: E=Sophos;i="6.01,170,1684825200"; d="scan'208";a="717769903" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga002.jf.intel.com with ESMTP; 30 Jun 2023 03:47:31 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Fri, 30 Jun 2023 03:47:30 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Fri, 30 Jun 2023 03:47:29 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Fri, 30 Jun 2023 03:47:29 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.175) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Fri, 30 Jun 2023 03:47:29 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mHPT5eNTFDSwxWz/90X2jp3Q6hQdXkaE0rE+Sv9sdL0DLimhSicucF8NMjc7LlWDzKjaNKMk2obxjxBeL/gm/D2eIRayo7+73lFjBAKUM7Dm1pQF4Op79rlpqi3e6MdREEjnHXrD1JqF/Bbd+W4RHXInE+dQXRWV5CsBs/E7twBRiR8i83YtzJ/gTXlCbNwN1+iu2aWsiVZrBFdE9wurR4pgxT/35ZAjXRc9yZg8QzDPpHTiAsQkrQHZa7Tg9kRkmdeusBomeD2mpQ332V/P404bRdM7l+HqiEzFDD4jiJkFGppJFbMpopzwiKv5DKYoTlKhrO6IpLZPfqqYFsYtDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=T9Y5gBOYW2iFjBLl6r+R6FDlq7uqNshIejK6hzI5Ndc=; b=F9WWD75aOE9HZMi2PW9yZFlg6VT+irmRm1kdX5IMqWxireqU8l4wM7lQxoOCAFl5IyVQ5+BRk6ThwcZFb6bR69cI+SI/Xr+TQle5lOJuCBYWf0Yb1b15oWzKJKYdRuCYF7OsOC4xiv03uyVmA8LISHRRTJPGhEKP+QaxxLudkeFK3NUJ0nhQ1AETrnKk31iFC5CU9J/hVCCrWI4fVKiPdSBIokI6IuK1aWhIVcSWmKEWD3BAnSaqbEzJPdDkbaCOQG/YeRpNfvkq5wq+lsQZ5dBwfsty7l2hL6ILxDu+XCumxeGDoG6yJqEzuM7x5xr8+1UeGZDG5+3PZSfsILLZGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5877.namprd11.prod.outlook.com (2603:10b6:510:141::12) by DM4PR11MB5343.namprd11.prod.outlook.com (2603:10b6:5:392::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.23; Fri, 30 Jun 2023 10:47:27 +0000 Received: from PH0PR11MB5877.namprd11.prod.outlook.com ([fe80::da1b:ee87:709:3174]) by PH0PR11MB5877.namprd11.prod.outlook.com ([fe80::da1b:ee87:709:3174%5]) with mapi id 15.20.6521.024; Fri, 30 Jun 2023 10:47:27 +0000 From: "Liu, Mingxia" To: "Zhang, Qi Z" , "dev@dpdk.org" CC: "Wu, Jingjing" , "Xing, Beilei" Subject: RE: [PATCH] net/idpf: refine RTE_PMD_REGISTER_PARAM_STRING of IDPF PMD Thread-Topic: [PATCH] net/idpf: refine RTE_PMD_REGISTER_PARAM_STRING of IDPF PMD Thread-Index: AQHZp/HiebM8co9DtkKns6vC1FheBq+jFOqAgAAbmKA= Date: Fri, 30 Jun 2023 10:47:27 +0000 Message-ID: References: <20230626140626.490896-1-mingxia.liu@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB5877:EE_|DM4PR11MB5343:EE_ x-ms-office365-filtering-correlation-id: a8fcb2c6-310a-43c7-03a8-08db795765ae x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Vmi9Coxuw8HvukXV7Lq3flFJB2FSiw9lv/jvwD0DuqeRVS1LFi1qzwZN7/o/LE53nJ4uAcZkNUTPFNtEJm3nwVCqI/qDT/5lmiNKXVkRphkbdvIhGjU1EWCXRv6hExwru5XuVTxyOQ5C5v4kuxf/uzJs3qD2ZAzP86Z2d3LbTKtMCGHetZHKnTCnNFVB7yK2bjS60z1aQhqCn+2iOKacAd3O+KDSOFsRbW/4bhWkFF7zTBAdvZvuAFIBgYXqV450uNDDXDJkLN/y+6fP6P6QFmAjQL3Gw+JxNp+4XhUKfR8+vP1BkFECzJm95Uhdjie7MLJIxL3i9oyGieSvfipqu9A3NzBOT2DwiYJy0gQgeLFrLaCyWM0SVTgHYEso3fNJ58h7ocEDPg1bzkq+xh7MS2PycbO3QGZlmZXCuKJm3h+K1hFjvrske5BtVWJ2Ok4SXDj+PawezbZezg3qPLDPuWhL7c7OkQPnswprzD5B93qjUnEMjdzfr9YRp20A5rV2rjJlHYya3wfSdJSvScV9dIj6MrodyE9sNX0dajp4nZJGE6s8fR9W/q33az2U42folHw0g85BvBuQLBWmYChfq3nRQkLiVxgbQCYPaqG+B2xZHK5wqCAvlLdaGmjjHmIL x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5877.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(346002)(396003)(366004)(376002)(136003)(39860400002)(451199021)(66556008)(66946007)(76116006)(66476007)(66446008)(53546011)(8936002)(26005)(107886003)(186003)(6506007)(8676002)(55016003)(41300700001)(9686003)(110136005)(54906003)(64756008)(7696005)(71200400001)(4326008)(316002)(478600001)(2906002)(5660300002)(52536014)(82960400001)(38070700005)(38100700002)(83380400001)(122000001)(86362001)(33656002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?LovLrD7rGiix9x6kkjJ0dhKU1U4jDsbDZDOloMSQKKhslVDdQ2HxnZ7xnE1k?= =?us-ascii?Q?zlfsQ4ykw/Cloe1aJgWDio7XKGnW2hl2DLVbFRxRhUkXR5F0D01qTMW8CG31?= =?us-ascii?Q?/wb+zKN4unMQwlUtfdJ0KwKKZ01cwOpc7hdCWqrEqQXdFc9+bx0KN+p9SKkK?= =?us-ascii?Q?CETwzuzdaMg64Vs3wSU0hoO6Db7sA74XHw95XWiPIJvygPVrn7F8PLNPQLUc?= =?us-ascii?Q?9ORftCx6V6STGdAx6W5vNXRbAhr6FCUryHBtMHvjNFEtJPJ1skei+57w9H3s?= =?us-ascii?Q?QJAbKqCaSxzDaqh8z6ja/RtfVDCRplOqt4N4yPFLoUt1vMIFhTWnBp5+UIkn?= =?us-ascii?Q?vw2awz0w1EwTklgImzc5m1ss2eC8+TFEfjc9JC9dMaeCTcSryzf/J539CqC+?= =?us-ascii?Q?yJXqhoF27sio6C8mftcLBqTAyDKtrRP1+i6CLfGXWh7iOQdTuiKIxDYeA2s0?= =?us-ascii?Q?rA5DNKlelU5xfEHl4QIPF2p1oUv7PfOMJpNDH85kT5PgOu8SP+ch0bTx4Ylk?= =?us-ascii?Q?4dAcVwranWc3M9xmOP+PEfqAVNL90r+eh4hsY0I72vN+7gN1eo/0k43fVU5R?= =?us-ascii?Q?U5GqWCevHAfUKd+g5lhTlBFOPHDKZaWaolQguV1CPSSssT7i7oGiWTvTgm9v?= =?us-ascii?Q?PQGh6+IzDT+3OM/+r6IwJgJ1B9KmLYdfyNqmc3rTpKgcMFbAb4YDd/wGLuvz?= =?us-ascii?Q?6CocAyRrqwB0fZBYEwqbxF0C4HJt1aAmWw/gdpMY2quFVFEwCGZEbNsI7LJE?= =?us-ascii?Q?nvG8GkFFByAgU/7aS0XzGCTq9RXJrNSec6JEK/Y+9IFnznB/oeYyIPqIinwT?= =?us-ascii?Q?uGtac28oqvacXfkA02rqceZQpm53mUIQe0CPx6F7MsnUaQb+vdAhulmZc9+p?= =?us-ascii?Q?egm262EYtaBWzKB22WIPurxFx11FF09wi7HUMBeqvUjp9/BFM4QjOG6eWNQd?= =?us-ascii?Q?3ajqIYrfH3uVej5CmxCJLssJ1o14zUL1hOhrwj56xxTbAeKu/9j/WuK8YMJ8?= =?us-ascii?Q?HU7VedQ9c0buEsWo5nkcR/NfGyRjYz0ajpeWoSc65YJ1+vb8tWLi+Sj5miQR?= =?us-ascii?Q?dvoU4bNMzsnI03qQuAAMuK/6aGIj+B7Zw1Iq3sbcr/yJVmHSGUAUJSmgXFyu?= =?us-ascii?Q?gG9sgaqCxdft64IEH7UTUMrP70M4uKUlCB5cTJe2CPXre2/8mTON93EOD6xV?= =?us-ascii?Q?fS7QefnjDFyJREpWeRz39YBYBQXRY+uv/xjZXfsD9QXOLWgGrG+bc30FHzy9?= =?us-ascii?Q?vNcGsmjsamj8VCe/djxKTFiM3dHbn7NmGxNp+o6yCB/jvw3zrGi0qECwlueT?= =?us-ascii?Q?ezZQ/OeAO8f3xqlb6iPt4lyLEdteQe2Ee01VK21fkakUyvCwjMAJSM/as7bE?= =?us-ascii?Q?MlUdXagMi16LKVI+ZMAiy0HgoXH3fuk04RQKK865uvcHA0L3PgYSJfqT0Ihq?= =?us-ascii?Q?sCjLkwxH+1/qxc9Egt7ji/frPXBskF8vZAC9OBrYZR8Hc3CGeqrRhWpwwJ0z?= =?us-ascii?Q?wpwKNw6/4njQ9L0jfUTUk7x+87T7K39TC5iQGrIKo1vpMdA+rY6AgaUH3/A/?= =?us-ascii?Q?OXKwmOc9/a90ZPJuvQBfUCTgFixvKcbimDA84jk+?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5877.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a8fcb2c6-310a-43c7-03a8-08db795765ae X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Jun 2023 10:47:27.8001 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: MzM+UJ1KZgOlR41LbNhZCS6wvvT4jB8+Cn5Bz3atCelODySEMX6Y/iehXQkdrDM+pKspygw3uWvdJzfDMfn+dg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5343 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Zhang, Qi Z > Sent: Friday, June 30, 2023 5:08 PM > To: Liu, Mingxia ; dev@dpdk.org > Cc: Wu, Jingjing ; Xing, Beilei ; > Liu, Mingxia > Subject: RE: [PATCH] net/idpf: refine RTE_PMD_REGISTER_PARAM_STRING of > IDPF PMD >=20 >=20 >=20 > > -----Original Message----- > > From: Mingxia Liu > > Sent: Monday, June 26, 2023 10:06 PM > > To: dev@dpdk.org > > Cc: Wu, Jingjing ; Xing, Beilei > > ; Liu, Mingxia > > Subject: [PATCH] net/idpf: refine RTE_PMD_REGISTER_PARAM_STRING of > > IDPF PMD >=20 > No need to mention the PMD in the title as its duplicate with the prefix. >=20 > How about >=20 > net/idpf: refine vport parameter string >=20 > > > > This patch refines 'IDPF_VPORT' param string in > > 'RTE_PMD_REGISTER_PARAM_STRING'. > > > > Signed-off-by: Mingxia Liu > > --- > > drivers/net/idpf/idpf_ethdev.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/net/idpf/idpf_ethdev.c > > b/drivers/net/idpf/idpf_ethdev.c index 3e66898aaf..34ca5909f1 100644 > > --- a/drivers/net/idpf/idpf_ethdev.c > > +++ b/drivers/net/idpf/idpf_ethdev.c > > @@ -1478,9 +1478,9 @@ RTE_PMD_REGISTER_PCI(net_idpf, rte_idpf_pmd); > > RTE_PMD_REGISTER_PCI_TABLE(net_idpf, pci_id_idpf_map); > > RTE_PMD_REGISTER_KMOD_DEP(net_idpf, "* igb_uio | vfio-pci"); > > RTE_PMD_REGISTER_PARAM_STRING(net_idpf, > > - IDPF_TX_SINGLE_Q "=3D<0|1> " > > - IDPF_RX_SINGLE_Q "=3D<0|1> " > > - IDPF_VPORT "=3D[vport_set0,[vport_set1],...]"); > > + IDPF_TX_SINGLE_Q "=3D<0|1> " > > + IDPF_RX_SINGLE_Q "=3D<0|1> " > > + IDPF_VPORT > > +"=3D[vport0_begin[-vport0_end][,vport1_begin[-vport1_end]][,..]]"); >=20 > Better to use "<>" to wrap a symbol > How about " [[-][,[-]][, ... ]]"? >=20 [Liu, Mingxia] Thanks, new patch has been sent. > > > > RTE_LOG_REGISTER_SUFFIX(idpf_logtype_init, init, NOTICE); > > RTE_LOG_REGISTER_SUFFIX(idpf_logtype_driver, driver, NOTICE); > > -- > > 2.34.1