From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 68230429D2; Mon, 24 Apr 2023 10:48:19 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 00F1C410EC; Mon, 24 Apr 2023 10:48:19 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 16C74410DE for ; Mon, 24 Apr 2023 10:48:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1682326098; x=1713862098; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=Ih2mq79ubLpmnpKKxlPXNqudQ6cj2GMzW0kgZ487/OM=; b=SN2XrqSimVYYSpOPgUTFc4x68Cn9+ORpfmBp9prBLbrpsqUJjzjS1Oy/ o4TcxLPWOQ03zs+D4i/pDLC7Cw10qgY5YpES+RqpZwLPLzSzCEHfg8kkj HN/haAI4wh9g4mr38HMJZ00Y2UtO6wItLKBhvaAFxTDluCkOb1d7v/BFx 648PGTuKznKCm3EtEb2mXPJXw/EKdnXmImuYbPRhgrLbvvhah2Q+MJ7ex M2GUnTy0gfbSHZtrApnQjmOoJXN1LpjiysW7xUIUkYoGSBLqEH6nl+Lup 21rQ7RA0Re0eQyNXLZu+HdIRh3lmjkSye31ZoqwKP2S3sbcWpcSKo3nvK g==; X-IronPort-AV: E=McAfee;i="6600,9927,10689"; a="411672799" X-IronPort-AV: E=Sophos;i="5.99,222,1677571200"; d="scan'208";a="411672799" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Apr 2023 01:48:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10689"; a="723504277" X-IronPort-AV: E=Sophos;i="5.99,222,1677571200"; d="scan'208";a="723504277" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga008.jf.intel.com with ESMTP; 24 Apr 2023 01:48:16 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Mon, 24 Apr 2023 01:48:16 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Mon, 24 Apr 2023 01:48:16 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.103) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Mon, 24 Apr 2023 01:48:16 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RvmmuOxRUjcqDTppTFFhJnx2cX1WIhnpHLK7KLXU0DELFfRy7iTSpGI870+4Sm/QHNXoAE9qqnCmAoAFX5W5xCTr68EvVyr9O4yBHUHZLNrXrVXLAbIVwW5MKJCa72+gPDF3DADtATy3pQWTUyy1I3ToDdND0lGpJ47cwmvOG2iSscP9Hs3NgCm0re9BJRkH4IwevFSu3zFX1T2UnWEk6xIAvIKoKgcWTAPYeD6HfgceLTguZWZw7gw9alnUApwKvVoaHkOtYim1D7Qj5hgnqrx9zLfqEe0uYYpbXaSGuyJpJRmOV6qfjuoW9I+WMnGDUwHdAqNwjfUkuVNROZBp+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bWOHXSJdZuwXERMuEHICEO7K1AR88AR+l7Xx/qBKOu0=; b=iMLy9h84coHxTVaHnQeuyt1vzPtQc7cld+kUhFlVKXJ7WAeASVEkWklhAAivzA+nBtvNYmxwmUi3PU0kp/a0LAkiQVTueNYRyLJnhtkliN+J26o5A2Izn7OcmaIVTIZ7K8/D0CXq8vObUpZzNfzI54bzNrSwLB0owYgNx39wwOLeCNLjr343CcX8U+cIfbnAzWdOGofm9RkSlAhEECTk+Kda6CLM3dKyajv0fXCoW0rwvrL52ZAGngd/zku4bKjEXd0GWfO53m/wk/+z1Uk5eUOZwqKcPuRiOWrIIjB8AEncixS4FRvIrRYtKoZJ0w6jrqzEhrUiQ7B/oo2MCtx9tQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5877.namprd11.prod.outlook.com (2603:10b6:510:141::12) by DM4PR11MB6168.namprd11.prod.outlook.com (2603:10b6:8:ab::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.33; Mon, 24 Apr 2023 08:48:13 +0000 Received: from PH0PR11MB5877.namprd11.prod.outlook.com ([fe80::da1b:ee87:709:3174]) by PH0PR11MB5877.namprd11.prod.outlook.com ([fe80::da1b:ee87:709:3174%2]) with mapi id 15.20.6319.022; Mon, 24 Apr 2023 08:48:13 +0000 From: "Liu, Mingxia" To: "Xing, Beilei" , "Wu, Jingjing" CC: "dev@dpdk.org" Subject: RE: [PATCH 03/10] common/idpf: support queue groups add/delete Thread-Topic: [PATCH 03/10] common/idpf: support queue groups add/delete Thread-Index: AQHZdCDX46y0y7Lt1k+xQsPjGRcIYK86KYGQ Date: Mon, 24 Apr 2023 08:48:13 +0000 Message-ID: References: <20230421065048.106899-1-beilei.xing@intel.com> <20230421065048.106899-4-beilei.xing@intel.com> In-Reply-To: <20230421065048.106899-4-beilei.xing@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB5877:EE_|DM4PR11MB6168:EE_ x-ms-office365-filtering-correlation-id: 43ccb53f-07f4-474f-54a7-08db44a0a387 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: WVR5rGgifOd8Jh2RpeMq8KYEf3v1TT2lpcPs3By9XAjS9FLFgkuJraxeYfWazoJD6zhqujyTysTlFvCtHkI9ZmX+xSK72LMGMCX8BdinaVo0rO1uPzJLjU1KGf2cQnleayUHWkUhqLDF5h21gEOV9epbpndMgRWtkO/jqwF7geB1tz7xCVAQZAkVN6EfwOeWPLSWV8cQfhqiFgf9LJs82hF0gKCyEA1JdKgRuJ37BktfODE6+9BoNKc13ZtpkwweGxqm1kovf/EJMVNhxooglC5dfLBRisVeaiT0Y2EMz7if3F/Tm0grsAHEAYmVxSue056sCexgpJkB5O2C35kaJHV8HLgvBJ8s/xUwhmHZ5GzYeih1C83wNJ/kH2i9qQEOUnlGZK0ROA9KygQDtbIhyIkMKVmVVjoU7NTyoZ5pfU8M4BAq9SeOmLSZdxtxr8H4BvsWrSbBhvWyFyBZbO4OjEzNCQmPs/+dkwozAL9RuM1sk8juvmh09MFHXm2zV1OmFFpagHG90Wzw7WnqTHomjPNxc9Ex83wF8sztgJvWk8UCtRulKnddT4NOw+nh1Q9DMz1k8r+FthdW2GIBqpLhUa6QU8apG1hDnQuWputlZ6aKkgGWzvN2suNQ/nzgbnvW x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5877.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(39860400002)(396003)(366004)(136003)(376002)(346002)(451199021)(26005)(9686003)(53546011)(6506007)(186003)(55016003)(6636002)(110136005)(33656002)(86362001)(478600001)(8936002)(38100700002)(5660300002)(52536014)(8676002)(83380400001)(316002)(82960400001)(64756008)(66446008)(66476007)(66556008)(66946007)(76116006)(4326008)(38070700005)(2906002)(41300700001)(122000001)(71200400001)(7696005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?gws4itdS4CZ5tc5BUpPZViavkxd5UrVQzicLlHBZIRUgKTpSbu+Qr+du/1cT?= =?us-ascii?Q?RtuHTWX8HNBu/UbTefiVMGInagieMO7ujmE23tItfw3b37XZVEb0BY3P6BDK?= =?us-ascii?Q?McbmNrSurd4oySvYmvZE74agYlNpjR1ZSqJj3IabRmRNfp3UNGPfMW5IWUOM?= =?us-ascii?Q?O2ndNJMUg6c8pweKBdoh2TxDvUl4A/6amu9LQH8q/NoyilXgiAkFPW7G4Wp0?= =?us-ascii?Q?M6KwrZfA2wN7QeMtEjXErRfUmB+FPF6+sBmc3OhkhhdQ85VuIl6fZOb/iOp/?= =?us-ascii?Q?P7KRtYyRRoV5Lvp7e2mQKQIlnq8Z4IpEpM5WhA2UJiSKBGO1pno9M059EL+r?= =?us-ascii?Q?PDrJeD2DxdeLlvm9XKqkZCQC31nlRFgpUGYWQnUClcvhzv6U77ZlQRj5R3gM?= =?us-ascii?Q?X2ISagSi/wBBD5eKtrzwh4PznLptvothCH4+libjyFDBWKbBbG2JB5DDJqiL?= =?us-ascii?Q?sZFcgw/CbMOqAoG1jQtRJZxfbivBnpMep5XXvqqcX7UfsafyoxqkbOjc+lF1?= =?us-ascii?Q?rWLd0EMTuiTJ309fuFL69fdLWAXBab7v3lW76hR5bqiaeog8td3LRNIaYBOm?= =?us-ascii?Q?D6WROsq57ivhJzgtT/Tea3m819+v4lsv0iHZT3aFcqRMpBM/96csAsRqEKvf?= =?us-ascii?Q?OI2I3KbRLVN4/hTXu/BOa6eQUtgsy5S0B24jGDZKIV3pcO4Kuu3saBhQPZs8?= =?us-ascii?Q?ISDLdjyV8XT1D+8PxV9DMDshQa82lQrLjeUxIfel7bUXg95hB8fQKmpmBfaT?= =?us-ascii?Q?M7jsDbsf1Q8OBNRruEUICpi/roGbvMkifcaEpQkbSQb3Ulgjz+seyg8Gz105?= =?us-ascii?Q?40HAMnqrm2qcaNIrpmYS151oVnbBgxslo0bg+MTBEB3Zy4vVIocsUN1F6Ocv?= =?us-ascii?Q?DgvoVFyasEzwE3B3qc7/l9hsIOsCr2BjR4eOfUGIXrRLGSLROUD4jX9IOcFk?= =?us-ascii?Q?DEAwqoJDoBUsfYpnc9C6UZh6U3S0U6UNx71u0mRM69Una0o/wrGlWCVPSzaA?= =?us-ascii?Q?fonBQuf51rk5xFmluqQDYtKf0biyW8aXIt9H+QBzzoZcNtWc16hJmOMOtSgZ?= =?us-ascii?Q?cOjijzCWnlq+h6ZTnQ2yvqVh1sVeHZLO3/1GWbnCf+q0E8eKycz8sgsCFezR?= =?us-ascii?Q?AaJrYbz8I9rxagKWLEwiFqmUcAiv0KC5wStzMkR1eVyAThA1VfxWUV1zcWOs?= =?us-ascii?Q?BeqvrjUgIuFi8D4+RW9MH9fpYNDnocEh5bAkoWWrJESpLH+u18/Bn24Eoqnt?= =?us-ascii?Q?GH+PlP9Srp/f9O5r1EPqtd+N+3CQi0xsdWrFJNYyPMDLG4AijJbxEf/3MGjW?= =?us-ascii?Q?/FjnoYOJQMPtWmbXWPjCJCNm/6F98DrwmWVlGr9PaUIhKCvwxLoYYfvaaw+T?= =?us-ascii?Q?+qhdT7p9qNQyeNDhjuPpwVmeL0lClSO14wev3OjdQAMtp7ua85/skFFNWawV?= =?us-ascii?Q?UVXLMQPcVwLueT/3xMOoz9cN6gjYud61bJwt802JMaho3+GkGzdA8O/uueLh?= =?us-ascii?Q?GPYkfNd26VOQwZaIjp10ibuwdBnhT9N8Sp7xo27KJCMqk0ufv5pO4BopUEOT?= =?us-ascii?Q?L9u9enVLrki1OZuraT2HSnWnffqHxHy/MQaewb9d?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5877.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 43ccb53f-07f4-474f-54a7-08db44a0a387 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Apr 2023 08:48:13.1559 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: b6bXo2+unZlqiEAxafjOBlzFs/BWEYjQeWiATM/HxS89BNyraYkc0HNUYeZZSYDbYBfEuGXsuCVz6JCgok3law== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6168 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Xing, Beilei > Sent: Friday, April 21, 2023 2:51 PM > To: Wu, Jingjing > Cc: dev@dpdk.org; Liu, Mingxia ; Xing, Beilei > > Subject: [PATCH 03/10] common/idpf: support queue groups add/delete >=20 > From: Beilei Xing >=20 > This patch adds queue group add/delete virtual channel support. >=20 > Signed-off-by: Mingxia Liu > Signed-off-by: Beilei Xing > --- > drivers/common/idpf/idpf_common_virtchnl.c | 66 > ++++++++++++++++++++++ > drivers/common/idpf/idpf_common_virtchnl.h | 9 +++ > drivers/common/idpf/version.map | 2 + > 3 files changed, 77 insertions(+) >=20 > diff --git a/drivers/common/idpf/idpf_common_virtchnl.c > b/drivers/common/idpf/idpf_common_virtchnl.c > index a4e129062e..76a658bb26 100644 > --- a/drivers/common/idpf/idpf_common_virtchnl.c > +++ b/drivers/common/idpf/idpf_common_virtchnl.c > @@ -359,6 +359,72 @@ idpf_vc_vport_destroy(struct idpf_vport *vport) > return err; > } >=20 > +int > +idpf_vc_queue_grps_add(struct idpf_vport *vport, > + struct virtchnl2_add_queue_groups > *ptp_queue_grps_info, > + uint8_t *ptp_queue_grps_out) [Liu, Mingxia] Better to unify the abbreviation of "port to port" , this pa= tch p2p is used, in the next patch p2p is used. > +{ > + struct idpf_adapter *adapter =3D vport->adapter; > + struct idpf_cmd_info args; > + int size, qg_info_size; > + int err =3D -1; > + > + size =3D sizeof(*ptp_queue_grps_info) + > + (ptp_queue_grps_info->qg_info.num_queue_groups - 1) * > + sizeof(struct virtchnl2_queue_group_info); > + > + memset(&args, 0, sizeof(args)); > + args.ops =3D VIRTCHNL2_OP_ADD_QUEUE_GROUPS; > + args.in_args =3D (uint8_t *)ptp_queue_grps_info; > + args.in_args_size =3D size; > + args.out_buffer =3D adapter->mbx_resp; > + args.out_size =3D IDPF_DFLT_MBX_BUF_SIZE; > + > + err =3D idpf_vc_cmd_execute(adapter, &args); > + if (err !=3D 0) { > + DRV_LOG(ERR, > + "Failed to execute command of > VIRTCHNL2_OP_ADD_QUEUE_GROUPS"); > + return err; > + } > + > + rte_memcpy(ptp_queue_grps_out, args.out_buffer, > IDPF_DFLT_MBX_BUF_SIZE); > + return 0; > +} > + > +int idpf_vc_queue_grps_del(struct idpf_vport *vport, > + uint16_t num_q_grps, > + struct virtchnl2_queue_group_id *qg_ids) { > + struct idpf_adapter *adapter =3D vport->adapter; > + struct virtchnl2_delete_queue_groups *vc_del_q_grps; > + struct idpf_cmd_info args; > + int size; > + int err; > + > + size =3D sizeof(*vc_del_q_grps) + > + (num_q_grps - 1) * sizeof(struct virtchnl2_queue_group_id); > + vc_del_q_grps =3D rte_zmalloc("vc_del_q_grps", size, 0); > + > + vc_del_q_grps->vport_id =3D vport->vport_id; > + vc_del_q_grps->num_queue_groups =3D num_q_grps; > + memcpy(vc_del_q_grps->qg_ids, qg_ids, > + num_q_grps * sizeof(struct virtchnl2_queue_group_id)); > + > + memset(&args, 0, sizeof(args)); > + args.ops =3D VIRTCHNL2_OP_DEL_QUEUE_GROUPS; > + args.in_args =3D (uint8_t *)vc_del_q_grps; > + args.in_args_size =3D size; > + args.out_buffer =3D adapter->mbx_resp; > + args.out_size =3D IDPF_DFLT_MBX_BUF_SIZE; > + > + err =3D idpf_vc_cmd_execute(adapter, &args); > + if (err !=3D 0) > + DRV_LOG(ERR, "Failed to execute command of > +VIRTCHNL2_OP_DEL_QUEUE_GROUPS"); > + > + rte_free(vc_del_q_grps); > + return err; > +} > + > int > idpf_vc_rss_key_set(struct idpf_vport *vport) { diff --git > a/drivers/common/idpf/idpf_common_virtchnl.h > b/drivers/common/idpf/idpf_common_virtchnl.h > index d479d93c8e..bf1d014c8d 100644 > --- a/drivers/common/idpf/idpf_common_virtchnl.h > +++ b/drivers/common/idpf/idpf_common_virtchnl.h > @@ -64,4 +64,13 @@ int idpf_vc_ctlq_recv(struct idpf_ctlq_info *cq, u16 > *num_q_msg, __rte_internal int idpf_vc_ctlq_post_rx_buffs(struct > idpf_hw *hw, struct idpf_ctlq_info *cq, > u16 *buff_count, struct idpf_dma_mem **buffs); > +__rte_internal > +int idpf_vc_queue_grps_del(struct idpf_vport *vport, > + uint16_t num_q_grps, > + struct virtchnl2_queue_group_id *qg_ids); > __rte_internal int > +idpf_vc_queue_grps_add(struct idpf_vport *vport, > + struct virtchnl2_add_queue_groups > *ptp_queue_grps_info, > + uint8_t *ptp_queue_grps_out); > #endif /* _IDPF_COMMON_VIRTCHNL_H_ */ > diff --git a/drivers/common/idpf/version.map > b/drivers/common/idpf/version.map index 7076759024..aa67f7ee27 > 100644 > --- a/drivers/common/idpf/version.map > +++ b/drivers/common/idpf/version.map > @@ -48,6 +48,8 @@ INTERNAL { > idpf_vc_irq_map_unmap_config; > idpf_vc_one_msg_read; > idpf_vc_ptype_info_query; > + idpf_vc_queue_grps_add; > + idpf_vc_queue_grps_del; > idpf_vc_queue_switch; > idpf_vc_queues_ena_dis; > idpf_vc_rss_hash_get; > -- > 2.26.2