DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Jiawei(Jonny) Wang" <jiaweiw@nvidia.com>
To: "NBU-Contact-Thomas Monjalon (EXTERNAL)" <thomas@monjalon.net>
Cc: Raslan Darawsheh <rasland@nvidia.com>,
	Asaf Penso <asafp@nvidia.com>, Matan Azrad <matan@nvidia.com>,
	Slava Ovsiienko <viacheslavo@nvidia.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Subject: RE: [PATCH] doc: update sample action description for mlx5
Date: Fri, 4 Nov 2022 13:23:36 +0000	[thread overview]
Message-ID: <PH0PR12MB5451A42F1A2EC5FE560E0A09C63B9@PH0PR12MB5451.namprd12.prod.outlook.com> (raw)
In-Reply-To: <5157278.bB369e8A3T@thomas>

Hi,

Sorry for the late reply.

> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Friday, October 14, 2022 9:11 PM
> To: Jiawei(Jonny) Wang <jiaweiw@nvidia.com>
> Cc: Raslan Darawsheh <rasland@nvidia.com>; Asaf Penso <asafp@nvidia.com>;
> Matan Azrad <matan@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>; dev@dpdk.org
> Subject: Re: [PATCH] doc: update sample action description for mlx5
> 
> 14/10/2022 12:14, Jiawei Wang:
> > This patch adds mlx5 description about E-Switch mirroring flow
> > (RTE_FLOW_ACTION_TYPE_SAMPLE with sample ratio=1) with encap action,
> > then supports the uplink port only in the sample actions list or in
> > the one flow.
> >
> > Signed-off-by: Jiawei Wang <jiaweiw@nvidia.com>
> [...]
> > +  - For E-Switch mirroring flow, supports ``ENCAP`` actions only to the
> > +    UpLink Port and in either of sample actions list or in the flow.
> 
> Sorry I don't understand the second part of the sentence:
> "and in either of sample actions list or in the flow."
> 
> Please could you explain so we can find a simpler wording?
> 

RTE sample action support a list of actions that be defined as below structure:
	struct rte_flow_action_sample {
		uint32_t ratio; /**< packets sampled equals to '1/ratio'. */
		const struct rte_flow_action *actions;
			/**< sub-action list specific for the sampling hit cases. */
	};

So the second part meaning that 'encap' with 'port' combination can be in the 'sub-action' list of sample
Or flow actions while user calls rte_flow_create(,, actions[]);

> 


      reply	other threads:[~2022-11-04 13:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-14 10:14 Jiawei Wang
2022-10-14 13:10 ` Thomas Monjalon
2022-11-04 13:23   ` Jiawei(Jonny) Wang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=PH0PR12MB5451A42F1A2EC5FE560E0A09C63B9@PH0PR12MB5451.namprd12.prod.outlook.com \
    --to=jiaweiw@nvidia.com \
    --cc=asafp@nvidia.com \
    --cc=dev@dpdk.org \
    --cc=matan@nvidia.com \
    --cc=rasland@nvidia.com \
    --cc=thomas@monjalon.net \
    --cc=viacheslavo@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).