From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1A5F04555B; Wed, 3 Jul 2024 10:09:00 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 065404029B; Wed, 3 Jul 2024 10:09:00 +0200 (CEST) Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2040.outbound.protection.outlook.com [40.107.102.40]) by mails.dpdk.org (Postfix) with ESMTP id B762E4003C for ; Wed, 3 Jul 2024 10:08:58 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Fp8ivku6Czb+y0VBOm0lesi9a655NBRA3nDeDgUnqdmGyoiZEjUbi9GlC+3iQsfZc2powhkqN9MqkwfZujx4IzpazlRZWm/X5qhJbG+ThzBFvlChRyd5yV05zrWAcSL1kT5ss7g68JpcbOrp8Po1xQOpdd2HQ6TPZBrQwoHI6rFukFSBHKWSNg2oop5pK4ld76rQ7VmtCOS0m1gSxGf2wvF9XupmH3dxFr/YHAng7iEFNMEN5JOwuKEN/ZOIFvIwvOdzkndvXg2CgprNk/f+V4HMSAfOl0NUNM7haGuvfuMqZ+xPPBYs8y+abz/5AGRcPuSFV7GKDmnBmqwQN9jE1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ggTCt9CU7g5w2bMgBnHwiFRQx0WNtDgVEZNHBgHm7tI=; b=OGbpLA5sHRpd3DOH5Kf9D03dGfGmPDSCcSeQIod89NE/wJCzFBYiBEIRg+ytdXo60B8lRmHLtRURenGrIjMquebTCDJ5APfmCr9STeElq4D7OWTcf4DOTOeUk1bxIAHfc9eCFb0NZquWMxAGGDN7nftbgmzW/IoQ7VkKyPFPMDiXdASxNuG4WJoIq3Mi9vk6fPXfDTeJNg2oUoSlovAWjSaQgQq3Lcjye76/SP0FriLIE35FyxATkxuSSNhlg/tvtL3Xs7MkcZa0bj47KzeG0UWryOBCMQPr6/lZvoBL7ZrQbfHlXGJi9MD7a2P8TfTUBm2UB75R7ej7eDy6ssOkVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ggTCt9CU7g5w2bMgBnHwiFRQx0WNtDgVEZNHBgHm7tI=; b=AbXw/0dUgTzhnG0XMntd3IvXYWQgcLFUZTM9L7NooESk1zAAH29BzcgyUpC1jIlFHAYN5BhQe5n46klVe3H0M9m+4teVk6KbXK0J2Ta2/ly98UkQWpRYvp6teRmVOdacZ2kAT+vWH7rVzyqU7aOYgCx+BY+Aznc8pUNost6rTgjE72vIebD6XqYU4jCxhty+1/DIiIZt+MI2AYPUw/WwdkTcO0HfLJTdZwY3IJmn7I1p+NaPMSqju0O8a+BvFppPDfAbvyNcMPoEVGevRm50YmX7H5Ie3q2Izr9evLeUux8BQxB2HoWOL754cmJi98kx7Gnt7XUss8cywdXCLG3Wig== Received: from PH0PR12MB8800.namprd12.prod.outlook.com (2603:10b6:510:26f::12) by PH8PR12MB6962.namprd12.prod.outlook.com (2603:10b6:510:1bd::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7719.26; Wed, 3 Jul 2024 08:08:53 +0000 Received: from PH0PR12MB8800.namprd12.prod.outlook.com ([fe80::bdb6:e12f:18b6:2b77]) by PH0PR12MB8800.namprd12.prod.outlook.com ([fe80::bdb6:e12f:18b6:2b77%7]) with mapi id 15.20.7719.029; Wed, 3 Jul 2024 08:08:53 +0000 From: Dariusz Sosnowski To: Bing Zhao , Mahmoud Maatuq , Slava Ovsiienko , Ori Kam , Suanming Mou , Matan Azrad , Maayan Kashani CC: "dev@dpdk.org" Subject: RE: [PATCH v3] net/mlx5: fix matcher object memory leak Thread-Topic: [PATCH v3] net/mlx5: fix matcher object memory leak Thread-Index: AQHazLySxbwIY53Ye0icY4IE1kQTibHkpJCAgAABvoA= Date: Wed, 3 Jul 2024 08:08:53 +0000 Message-ID: References: <20240623103539.1690600-1-mahmoudmatook.mm@gmail.com> <20240702201450.349991-1-mahmoudmatook.mm@gmail.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR12MB8800:EE_|PH8PR12MB6962:EE_ x-ms-office365-filtering-correlation-id: 686fd9f9-c09f-4b68-4457-08dc9b376101 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|1800799024|366016|376014|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?mjsxGXngBmZLUx0Xy8Yzm+fyICKHKfTR0TqF+moTIqu932yReexvimbtvHT9?= =?us-ascii?Q?nLG5I4g85uF6rLXtohXj7hvGZxfvoawI2jI6Ck8vJmbAIrJKAm9CMnJmdzO7?= =?us-ascii?Q?NF9qMinIQ3bA8qp+uQY3tsQpE+fxtqd2RimBNqSK1BuDC3EOD4eRDzF7C/ey?= =?us-ascii?Q?gUkT6LGFywZtArJhfBU9uODwMED7moUjCNL6GduacFAHxBHfiaVIlMaqhbnd?= =?us-ascii?Q?jmHhY5NtyfGPaM8Lstt6Q/UFYjHSsYp818ibVA6/Y8D0epQCIkMoo9t5A9w+?= =?us-ascii?Q?JCbj1BfDpE4T0XI8lhp95tGVfmH6TxdMUuUatITqUSr/k3yeUboIwGKlt/3F?= =?us-ascii?Q?+JGevj6dda01AO+lLkgVS2Qp8RvX0kGm1L8Xok0CkjPR7h134swEsn+GVttr?= =?us-ascii?Q?bZPU4jpqFz76A6V3f3zrkY/tiKqoi8W810E7HJ1invnqZmw84IODhudQuO6K?= =?us-ascii?Q?mqP1I07oQll4Tc8efowpN4xs4e1i5T0YJJ+1D8QalFUm5fIZw+f4VpStHeED?= =?us-ascii?Q?oyzNYQpYkKOjoVBrx8l4thSR1kFI0jPYDVnm7AIgODulXZW+aveJVdGsnP5p?= =?us-ascii?Q?oWgrIN8x9OKBj3fb/YzF8Lr+gdV4ic+uFpdprUAoyZoZU4oKkaZfL8Wi6dbT?= =?us-ascii?Q?w3ZoLJOS3nlvXdcvgP17kvhFuJcI0nAKYxtKVIjhX1WVGwhfilyhRYZXuHQC?= =?us-ascii?Q?Bkjf2IjySakXfAoBkxcT4VMCQcgzoN8DFateTBK6JJoBjNqnXYzNkOBoBPox?= =?us-ascii?Q?evfSnR94mipovOzAESilcL66dkk325oAqX7yO659/MZwFGu6jXfDEvpyDjAe?= =?us-ascii?Q?os5DW0Dz2JcBiLOCf6cu84S34qgdI6JFaHNAmb93of+4n/8VTr17RJX0X8QA?= =?us-ascii?Q?WOmZewtPPyjw0xuf5hMH53P+5e9WpLgzl11heZ/L4X1QXaOA3UUxe0hBNFAe?= =?us-ascii?Q?Zk7JOXtD4LmqJi+dwpc2eG2ak6q+0XBEbQ4zFWPBLT2HqGngl2n7uOy5Y/w6?= =?us-ascii?Q?Vg4sxpfrkfWYX8fG+kWkaEeXSMsuFri6xLR/qqHtDoQOR1hRKUN7wPia6HMz?= =?us-ascii?Q?HLZBGVUsJmqIaQbox+zCmmoIFMsyzP6fHljm6S6475YFc8yGDhy0PSaQJj8H?= =?us-ascii?Q?eI8wvxtVcLwJiLykGExko/49+tSQihDgESDRRQ08Zm9exVoxSG/rYw9FP6kY?= =?us-ascii?Q?sS6JoyOwoVl60aq3oNNbcfU8kUF99YzfssdGkOgjMFrzdvwX4RsVwME2DL7S?= =?us-ascii?Q?3kijspDxuNWW/roXuBh4WnFH44nphWMM96+oo+BYzqKyUQSaOnpk/Yid4/rc?= =?us-ascii?Q?JwM3N3fXBpbdUcxUZZPgCC7mRR4jTjCRrkj+MfKLf+T2q7oM5pihSwW9l5pv?= =?us-ascii?Q?uyHU9UF3jqL6L0eZsLlfnmgorZc0RUwslrWljuTl7X4HrhyHdA=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR12MB8800.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014)(38070700018); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?bG0X3fO7u706IMtvaksZLmI+kYRBXpYTM5VeZXEWXHMW8KAPfqo2fECjLWmn?= =?us-ascii?Q?Jn2I+JB5WkpSTs159VGhux1ssxOG/7TSI/JESK3RegBtBqSMuGn8b6IQc6gA?= =?us-ascii?Q?Zkle89l/nQI2f3cgJnjC4u6UazQP1dewZCBa9XkKWcqMO68rCXHSX9W8uyZH?= =?us-ascii?Q?7vz6WAf6FvlOfn64yNIx2MHkz/bvjRGKAGwJc0Yz5jtJBpjls55KtdRlLpZZ?= =?us-ascii?Q?vc/QK7T7tHGqRlYYAbmdAg1w+7Ki+SZJqCqD8ISYmwfMQ7P74/GDIll6TBUg?= =?us-ascii?Q?3fp5MP0nL2t/6UzSbg1UgKy/7PbARPanlh5WhVuC3je8ZAvC4T5Zewb7w83i?= =?us-ascii?Q?RmIC0WwU20karNwIffDjEezMBpxHAgozURFIw1GIax3lhkQLsmOfg/jcOz1N?= =?us-ascii?Q?AR+tjR9w5tDPm6f58x1Ptf8gu26WUNjiKeqf+xq3vwr35Ue5B8614LMGHgVE?= =?us-ascii?Q?HppYtJOGt4AiY0CE6wuB2p162TDcqN0lQlLIT3kIxuu0gsXBHdOlAQyGSCnW?= =?us-ascii?Q?QUHckCfFZcJDwinRS2H4Tc0mA+sgBbD4e98bj/Yw80MT/XDEt98uLwNWMGb2?= =?us-ascii?Q?1PJuZXziH8VxPmlXUuGuKeJXItpkWUVGHbcD6+AzPepr0aIwzS/coaWpsMz7?= =?us-ascii?Q?17zvbLBC5fPNupw0enRIsHQACiAAyph/pzU/wEfek7Q8WDNE3CbPmyOffYwC?= =?us-ascii?Q?rdSPd7c2Vys6yQwR/x5sfY7HRqCVpy6WCszg4ezxe7SypA7fuvFafuLVW45N?= =?us-ascii?Q?kNL23otYZXnXJPU8y0TlmkyFzzroLpUEwaiyMcKqL3Y4SfPkug+39fqlrXDl?= =?us-ascii?Q?uGT9sP5iW5lfY2L93ZN5CPssgN/peHSR/GY4ZOC18Qxe427KEEPO9BVBrUkc?= =?us-ascii?Q?TmchmGi5aZ65dR2UmVKrZxwe0Jwx9Rh6NfhU7qKWA74oOHhtLWW18PHbbzgr?= =?us-ascii?Q?RiRjHVgPcBkZ7959mvQpWe1yL3X0oXuK6Nls4rO4DNhzfLc+1F9hquWGS5HJ?= =?us-ascii?Q?c0ImVXth13Mpp5YNWW0VNRaTSg+dUUYw9Hzwjs43/5ftMKLfvEMIsETJRmHP?= =?us-ascii?Q?ZYeQvJ7MlHRbnDjnjiRrGZjW6uc2AWhESLKcB03cATRxIqk5bwdh9WhX2lAi?= =?us-ascii?Q?H4UP/vwWrPkxKyXPYh/BlnBNzG6S54o+0xfLbjz+VRscZtkbKaUBLm1WVrCI?= =?us-ascii?Q?PWPA7X1UGMtj+hmZJmD+Ja5RWOlczu8iRkByeJtwP1FzyECsyUkofkuMi/iv?= =?us-ascii?Q?L+/1o0Zv8Vn7Ekli7h+HrmQJLg0MQVO0s8/F7w9C8Q3II66fk9YcKDTK7hKi?= =?us-ascii?Q?4SA5ppMcNkaSGblsTVMB3C4cZnC/S1pKsTvqifPWbIiXsE9oU98f7j4ihk8P?= =?us-ascii?Q?cqcXpJW1Gbr9jINMplKk+mTjXURpbIENHEZaf9eweHN72RQ23WGQT7O0UWMK?= =?us-ascii?Q?dPiZKXFm1Ri42qKw1+F8kaHEj9T6sn2+6USYkpGiy0gEOVF3ITD+PdkxHnIJ?= =?us-ascii?Q?H/gV+eFSa5x+RO0vF0SLFXOgbeBofgk3OEfwydvyyhTeHSrtnlCxOF3l7b7j?= =?us-ascii?Q?ccW4fbZLgHeErO/qlo8uOKOocFlo9O0BuWJig53y?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR12MB8800.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 686fd9f9-c09f-4b68-4457-08dc9b376101 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Jul 2024 08:08:53.2197 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: RBRGtAKSIQqxJ+UUAP+4QpGSInfJKLBI/gEfUhwusKEhm6gpl25dRliIRn/rJ4Io7118PJY3u+WHlIHptpRwVA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB6962 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, > -----Original Message----- > From: Bing Zhao > Sent: Wednesday, July 3, 2024 10:00 > To: Mahmoud Maatuq ; Dariusz > Sosnowski ; Slava Ovsiienko > ; Ori Kam ; Suanming Mou > ; Matan Azrad ; Maayan > Kashani > Cc: dev@dpdk.org > Subject: RE: [PATCH v3] net/mlx5: fix matcher object memory leak >=20 > Hi, >=20 >=20 > > -----Original Message----- > > From: Mahmoud Maatuq > > Sent: Wednesday, July 3, 2024 4:15 AM > > To: Dariusz Sosnowski ; Slava Ovsiienko > > ; Bing Zhao ; Ori Kam > > ; Suanming Mou ; Matan > Azrad > > ; Maayan Kashani > > Cc: dev@dpdk.org; Mahmoud Maatuq > > Subject: [PATCH v3] net/mlx5: fix matcher object memory leak > > > > External email: Use caution opening links or attachments > > > > > > This makes sure that the allocated matcher object is freed for all > > branches that return NULL. > > > > Coverity issue: 426424 > > Fixes: 27d171b88031 ("net/mlx5: abstract flow action and enable > > reconfigure") > > Cc: mkashani@nvidia.com > > > > Signed-off-by: Mahmoud Maatuq > > --- > > v3: > > * changed commit message. > > * fixed typos > > v2: > > * fixed Fixes and Cc tags. > > --- > > drivers/net/mlx5/mlx5_flow_dv.c | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/net/mlx5/mlx5_flow_dv.c > > b/drivers/net/mlx5/mlx5_flow_dv.c index d46beffd4c..8a0d58cb05 100644 > > --- a/drivers/net/mlx5/mlx5_flow_dv.c > > +++ b/drivers/net/mlx5/mlx5_flow_dv.c > > @@ -12010,9 +12010,12 @@ flow_matcher_create_cb(void *tool_ctx, void > > *cb_ctx) > > items =3D *((const struct rte_flow_item **)(ctx->data2)= ); > > resource->matcher_object =3D mlx5dr_bwc_matcher_create > > (resource->group->tbl, > > resource->priority, items); > > - if (!(resource->matcher_object)) > > + if (!resource->matcher_object) { > > + mlx5_free(resource); > > return NULL; > > + } > > #else > > + mlx5_free(resource); > > return NULL; > > #endif > > } > > -- > > 2.43.0 >=20 > Acked-by: Bing Zhao Thank you for all the changes and the patch! Acked-by: Dariusz Sosnowski Best regards, Dariusz Sosnowski