DPDK patches and discussions
 help / color / mirror / Atom feed
From: Dariusz Sosnowski <dsosnowski@nvidia.com>
To: rongwei liu <rongweil@nvidia.com>,
	"NBU-Contact-Thomas Monjalon (EXTERNAL)" <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Matan Azrad <matan@nvidia.com>,
	Slava Ovsiienko <viacheslavo@nvidia.com>,
	Ori Kam <orika@nvidia.com>, Suanming Mou <suanmingm@nvidia.com>,
	Aman Singh <aman.deep.singh@intel.com>,
	Yuying Zhang <yuying.zhang@intel.com>,
	Ferruh Yigit <ferruh.yigit@amd.com>,
	Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Subject: RE: [PATCH v4 2/3] ethdev: add VXLAN last reserved field
Date: Tue, 4 Jun 2024 16:40:59 +0000	[thread overview]
Message-ID: <PH0PR12MB8800ECD345A322AFC4F5DC5CA4F82@PH0PR12MB8800.namprd12.prod.outlook.com> (raw)
In-Reply-To: <CH3PR12MB8209FC4C9706B0CBAD894C8DABF82@CH3PR12MB8209.namprd12.prod.outlook.com>

> > 04/06/2024 14:38, Rongwei Liu:
> > > --- a/app/test-pmd/cmdline_flow.c
> > > +++ b/app/test-pmd/cmdline_flow.c
> > > @@ -1006,6 +1006,7 @@ static const char *const flow_field_ids[] = {
> > >       "ipv6_flow_label", "ipv6_traffic_class",
> > >       "esp_spi", "esp_seq_num", "esp_proto",
> > >       "random",
> > > +     "vxlan_last_rsvd",
> > >       NULL
> > >  };
> >
> > How vxlan_last_rsvd is linked to RTE_FLOW_FIELD_VXLAN_RSVD1 in testpmd?
> > Just because it is the same order?

Yes, it's because of the order.
We should refactor this to use array designators.

> > > --- a/lib/ethdev/rte_flow.h
> > > +++ b/lib/ethdev/rte_flow.h
> > > @@ -2428,6 +2428,7 @@ enum rte_flow_field_id {
> > >       RTE_FLOW_FIELD_ESP_SEQ_NUM,     /**< ESP Sequence Number. */
> > >       RTE_FLOW_FIELD_ESP_PROTO,       /**< ESP next protocol value. */
> > >       RTE_FLOW_FIELD_RANDOM,          /**< Random value. */
> > > +     RTE_FLOW_FIELD_VXLAN_RSVD1,     /**< VXLAN last reserved byte. */
> > >  };
> >
> > I think we should use the same naming as in testpmd.
> > What about RTE_FLOW_FIELD_VXLAN_LAST_RSVD?
> To be honest, no strong objection per my personal thought.  Considering the API "vxlan_hdr" names this field as "uint8_t rsvd1", maybe RTE_FLOW_FIELD_VXLAN_RSVD1 will be clearer for user as 1 vs 1 mapping?

+1 on using RSVD1 so it matches rte_vxlan_hdr definition.

In this patch, "vxlan_last_rsvd" is used in testpmd, so it matches existing "last_rsvd" field in VXLAN item.
If we choose to use "rsvd1", we should probably rename all other instances of "last_rsvd" to match.

Best regards,
Dariusz Sosnowski

  reply	other threads:[~2024-06-04 16:41 UTC|newest]

Thread overview: 67+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-23  7:28 [PATCH v1 0/3] support VXLAN rsvd1 modification Rongwei Liu
2024-05-23  7:28 ` [PATCH v1 1/3] ethdev: add VXLAN last reserved field Rongwei Liu
2024-05-23  7:28 ` [PATCH v1 2/3] app/testpmd: add VXLAN last reserved modification command Rongwei Liu
2024-05-24 15:53   ` Dariusz Sosnowski
2024-05-27  2:47     ` [PATCH v2 0/4] support VXLAN rsvd1 modification Rongwei Liu
2024-05-27  2:47       ` [PATCH v2 1/4] app/testpmd: fix the testpmd field string sequence Rongwei Liu
2024-05-30  8:22         ` rongwei liu
2024-06-03  7:30         ` Dariusz Sosnowski
2024-05-27  2:47       ` [PATCH v2 2/4] ethdev: add VXLAN last reserved field Rongwei Liu
2024-06-04 11:27         ` rongwei liu
2024-06-04 11:59         ` Thomas Monjalon
2024-06-04 12:06           ` rongwei liu
2024-06-04 12:14           ` [PATCH v3 0/3] support VXLAN rsvd1 modification Rongwei Liu
2024-06-04 12:15             ` [PATCH v3 1/3] app/testpmd: fix the testpmd field string sequence Rongwei Liu
2024-06-04 12:15             ` [PATCH v3 2/3] ethdev: add VXLAN last reserved field Rongwei Liu
2024-06-04 12:15             ` [PATCH v3 3/3] net/mlx5: implement VXLAN last reserved modification Rongwei Liu
2024-05-27  2:47       ` [PATCH v2 3/4] app/testpmd: add VXLAN last reserved modification command Rongwei Liu
2024-06-04 12:00         ` Thomas Monjalon
2024-05-27  2:47       ` [PATCH v2 4/4] net/mlx5: implement VXLAN last reserved modification Rongwei Liu
2024-06-04 12:19         ` Thomas Monjalon
2024-06-04 12:24           ` rongwei liu
2024-06-04 12:38           ` [PATCH v4 0/3] support VXLAN rsvd1 modification Rongwei Liu
2024-06-04 12:38             ` [PATCH v4 1/3] app/testpmd: fix the testpmd field string sequence Rongwei Liu
2024-06-04 12:38             ` [PATCH v4 2/3] ethdev: add VXLAN last reserved field Rongwei Liu
2024-06-04 15:03               ` Thomas Monjalon
2024-06-04 16:29                 ` rongwei liu
2024-06-04 16:40                   ` Dariusz Sosnowski [this message]
2024-06-04 18:37                     ` Thomas Monjalon
2024-06-05  1:16                       ` rongwei liu
2024-06-05  7:13                         ` Thomas Monjalon
2024-06-05  8:14                           ` rongwei liu
2024-06-05  9:35                             ` Thomas Monjalon
2024-06-05  9:41                               ` rongwei liu
2024-06-05  9:53                                 ` Thomas Monjalon
2024-06-05 10:21                                   ` [PATCH v6 0/4] support VXLAN last reserved byte modification Rongwei Liu
2024-06-05 10:21                                     ` [PATCH v6 1/4] app/testpmd: fix the testpmd field string sequence Rongwei Liu
2024-06-09 14:29                                       ` Ori Kam
2024-06-05 10:21                                     ` [PATCH v6 2/4] net: add new union into VXLAN header Rongwei Liu
2024-06-05 10:42                                       ` Thomas Monjalon
2024-06-05 11:28                                         ` rongwei liu
2024-06-05 12:14                                           ` Thomas Monjalon
2024-06-05 13:04                                             ` [PATCH v7 0/3] support VXLAN last reserved byte modification Rongwei Liu
2024-06-05 13:04                                               ` [PATCH v7 1/3] app/testpmd: fix the testpmd field string sequence Rongwei Liu
2024-06-05 13:04                                               ` [PATCH v7 2/3] ethdev: add VXLAN last reserved field Rongwei Liu
2024-06-07 13:25                                                 ` Thomas Monjalon
2024-06-07 13:55                                                   ` rongwei liu
2024-06-07 14:02                                                   ` [PATCH v8 0/3] support VXLAN last reserved byte modification Rongwei Liu
2024-06-07 14:02                                                     ` [PATCH v8 1/3] app/testpmd: fix the testpmd field string sequence Rongwei Liu
2024-06-11  6:59                                                       ` Ori Kam
2024-06-11 14:52                                                       ` Ferruh Yigit
2024-06-07 14:02                                                     ` [PATCH v8 2/3] ethdev: add VXLAN last reserved field Rongwei Liu
2024-06-09 10:32                                                       ` Thomas Monjalon
2024-06-11 14:52                                                       ` Ferruh Yigit
2024-06-12  1:25                                                         ` rongwei liu
2024-06-25 14:46                                                           ` Thomas Monjalon
2024-06-07 14:02                                                     ` [PATCH v8 3/3] net/mlx5: implement VXLAN last reserved modification Rongwei Liu
2024-06-11 14:52                                                     ` [PATCH v8 0/3] support VXLAN last reserved byte modification Ferruh Yigit
2024-06-05 13:04                                               ` [PATCH v7 3/3] net/mlx5: implement VXLAN last reserved modification Rongwei Liu
2024-06-05 10:21                                     ` [PATCH v6 3/4] ethdev: add VXLAN last reserved field Rongwei Liu
2024-06-05 10:21                                     ` [PATCH v6 4/4] net/mlx5: implement VXLAN last reserved modification Rongwei Liu
2024-06-05  8:41                           ` [PATCH v5 0/3] support VXLAN last reserved byte modification Rongwei Liu
2024-06-05  8:41                             ` [PATCH v5 1/3] app/testpmd: fix the testpmd field string sequence Rongwei Liu
2024-06-05  8:41                             ` [PATCH v5 2/3] ethdev: add VXLAN last reserved field Rongwei Liu
2024-06-05  8:41                             ` [PATCH v5 3/3] net/mlx5: implement VXLAN last reserved modification Rongwei Liu
2024-06-04 12:38             ` [PATCH v4 " Rongwei Liu
2024-05-27  2:56     ` [PATCH v1 2/3] app/testpmd: add VXLAN last reserved modification command rongwei liu
2024-05-23  7:28 ` [PATCH v1 3/3] net/mlx5: implement VXLAN last reserved modification Rongwei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=PH0PR12MB8800ECD345A322AFC4F5DC5CA4F82@PH0PR12MB8800.namprd12.prod.outlook.com \
    --to=dsosnowski@nvidia.com \
    --cc=aman.deep.singh@intel.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@amd.com \
    --cc=matan@nvidia.com \
    --cc=orika@nvidia.com \
    --cc=rongweil@nvidia.com \
    --cc=suanmingm@nvidia.com \
    --cc=thomas@monjalon.net \
    --cc=viacheslavo@nvidia.com \
    --cc=yuying.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).