From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0779B4416C; Thu, 6 Jun 2024 03:41:10 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C83BB4027D; Thu, 6 Jun 2024 03:41:09 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2130.outbound.protection.outlook.com [40.107.220.130]) by mails.dpdk.org (Postfix) with ESMTP id B62B140268 for ; Thu, 6 Jun 2024 03:41:07 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iBPNJ24glMFH1kod2F8ACTjCupkRj17abuIpga5JRj0IxrKibPKe12YOF4BjryKlTovIfVHD3aZ81jAOZecCQNeDhnMvFNaQKyqdSP2hejgeHLH4Z121JNCX/HcUrgBiQxC/LQzfeG1AriM79XDENx1RRzE6Ss7XyDVXKeKFiX0U5WG89go+IJS56Izqa0eUwBpk0p2yq75kEILrpTWSD1mmKHJqqfsQ4n+PzH++XE8zslhazJ3AMX+zaiISBn49I1iuiYGSCU+GwhNgZ8mOGFQgUsaUVBA0l+r4/VhdmtDPMfYbd6cimfHP3RS+suEYrDibcRwBiavph8/qxifp4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fS1YQ7VHzLUMvw7Bl7Z9KWAtMAwhehPgcpmTJ6GMPNQ=; b=WV2p0GNybj+KM8x2MkkmYmCEH0CKCicKZr6+8EmaPSXgs0yF60qKFvhC78uEoNt35u0VO1XCA+ICCjUK9KfGT7sXu6nfyvVh1srS9pWYdDsyHVF48Ad0L3z02Q3yVXSMmFRmWioEoiQtRRmIFwHd0VVmEkUuLlHv98OE+jUENEJJIQw0ee4jzwXmP/cy3n2EX19eGDtRBFVJ2wFy0rlgLZ58mghgGuD0E9cKZNcHC43eT5Cs75izTKDqGXJuCNUf+jiUh6bPPvUptr48xQtSAYja2yDir5EIyY5WOQXrHph1xUoWIQPvt175Tw+DOMyN5DgeGoB3dMmQ61euCudnVg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fS1YQ7VHzLUMvw7Bl7Z9KWAtMAwhehPgcpmTJ6GMPNQ=; b=X787PMGuCE5TGucfuoJWfipA9LzNNL7Hxn+mJrpX6LatrtNEryr3w5ZYs0ltm7wMTIBzD4RRQvrjosrQ8WAv6fjvphb4dzgurCpEOA4vlnY5BuAazAhXgZjO80hOvdGLjd3SPKh3eIoM2IelAlIOa7G04nB7t/t9rYlSSL4rrU0= Received: from PH0PR13MB5568.namprd13.prod.outlook.com (2603:10b6:510:12b::16) by BLAPR13MB4659.namprd13.prod.outlook.com (2603:10b6:208:330::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.9; Thu, 6 Jun 2024 01:41:04 +0000 Received: from PH0PR13MB5568.namprd13.prod.outlook.com ([fe80::277d:5013:95a1:d8b9]) by PH0PR13MB5568.namprd13.prod.outlook.com ([fe80::277d:5013:95a1:d8b9%4]) with mapi id 15.20.7633.021; Thu, 6 Jun 2024 01:41:04 +0000 From: Chaoyong He To: Stephen Hemminger CC: "dev@dpdk.org" , oss-drivers Subject: RE: [PATCH 0/2] add function to set dedicated queue size Thread-Topic: [PATCH 0/2] add function to set dedicated queue size Thread-Index: AQHatwz+OLPHn9lZwEWlUIVe+rFKt7G5U+oAgACfJxA= Date: Thu, 6 Jun 2024 01:41:04 +0000 Message-ID: References: <20240605055520.2587034-1-chaoyong.he@corigine.com> <20240605085704.137e8e3e@hermes.local> In-Reply-To: <20240605085704.137e8e3e@hermes.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR13MB5568:EE_|BLAPR13MB4659:EE_ x-ms-office365-filtering-correlation-id: 818141ff-bac4-4962-4146-08dc85c9ba68 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230031|376005|1800799015|366007|38070700009; x-microsoft-antispam-message-info: =?us-ascii?Q?2etriC5FQTmw7W6b0VcDYyHAFnLoLEWWlXcxPdU0YvBCPTkapavUBpNM1UYL?= =?us-ascii?Q?FX6RdStwfdtQhR4QlZqAGU+7/WBqjqR3siXifrH0n0a+n17PlcxK5p+z1sp2?= =?us-ascii?Q?VO/0mygnNDRowbaGUtLG2agy7gSWD139OewPLy0JPsFdlZwAoJnEzAjHQkO3?= =?us-ascii?Q?MN8xdS+5zkMF8TqemN6o6rELupn3qmdgVmclGcO8uGLHyJfX1r4Pj80xNnmJ?= =?us-ascii?Q?C11usDGZJu06BcqCvKhb070w4IsyjxmaQrTDJuKH71UXN+4bYzk/R0KjOfYU?= =?us-ascii?Q?wfazOlWE0AN7ZojW1xNs1BQ7JvnlPHqcyIF8UmbCc+wgPbuO7p21KJF6GH8z?= =?us-ascii?Q?Gb+jSRgILXVerSnoi3g3DCl4QINP1Q2a7r7a4dzKd6VZG0O8ElN7TV+at3tM?= =?us-ascii?Q?QX5+stbKazKq9inoYUPeO24QlxK68/73WFbP0BEGO3GDdCvhRzspxn3HgVmA?= =?us-ascii?Q?8Hu3kp8YokMJaTD8atvPcgRC2B1lmwya0Q15OlziJuIOkCJk86ifeB7gsFgN?= =?us-ascii?Q?hnbLRiUMNPCMCjoN7mSbwSBOD+2iXHTf8YCpnYYvpbujI7ysTzBOqZd3EJgg?= =?us-ascii?Q?1YTXJWRk9IpAQcm/MN0Uq0HHfWCLJIdVvrQO05HgwiAgTjioRWTuEcCQhnnd?= =?us-ascii?Q?i6iT+2EGXjHHLN9xOYwzS4bgwwTRRuE1a7d5OhMytoB5XMF7fXTgH9DQsC81?= =?us-ascii?Q?M+99VbGUbNzhji/TYFw0rY9uPxDDyZEiYkIv2/ecwnk0YMy9kH4LsqgtbCD8?= =?us-ascii?Q?5qofTRV1APMngP0RLJKY9tcrYSsSuSpvYdaG/HKTAoMZpmYZ+heEnQSNToQp?= =?us-ascii?Q?ijqk8v5We9YVwQnQthorvoS3z4VI3seEsBVlTiie/kkzd2QlmPwLkkH60uke?= =?us-ascii?Q?y+GeHNhFmgHFPOORkLXRlwxHkZ6AdFT1Ky4L2IUcWOG0SCv/Etfqsg8Py2nq?= =?us-ascii?Q?07FfI78Y3ZHmi3vbNfIFW3BKDNrli8fXkN0oPdO2PzBEC98ugI3KcZnpf0LP?= =?us-ascii?Q?bdmgc13zZ11mwbAXo3c03a6S+ZtqTUoma8OEBcTGv0kc0OlFJOnqe6Gld0aa?= =?us-ascii?Q?sBzdbCdeNo3CeXWHAxAtYoLEMccgb4Lpq3LjYyqSilUlX65svQnGmRPgdEUJ?= =?us-ascii?Q?wvMF6cbVK43eQXiPYHK8j4gMPyzhR59vVL7l3k9C/AgRE5Hq/oeGnsYKHzS7?= =?us-ascii?Q?TxkxCjPJ/u2u2si6sTLZvOyykIMR8Z9ITgMNDtUM0pj1akcBpbF094Jqb2wX?= =?us-ascii?Q?2QGZkhPP9RPniI0gDmfokgU1MQ4mvOKYX3VpXB3ooZeHQY1l6RwBaPsZiHGv?= =?us-ascii?Q?DCEXEkEYEH+FEbjr3xXM+kTDnbSFmoph0hlFYqvbQlaNM74O2gOtl1n2JPJ/?= =?us-ascii?Q?UZMHGKs=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR13MB5568.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(1800799015)(366007)(38070700009); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?QkPjWSnOQv5TDm5APnsbKzS7RNHxmqOmrpOW3ZAajY/aq5ic7mfiXA1Y/GYQ?= =?us-ascii?Q?2NCu0LyJgaFOXU80XtwJi0GX/h7be13jIb69wCPcl9J0GlofWORL32PywGoO?= =?us-ascii?Q?hyOLDBNhI1IxNLkFVnoUvvMpjOy/OUbQuJwHkpI/DbDLIvlaWjkvpNY4NLZ9?= =?us-ascii?Q?e8NP0zE9/pcErHr34YJfwyOu10UC0ZOjcUj3SdBO7nry3TTyz0RzTrbqezWG?= =?us-ascii?Q?FBn0pZTk754cvb3Q+XjatDU2cEfpypb5LAG3Ntjnj9aqum473SFK3X17uoNI?= =?us-ascii?Q?QIyzUnSpjUiwCGf9l1luzKvaYfQv/bsbNS6rRYsLocDpv3m7vQUVfujVIKsU?= =?us-ascii?Q?6/C9FlMiR2BfBJrtHbm8QDfH/L6KFI13FAAzkiQtStMeHZ2gd8tnGEHFz4RQ?= =?us-ascii?Q?gizpFR3tXcDXPapd92qhhxKNg60rqyyHDCtC+eU6yLeu1k1rwJv0sPytKigp?= =?us-ascii?Q?23u8dEzv5L8IwMzKa/1KQ0/CJYfC7+nZ4HBsL6zYnb4CqUT5SBKoNnwafsIR?= =?us-ascii?Q?XJpbQsGyZC09TCkOW99Ej6nHp51jwvUco1nZhxYgkSulmBG3Zt8WoMTo4AgU?= =?us-ascii?Q?MNfrASDM5msOxAOHLmwmxuzFoekAaKpwTr70IytAM64hwCIRt3Ebft5gThcV?= =?us-ascii?Q?I88+aUjtRvTBegpO2nZnV50039XWF0o6DyCBzX2K4ITwji7q0IHBs063GquB?= =?us-ascii?Q?NTizX4OhhpQyrtqgR19EDiCapRam2tewPawqsnS7AmDdIzegEIMj2Bbe9e9a?= =?us-ascii?Q?vpWYjWjCjgaYIQe0eAoXWu1P/rUlPCjR6NVevJBnYeXlfBdorXtbQl6lkHSC?= =?us-ascii?Q?ZwxJ0QVMsU2kn7Zfc39/vbCCXUnXmfRR148PpeyD7li0r0zMBfvk09evdpVd?= =?us-ascii?Q?eRR7Y0t97VI/3n6TOoIAWIASydUirG+AoNl3XMgy9c4a8k34G2/KQLM+FSQl?= =?us-ascii?Q?ayubeaZfdBYoa+GE3szlw4OhBW+HHR4eBmUvXidzAUo3yDjazX9qdjB9dYhG?= =?us-ascii?Q?5qE9WH1aB49gm9Zmz5csve9TKM2VwH4wXS5imaBN0F9xqP/lPho+G/bIsj8p?= =?us-ascii?Q?1gZyVL8biQ+h49VcAy/qhbDC1MTWNrfElLhQ4EkVBGAJ4DCIIgjuS770M9eb?= =?us-ascii?Q?WsS6mdk+YvorTJZcPCDltfIs8WvPry/KYqqGLv8ihmlKZV2EjNiBjB+hg6zk?= =?us-ascii?Q?Gxg7jznszkTsJfl4vWNIe5ZTQdtQ3owoR5X9z28xqe97b3KDbhMC0PjFUrKs?= =?us-ascii?Q?7pvaFNmXe2wljiRUI/CI3COmHZbuLBo3HJXjJgN5JLn1OUU/4ssUzgl/4lHW?= =?us-ascii?Q?K7gemvjqq8QQzpU+mJjFZUUIadI57BTi7SSKy9Mire2p8hQhPoslSeXdR6IH?= =?us-ascii?Q?6Ad4PhqzYCTLZf7tAm8PWlbdiuzZpWoAC8VZRodwI9sNg1fvHStsjpBnbWM1?= =?us-ascii?Q?woV73lpvhTbW26fwpyR2LCcFq/na77oBjmSx41XmIY/uoWlkG75EcfnRNwJ1?= =?us-ascii?Q?rPMF0ObsI51pBwI77a6GXvQ+z6DssLS4f6JnAVo4oZphizYTzmalN4rR88zx?= =?us-ascii?Q?ln9bw7uoWU60d87a5XPX9OVp/B2YEHGVf6Oge4Wt?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB5568.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 818141ff-bac4-4962-4146-08dc85c9ba68 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jun 2024 01:41:04.1648 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3SKGyKngJ9c/GTH/7emwb+otbATXh+qe3E8lPqyRhAUbxtv7Pz++pYwi1uwlrrZ+GIL1OQiH2vSvVH4aUkni7jeWHPCNoewvWHnolfwGhSw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR13MB4659 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > On Wed, 5 Jun 2024 13:55:18 +0800 > Chaoyong He wrote: >=20 > > This patch series mainly add a function to bonding PMD to set > > dedicated queue size, also add a command to testpmd application to > > invoke this function. > > > > At the same time, standard the log message of bonding PMD. > > > > Long Wu (2): > > net/bonding: standard the log message > > net/bonding: add command to set dedicated queue size > > > > .../link_bonding_poll_mode_drv_lib.rst | 8 ++ > > doc/guides/rel_notes/release_24_07.rst | 4 + > > drivers/net/bonding/bonding_testpmd.c | 126 ++++++++++++++---- > > drivers/net/bonding/eth_bond_8023ad_private.h | 3 + > > drivers/net/bonding/rte_eth_bond_8023ad.c | 39 ++++++ > > drivers/net/bonding/rte_eth_bond_8023ad.h | 23 ++++ > > drivers/net/bonding/rte_eth_bond_pmd.c | 6 +- > > drivers/net/bonding/version.map | 1 + > > 8 files changed, 185 insertions(+), 25 deletions(-) > > >=20 > This is confusing. > The patch goes to all the effort to configure rx_queue_size but it is nev= er > actually used in the driver. We do used it in the function 'member_configure_slow_queue()' of file 'driv= ers/net/bonding/rte_eth_bond_pmd.c'. The original logic hardcodes the value of dedicated hardware Rx/Tx queue si= ze into (128/512) and this will cause the bonding port start fail if the NIC requires more Rx/Tx descriptors than the= hardcoded number. And this is the situation for our NFP card: ``` testpmd> port stop all testpmd> create bonding device 4 0 testpmd> set bonding balance_xmit_policy 2 l34 testpmd> add bonding member 0 2 testpmd> add bonding member 1 2 testpmd> set bonding lacp dedicated_queues 2 enable testpmd> show bonding config 2 testpmd> port start 2 Configuring Port 2 (socket 0) ETHDEV: Device with port_id=3D0 already stopped ETHDEV: Device with port_id=3D1 already stopped ETHDEV: Device with port_id=3D0 already stopped ETHDEV: Invalid value for nb_rx_desc(=3D128), should be: <=3D 32768, >=3D 5= 12, and a product of 128 member_configure_slow_queue(1699) - rte_eth_rx_queue_setup: port=3D0 queue_= id 1, err (-22) ETHDEV: Device with port_id=3D1 already stopped ETHDEV: Invalid value for nb_rx_desc(=3D128), should be: <=3D 32768, >=3D 5= 12, and a product of 128 member_configure_slow_queue(1699) - rte_eth_rx_queue_setup: port=3D1 queue_= id 1, err (-22) Port 2: 88:3C:C5:A0:32:46 Checking link statuses... Done ``` And if apply this patch and configure the 'rx_queue_size', then we can star= t the bonding port successfully.